<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>33246</bug_id>
          
          <creation_ts>2010-01-05 18:25:53 -0800</creation_ts>
          <short_desc>webkit-patch land should warn when changelog doesn&apos;t match committer</short_desc>
          <delta_ts>2010-04-01 23:21:52 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>28092</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ojan Vafai">ojan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>177511</commentid>
    <comment_count>0</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2010-01-05 18:25:53 -0800</bug_when>
    <thetext>I just had the following happen:
1. git svn rebase successfully merged my ChangeLog file, but didn&apos;t put my entry at the top
2. bugzilla-tool land-diff committed my change with the wrong commit message

See http://trac.webkit.org/changeset/52844

Technically, I should have noticed in the diff that the ChangeLog entry wasn&apos;t at the top, but it would be nice to be a bit more idiot-proof. Can land-diff confirm that you want to commit if the email address doesn&apos;t match git&apos;s configured email address? Obviously, this would always be true on the commit bot, but for human beings committing, I think this is by far the common case (i.e. that they&apos;re committing their own patches).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182544</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-19 17:00:18 -0800</bug_when>
    <thetext>We have like 8 dupes of this bug on file.  Git users run into this kind of thing all the time. :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>207699</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-04-01 23:21:52 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 28092 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>