33228 2010-01-05 13:07:25 -0800 Line boxes aren't cleared when the last child is removed from a RenderBlock 2010-01-05 16:08:10 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jamesr webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 177333 0 jamesr 2010-01-05 13:07:25 -0800 When the last child is removed from a RenderBlock its line box list is not cleared until the next layout pass. This is slightly wasteful and makes the fullLayout flag in RenderBlock::layoutInlineChildren() harder to reason about. 177335 1 45924 jamesr 2010-01-05 13:09:00 -0800 Created attachment 45924 Clears lineboxes when last child is deleted 177337 2 webkit.review.bot 2010-01-05 13:10:15 -0800 style-queue ran check-webkit-style on attachment 45924 without any errors. 177341 3 45924 hyatt 2010-01-05 13:16:31 -0800 Comment on attachment 45924 Clears lineboxes when last child is deleted Seems like this should be: if (childrenInline() && !firstChild()) just to not waste time calling into lineBoxes() in the block child removal case? r=me 177352 4 45928 jamesr 2010-01-05 13:28:07 -0800 Created attachment 45928 Adds the childrenInline() check 177358 5 webkit.review.bot 2010-01-05 13:29:15 -0800 style-queue ran check-webkit-style on attachment 45928 without any errors. 177360 6 45928 hyatt 2010-01-05 13:30:57 -0800 Comment on attachment 45928 Adds the childrenInline() check r=me 177364 7 45924 eric 2010-01-05 13:34:10 -0800 Comment on attachment 45924 Clears lineboxes when last child is deleted Obsoleting this old patch. 177448 8 45928 commit-queue 2010-01-05 16:08:06 -0800 Comment on attachment 45928 Adds the childrenInline() check Clearing flags on attachment: 45928 Committed r52838: <http://trac.webkit.org/changeset/52838> 177449 9 commit-queue 2010-01-05 16:08:10 -0800 All reviewed patches have been landed. Closing bug. 45924 2010-01-05 13:09:00 -0800 2010-01-05 13:34:10 -0800 Clears lineboxes when last child is deleted clear_linebox.diff text/plain 2075 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjM1ZDg2Zi4uZTcwMmFmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAwOS0xMi0xNCAgSmFtZXMgUm9iaW5z b24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENsZWFucyB1cCBsaW5lIGJveCBjbGVhcmluZyB3aGVuIGEgUmVu ZGVyQmxvY2sgbG9zZXMgaXRzIGxhc3QgY2hpbGQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzIyOAorCisgICAgICAgIFRoZSAnZnVsbExheW91dCcg ZmxhZyBpbiBSZW5kZXJCbG9jazo6bGF5b3V0SW5saW5lQ2hpbGRyZW4oKSBpcyBwcmV0dHkgdmFn dWUsIGhvcGVmdWxseSB0aGlzIHdpbGwgYmUgZWFzaWVyIGZvciB0aGUgbmV4dCBwZXJzb24gdG8g ZmlndXJlIG91dC4KKworCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6cmVt b3ZlQ2hpbGQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmxheW91dElubGluZUNoaWxkcmVuKToK KwogMjAwOS0xMi0zMCAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNw cAppbmRleCA0YjFjZmRiLi4zNzI4MTU0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9jay5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBA IC01NTQsNiArNTU0LDEwIEBAIHZvaWQgUmVuZGVyQmxvY2s6OnJlbW92ZUNoaWxkKFJlbmRlck9i amVjdCogb2xkQ2hpbGQpCiAgICAgICAgIGFub25CbG9jay0+ZGVsZXRlTGluZUJveFRyZWUoKTsK ICAgICAgICAgYW5vbkJsb2NrLT5kZXN0cm95KCk7CiAgICAgfQorCisgICAgLy8gSWYgdGhpcyB3 YXMgb3VyIGxhc3QgY2hpbGQgYmUgc3VyZSB0byBjbGVhciBvdXQgb3VyIGxpbmUgYm94ZXMuCisg ICAgaWYgKCFmaXJzdENoaWxkKCkpCisgICAgICAgIGxpbmVCb3hlcygpLT5kZWxldGVMaW5lQm94 ZXMocmVuZGVyQXJlbmEoKSk7CiB9CiAKIGJvb2wgUmVuZGVyQmxvY2s6OmlzU2VsZkNvbGxhcHNp bmdCbG9jaygpIGNvbnN0CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j a0xpbmVMYXlvdXQuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0 LmNwcAppbmRleCBmMDVkNzI0Li40NzFmYTgxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrTGluZUxheW91dC5jcHAKQEAgLTgyMyw3ICs4MjMsNyBAQCB2b2lkIFJlbmRlckJsb2Nr OjpsYXlvdXRJbmxpbmVDaGlsZHJlbihib29sIHJlbGF5b3V0Q2hpbGRyZW4sIGludCYgcmVwYWlu dFRvcCwgaQogCiAgICAgLy8gRmlndXJlIG91dCBpZiB3ZSBzaG91bGQgY2xlYXIgb3V0IG91ciBs aW5lIGJveGVzLgogICAgIC8vIEZJWE1FOiBIYW5kbGUgcmVzaXplIGV2ZW50dWFsbHkhCi0gICAg Ym9vbCBmdWxsTGF5b3V0ID0gIWZpcnN0TGluZUJveCgpIHx8ICFmaXJzdENoaWxkKCkgfHwgc2Vs Zk5lZWRzTGF5b3V0KCkgfHwgcmVsYXlvdXRDaGlsZHJlbjsKKyAgICBib29sIGZ1bGxMYXlvdXQg PSAhZmlyc3RMaW5lQm94KCkgfHwgc2VsZk5lZWRzTGF5b3V0KCkgfHwgcmVsYXlvdXRDaGlsZHJl bjsKICAgICBpZiAoZnVsbExheW91dCkKICAgICAgICAgbGluZUJveGVzKCktPmRlbGV0ZUxpbmVC b3hlcyhyZW5kZXJBcmVuYSgpKTsKIAo= 45928 2010-01-05 13:28:07 -0800 2010-01-05 16:08:06 -0800 Adds the childrenInline() check clear_linebox2.diff text/plain 2095 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjM1ZDg2Zi4uZTcwMmFmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAwOS0xMi0xNCAgSmFtZXMgUm9iaW5z b24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENsZWFucyB1cCBsaW5lIGJveCBjbGVhcmluZyB3aGVuIGEgUmVu ZGVyQmxvY2sgbG9zZXMgaXRzIGxhc3QgY2hpbGQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzIyOAorCisgICAgICAgIFRoZSAnZnVsbExheW91dCcg ZmxhZyBpbiBSZW5kZXJCbG9jazo6bGF5b3V0SW5saW5lQ2hpbGRyZW4oKSBpcyBwcmV0dHkgdmFn dWUsIGhvcGVmdWxseSB0aGlzIHdpbGwgYmUgZWFzaWVyIGZvciB0aGUgbmV4dCBwZXJzb24gdG8g ZmlndXJlIG91dC4KKworCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6cmVt b3ZlQ2hpbGQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmxheW91dElubGluZUNoaWxkcmVuKToK KwogMjAwOS0xMi0zMCAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNw cAppbmRleCA0YjFjZmRiLi5iNTcyMzZhIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9jay5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBA IC01NTQsNiArNTU0LDEwIEBAIHZvaWQgUmVuZGVyQmxvY2s6OnJlbW92ZUNoaWxkKFJlbmRlck9i amVjdCogb2xkQ2hpbGQpCiAgICAgICAgIGFub25CbG9jay0+ZGVsZXRlTGluZUJveFRyZWUoKTsK ICAgICAgICAgYW5vbkJsb2NrLT5kZXN0cm95KCk7CiAgICAgfQorCisgICAgLy8gSWYgdGhpcyB3 YXMgb3VyIGxhc3QgY2hpbGQgYmUgc3VyZSB0byBjbGVhciBvdXQgb3VyIGxpbmUgYm94ZXMuCisg ICAgaWYgKGNoaWxkcmVuSW5saW5lKCkgJiYgIWZpcnN0Q2hpbGQoKSkKKyAgICAgICAgbGluZUJv eGVzKCktPmRlbGV0ZUxpbmVCb3hlcyhyZW5kZXJBcmVuYSgpKTsKIH0KIAogYm9vbCBSZW5kZXJC bG9jazo6aXNTZWxmQ29sbGFwc2luZ0Jsb2NrKCkgY29uc3QKZGlmZiAtLWdpdCBhL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCmluZGV4IGYwNWQ3MjQuLjQ3MWZhODEgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKKysrIGIvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcApAQCAtODIzLDcgKzgyMyw3 IEBAIHZvaWQgUmVuZGVyQmxvY2s6OmxheW91dElubGluZUNoaWxkcmVuKGJvb2wgcmVsYXlvdXRD aGlsZHJlbiwgaW50JiByZXBhaW50VG9wLCBpCiAKICAgICAvLyBGaWd1cmUgb3V0IGlmIHdlIHNo b3VsZCBjbGVhciBvdXQgb3VyIGxpbmUgYm94ZXMuCiAgICAgLy8gRklYTUU6IEhhbmRsZSByZXNp emUgZXZlbnR1YWxseSEKLSAgICBib29sIGZ1bGxMYXlvdXQgPSAhZmlyc3RMaW5lQm94KCkgfHwg IWZpcnN0Q2hpbGQoKSB8fCBzZWxmTmVlZHNMYXlvdXQoKSB8fCByZWxheW91dENoaWxkcmVuOwor ICAgIGJvb2wgZnVsbExheW91dCA9ICFmaXJzdExpbmVCb3goKSB8fCBzZWxmTmVlZHNMYXlvdXQo KSB8fCByZWxheW91dENoaWxkcmVuOwogICAgIGlmIChmdWxsTGF5b3V0KQogICAgICAgICBsaW5l Qm94ZXMoKS0+ZGVsZXRlTGluZUJveGVzKHJlbmRlckFyZW5hKCkpOwogCg==