33219 2010-01-05 10:46:28 -0800 Add assertions to catch double-destruction of WebViews earlier 2010-01-05 15:09:24 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 aroben webkit-unassigned sam oldest_to_newest 177236 0 45909 aroben 2010-01-05 10:46:28 -0800 Created attachment 45909 Patch I basically copied the m_deletionHasBegun logic from WTF::RefCounted. Need a short description and bug URL (OOPS!) Reviewed by NOBODY (OOPS!). * WebView.cpp: (WebView::WebView): Initialize m_deletionHasBegun (WebView::AddRef): Assert that deletion hasn't already begun. (WebView::Release): Assert that deletion hasn't already begun, then record when deletion *does* begin. * WebView.h: Added m_deletionHasBegun. --- 3 files changed, 32 insertions(+), 1 deletions(-) 177427 1 aroben 2010-01-05 15:09:24 -0800 Committed r52828: <http://trac.webkit.org/changeset/52828> 45909 2010-01-05 10:46:28 -0800 2010-01-05 10:48:35 -0800 Patch 20100105134640.patch text/plain 2230 aroben ZGlmZiAtLWdpdCBhL1dlYktpdC93aW4vQ2hhbmdlTG9nIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cK aW5kZXggNDdkODQzMS4uMjc0MjIyNiAxMDA2NDQKLS0tIGEvV2ViS2l0L3dpbi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMyBAQAogMjAxMC0wMS0wNSAg QWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIGFzc2VydGlvbnMg dG8gY2F0Y2ggZG91YmxlLWRlc3RydWN0aW9uIG9mIFdlYlZpZXdzIGVhcmxpZXIKKworICAgICAg ICBJIGJhc2ljYWxseSBjb3BpZWQgdGhlIG1fZGVsZXRpb25IYXNCZWd1biBsb2dpYyBmcm9tIFdU Rjo6UmVmQ291bnRlZC4KKworICAgICAgICBOZWVkIGEgc2hvcnQgZGVzY3JpcHRpb24gYW5kIGJ1 ZyBVUkwgKE9PUFMhKQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogV2ViVmlldy5jcHA6CisgICAgICAgIChXZWJWaWV3OjpXZWJWaWV3KTogSW5pdGlh bGl6ZSBtX2RlbGV0aW9uSGFzQmVndW4KKyAgICAgICAgKFdlYlZpZXc6OkFkZFJlZik6IEFzc2Vy dCB0aGF0IGRlbGV0aW9uIGhhc24ndCBhbHJlYWR5IGJlZ3VuLgorICAgICAgICAoV2ViVmlldzo6 UmVsZWFzZSk6IEFzc2VydCB0aGF0IGRlbGV0aW9uIGhhc24ndCBhbHJlYWR5IGJlZ3VuLCB0aGVu CisgICAgICAgIHJlY29yZCB3aGVuIGRlbGV0aW9uICpkb2VzKiBiZWdpbi4KKworICAgICAgICAq IFdlYlZpZXcuaDogQWRkZWQgbV9kZWxldGlvbkhhc0JlZ3VuLgorCisyMDEwLTAxLTA1ICBBZGFt IFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KKwogICAgICAgICBSZW1vdmUgZGVhZCBjb2RlIGlu IFdlYlZpZXdXbmRQcm9jCiAKICAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBi dWcgVVJMIChPT1BTISkKZGlmZiAtLWdpdCBhL1dlYktpdC93aW4vV2ViVmlldy5jcHAgYi9XZWJL aXQvd2luL1dlYlZpZXcuY3BwCmluZGV4IGJiOGMyZjEuLmM1ZDU5YzAgMTAwNjQ0Ci0tLSBhL1dl YktpdC93aW4vV2ViVmlldy5jcHAKKysrIGIvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcApAQCAtMjk2 LDYgKzI5Niw5IEBAIGJvb2wgV2ViVmlldzo6c19hbGxvd1NpdGVTcGVjaWZpY0hhY2tzID0gZmFs c2U7CiAKIFdlYlZpZXc6OldlYlZpZXcoKQogICAgIDogbV9yZWZDb3VudCgwKQorI2lmICFBU1NF UlRfRElTQUJMRUQKKyAgICAsIG1fZGVsZXRpb25IYXNCZWd1bihmYWxzZSkKKyNlbmRpZgogICAg ICwgbV9ob3N0V2luZG93KDApCiAgICAgLCBtX3ZpZXdXaW5kb3coMCkKICAgICAsIG1fbWFpbkZy YW1lKDApCkBAIC0yMjY3LDE0ICsyMjcwLDIxIEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUg V2ViVmlldzo6UXVlcnlJbnRlcmZhY2UoUkVGSUlEIHJpaWQsIHZvaWQqKiBwcHZPYmplY3QpCiAK IFVMT05HIFNURE1FVEhPRENBTExUWVBFIFdlYlZpZXc6OkFkZFJlZih2b2lkKQogeworICAgIEFT U0VSVCghbV9kZWxldGlvbkhhc0JlZ3VuKTsKICAgICByZXR1cm4gKyttX3JlZkNvdW50OwogfQog CiBVTE9ORyBTVERNRVRIT0RDQUxMVFlQRSBXZWJWaWV3OjpSZWxlYXNlKHZvaWQpCiB7CisgICAg QVNTRVJUKCFtX2RlbGV0aW9uSGFzQmVndW4pOworCiAgICAgVUxPTkcgbmV3UmVmID0gLS1tX3Jl ZkNvdW50OwotICAgIGlmICghbmV3UmVmKQorICAgIGlmICghbmV3UmVmKSB7CisjaWYgIUFTU0VS VF9ESVNBQkxFRAorICAgICAgICBtX2RlbGV0aW9uSGFzQmVndW4gPSB0cnVlOworI2VuZGlmCiAg ICAgICAgIGRlbGV0ZSh0aGlzKTsKKyAgICB9CiAKICAgICByZXR1cm4gbmV3UmVmOwogfQpkaWZm IC0tZ2l0IGEvV2ViS2l0L3dpbi9XZWJWaWV3LmggYi9XZWJLaXQvd2luL1dlYlZpZXcuaAppbmRl eCA3YjI3MjkzLi45NTIyZWQzIDEwMDY0NAotLS0gYS9XZWJLaXQvd2luL1dlYlZpZXcuaAorKysg Yi9XZWJLaXQvd2luL1dlYlZpZXcuaApAQCAtOTE1LDYgKzkxNSw5IEBAIHByb3RlY3RlZDoKICAg ICB2aXJ0dWFsIHZvaWQgd2luZG93UmVjZWl2ZWRNZXNzYWdlKEhXTkQsIFVJTlQgbWVzc2FnZSwg V1BBUkFNLCBMUEFSQU0pOwogCiAgICAgVUxPTkcgbV9yZWZDb3VudDsKKyNpZiAhQVNTRVJUX0RJ U0FCTEVECisgICAgYm9vbCBtX2RlbGV0aW9uSGFzQmVndW47CisjZW5kaWYKICAgICBIV05EIG1f aG9zdFdpbmRvdzsKICAgICBIV05EIG1fdmlld1dpbmRvdzsKICAgICBXZWJGcmFtZSogbV9tYWlu RnJhbWU7Cg==