33214 2010-01-05 10:32:05 -0800 Having a comment for the #endif for a header guard is not required WebKit style. 2010-02-18 22:56:31 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 35133 1 levin levin abarth eric oldest_to_newest 177220 0 levin 2010-01-05 10:32:05 -0800 Need to fix the scripts not to flag this. 177224 1 45905 levin 2010-01-05 10:35:45 -0800 Created attachment 45905 Patch 177235 2 levin 2010-01-05 10:44:49 -0800 Committed as http://trac.webkit.org/changeset/52808 45905 2010-01-05 10:35:45 -0800 2010-01-05 10:37:15 -0800 Patch bug-33214-20100105103542.patch text/plain 5407 levin ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhYjAxYWU5Li5kZmU5ZDVhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEt MDUgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhdmluZyBhIGNvbW1lbnQgZm9yIHRoZSAj ZW5kaWYgZm9yIGEgaGVhZGVyIGd1YXJkIGlzIG5vdCByZXF1aXJlZCBXZWJLaXQgc3R5bGUuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzIxNAorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jcHBfc3R5bGUucHk6IHJlbW92ZWQgdGhlIGNoZWNr IGFuZCBtYWRlIHRoZSBsb29wIGV4aXQKKyAgICAgICAgICBlYXJseSB3aGVuIGl0IGhhcyBhbGwg dGhlIG5lZWRlZCBpbmZvcm1hdGlvbiB0byBjb250aW51ZS4KKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2NwcF9zdHlsZV91bml0dGVzdC5weTogcmVtb3ZlZCB0aGUgY29ycmVzcG9uZGluZyB0 ZXN0cy4KKwogMjAxMC0wMS0wNCAgVG9yIEFybmUgVmVzdGLDuCAgPHRvci5hcm5lLnZlc3Rib0Bu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgS2lsemVyLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jcHBfc3R5bGUucHkgYi9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2NwcF9zdHlsZS5weQppbmRleCAwNWM1OTJlLi4yZDk1ZDNlIDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NwcF9zdHlsZS5weQorKysg Yi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NwcF9zdHlsZS5weQpAQCAtNzg3LDggKzc4 Nyw2IEBAIGRlZiBjaGVja19mb3JfaGVhZGVyX2d1YXJkKGZpbGVuYW1lLCBsaW5lcywgZXJyb3Ip OgogICAgIGlmbmRlZiA9IE5vbmUKICAgICBpZm5kZWZfbGluZV9udW1iZXIgPSAwCiAgICAgZGVm aW5lID0gTm9uZQotICAgIGVuZGlmID0gTm9uZQotICAgIGVuZGlmX2xpbmVfbnVtYmVyID0gMAog ICAgIGZvciBsaW5lX251bWJlciwgbGluZSBpbiBlbnVtZXJhdGUobGluZXMpOgogICAgICAgICBs aW5lX3NwbGl0ID0gbGluZS5zcGxpdCgpCiAgICAgICAgIGlmIGxlbihsaW5lX3NwbGl0KSA+PSAy OgpAQCAtNzk5LDEwICs3OTcsOCBAQCBkZWYgY2hlY2tfZm9yX2hlYWRlcl9ndWFyZChmaWxlbmFt ZSwgbGluZXMsIGVycm9yKToKICAgICAgICAgICAgICAgICBpZm5kZWZfbGluZV9udW1iZXIgPSBs aW5lX251bWJlcgogICAgICAgICAgICAgaWYgbm90IGRlZmluZSBhbmQgbGluZV9zcGxpdFswXSA9 PSAnI2RlZmluZSc6CiAgICAgICAgICAgICAgICAgZGVmaW5lID0gbGluZV9zcGxpdFsxXQotICAg ICAgICAjIGZpbmQgdGhlIGxhc3Qgb2NjdXJyZW5jZSBvZiAjZW5kaWYsIHNhdmUgZW50aXJlIGxp bmUKLSAgICAgICAgaWYgbGluZS5zdGFydHN3aXRoKCcjZW5kaWYnKToKLSAgICAgICAgICAgIGVu ZGlmID0gbGluZQotICAgICAgICAgICAgZW5kaWZfbGluZV9udW1iZXIgPSBsaW5lX251bWJlcgor ICAgICAgICAgICAgaWYgZGVmaW5lIGFuZCBpZm5kZWY6CisgICAgICAgICAgICAgICAgYnJlYWsK IAogICAgIGlmIG5vdCBpZm5kZWYgb3Igbm90IGRlZmluZSBvciBpZm5kZWYgIT0gZGVmaW5lOgog ICAgICAgICBlcnJvcihmaWxlbmFtZSwgMCwgJ2J1aWxkL2hlYWRlcl9ndWFyZCcsIDUsCkBAIC04 MTUsMTAgKzgxMSw2IEBAIGRlZiBjaGVja19mb3JfaGVhZGVyX2d1YXJkKGZpbGVuYW1lLCBsaW5l cywgZXJyb3IpOgogICAgICAgICBlcnJvcihmaWxlbmFtZSwgaWZuZGVmX2xpbmVfbnVtYmVyLCAn YnVpbGQvaGVhZGVyX2d1YXJkJywgNSwKICAgICAgICAgICAgICAgJyNpZm5kZWYgaGVhZGVyIGd1 YXJkIGhhcyB3cm9uZyBzdHlsZSwgcGxlYXNlIHVzZTogJXMnICUgY3BwdmFyKQogCi0gICAgaWYg ZW5kaWYgIT0gKCcjZW5kaWYgLy8gJXMnICUgY3BwdmFyKToKLSAgICAgICAgZXJyb3IoZmlsZW5h bWUsIGVuZGlmX2xpbmVfbnVtYmVyLCAnYnVpbGQvaGVhZGVyX2d1YXJkJywgNSwKLSAgICAgICAg ICAgICAgJyNlbmRpZiBsaW5lIHNob3VsZCBiZSAiI2VuZGlmIC8vICVzIicgJSBjcHB2YXIpCi0K IAogZGVmIGNoZWNrX2Zvcl91bmljb2RlX3JlcGxhY2VtZW50X2NoYXJhY3RlcnMoZmlsZW5hbWUs IGxpbmVzLCBlcnJvcik6CiAgICAgIiIiTG9ncyBhbiBlcnJvciBmb3IgZWFjaCBsaW5lIGNvbnRh aW5pbmcgVW5pY29kZSByZXBsYWNlbWVudCBjaGFyYWN0ZXJzLgpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jcHBfc3R5bGVfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2NwcF9zdHlsZV91bml0dGVzdC5weQppbmRleCBkNTY3YTQ3Li4w ZWZmYjc1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NwcF9zdHls ZV91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NwcF9zdHls ZV91bml0dGVzdC5weQpAQCAtMTcxNCw0NyArMTcxNCw2IEBAIGNsYXNzIENwcFN0eWxlVGVzdChD cHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICAgICAnICBbYnVpbGQvaGVhZGVyX2d1YXJk XSBbNV0nICUgZXhwZWN0ZWRfZ3VhcmQpLAogICAgICAgICAgICAgZXJyb3JfY29sbGVjdG9yLnJl c3VsdF9saXN0KCkpCiAKLSAgICAgICAgIyBObyBlbmRpZgotICAgICAgICBlcnJvcl9jb2xsZWN0 b3IgPSBFcnJvckNvbGxlY3RvcihzZWxmLmFzc2VydF8pCi0gICAgICAgIGNwcF9zdHlsZS5wcm9j ZXNzX2ZpbGVfZGF0YShmaWxlX3BhdGgsICdoJywKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFsnI2lmbmRlZiAlcycgJSBleHBlY3RlZF9ndWFyZCwKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAnI2RlZmluZSAlcycgJSBleHBlY3RlZF9ndWFyZF0sCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlcnJvcl9jb2xsZWN0b3IpCi0gICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWxzKAotICAgICAgICAgICAgMSwKLSAgICAgICAgICAgIGVycm9y X2NvbGxlY3Rvci5yZXN1bHRfbGlzdCgpLmNvdW50KAotICAgICAgICAgICAgICAgICcjZW5kaWYg bGluZSBzaG91bGQgYmUgIiNlbmRpZiAvLyAlcyInCi0gICAgICAgICAgICAgICAgJyAgW2J1aWxk L2hlYWRlcl9ndWFyZF0gWzVdJyAlIGV4cGVjdGVkX2d1YXJkKSwKLSAgICAgICAgICAgIGVycm9y X2NvbGxlY3Rvci5yZXN1bHRfbGlzdCgpKQotCi0gICAgICAgICMgQ29tbWVudGxlc3MgZW5kaWYK LSAgICAgICAgZXJyb3JfY29sbGVjdG9yID0gRXJyb3JDb2xsZWN0b3Ioc2VsZi5hc3NlcnRfKQot ICAgICAgICBjcHBfc3R5bGUucHJvY2Vzc19maWxlX2RhdGEoZmlsZV9wYXRoLCAnaCcsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBbJyNpZm5kZWYgJXMnICUgZXhwZWN0ZWRf Z3VhcmQsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNkZWZpbmUgJXMn ICUgZXhwZWN0ZWRfZ3VhcmQsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg JyNlbmRpZiddLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZXJyb3JfY29s bGVjdG9yKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFscygKLSAgICAgICAgICAgIDEsCi0gICAg ICAgICAgICBlcnJvcl9jb2xsZWN0b3IucmVzdWx0X2xpc3QoKS5jb3VudCgKLSAgICAgICAgICAg ICAgICAnI2VuZGlmIGxpbmUgc2hvdWxkIGJlICIjZW5kaWYgLy8gJXMiJwotICAgICAgICAgICAg ICAgICcgIFtidWlsZC9oZWFkZXJfZ3VhcmRdIFs1XScgJSBleHBlY3RlZF9ndWFyZCksCi0gICAg ICAgICAgICBlcnJvcl9jb2xsZWN0b3IucmVzdWx0X2xpc3QoKSkKLQotICAgICAgICAjIENvbW1l bnRsZXNzIGVuZGlmIGZvciBvbGQtc3R5bGUgZ3VhcmQKLSAgICAgICAgZXJyb3JfY29sbGVjdG9y ID0gRXJyb3JDb2xsZWN0b3Ioc2VsZi5hc3NlcnRfKQotICAgICAgICBjcHBfc3R5bGUucHJvY2Vz c19maWxlX2RhdGEoZmlsZV9wYXRoLCAnaCcsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBbJyNpZm5kZWYgJXNfJyAlIGV4cGVjdGVkX2d1YXJkLAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICcjZGVmaW5lICVzXycgJSBleHBlY3RlZF9ndWFyZCwKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2VuZGlmJ10sCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBlcnJvcl9jb2xsZWN0b3IpCi0gICAgICAgIHNlbGYu YXNzZXJ0RXF1YWxzKAotICAgICAgICAgICAgMSwKLSAgICAgICAgICAgIGVycm9yX2NvbGxlY3Rv ci5yZXN1bHRfbGlzdCgpLmNvdW50KAotICAgICAgICAgICAgICAgICcjZW5kaWYgbGluZSBzaG91 bGQgYmUgIiNlbmRpZiAvLyAlcyInCi0gICAgICAgICAgICAgICAgJyAgW2J1aWxkL2hlYWRlcl9n dWFyZF0gWzVdJyAlIGV4cGVjdGVkX2d1YXJkKSwKLSAgICAgICAgICAgIGVycm9yX2NvbGxlY3Rv ci5yZXN1bHRfbGlzdCgpKQotCiAgICAgICAgICMgTm8gaGVhZGVyIGd1YXJkIGVycm9ycwogICAg ICAgICBlcnJvcl9jb2xsZWN0b3IgPSBFcnJvckNvbGxlY3RvcihzZWxmLmFzc2VydF8pCiAgICAg ICAgIGNwcF9zdHlsZS5wcm9jZXNzX2ZpbGVfZGF0YShmaWxlX3BhdGgsICdoJywKQEAgLTE3Nzks MTIgKzE3MzgsNiBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAg ICAgICAgICAgICAgJyNpZm5kZWYgaGVhZGVyIGd1YXJkIGhhcyB3cm9uZyBzdHlsZSwgcGxlYXNl IHVzZTogJXMnCiAgICAgICAgICAgICAgICAgJyAgW2J1aWxkL2hlYWRlcl9ndWFyZF0gWzVdJyAl IGV4cGVjdGVkX2d1YXJkKSwKICAgICAgICAgICAgIGVycm9yX2NvbGxlY3Rvci5yZXN1bHRfbGlz dCgpKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFscygKLSAgICAgICAgICAgIDEsCi0gICAgICAg ICAgICBlcnJvcl9jb2xsZWN0b3IucmVzdWx0X2xpc3QoKS5jb3VudCgKLSAgICAgICAgICAgICAg ICAnI2VuZGlmIGxpbmUgc2hvdWxkIGJlICIjZW5kaWYgLy8gJXMiJwotICAgICAgICAgICAgICAg ICcgIFtidWlsZC9oZWFkZXJfZ3VhcmRdIFs1XScgJSBleHBlY3RlZF9ndWFyZCksCi0gICAgICAg ICAgICBlcnJvcl9jb2xsZWN0b3IucmVzdWx0X2xpc3QoKSkKIAogICAgIGRlZiB0ZXN0X2J1aWxk X3ByaW50Zl9mb3JtYXQoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCg==