33210 2010-01-05 07:49:06 -0800 EventSource should support receiving empty events and events with newline characters only 2010-03-15 21:59:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 adam.bergkvist webkit-unassigned commit-queue eric webkit.review.bot oldest_to_newest 177151 0 adam.bergkvist 2010-01-05 07:49:06 -0800 According to the updated specification, EventSource should support receiving empty events and events with newline characters only. 177153 1 45891 adam.bergkvist 2010-01-05 07:57:17 -0800 Created attachment 45891 patch Proposed patch. 177156 2 webkit.review.bot 2010-01-05 08:00:32 -0800 style-queue ran check-webkit-style on attachment 45891 without any errors. 177164 3 45891 darin 2010-01-05 08:34:37 -0800 Comment on attachment 45891 patch Are the two code changes here separate fixes? How do the code changes relate to the desired behavior? What is the removeLast for? I think the comments in the change log are too terse. They assume that it's obvious what is wrong here and why this fixes it. Let those things are not clear to me. 177302 4 45891 eric 2010-01-05 12:25:01 -0800 Comment on attachment 45891 patch I agree with Darin, this change is unreviewable. It's not clear from the ChagneLog or from the code comments what you're trying to do here. 178191 5 46054 adam.bergkvist 2010-01-07 08:34:28 -0800 Created attachment 46054 updated patch I agree that the ChangeLog message was insufficient. Here's an updated patch with more descriptive message in the ChangeLog. The diff of the specification change in question: http://html5.org/tools/web-apps-tracker?from=4078&to=4079 178193 6 webkit.review.bot 2010-01-07 08:38:37 -0800 style-queue ran check-webkit-style on attachment 46054 without any errors. 191248 7 eric 2010-02-17 15:12:18 -0800 You mention the "updated specification" in the ChangeLog, but a link would be much more helpful. Especially one which points to the paragraph in question. I don't even know what specification is under discussion here. 197223 8 46054 abarth 2010-03-08 10:39:22 -0800 Comment on attachment 46054 updated patch The code looks reasonable. I haven't validated that this behavior actually matches what the spec requires, but I'm trusting Adam here. 200000 9 46054 commit-queue 2010-03-15 21:59:03 -0700 Comment on attachment 46054 updated patch Clearing flags on attachment: 46054 Committed r56035: <http://trac.webkit.org/changeset/56035> 200002 10 commit-queue 2010-03-15 21:59:09 -0700 All reviewed patches have been landed. Closing bug. 45891 2010-01-05 07:57:17 -0800 2010-01-07 08:34:28 -0800 patch eventsource_empty_data_r52792.patch text/plain 4657 adam.bergkvist ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmODFhZTI2Li45MWEzMDQwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEt MDUgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24uY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZWQgRXZlbnRT b3VyY2UgdG8gc3VwcG9ydCByZWNlaXZpbmcgZW1wdHkgZXZlbnRzIGFuZCBldmVudHMgd2l0aAor ICAgICAgICBuZXdsaW5lIGNoYXJhY3RlcnMgb25seS4gVXBkYXRlZCB0ZXN0IGFjY29yZGluZ2x5 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMyMTAK KworICAgICAgICAqIGh0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtcGFyc2UtZXZl bnQtc3RyZWFtLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL2V2ZW50c291cmNl L2V2ZW50c291cmNlLXBhcnNlLWV2ZW50LXN0cmVhbS5odG1sOgorICAgICAgICAqIGh0dHAvdGVz dHMvZXZlbnRzb3VyY2UvcmVzb3VyY2VzL2V2ZW50LXN0cmVhbS5waHA6CisKIDIwMTAtMDEtMDQg IENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZl bnRzb3VyY2UvZXZlbnRzb3VyY2UtcGFyc2UtZXZlbnQtc3RyZWFtLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtcGFyc2UtZXZlbnQt c3RyZWFtLWV4cGVjdGVkLnR4dAppbmRleCA3ZmM4MjNkLi5jOTc2ZDFlIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50c291cmNlL2V2ZW50c291cmNlLXBhcnNlLWV2ZW50 LXN0cmVhbS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudHNv dXJjZS9ldmVudHNvdXJjZS1wYXJzZS1ldmVudC1zdHJlYW0tZXhwZWN0ZWQudHh0CkBAIC0xLDYg KzEsNyBAQAogVGVzdCBFdmVudFNvdXJjZSB0ZXh0L2V2ZW50LXN0cmVhbSBwYXJzaW5nLiBTaG91 bGQgcHJpbnQgYSBzZXJpZXMgb2YgUEFTUyBtZXNzYWdlcyBmb2xsb3dlZCBieSBET05FLgogCiBQ QVNTOiBnb3Qgb3BlbiBldmVudAorUEFTUzogcmVjZWl2ZWQgZXZlbnQgd2l0aCB0d28gbmV3bGlu ZXMKIFBBU1M6IHJlY2VpdmVkIGV2ZW50IHdpdGggZGF0YSAic2ltcGxlIgogUEFTUzogcmVjZWl2 ZWQgZXZlbnQgd2l0aCBkYXRhIHNwYW5uaW5nIG11bHRpcGxlIGxpbmVzCiBQQVNTOiByZWNlaXZl ZCBldmVudCBhbmQgbGFzdEV2ZW50SWQgaXMgIjEiCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL2V2ZW50c291cmNlL2V2ZW50c291cmNlLXBhcnNlLWV2ZW50LXN0cmVhbS5odG1s IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1wYXJzZS1l dmVudC1zdHJlYW0uaHRtbAppbmRleCBkYTcxMTY5Li4wM2FjOThhIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50c291cmNlL2V2ZW50c291cmNlLXBhcnNlLWV2ZW50LXN0 cmVhbS5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRz b3VyY2UtcGFyc2UtZXZlbnQtc3RyZWFtLmh0bWwKQEAgLTEyLDcgKzEyLDcgQEAgaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRV bnRpbERvbmUoKTsKIH0KIAotdmFyIGNvdW50ID0gMDsKK3ZhciBjb3VudCA9IC0xOwogdmFyIGVz ID0gbmV3IEV2ZW50U291cmNlKCJyZXNvdXJjZXMvZXZlbnQtc3RyZWFtLnBocCIpOwogCiBlcy5v bm9wZW4gPSBmdW5jdGlvbiAoZXZ0KSB7CkBAIC0yNCw2ICsyNCwxMCBAQCBlcy5vbm9wZW4gPSBm dW5jdGlvbiAoZXZ0KSB7CiAKIGVzLm9ubWVzc2FnZSA9IGZ1bmN0aW9uIChldnQpIHsKICAgICBz d2l0Y2goY291bnQrKykgeworICAgICAgICBjYXNlIC0xOgorICAgICAgICAgICAgaWYgKGV2dC5k YXRhID09ICJcblxuIikKKyAgICAgICAgICAgICAgICBsb2coIlBBU1M6IHJlY2VpdmVkIGV2ZW50 IHdpdGggdHdvIG5ld2xpbmVzIik7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSAw OgogICAgICAgICAgICAgaWYgKGV2dC5kYXRhID09ICJzaW1wbGUiKQogICAgICAgICAgICAgICAg IGxvZygiUEFTUzogcmVjZWl2ZWQgZXZlbnQgd2l0aCBkYXRhIFwic2ltcGxlXCIiKTsKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvcmVzb3VyY2VzL2V2ZW50 LXN0cmVhbS5waHAgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50c291cmNlL3Jlc291cmNl cy9ldmVudC1zdHJlYW0ucGhwCmluZGV4IGM5MDM5NmEuLmY5ZTUwNWYgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvcmVzb3VyY2VzL2V2ZW50LXN0cmVhbS5w aHAKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudHNvdXJjZS9yZXNvdXJjZXMvZXZl bnQtc3RyZWFtLnBocApAQCAtMTIsNyArMTIsNyBAQCBkYXRhIDogdGhpcyBsaW5lIHdpbGwgYmUg aWdub3JlZCBzaW5jZSB0aGVyZSBpcyBhIHNwYWNlIGFmdGVyIGRhdGEKIGRhdGEKIGRhdGE6CiBk YXRhCi06IG5vIGRpc3BhdGNoIHNpbmNlIGRhdGEgYnVmZmVyIGlzIGVtcHR5Cis6IGRpc3BhdGNo IGV2ZW50IHdpdGggdHdvIG5ld2xpbmVzCiAKIGRhdGE6IHNpbXBsZQogCmRpZmYgLS1naXQgYS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGY1MmM0NDEuLjkwYjUz ODIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEtMDUgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJn a3Zpc3RAZXJpY3Nzb24uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFVwZGF0ZWQgRXZlbnRTb3VyY2UgdG8gc3VwcG9ydCByZWNlaXZpbmcgZW1w dHkgZXZlbnRzIGFuZCBldmVudHMgd2l0aAorICAgICAgICBuZXdsaW5lIGNoYXJhY3RlcnMgb25s eS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMjEw CisKKyAgICAgICAgKiBwYWdlL0V2ZW50U291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2 ZW50U291cmNlOjpwYXJzZUV2ZW50U3RyZWFtTGluZSk6CisKIDIwMTAtMDEtMDUgIFNpbW9uIEhh dXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFRvciBBcm5lIFZlc3Riw7guCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvRXZlbnRTb3VyY2Uu Y3BwIGIvV2ViQ29yZS9wYWdlL0V2ZW50U291cmNlLmNwcAppbmRleCAyYzlhMzQzLi45NmM5Mzgx IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvRXZlbnRTb3VyY2UuY3BwCisrKyBiL1dlYkNvcmUv cGFnZS9FdmVudFNvdXJjZS5jcHAKQEAgLTI0Niw4ICsyNDYsMTAgQEAgdm9pZCBFdmVudFNvdXJj ZTo6cGFyc2VFdmVudFN0cmVhbSgpCiB2b2lkIEV2ZW50U291cmNlOjpwYXJzZUV2ZW50U3RyZWFt TGluZSh1bnNpZ25lZCBpbnQgYnVmUG9zLCBpbnQgZmllbGRMZW5ndGgsIGludCBsaW5lTGVuZ3Ro KQogewogICAgIGlmICghbGluZUxlbmd0aCkgewotICAgICAgICBpZiAoIW1fZGF0YS5pc0VtcHR5 KCkpCisgICAgICAgIGlmICghbV9kYXRhLmlzRW1wdHkoKSkgeworICAgICAgICAgICAgbV9kYXRh LnJlbW92ZUxhc3QoKTsKICAgICAgICAgICAgIGRpc3BhdGNoRXZlbnQoY3JlYXRlTWVzc2FnZUV2 ZW50KCkpOworICAgICAgICB9CiAgICAgICAgIGlmICghbV9ldmVudE5hbWUuaXNFbXB0eSgpKQog ICAgICAgICAgICAgbV9ldmVudE5hbWUgPSAiIjsKICAgICB9IGVsc2UgaWYgKGZpZWxkTGVuZ3Ro KSB7CkBAIC0yNjUsMTAgKzI2Nyw5IEBAIHZvaWQgRXZlbnRTb3VyY2U6OnBhcnNlRXZlbnRTdHJl YW1MaW5lKHVuc2lnbmVkIGludCBidWZQb3MsIGludCBmaWVsZExlbmd0aCwgaW50CiAgICAgICAg IGludCB2YWx1ZUxlbmd0aCA9IGxpbmVMZW5ndGggLSBzdGVwOwogCiAgICAgICAgIGlmIChmaWVs ZCA9PSAiZGF0YSIpIHsKLSAgICAgICAgICAgIGlmIChtX2RhdGEuc2l6ZSgpID4gMCkKLSAgICAg ICAgICAgICAgICBtX2RhdGEuYXBwZW5kKCdcbicpOwogICAgICAgICAgICAgaWYgKHZhbHVlTGVu Z3RoKQogICAgICAgICAgICAgICAgIG1fZGF0YS5hcHBlbmQoJm1fcmVjZWl2ZUJ1ZltidWZQb3Nd LCB2YWx1ZUxlbmd0aCk7CisgICAgICAgICAgICBtX2RhdGEuYXBwZW5kKCdcbicpOwogICAgICAg ICB9IGVsc2UgaWYgKGZpZWxkID09ICJldmVudCIpCiAgICAgICAgICAgICBtX2V2ZW50TmFtZSA9 IHZhbHVlTGVuZ3RoID8gU3RyaW5nKCZtX3JlY2VpdmVCdWZbYnVmUG9zXSwgdmFsdWVMZW5ndGgp IDogIiI7CiAgICAgICAgIGVsc2UgaWYgKGZpZWxkID09ICJpZCIpCg== 46054 2010-01-07 08:34:28 -0800 2010-03-15 21:59:03 -0700 updated patch eventsource_empty_data_r52909.patch text/plain 5585 adam.bergkvist ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjOWJlNDg3Li5hZGY4YmFlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDEt MDcgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24uY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFjY29yZGluZyB0byB0 aGUgdXBkYXRlZCBzcGVjaWZpY2F0aW9uLCBhIGRhdGEgZmllbGQgc2hvdWxkIGFsd2F5cworICAg ICAgICByZXN1bHQgaW4gYSBuZXdsaW5lIGNoYXJhY3RlciBiZWluZyBhcHBlbmRlZCB0byB0aGUg ZGF0YSBidWZmZXIKKyAgICAgICAgcmVnYXJkbGVzcyBpZiB0aGUgZGF0YSBidWZmZXIgY29udGFp bnMgYW55IGRhdGEgb3Igbm90LiBIb3dldmVyLCB1cG9uCisgICAgICAgIGV2ZW50IGRpc3BhdGNo LCB0aGUgbGFzdCBuZXdsaW5lIHdpbGwgYmUgcmVtb3ZlZC4gVGhpcyBkaWZmZXJzIGZyb20gYW4K KyAgICAgICAgb2xkZXIgdmVyc2lvbiBvZiB0aGUgc3BlY2lmaWNhdGlvbiB3aGVyZSBhIG5ld2xp bmUgY2hhcmFjdGVyIHdhcworICAgICAgICBhcHBlbmRlZCBiZWZvcmUgdGhlIGRhdGEgdmFsdWUg b25seSBpZiB0aGUgYnVmZmVyIGFscmVhZHkgY29udGFpbmVkCisgICAgICAgIGRhdGEuIEFzIGEg cmVzdWx0LCBFdmVudFNvdXJjZSBub3cgc3VwcG9ydHMgcmVjZWl2aW5nIGV2ZW50cyB3aXRoIGVt cHR5CisgICAgICAgIGRhdGEgb3IgbmV3bGluZSBjaGFyYWN0ZXJzIG9ubHkuIFVwZGF0ZWQgdGVz dCBhY2NvcmRpbmdseS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMzMjEwCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL2V2ZW50c291cmNlL2V2ZW50c291 cmNlLXBhcnNlLWV2ZW50LXN0cmVhbS1leHBlY3RlZC50eHQ6CisgICAgICAgICogaHR0cC90ZXN0 cy9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1wYXJzZS1ldmVudC1zdHJlYW0uaHRtbDoKKyAgICAg ICAgKiBodHRwL3Rlc3RzL2V2ZW50c291cmNlL3Jlc291cmNlcy9ldmVudC1zdHJlYW0ucGhwOgor CiAyMDEwLTAxLTA2ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnbWFpbC5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgTmlrb2xhcyBaaW1tZXJtYW5uLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1wYXJzZS1ldmVudC1zdHJlYW0t ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudHNvdXJjZS9ldmVudHNv dXJjZS1wYXJzZS1ldmVudC1zdHJlYW0tZXhwZWN0ZWQudHh0CmluZGV4IGY0M2NlYWEuLjliYTBj MjcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRz b3VyY2UtcGFyc2UtZXZlbnQtc3RyZWFtLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL2V2ZW50c291cmNlL2V2ZW50c291cmNlLXBhcnNlLWV2ZW50LXN0cmVhbS1leHBl Y3RlZC50eHQKQEAgLTEsNiArMSw3IEBACiBUZXN0IEV2ZW50U291cmNlIHRleHQvZXZlbnQtc3Ry ZWFtIHBhcnNpbmcuIFNob3VsZCBwcmludCBhIHNlcmllcyBvZiBQQVNTIG1lc3NhZ2VzIGZvbGxv d2VkIGJ5IERPTkUuCiAKIFBBU1M6IGdvdCBvcGVuIGV2ZW50CitQQVNTOiByZWNlaXZlZCBldmVu dCB3aXRoIHR3byBuZXdsaW5lcwogUEFTUzogcmVjZWl2ZWQgZXZlbnQgd2l0aCBkYXRhICJzaW1w bGUiCiBQQVNTOiByZWNlaXZlZCBldmVudCB3aXRoIGRhdGEgc3Bhbm5pbmcgbXVsdGlwbGUgbGlu ZXMKIFBBU1M6IHJlY2VpdmVkIGV2ZW50IGFuZCBsYXN0RXZlbnRJZCBpcyAiMSIKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtcGFyc2Ut ZXZlbnQtc3RyZWFtLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50c291cmNlL2V2 ZW50c291cmNlLXBhcnNlLWV2ZW50LXN0cmVhbS5odG1sCmluZGV4IDUyNWMyNjcuLjYwY2IxNGEg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRzb3Vy Y2UtcGFyc2UtZXZlbnQtc3RyZWFtLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9l dmVudHNvdXJjZS9ldmVudHNvdXJjZS1wYXJzZS1ldmVudC1zdHJlYW0uaHRtbApAQCAtMTIsNyAr MTIsNyBAQCBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiAgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwogfQogCi12YXIgY291bnQgPSAwOwordmFyIGNv dW50ID0gLTE7CiB2YXIgZXMgPSBuZXcgRXZlbnRTb3VyY2UoInJlc291cmNlcy9ldmVudC1zdHJl YW0ucGhwIik7CiAKIGVzLm9ub3BlbiA9IGZ1bmN0aW9uIChldnQpIHsKQEAgLTI0LDYgKzI0LDEw IEBAIGVzLm9ub3BlbiA9IGZ1bmN0aW9uIChldnQpIHsKIAogZXMub25tZXNzYWdlID0gZnVuY3Rp b24gKGV2dCkgewogICAgIHN3aXRjaChjb3VudCsrKSB7CisgICAgICAgIGNhc2UgLTE6CisgICAg ICAgICAgICBpZiAoZXZ0LmRhdGEgPT0gIlxuXG4iKQorICAgICAgICAgICAgICAgIGxvZygiUEFT UzogcmVjZWl2ZWQgZXZlbnQgd2l0aCB0d28gbmV3bGluZXMiKTsKKyAgICAgICAgICAgIGJyZWFr OwogICAgICAgICBjYXNlIDA6CiAgICAgICAgICAgICBpZiAoZXZ0LmRhdGEgPT0gInNpbXBsZSIp CiAgICAgICAgICAgICAgICAgbG9nKCJQQVNTOiByZWNlaXZlZCBldmVudCB3aXRoIGRhdGEgXCJz aW1wbGVcIiIpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudHNvdXJj ZS9yZXNvdXJjZXMvZXZlbnQtc3RyZWFtLnBocCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZl bnRzb3VyY2UvcmVzb3VyY2VzL2V2ZW50LXN0cmVhbS5waHAKaW5kZXggMzEyYjI5Zi4uNGU2NWZl ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudHNvdXJjZS9yZXNvdXJj ZXMvZXZlbnQtc3RyZWFtLnBocAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50c291 cmNlL3Jlc291cmNlcy9ldmVudC1zdHJlYW0ucGhwCkBAIC0xMiw3ICsxMiw3IEBAIGRhdGEgOiB0 aGlzIGxpbmUgd2lsbCBiZSBpZ25vcmVkIHNpbmNlIHRoZXJlIGlzIGEgc3BhY2UgYWZ0ZXIgZGF0 YQogZGF0YQogZGF0YToKIGRhdGEKLTogbm8gZGlzcGF0Y2ggc2luY2UgZGF0YSBidWZmZXIgaXMg ZW1wdHkKKzogZGlzcGF0Y2ggZXZlbnQgd2l0aCB0d28gbmV3bGluZXMKIAogZGF0YTogc2ltcGxl CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggMDJmM2UxYS4uMWUxM2E0NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wMS0wNyAgQWRhbSBCZXJn a3Zpc3QgIDxhZGFtLmJlcmdrdmlzdEBlcmljc3Nvbi5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjb3JkaW5nIHRvIHRoZSB1cGRhdGVkIHNw ZWNpZmljYXRpb24sIGEgZGF0YSBmaWVsZCBzaG91bGQgYWx3YXlzCisgICAgICAgIHJlc3VsdCBp biBhIG5ld2xpbmUgY2hhcmFjdGVyIGJlaW5nIGFwcGVuZGVkIHRvIHRoZSBkYXRhIGJ1ZmZlcgor ICAgICAgICByZWdhcmRsZXNzIGlmIHRoZSBkYXRhIGJ1ZmZlciBjb250YWlucyBhbnkgZGF0YSBv ciBub3QuIEhvd2V2ZXIsIHVwb24KKyAgICAgICAgZXZlbnQgZGlzcGF0Y2gsIHRoZSBsYXN0IG5l d2xpbmUgd2lsbCBiZSByZW1vdmVkLiBUaGlzIGRpZmZlcnMgZnJvbSBhbgorICAgICAgICBvbGRl ciB2ZXJzaW9uIG9mIHRoZSBzcGVjaWZpY2F0aW9uIHdoZXJlIGEgbmV3bGluZSBjaGFyYWN0ZXIg d2FzCisgICAgICAgIGFwcGVuZGVkIGJlZm9yZSB0aGUgZGF0YSB2YWx1ZSBvbmx5IGlmIHRoZSBi dWZmZXIgYWxyZWFkeSBjb250YWluZWQKKyAgICAgICAgZGF0YS4gQXMgYSByZXN1bHQsIEV2ZW50 U291cmNlIG5vdyBzdXBwb3J0cyByZWNlaXZpbmcgZXZlbnRzIHdpdGggZW1wdHkKKyAgICAgICAg ZGF0YSBvciBuZXdsaW5lIGNoYXJhY3RlcnMgb25seS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMjEwCisKKyAgICAgICAgKiBwYWdlL0V2ZW50U291 cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50U291cmNlOjpwYXJzZUV2ZW50U3RyZWFt TGluZSk6CisKIDIwMTAtMDEtMDcgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9w YWdlL0V2ZW50U291cmNlLmNwcCBiL1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5jcHAKaW5kZXgg MGM3OTk5OC4uOWNjY2NkNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0V2ZW50U291cmNlLmNw cAorKysgYi9XZWJDb3JlL3BhZ2UvRXZlbnRTb3VyY2UuY3BwCkBAIC0yNTAsOCArMjUwLDEwIEBA IHZvaWQgRXZlbnRTb3VyY2U6OnBhcnNlRXZlbnRTdHJlYW0oKQogdm9pZCBFdmVudFNvdXJjZTo6 cGFyc2VFdmVudFN0cmVhbUxpbmUodW5zaWduZWQgaW50IGJ1ZlBvcywgaW50IGZpZWxkTGVuZ3Ro LCBpbnQgbGluZUxlbmd0aCkKIHsKICAgICBpZiAoIWxpbmVMZW5ndGgpIHsKLSAgICAgICAgaWYg KCFtX2RhdGEuaXNFbXB0eSgpKQorICAgICAgICBpZiAoIW1fZGF0YS5pc0VtcHR5KCkpIHsKKyAg ICAgICAgICAgIG1fZGF0YS5yZW1vdmVMYXN0KCk7CiAgICAgICAgICAgICBkaXNwYXRjaEV2ZW50 KGNyZWF0ZU1lc3NhZ2VFdmVudCgpKTsKKyAgICAgICAgfQogICAgICAgICBpZiAoIW1fZXZlbnRO YW1lLmlzRW1wdHkoKSkKICAgICAgICAgICAgIG1fZXZlbnROYW1lID0gIiI7CiAgICAgfSBlbHNl IGlmIChmaWVsZExlbmd0aCkgewpAQCAtMjY5LDEwICsyNzEsOSBAQCB2b2lkIEV2ZW50U291cmNl OjpwYXJzZUV2ZW50U3RyZWFtTGluZSh1bnNpZ25lZCBpbnQgYnVmUG9zLCBpbnQgZmllbGRMZW5n dGgsIGludAogICAgICAgICBpbnQgdmFsdWVMZW5ndGggPSBsaW5lTGVuZ3RoIC0gc3RlcDsKIAog ICAgICAgICBpZiAoZmllbGQgPT0gImRhdGEiKSB7Ci0gICAgICAgICAgICBpZiAobV9kYXRhLnNp emUoKSA+IDApCi0gICAgICAgICAgICAgICAgbV9kYXRhLmFwcGVuZCgnXG4nKTsKICAgICAgICAg ICAgIGlmICh2YWx1ZUxlbmd0aCkKICAgICAgICAgICAgICAgICBtX2RhdGEuYXBwZW5kKCZtX3Jl Y2VpdmVCdWZbYnVmUG9zXSwgdmFsdWVMZW5ndGgpOworICAgICAgICAgICAgbV9kYXRhLmFwcGVu ZCgnXG4nKTsKICAgICAgICAgfSBlbHNlIGlmIChmaWVsZCA9PSAiZXZlbnQiKQogICAgICAgICAg ICAgbV9ldmVudE5hbWUgPSB2YWx1ZUxlbmd0aCA/IFN0cmluZygmbV9yZWNlaXZlQnVmW2J1ZlBv c10sIHZhbHVlTGVuZ3RoKSA6ICIiOwogICAgICAgICBlbHNlIGlmIChmaWVsZCA9PSAiaWQiKQo=