33207 2010-01-05 07:00:10 -0800 EventSource event-stream parser should support a single CR as line ending 2010-01-06 18:20:14 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 adam.bergkvist webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 177130 0 adam.bergkvist 2010-01-05 07:00:10 -0800 According to the specification the event-stream parser should support a single CR as line ending in addition to CRLF and a single LF. 177133 1 45885 adam.bergkvist 2010-01-05 07:09:33 -0800 Created attachment 45885 patch Proposed patch. 177135 2 webkit.review.bot 2010-01-05 07:12:10 -0800 style-queue ran check-webkit-style on attachment 45885 without any errors. 177908 3 45885 commit-queue 2010-01-06 18:20:10 -0800 Comment on attachment 45885 patch Clearing flags on attachment: 45885 Committed r52891: <http://trac.webkit.org/changeset/52891> 177909 4 commit-queue 2010-01-06 18:20:14 -0800 All reviewed patches have been landed. Closing bug. 45885 2010-01-05 07:09:33 -0800 2010-01-06 18:20:09 -0800 patch eventsource_cr_r52792.patch text/plain 6017 adam.bergkvist ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmODFhZTI2Li4yMzk0MjUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEt MDUgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24uY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vZGlmaWVkIEV2ZW50 U291cmNlIGV2ZW50LXN0cmVhbSBwYXJzZXIgdG8gc3VwcG9ydCBhIHNpbmdsZSBDUiBhcyBsaW5l IGVuZGluZy4KKyAgICAgICAgVXBkYXRlZCB0ZXN0IGFjY29yZGluZ2x5LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMyMDcKKworICAgICAgICAqIGh0 dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtcGFyc2UtZXZlbnQtc3RyZWFtLWV4cGVj dGVkLnR4dDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL2V2ZW50c291cmNlL2V2ZW50c291cmNlLXBh cnNlLWV2ZW50LXN0cmVhbS5odG1sOgorICAgICAgICAqIGh0dHAvdGVzdHMvZXZlbnRzb3VyY2Uv cmVzb3VyY2VzL2V2ZW50LXN0cmVhbS5waHA6CisKIDIwMTAtMDEtMDQgIENocmlzIEZsZWl6YWNo ICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxl ci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRz b3VyY2UtcGFyc2UtZXZlbnQtc3RyZWFtLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtcGFyc2UtZXZlbnQtc3RyZWFtLWV4cGVjdGVk LnR4dAppbmRleCA3ZmM4MjNkLi5mNDNjZWFhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL2V2ZW50c291cmNlL2V2ZW50c291cmNlLXBhcnNlLWV2ZW50LXN0cmVhbS1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudHNvdXJjZS9ldmVudHNvdXJj ZS1wYXJzZS1ldmVudC1zdHJlYW0tZXhwZWN0ZWQudHh0CkBAIC04LDYgKzgsNiBAQCBQQVNTOiBy ZWNlaXZlZCBldmVudCBhbmQgbGFzdEV2ZW50SWQgaXMgc3RpbGwgIjEiCiBQQVNTOiByZWNlaXZl ZCBldmVudCBhbmQgbGFzdEV2ZW50SWQgaGFzIGJlZW4gY2xlYXJlZAogUEFTUzogZ290IG9wZW4g ZXZlbnQgZnJvbSBzZXJ2ZXIKIFBBU1M6IHJlY2VpdmVkIGV2ZW50IGFuZCB0aGUgZXZlbnQgbmFt ZSBoYXMgYmVlbiByZXNldAotUEFTUzogcmVjZWl2ZWQgZXZlbnQgd2l0aCBkYXRhIHRoYXQgY29u dGFpbnMgYSBjb2xvbiBhbmQgYSBjYXJyaWFnZSByZXR1cm4KK1BBU1M6IHJlY2VpdmVkIGV2ZW50 IHdpdGggZGF0YSB0aGF0IGNvbnRhaW5zIGEgY29sb24KIERPTkUKIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1wYXJzZS1ldmVudC1z dHJlYW0uaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRzb3Vy Y2UtcGFyc2UtZXZlbnQtc3RyZWFtLmh0bWwKaW5kZXggZGE3MTE2OS4uNTI1YzI2NyAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1wYXJz ZS1ldmVudC1zdHJlYW0uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50c291 cmNlL2V2ZW50c291cmNlLXBhcnNlLWV2ZW50LXN0cmVhbS5odG1sCkBAIC00OSw4ICs0OSw4IEBA IGVzLm9ubWVzc2FnZSA9IGZ1bmN0aW9uIChldnQpIHsKICAgICAgICAgICAgICAgICBsb2coIlBB U1M6IHJlY2VpdmVkIGV2ZW50IGFuZCB0aGUgZXZlbnQgbmFtZSBoYXMgYmVlbiByZXNldCIpOwog ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgNjoKLSAgICAgICAgICAgIGlmIChldnQu ZGF0YSA9PSAiYSBsaW5lIGVuZGluZyB3aXRoIGNybGZcbmEgbGluZSB3aXRoIGEgOiAoY29sb24p XG5hIGxpbmUgd2l0aCBhIFxyIChjYXJyaWFnZSByZXR1cm4pIikKLSAgICAgICAgICAgICAgICBs b2coIlBBU1M6IHJlY2VpdmVkIGV2ZW50IHdpdGggZGF0YSB0aGF0IGNvbnRhaW5zIGEgY29sb24g YW5kIGEgY2FycmlhZ2UgcmV0dXJuIik7CisgICAgICAgICAgICBpZiAoZXZ0LmRhdGEgPT0gImEg bGluZSBlbmRpbmcgd2l0aCBjcmxmXG5hIGxpbmUgd2l0aCBhIDogKGNvbG9uKVxuYSBsaW5lIGVu ZGluZyB3aXRoIGNyIik7CisgICAgICAgICAgICAgICAgbG9nKCJQQVNTOiByZWNlaXZlZCBldmVu dCB3aXRoIGRhdGEgdGhhdCBjb250YWlucyBhIGNvbG9uIik7CiAgICAgICAgICAgICBicmVhazsK ICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgIGxvZygiRkFJTDogZ290IHVuZXhwZWN0ZWQg ZXZlbnQiKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2Uv cmVzb3VyY2VzL2V2ZW50LXN0cmVhbS5waHAgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2V2ZW50 c291cmNlL3Jlc291cmNlcy9ldmVudC1zdHJlYW0ucGhwCmluZGV4IGM5MDM5NmEuLjMxMmIyOWYg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZXZlbnRzb3VyY2UvcmVzb3VyY2Vz L2V2ZW50LXN0cmVhbS5waHAKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9ldmVudHNvdXJj ZS9yZXNvdXJjZXMvZXZlbnQtc3RyZWFtLnBocApAQCAtMzgsNyArMzgsNyBAQCB0YTogYSBtZXNz YWdlIGV2ZW50IHdpdGggdGhlIG5hbWUgIm1lc3NhZ2UiCiAKIDw/cGhwIGVjaG8gImRhdGE6IGEg bGluZSBlbmRpbmcgd2l0aCBjcmxmXHJcbiI7ID8+CiBkYXRhOiBhIGxpbmUgd2l0aCBhIDogKGNv bG9uKQotPD9waHAgZWNobyAiZGF0YTogYSBsaW5lIHdpdGggYSBcciAoY2FycmlhZ2UgcmV0dXJu KVxuIjsgPz4KKzw/cGhwIGVjaG8gImRhdGE6IGEgbGluZSBlbmRpbmcgd2l0aCBjclxyIjsgPz4K IAogcmV0cnk6IDEwMDAwCiA6IHJlY29ubmVjdGlvbiB0aW1lIHNldCB0byAxMCBzZWNvbmRzCmRp ZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGY1 MmM0NDEuLjRlMzVhZWIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEtMDUgIEFkYW0gQmVyZ2t2aXN0 ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vZGlmaWVkIEV2ZW50U291cmNlIGV2ZW50LXN0cmVh bSBwYXJzZXIgdG8gc3VwcG9ydCBhIHNpbmdsZSBDUiBhcyBsaW5lIGVuZGluZy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMjA3CisKKyAgICAgICAg KiBwYWdlL0V2ZW50U291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50U291cmNlOjpF dmVudFNvdXJjZSk6CisgICAgICAgIChXZWJDb3JlOjpFdmVudFNvdXJjZTo6cGFyc2VFdmVudFN0 cmVhbSk6CisgICAgICAgICogcGFnZS9FdmVudFNvdXJjZS5oOgorCiAyMDEwLTAxLTA1ICBTaW1v biBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBUb3IgQXJuZSBWZXN0YsO4LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL0V2ZW50U291 cmNlLmNwcCBiL1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5jcHAKaW5kZXggMmM5YTM0My4uMGM3 OTk5OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0V2ZW50U291cmNlLmNwcAorKysgYi9XZWJD b3JlL3BhZ2UvRXZlbnRTb3VyY2UuY3BwCkBAIC01Nyw2ICs1Nyw3IEBAIEV2ZW50U291cmNlOjpF dmVudFNvdXJjZShjb25zdCBTdHJpbmcmIHVybCwgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29u dGV4dCwgRXhjCiAgICAgOiBBY3RpdmVET01PYmplY3QoY29udGV4dCwgdGhpcykKICAgICAsIG1f c3RhdGUoQ09OTkVDVElORykKICAgICAsIG1fcmVjb25uZWN0VGltZXIodGhpcywgJkV2ZW50U291 cmNlOjpyZWNvbm5lY3RUaW1lckZpcmVkKQorICAgICwgbV9kaXNjYXJkVHJhaWxpbmdOZXdsaW5l KGZhbHNlKQogICAgICwgbV9mYWlsU2lsZW50bHkoZmFsc2UpCiAgICAgLCBtX3JlcXVlc3RJbkZs aWdodChmYWxzZSkKICAgICAsIG1fcmVjb25uZWN0RGVsYXkoZGVmYXVsdFJlY29ubmVjdERlbGF5 KQpAQCAtMjEwLDIxICsyMTEsMjQgQEAgdm9pZCBFdmVudFNvdXJjZTo6cGFyc2VFdmVudFN0cmVh bSgpCiB7CiAgICAgdW5zaWduZWQgaW50IGJ1ZlBvcyA9IDA7CiAgICAgdW5zaWduZWQgaW50IGJ1 ZlNpemUgPSBtX3JlY2VpdmVCdWYuc2l6ZSgpOwotICAgIGZvciAoOzspIHsKKyAgICB3aGlsZSAo YnVmUG9zIDwgYnVmU2l6ZSkgeworICAgICAgICBpZiAobV9kaXNjYXJkVHJhaWxpbmdOZXdsaW5l KSB7CisgICAgICAgICAgICBpZiAobV9yZWNlaXZlQnVmW2J1ZlBvc10gPT0gJ1xuJykKKyAgICAg ICAgICAgICAgICBidWZQb3MrKzsKKyAgICAgICAgICAgIG1fZGlzY2FyZFRyYWlsaW5nTmV3bGlu ZSA9IGZhbHNlOworICAgICAgICB9CisKICAgICAgICAgaW50IGxpbmVMZW5ndGggPSAtMTsKICAg ICAgICAgaW50IGZpZWxkTGVuZ3RoID0gLTE7Ci0gICAgICAgIGludCBjYXJyaWFnZVJldHVybiA9 IDA7CiAgICAgICAgIGZvciAodW5zaWduZWQgaW50IGkgPSBidWZQb3M7IGxpbmVMZW5ndGggPCAw ICYmIGkgPCBidWZTaXplOyBpKyspIHsKICAgICAgICAgICAgIHN3aXRjaCAobV9yZWNlaXZlQnVm W2ldKSB7CiAgICAgICAgICAgICBjYXNlICc6JzoKICAgICAgICAgICAgICAgICBpZiAoZmllbGRM ZW5ndGggPCAwKQogICAgICAgICAgICAgICAgICAgICBmaWVsZExlbmd0aCA9IGkgLSBidWZQb3M7 CiAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBjYXNlICdccic6CisgICAgICAg ICAgICAgICAgbV9kaXNjYXJkVHJhaWxpbmdOZXdsaW5lID0gdHJ1ZTsKICAgICAgICAgICAgIGNh c2UgJ1xuJzoKLSAgICAgICAgICAgICAgICBpZiAoaSA+IGJ1ZlBvcyAmJiBtX3JlY2VpdmVCdWZb aSAtIDFdID09ICdccicpIHsKLSAgICAgICAgICAgICAgICAgICAgY2FycmlhZ2VSZXR1cm4rKzsK LSAgICAgICAgICAgICAgICAgICAgaS0tOwotICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAg ICAgICBsaW5lTGVuZ3RoID0gaSAtIGJ1ZlBvczsKICAgICAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgICAgIH0KQEAgLTIzNCw3ICsyMzgsNyBAQCB2b2lkIEV2ZW50U291cmNlOjpwYXJzZUV2 ZW50U3RyZWFtKCkKICAgICAgICAgICAgIGJyZWFrOwogCiAgICAgICAgIHBhcnNlRXZlbnRTdHJl YW1MaW5lKGJ1ZlBvcywgZmllbGRMZW5ndGgsIGxpbmVMZW5ndGgpOwotICAgICAgICBidWZQb3Mg Kz0gbGluZUxlbmd0aCArIGNhcnJpYWdlUmV0dXJuICsgMTsKKyAgICAgICAgYnVmUG9zICs9IGxp bmVMZW5ndGggKyAxOwogICAgIH0KIAogICAgIGlmIChidWZQb3MgPT0gYnVmU2l6ZSkKZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5oIGIvV2ViQ29yZS9wYWdlL0V2ZW50U291 cmNlLmgKaW5kZXggYzdmZjJjOS4uZDBkNDVjYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0V2 ZW50U291cmNlLmgKKysrIGIvV2ViQ29yZS9wYWdlL0V2ZW50U291cmNlLmgKQEAgLTExNCw2ICsx MTQsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIFJlZlB0cjxUaHJlYWRhYmxlTG9h ZGVyPiBtX2xvYWRlcjsKICAgICAgICAgVGltZXI8RXZlbnRTb3VyY2U+IG1fcmVjb25uZWN0VGlt ZXI7CiAgICAgICAgIFZlY3RvcjxVQ2hhcj4gbV9yZWNlaXZlQnVmOworICAgICAgICBib29sIG1f ZGlzY2FyZFRyYWlsaW5nTmV3bGluZTsKICAgICAgICAgYm9vbCBtX2ZhaWxTaWxlbnRseTsKICAg ICAgICAgYm9vbCBtX3JlcXVlc3RJbkZsaWdodDsKIAo=