33204 2010-01-05 02:59:03 -0800 [Qt] Assertion failure in SelectionController::recomputeCaretRect() 2010-01-06 23:08:06 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue laszlo.gombos webkit.review.bot oldest_to_newest 177103 0 kling 2010-01-05 02:59:03 -0800 Introduced by http://trac.webkit.org/changeset/52778 177104 1 kling 2010-01-05 03:00:42 -0800 ASSERTION FAILED: !m_frame->view() || !m_frame->view()->needsLayout() (../../../WebCore/editing/SelectionController.cpp:929 bool WebCore::SelectionController::recomputeCaretRect()) The problem originates in QWebPage::inputMethodQuery(Qt::ImMicroFocus) which calls SelectionController::absoluteCaretBounds() when the view needs to layout. 177106 2 45879 kling 2010-01-05 03:08:46 -0800 Created attachment 45879 Trigger a layout (if needed) before calling SelectionController::absoluteCaretBounds() 177108 3 webkit.review.bot 2010-01-05 03:11:27 -0800 style-queue ran check-webkit-style on attachment 45879 without any errors. 177109 4 45879 hausmann 2010-01-05 03:15:59 -0800 Comment on attachment 45879 Trigger a layout (if needed) before calling SelectionController::absoluteCaretBounds() r=me, appears consistent with similar changes in r52778 177116 5 45882 kling 2010-01-05 05:18:53 -0800 Created attachment 45882 Return an invalid Qt::ImMicroFocus if queried while the view needs to layout. There was more than one way to trigger that assertion, so instead of hacking our way out of it, just return an invalid ImMicroFocus if called at a bad time. 177117 6 webkit.review.bot 2010-01-05 05:24:11 -0800 style-queue ran check-webkit-style on attachment 45882 without any errors. 178020 7 45882 commit-queue 2010-01-06 23:08:01 -0800 Comment on attachment 45882 Return an invalid Qt::ImMicroFocus if queried while the view needs to layout. Clearing flags on attachment: 45882 Committed r52903: <http://trac.webkit.org/changeset/52903> 178021 8 commit-queue 2010-01-06 23:08:06 -0800 All reviewed patches have been landed. Closing bug. 45879 2010-01-05 03:08:46 -0800 2010-01-05 04:17:19 -0800 Trigger a layout (if needed) before calling SelectionController::absoluteCaretBounds() bug-33204.diff text/plain 1129 kling ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggN2VkNzU1NS4uZGMxZjZkOCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTEz ODQsNiArMTM4NCw5IEBAIFFWYXJpYW50IFFXZWJQYWdlOjppbnB1dE1ldGhvZFF1ZXJ5KFF0OjpJ bnB1dE1ldGhvZFF1ZXJ5IHByb3BlcnR5KSBjb25zdAogCiAgICAgc3dpdGNoIChwcm9wZXJ0eSkg ewogICAgICAgICBjYXNlIFF0OjpJbU1pY3JvRm9jdXM6IHsKKyAgICAgICAgICAgIFdlYkNvcmU6 OkZyYW1lVmlldyogdmlldyA9IGZyYW1lLT52aWV3KCk7CisgICAgICAgICAgICBpZiAodmlldyAm JiB2aWV3LT5uZWVkc0xheW91dCgpKQorICAgICAgICAgICAgICAgIHZpZXctPmxheW91dCgpOwog ICAgICAgICAgICAgcmV0dXJuIFFWYXJpYW50KGZyYW1lLT5zZWxlY3Rpb24oKS0+YWJzb2x1dGVD YXJldEJvdW5kcygpKTsKICAgICAgICAgfQogICAgICAgICBjYXNlIFF0OjpJbUZvbnQ6IHsKZGlm ZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4 IGE2ODUzYjcuLjdkNmJiYWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIv V2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTAxLTA1ICBBbmRyZWFz IEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBUcmlnZ2VyIGEgbGF5b3V0IChpZiBuZWVk ZWQpIGJlZm9yZSBjYWxsaW5nIFNlbGVjdGlvbkNvbnRyb2xsZXI6OmFic29sdXRlQ2FyZXRCb3Vu ZHMoKQorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MzIwNAorCisgICAgICAgICogQXBpL3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdlOjpp bnB1dE1ldGhvZFF1ZXJ5KToKKwogMjAxMC0wMS0wNCAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCg== 45882 2010-01-05 05:18:53 -0800 2010-01-06 23:08:01 -0800 Return an invalid Qt::ImMicroFocus if queried while the view needs to layout. bug-33204-2.diff text/plain 1231 kling ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggN2VkNzU1NS4uYzYxODNhZCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTEz ODQsNiArMTM4NCwxMSBAQCBRVmFyaWFudCBRV2ViUGFnZTo6aW5wdXRNZXRob2RRdWVyeShRdDo6 SW5wdXRNZXRob2RRdWVyeSBwcm9wZXJ0eSkgY29uc3QKIAogICAgIHN3aXRjaCAocHJvcGVydHkp IHsKICAgICAgICAgY2FzZSBRdDo6SW1NaWNyb0ZvY3VzOiB7CisgICAgICAgICAgICBXZWJDb3Jl OjpGcmFtZVZpZXcqIHZpZXcgPSBmcmFtZS0+dmlldygpOworICAgICAgICAgICAgaWYgKHZpZXcg JiYgdmlldy0+bmVlZHNMYXlvdXQoKSkgeworICAgICAgICAgICAgICAgIC8vIFdlIGNhbid0IGFj Y2VzcyBhYnNvbHV0ZUNhcmV0Qm91bmRzKCkgd2hpbGUgdGhlIHZpZXcgbmVlZHMgdG8gbGF5b3V0 LgorICAgICAgICAgICAgICAgIHJldHVybiBRVmFyaWFudCgpOworICAgICAgICAgICAgfQogICAg ICAgICAgICAgcmV0dXJuIFFWYXJpYW50KGZyYW1lLT5zZWxlY3Rpb24oKS0+YWJzb2x1dGVDYXJl dEJvdW5kcygpKTsKICAgICAgICAgfQogICAgICAgICBjYXNlIFF0OjpJbUZvbnQ6IHsKZGlmZiAt LWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGE2 ODUzYjcuLjMxYzM3ZDQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTAxLTA1ICBBbmRyZWFzIEts aW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBSZXR1cm4gYW4gaW52YWxpZCBRdDo6SW1NaWNy b0ZvY3VzIGlmIHF1ZXJpZWQgd2hpbGUgdGhlIHZpZXcgbmVlZHMgdG8gbGF5b3V0LgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzIwNAorCisgICAg ICAgICogQXBpL3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdlOjppbnB1dE1ldGhvZFF1 ZXJ5KToKKwogMjAxMC0wMS0wNCAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCg==