33200 2010-01-05 00:37:22 -0800 Generate list of Perl unit test files dynamically 2010-01-05 14:36:10 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 cjerdonek cjerdonek abarth aroben cjerdonek commit-queue darin ddkilzer eric hamaji webkit.review.bot oldest_to_newest 177067 0 cjerdonek 2010-01-05 00:37:22 -0800 As David K. suggested here: https://bugs.webkit.org/show_bug.cgi?id=33124#c15 177068 1 45869 cjerdonek 2010-01-05 00:47:30 -0800 Created attachment 45869 Proposed patch Is there a preferred ordering of the "use" statements at the top? 177071 2 webkit.review.bot 2010-01-05 00:49:59 -0800 style-queue ran check-webkit-style on attachment 45869 without any errors. 177129 3 45869 ddkilzer 2010-01-05 06:54:06 -0800 Comment on attachment 45869 Proposed patch These changes look fine, but I noticed that the script isn't using strict mode and doesn't have warnings enabled: > Index: WebKitTools/Scripts/test-webkitperl - #/usr/bin/perl + #/usr/bin/perl -w > @@ -30,6 +30,7 @@ > > # Runs unit tests of WebKit Perl code. + use strict; > +use File::Spec; > use FindBin; > use Test::Harness; > use lib $FindBin::Bin; # so this script can be run from any directory. These two changes will require all variables to be declared (using 'my'). Sorry I didn't catch this earlier! 177137 4 cjerdonek 2010-01-05 07:22:13 -0800 (In reply to comment #3) > (From update of attachment 45869 [details]) > These changes look fine, but I noticed that the script isn't using strict mode > and doesn't have warnings enabled: > ... > These two changes will require all variables to be declared (using 'my'). > Sorry I didn't catch this earlier! No problem -- thanks for noticing it now! 177138 5 45887 cjerdonek 2010-01-05 07:23:06 -0800 Created attachment 45887 Proposed patch 2 177141 6 webkit.review.bot 2010-01-05 07:28:41 -0800 style-queue ran check-webkit-style on attachment 45887 without any errors. 177198 7 45887 ddkilzer 2010-01-05 09:54:17 -0800 Comment on attachment 45887 Proposed patch 2 > Index: WebKitTools/Scripts/test-webkitperl > =================================================================== > --- WebKitTools/Scripts/test-webkitperl (revision 52795) > +++ WebKitTools/Scripts/test-webkitperl (working copy) > @@ -30,23 +30,20 @@ > > # Runs unit tests of WebKit Perl code. > > +use strict; > +use warnings; Adding "-w" to the "#!/usr/bin/perl" line actually catches slightly more issues than "use warnings" (IIRC), but I don't think it really matters for this script. r=me 177279 8 45887 commit-queue 2010-01-05 11:51:40 -0800 Comment on attachment 45887 Proposed patch 2 Clearing flags on attachment: 45887 Committed r52817: <http://trac.webkit.org/changeset/52817> 177280 9 commit-queue 2010-01-05 11:51:48 -0800 All reviewed patches have been landed. Closing bug. 177332 10 cjerdonek 2010-01-05 13:07:03 -0800 (In reply to comment #7) Sorry I missed that part of your comment. Is "use warnings" redundant with "-w"? The other Perl scripts seem to have both. 177344 11 ddkilzer 2010-01-05 13:18:50 -0800 (In reply to comment #10) > Sorry I missed that part of your comment. Is "use warnings" redundant with > "-w"? The other Perl scripts seem to have both. Having both is technically redundant, but doesn't hurt anything. In this specific case, I think "-w" is equivalent to "use warnings", so it doesn't need both. See "man warnings" and "man perllexwarn" for details. 177395 12 eric 2010-01-05 14:27:50 -0800 http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/8891 seems to think this change caused a regression. I don't believe it. 177405 13 eric 2010-01-05 14:36:10 -0800 Filed bug 33230 about the failures seen on the bot. I don't think they're related to this change. 45869 2010-01-05 00:47:30 -0800 2010-01-05 07:23:06 -0800 Proposed patch patch-tools3-1.txt text/plain 1587 cjerdonek SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUyNzg5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEtMDUgIENocmlzIEplcmRvbmVrICA8 Y2hyaXMuamVyZG9uZWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFN3aXRjaGVkIHRvIGdlbmVyYXRpbmcgbGlzdCBvZiBQZXJsIHVu aXQgdGVzdCBmaWxlcyBkeW5hbWljYWxseSwKKyAgICAgICAgaW5zdGVhZCBvZiBleHBsaWNpdGx5 LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzIw MAorCisgICAgICAgICogU2NyaXB0cy90ZXN0LXdlYmtpdHBlcmw6CisKIDIwMTAtMDEtMDUgIENo cmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBObyByZXZpZXcu IEZpeCBEUlQgYnJlYWthZ2Ugb24gVGlnZXIvTGVvcGFyZC4KSW5kZXg6IFdlYktpdFRvb2xzL1Nj cmlwdHMvdGVzdC13ZWJraXRwZXJsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMv dGVzdC13ZWJraXRwZXJsCShyZXZpc2lvbiA1Mjc4MikKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMv dGVzdC13ZWJraXRwZXJsCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw2ICszMCw3IEBACiAKICMgUnVu cyB1bml0IHRlc3RzIG9mIFdlYktpdCBQZXJsIGNvZGUuCiAKK3VzZSBGaWxlOjpTcGVjOwogdXNl IEZpbmRCaW47CiB1c2UgVGVzdDo6SGFybmVzczsKIHVzZSBsaWIgJEZpbmRCaW46OkJpbjsgIyBz byB0aGlzIHNjcmlwdCBjYW4gYmUgcnVuIGZyb20gYW55IGRpcmVjdG9yeS4KQEAgLTM3LDE2ICsz OCw5IEBAIHVzZSBWQ1NVdGlsczsKIAogIyBVc2UgYW4gYWJzb2x1dGUgcGF0aCBzbyB0aGlzIHNj cmlwdCBjYW4gYmUgcnVuIGZyb20gYW55IGRpcmVjdG9yeS4KICRzY3JpcHRzRGlyID0gJEZpbmRC aW46OkJpbjsKLSRzY3JpcHRzRGlyID1+IHN8LyskfHw7ICMgUmVtb3ZlIHRyYWlsaW5nICcvJwog Ci0jIFZDU1V0aWxzIHN1YnJvdXRpbmVzCi1teSBAZmlsZXMgPSAoCi0gICAgImZpeENoYW5nZUxv Z1BhdGNoLnBsIiwKLSAgICAiZ2VuZXJhdGVQYXRjaENvbW1hbmQucGwiLAotICAgICJnaXRkaWZm MnN2bmRpZmYucGwiLAotICAgICJydW5QYXRjaENvbW1hbmQucGwiLAotKTsKKyRwYXR0ZXJuID0g RmlsZTo6U3BlYy0+Y2F0ZmlsZSgkc2NyaXB0c0RpciwgIndlYmtpdHBlcmwvKl91bml0dGVzdC8q LnBsIik7CiAKLUBmaWxlcyA9IG1hcCAiJHNjcmlwdHNEaXIvd2Via2l0cGVybC9WQ1NVdGlsc191 bml0dGVzdC8kXyIsIEBmaWxlczsgIyBwcmVwZW5kCitAZmlsZXMgPSA8JHtwYXR0ZXJufT47ICMg bGlzdHMgZmlsZXMgYWxwaGFiZXRpY2FsbHkKIAogcnVudGVzdHMoQGZpbGVzKTsK 45887 2010-01-05 07:23:06 -0800 2010-01-05 11:51:39 -0800 Proposed patch 2 patch-tools3-2.txt text/plain 1617 cjerdonek SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUyNzk1KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEtMDUgIENocmlzIEplcmRvbmVrICA8 Y2hyaXMuamVyZG9uZWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFN3aXRjaGVkIHRvIGdlbmVyYXRpbmcgbGlzdCBvZiBQZXJsIHVu aXQgdGVzdCBmaWxlcyBkeW5hbWljYWxseSwKKyAgICAgICAgaW5zdGVhZCBvZiBleHBsaWNpdGx5 LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzIw MAorCisgICAgICAgICogU2NyaXB0cy90ZXN0LXdlYmtpdHBlcmw6CisKIDIwMTAtMDEtMDQgIE1h Y2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBGaXNoZXIuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cGVybAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cGVybAkocmV2aXNp b24gNTI3OTUpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cGVybAkod29ya2lu ZyBjb3B5KQpAQCAtMzAsMjMgKzMwLDIwIEBACiAKICMgUnVucyB1bml0IHRlc3RzIG9mIFdlYktp dCBQZXJsIGNvZGUuCiAKK3VzZSBzdHJpY3Q7Cit1c2Ugd2FybmluZ3M7CisKK3VzZSBGaWxlOjpT cGVjOwogdXNlIEZpbmRCaW47CiB1c2UgVGVzdDo6SGFybmVzczsKIHVzZSBsaWIgJEZpbmRCaW46 OkJpbjsgIyBzbyB0aGlzIHNjcmlwdCBjYW4gYmUgcnVuIGZyb20gYW55IGRpcmVjdG9yeS4KIHVz ZSBWQ1NVdGlsczsKIAogIyBVc2UgYW4gYWJzb2x1dGUgcGF0aCBzbyB0aGlzIHNjcmlwdCBjYW4g YmUgcnVuIGZyb20gYW55IGRpcmVjdG9yeS4KLSRzY3JpcHRzRGlyID0gJEZpbmRCaW46OkJpbjsK LSRzY3JpcHRzRGlyID1+IHN8LyskfHw7ICMgUmVtb3ZlIHRyYWlsaW5nICcvJworbXkgJHNjcmlw dHNEaXIgPSAkRmluZEJpbjo6QmluOwogCi0jIFZDU1V0aWxzIHN1YnJvdXRpbmVzCi1teSBAZmls ZXMgPSAoCi0gICAgImZpeENoYW5nZUxvZ1BhdGNoLnBsIiwKLSAgICAiZ2VuZXJhdGVQYXRjaENv bW1hbmQucGwiLAotICAgICJnaXRkaWZmMnN2bmRpZmYucGwiLAotICAgICJydW5QYXRjaENvbW1h bmQucGwiLAotKTsKK215ICRwYXR0ZXJuID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkc2NyaXB0c0Rp ciwgIndlYmtpdHBlcmwvKl91bml0dGVzdC8qLnBsIik7CiAKLUBmaWxlcyA9IG1hcCAiJHNjcmlw dHNEaXIvd2Via2l0cGVybC9WQ1NVdGlsc191bml0dGVzdC8kXyIsIEBmaWxlczsgIyBwcmVwZW5k CitteSBAZmlsZXMgPSA8JHtwYXR0ZXJufT47ICMgbGlzdHMgZmlsZXMgYWxwaGFiZXRpY2FsbHkK IAogcnVudGVzdHMoQGZpbGVzKTsK