33193 2010-01-04 19:42:14 -0800 [V8] CodeGeenratorV8 can't find item() or namedItem() in parent classes 2010-01-07 02:52:19 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 32854 33190 1 tkent webkit-unassigned abarth commit-queue dglazkov webkit.review.bot oldest_to_newest 177000 0 tkent 2010-01-04 19:42:14 -0800 WebCore/CSS/WebKitCSSTransformValue.idl looks like having IndexGetter extended attributes. However, the attribute is ignored by Bug#33190. If Bug#33190 is fixed or Bug#32854 is committed, we need to have a WebKitCSSTransformValue index-getter implementation for V8. 177011 1 tkent 2010-01-04 21:07:28 -0800 I investigated how to fix this and concluded it's a bug that CodeGeneratorV8.pm didn't understand WebKitCSSTransformValue had item() inherited from it's parent interface. 177024 2 45862 tkent 2010-01-04 21:41:53 -0800 Created attachment 45862 Proposed patch 177033 3 webkit.review.bot 2010-01-04 21:59:57 -0800 style-queue ran check-webkit-style on attachment 45862 without any errors. 177035 4 45862 abarth 2010-01-04 22:06:40 -0800 Comment on attachment 45862 Proposed patch I'm willing to believe that we need this patch, but does this fix a specific test or do we need to add a new test to show the improvement? 177095 5 tkent 2010-01-05 02:28:41 -0800 (In reply to comment #4) > (From update of attachment 45862 [details]) > I'm willing to believe that we need this patch, but does this fix a specific > test or do we need to add a new test to show the improvement? I'm making a test, and probably we don't need to add index access setting to WebKitCSSTransformValue like this patch because its parent interface already has index access setting. 177182 6 dglazkov 2010-01-05 09:23:46 -0800 Thanks so much for picking finding this! However, I don't think this is the right approach. We should instead work on making our template configuration aware of inheritance. In the meantime, let's just add an exception to GenerateImplementationIndexer (see HTMLOptionCollection). 177531 7 45953 tkent 2010-01-05 20:40:15 -0800 Created attachment 45953 Proposed patch (rev.2) (In reply to comment #6) > Thanks so much for picking finding this! However, I don't think this is the > right approach. We should instead work on making our template configuration > aware of inheritance. > > In the meantime, let's just add an exception to GenerateImplementationIndexer > (see HTMLOptionCollection). Thank you for the comment. Ok, the updated patch just adds a workaround for WebKitCSSTransformValue. 177532 8 webkit.review.bot 2010-01-05 20:41:10 -0800 style-queue ran check-webkit-style on attachment 45953 without any errors. 177539 9 45953 abarth 2010-01-05 22:04:44 -0800 Comment on attachment 45953 Proposed patch (rev.2) Can we add a test for the behavior change? 177540 10 tkent 2010-01-05 22:13:00 -0800 (In reply to comment #9) > (From update of attachment 45953 [details]) > Can we add a test for the behavior change? Adding "," to "HasIndexGetter" in css/WebKitCSSTransformValue.idl causes a build error of Chromium. This change will fix it. I have no idea how to test this without a build error :-) 178059 11 45953 abarth 2010-01-07 00:50:10 -0800 Comment on attachment 45953 Proposed patch (rev.2) tkent explained the issue to me over IRC and I understand now that this fixes a build error, which is even better than a test. :) 178108 12 45953 commit-queue 2010-01-07 02:52:11 -0800 Comment on attachment 45953 Proposed patch (rev.2) Clearing flags on attachment: 45953 Committed r52913: <http://trac.webkit.org/changeset/52913> 178109 13 commit-queue 2010-01-07 02:52:19 -0800 All reviewed patches have been landed. Closing bug. 45862 2010-01-04 21:41:53 -0800 2010-01-05 20:40:15 -0800 Proposed patch 0001-v8-inherited-item-1.patch text/plain 3601 tkent RnJvbSBkOWY5YWU0N2VkODg1NzBhZWJkN2JhNWRjNzg5NjA4ZmRkMWJiNTA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW50IFRhbXVyYSA8dGtlbnRAY2hyb21pdW0ub3JnPgpEYXRl OiBUdWUsIDUgSmFuIDIwMTAgMTQ6MzE6MTggKzA5MDAKU3ViamVjdDogW1BBVENIXSB2OC1pbmhl cml0ZWQtaXRlbS0xCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDE4ICsrKysrKysrKysrKysKIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9yVjgucG0gfCAgIDM3ICsrKysrKysrKysrKysrKysrKystLS0tLS0tCiAyIGZpbGVz IGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2RkMGFjOS4uZmIz NjE3OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wMS0wNSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRml4IGEgYnVnIHRoYXQgQ29kZUdlbmVyYXRvclY4LnBtIGRvZXNuJ3QgZmluZCBpdGVtKCkg b3IgbmFtZWRJdGVtKCkKKyAgICAgICAgZGVjbGFyZWQgYnkgcGFyZW50IGludGVyZmFjZXMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzE5MworCisg ICAgICAgIEdlbmVyYXRlSW1wbGVtZW50YXRpb24gaW4gQ29kZUdlbmVyYXRvclY4LnBtIHNlYXJj aGVkIGZ1bmN0aW9ucyBkZWNsYXJlZAorICAgICAgICBpbiB0aGUgY3VycmVudCBpbnRlcmZhY2Ug Zm9yICJpdGVtIiBvciAibmFtZWRJdGVtIiBmdW5jdGlvbnMuIFRoaXMKKyAgICAgICAgY2hhbmdl IGludHJvZHVjZXMgbmV3IGZ1bmN0aW9uIHRvIHNlYXJjaCBmdW5jdGlvbnMgZGVjbGFyZWQgaW4g YWxsCisgICAgICAgIGluaGVyaXRlZCBpbnRlcmZhY2VzLCBhbmQgdXNlIGl0IHRvIGNoZWNrICJp dGVtIiBvciAibmFtZWRJdGVtIi4KKworICAgICAgICBUaGlzIGNoYW5nZSByZXNvbHZlcyBhbiBp c3N1ZSBvZiBXZWJDb3JlL2Nzcy9XZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZS5pZGwsCisgICAgICAg IHdoaWNoIGhhcyBIYXNJbmRleEdldHRlciBhbmQgdGhlIHBhcmVudCBpbnRlcmZhY2UgaGFzIGl0 ZW0oKS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgor CiAyMDEwLTAxLTA0ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0gYi9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvclY4LnBtCmluZGV4IGI5OTlhYTYuLmQ4OTk5MjEgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KKysrIGIvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtMTM2MCw2ICsxMzYwLDMwIEBA IHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uTWFzcXVlcmFkZXNBc1VuZGVmaW5lZAogICAgIH0K IH0KIAorc3ViIEdldEZ1bmN0aW9uU2lnbmF0dXJlCit7CisgICAgbXkgJGRhdGFOb2RlID0gc2hp ZnQ7CisgICAgbXkgJG5hbWUgPSBzaGlmdDsKKworICAgIGZvcmVhY2ggbXkgJGZ1bmN0aW9uIChA eyRkYXRhTm9kZS0+ZnVuY3Rpb25zfSkgeworICAgICAgICBpZiAoJGZ1bmN0aW9uLT5zaWduYXR1 cmUtPm5hbWUgZXEgJG5hbWUpIHsKKyAgICAgICAgICAgIHJldHVybiAkZnVuY3Rpb24tPnNpZ25h dHVyZTsKKyAgICAgICAgfQorICAgIH0KKyAgICBteSAkc2lnbmF0dXJlOworICAgICRjb2RlR2Vu ZXJhdG9yLT5Gb3JBbGxQYXJlbnRzKCRkYXRhTm9kZSwgc3ViIHsKKyAgICAgICAgbXkgJGludGVy ZmFjZSA9IHNoaWZ0OworICAgICAgICBmb3JlYWNoIG15ICRmdW5jdGlvbiAoQHskaW50ZXJmYWNl LT5mdW5jdGlvbnN9KSB7CisgICAgICAgICAgICBpZiAoJGZ1bmN0aW9uLT5zaWduYXR1cmUtPm5h bWUgZXEgJG5hbWUpIHsKKyAgICAgICAgICAgICAgICAkc2lnbmF0dXJlID0gJGZ1bmN0aW9uLT5z aWduYXR1cmU7CisgICAgICAgICAgICAgICAgcmV0dXJuICJwcnVuZSI7CisgICAgICAgICAgICB9 CisgICAgICAgIH0KKyAgICAgICAgcmV0dXJuICIiOworICAgIH0pOworICAgIHJldHVybiAkc2ln bmF0dXJlOworfQorCiBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogewogICAgIG15ICRvYmpl Y3QgPSBzaGlmdDsKQEAgLTE0NDgsOCArMTQ3Miw2IEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0 aW9uCiAgICAgICAgIEdlbmVyYXRlQ29uc3RydWN0b3JHZXR0ZXIoJGltcGxDbGFzc05hbWUsICRj bGFzc0luZGV4KTsKICAgICB9CiAKLSAgICBteSAkaW5kZXhlcjsKLSAgICBteSAkbmFtZWRQcm9w ZXJ0eUdldHRlcjsKICAgICAjIEdlbmVyYXRlIG1ldGhvZHMgZm9yIGZ1bmN0aW9ucy4KICAgICBm b3JlYWNoIG15ICRmdW5jdGlvbiAoQHskZGF0YU5vZGUtPmZ1bmN0aW9uc30pIHsKICAgICAgICAg IyBoYWNrIGZvciBhZGRFdmVudExpc3RlbmVyL1JlbW92ZUV2ZW50TGlzdGVuZXIKQEAgLTE0NjAs MTQgKzE0ODIsNiBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogICAgICAgICAgICAgR2Vu ZXJhdGVGdW5jdGlvbkNhbGxiYWNrKCRmdW5jdGlvbiwgJGRhdGFOb2RlLCAkY2xhc3NJbmRleCwg JGltcGxDbGFzc05hbWUpOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKCRmdW5jdGlvbi0+c2ln bmF0dXJlLT5uYW1lIGVxICJpdGVtIikgewotICAgICAgICAgICAgJGluZGV4ZXIgPSAkZnVuY3Rp b24tPnNpZ25hdHVyZTsKLSAgICAgICAgfQotCi0gICAgICAgIGlmICgkZnVuY3Rpb24tPnNpZ25h dHVyZS0+bmFtZSBlcSAibmFtZWRJdGVtIikgewotICAgICAgICAgICAgJG5hbWVkUHJvcGVydHlH ZXR0ZXIgPSAkZnVuY3Rpb24tPnNpZ25hdHVyZTsKLSAgICAgICAgfQotCiAgICAgICAgICMgSWYg dGhlIGZ1bmN0aW9uIGRvZXMgbm90IG5lZWQgZG9tYWluIHNlY3VyaXR5IGNoZWNrLCB3ZSBuZWVk IHRvCiAgICAgICAgICMgZ2VuZXJhdGUgYW4gYWNjZXNzIGdldHRlciB0aGF0IHJldHVybnMgZGlm ZmVyZW50IGZ1bmN0aW9uIG9iamVjdHMKICAgICAgICAgIyBmb3IgZGlmZmVyZW50IGNhbGxpbmcg Y29udGV4dC4KQEAgLTE0NzYsNiArMTQ5MCw5IEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9u CiAgICAgICAgIH0KICAgICB9CiAKKyAgICBteSAkaW5kZXhlciA9IEdldEZ1bmN0aW9uU2lnbmF0 dXJlKCRkYXRhTm9kZSwgIml0ZW0iKTsKKyAgICBteSAkbmFtZWRQcm9wZXJ0eUdldHRlciA9IEdl dEZ1bmN0aW9uU2lnbmF0dXJlKCRkYXRhTm9kZSwgIm5hbWVkSXRlbSIpOworCiAgICAgIyBBdHRy aWJ1dGVzCiAgICAgbXkgJGF0dHJpYnV0ZXMgPSAkZGF0YU5vZGUtPmF0dHJpYnV0ZXM7CiAKLS0g CjEuNi4zLjMKCg== 45953 2010-01-05 20:40:15 -0800 2010-01-07 02:52:11 -0800 Proposed patch (rev.2) 0001-v8-inherited-item-2.patch text/plain 2206 tkent RnJvbSBhYjZiMWJmMWJiZTMwMjczYmE5N2Q1MGE4NDRmMGY4NDBlYmExZDBjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW50IFRhbXVyYSA8dGtlbnRAY2hyb21pdW0ub3JnPgpEYXRl OiBUdWUsIDUgSmFuIDIwMTAgMTQ6MzE6MTggKzA5MDAKU3ViamVjdDogW1BBVENIXSB2OC1pbmhl cml0ZWQtaXRlbS0yCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDE3ICsrKysrKysrKysrKysrKysrCiBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvclY4LnBtIHwgICAgNSArKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNl cnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9n IGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2RkMGFjOS4uNjljYzJiMyAxMDA2NDQKLS0tIGEv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBA QAorMjAxMC0wMS0wNSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGFuIGlzc3VlIHRo YXQgQ29kZUdlbmVyYXRvclY4LnBtIGRvZXNudCBoYW5kbGUgSGFzSW5kZXhHZXR0ZXIgb2YKKyAg ICAgICAgV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWUuaWRsIGNvcnJlY3RseS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMTkzCisKKyAgICAgICAgQ29k ZUdlbmVyYXRvclY4LnBtIGRvZXNuJ3QgaGFuZGxlIGluaGVyaXRhbmNlIHZlcnkgd2VsbCBhbmQg aXQKKyAgICAgICAgdHJpZWQgdG8gcmVmZXIgdjhXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZUluZGV4 ZWRQcm9wZXJ0eUdldHRlcigpLAorICAgICAgICB3aGljaCBkb2VzIG5vdCBleGlzdC4gQmVjYXVz ZSBXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZSBpbmhlcml0cworICAgICAgICBDU1NWYWx1ZUxpc3Qg YW5kIENTU1ZhbHVlTGlzdCBhbHJlYWR5IGhhcyBIYWRJbmRleEdldHRlciwgd2UgZG9uJ3QKKyAg ICAgICAgbmVlZCB0byBkbyBhbnl0aGluZyBmb3IgV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWUgYWJv dXQgSGFzSW5kZXhHZXR0ZXIuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JWOC5wbToKKyAgICAgICAgICBSZXNldCAkaGFzR2V0dGVyIGZvciBXZWJLaXRDU1NUcmFu c2Zvcm1WYWx1ZS4KKwogMjAxMC0wMS0wNCAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCBiOTk5YWE2Li43Njc5Njk1IDEw MDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisr KyBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTEyMTUs NiArMTIxNSwxMSBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbkluZGV4ZXIKICAgICBpZiAo JGludGVyZmFjZU5hbWUgZXEgIkhUTUxPcHRpb25zQ29sbGVjdGlvbiIpIHsKICAgICAgICAgJGhh c0dldHRlciA9IDE7CiAgICAgfQorICAgICMgRklYTUU6IElmIHRoZSBwYXJlbnQgaW50ZXJmYWNl IG9mICRkYXRhTm9kZSBhbHJlYWR5IGhhcworICAgICMgSGFzSW5kZXhHZXR0ZXIsIHdlIGRvbid0 IG5lZWQgdG8gaGFuZGxlIHRoZSBnZXR0ZXIgaGVyZS4KKyAgICBpZiAoJGludGVyZmFjZU5hbWUg ZXEgIldlYktpdENTU1RyYW5zZm9ybVZhbHVlIikgeworICAgICAgICAkaGFzR2V0dGVyID0gMDsK KyAgICB9CiAKICAgICAjIEZJWE1FOiBJbnZlc3RpZ2F0ZSBhbmQgcmVtb3ZlIHRoaXMgbmFzdGlu ZXNzcy4gSW4gVjgsIG5hbWVkIHByb3BlcnR5IGhhbmRsaW5nIGFuZCBpbmRleGVyIGhhbmRsaW5n IGFyZSBhcHBhcmVudGx5IGRlY291cGxlZCwKICAgICAjIHdoaWNoIG1lYW5zIHRoYXQgb2JqZWN0 W1hdIHdoZXJlIFggaXMgYSBudW1iZXIgZG9lc24ndCByZWFjaCBuYW1lZCBwcm9wZXJ0eSBpbmRl eGVyLiBTbyB3ZSBuZWVkIHRvIHByb3ZpZGUKLS0gCjEuNi4zLjMKCg==