33191 2010-01-04 18:13:20 -0800 CDATA sections are merged into Text nodes when normalize() is used 2019-02-06 09:04:13 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED EasyFix P2 Normal --- 1 bedney darin ap cdumez darin oldest_to_newest 176988 0 45855 bedney 2010-01-04 18:13:20 -0800 Created attachment 45855 Testcase showing invalid merging behavior As the attached testcase demonstrates, Webkit violates the DOM Specification by merging adjacent CDATA sections into Text nodes when normalize() is used. The 'normalize()' method in the DOM Level 2 specification says: "Puts all Text nodes in the full depth of the sub-tree underneath this Node, including attribute nodes, into a "normal" form where only structure (e.g., elements, comments, processing instructions, CDATA sections, and entity references) separates Text nodes". Further, section 1.3 describing CDATA sections state that adjacent CDATA sections are not to be merged with each other when normalize() is used: "Adjacent CDATASection nodes are not merged by use of the normalize method of the Node interface" The attached testcase shows that the XML chunk starts out with 3 nodes under the document element in this order: - Text node - CDATA Section node - Text node and confirms that the document element has 3 child nodes before normalization and 1 child node after normalization (when it should still have 3, having preserved the above structure). This test passes on Mozilla and IE. This is failing on the latest Webkit build I have: build 52571. Cheers, - Bill 177247 1 darin 2010-01-05 11:03:37 -0800 Looking at Node::normalize it seems the problem is using nodeType which returns TEXT_NODE for both text nodes and character data nodes. Instead we should call isTextNode and isElementNode in that function. 177416 2 darin 2010-01-05 14:51:55 -0800 Turns out I had it backwards. CDATASection nodes are text nodes. So we need to call nodeType more, not less. 177417 3 darin 2010-01-05 14:56:00 -0800 I’ll fix this. 177487 4 45947 darin 2010-01-05 17:30:16 -0800 Created attachment 45947 patch 177490 5 darin 2010-01-05 17:36:12 -0800 http://trac.webkit.org/changeset/52840 177537 6 bedney 2010-01-05 21:53:36 -0800 That was fast! Thanks Darin! Cheers, - Bill 1503126 7 lforschler 2019-02-06 09:04:13 -0800 Mass moving XML DOM bugs to the "DOM" Component. 45855 2010-01-04 18:13:20 -0800 2010-01-04 18:13:20 -0800 Testcase showing invalid merging behavior normalizemergescdata.html text/html 1022 bedney PGh0bWw+Cgk8aGVhZD4KCQoJPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgoJZnVuY3Rp b24gZG9JdCgpCgl7CgkJdmFyIHBhcnNlcjsKCQl2YXIgc2VyaWFsaXplcjsKCQl2YXIgeG1sQ2h1 bms7CgoJCXBhcnNlciA9IG5ldyBET01QYXJzZXIoKTsKCQlzZXJpYWxpemVyID0gbmV3IFhNTFNl cmlhbGl6ZXIoKTsKCgkJeG1sQ2h1bmsgPSBwYXJzZXIucGFyc2VGcm9tU3RyaW5nKAoJCQkJCSc8 Zm9vPicgKwoJCQkJCSdUaGlzIGlzIHNvbWUgdGV4dCBiZWZvcmUgdGhlIENEQVRBJyArCgkJCQkJ JzwhW0NEQVRBW1RoaXMgaXMgc29tZSA8Ym9sZD5tYXJrdXA8L2JvbGQ+IGluc2lkZSBvZiBhIENE QVRBXV0+JyArCgkJCQkJJ1RoaXMgaXMgc29tZSB0ZXh0IGFmdGVyIHRoZSBDREFUQScgKwoJCQkJ CSc8L2Zvbz4nLAoJCQkJCSdhcHBsaWNhdGlvbi94bWwnKTsKCgkJYWxlcnQoJ1RoZSBtYXJrdXAg YmVmb3JlIG5vcm1hbGl6YXRpb24gaXM6IFxuXG4nICsgc2VyaWFsaXplci5zZXJpYWxpemVUb1N0 cmluZyh4bWxDaHVuaykpOwoJCWFsZXJ0KCdUaGUgZG9jdW1lbnQgZWxlbWVudCBiZWZvcmUgbm9y bWFsaXphdGlvbiBoYXM6ICcgKyB4bWxDaHVuay5kb2N1bWVudEVsZW1lbnQuY2hpbGROb2Rlcy5s ZW5ndGggKyAnIG5vZGVzJyk7CgoJCXhtbENodW5rLmRvY3VtZW50RWxlbWVudC5ub3JtYWxpemUo KTsKCgkJYWxlcnQoJ1RoZSBtYXJrdXAgYWZ0ZXIgbm9ybWFsaXphdGlvbiBpczogXG5cbicgKyBz ZXJpYWxpemVyLnNlcmlhbGl6ZVRvU3RyaW5nKHhtbENodW5rKSk7CgkJYWxlcnQoJ1RoZSBkb2N1 bWVudCBlbGVtZW50IGFmdGVyIG5vcm1hbGl6YXRpb24gaGFzOiAnICsgeG1sQ2h1bmsuZG9jdW1l bnRFbGVtZW50LmNoaWxkTm9kZXMubGVuZ3RoICsgJyBub2RlcycpOwoJfTsKCTwvc2NyaXB0PgoK CTwvaGVhZD4KCQoJPGJvZHk+CgkJPGJ1dHRvbiBvbmNsaWNrPSJkb0l0KCkiPkNsaWNrIG1lIHRv IGFsZXJ0KCkgdGhlIHRlc3QgcmVzdWx0czwvYnV0dG9uPgoJPC9ib2R5PgoKPC9odG1sPgo= 45947 2010-01-05 17:30:16 -0800 2010-01-05 17:33:25 -0800 patch NormalizePatch.txt text/plain 5316 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjgzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEtMDUgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENEQVRB IHNlY3Rpb25zIGFyZSBtZXJnZWQgaW50byBUZXh0IG5vZGVzIHdoZW4gbm9ybWFsaXplKCkgaXMg dXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMx OTEKKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9Ob2RlL25vcm1hbGl6ZS13aXRoLWNkYXRhLmh0 bWwKKworICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6Om5v cm1hbGl6ZSk6IFVzZSBub2RlVHlwZSBpbnN0ZWFkIG9mIGlzVGV4dE5vZGUuCisKIDIwMTAtMDEt MDUgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL2RvbS9Ob2RlLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2RvbS9Ob2RlLmNwcAkocmV2aXNpb24gNTI4MzkpCisrKyBXZWJDb3JlL2Rv bS9Ob2RlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjgxLDcgKzY4MSw3IEBAIHZvaWQgTm9kZTo6 bm9ybWFsaXplKCkKIAogICAgICAgICAvLyBNZXJnZSB0ZXh0IG5vZGVzLgogICAgICAgICB3aGls ZSAoTm9kZSogbmV4dFNpYmxpbmcgPSBub2RlLT5uZXh0U2libGluZygpKSB7Ci0gICAgICAgICAg ICBpZiAoIW5leHRTaWJsaW5nLT5pc1RleHROb2RlKCkpCisgICAgICAgICAgICBpZiAobmV4dFNp YmxpbmctPm5vZGVUeXBlKCkgIT0gVEVYVF9OT0RFKQogICAgICAgICAgICAgICAgIGJyZWFrOwog ICAgICAgICAgICAgUmVmUHRyPFRleHQ+IG5leHRUZXh0ID0gc3RhdGljX2Nhc3Q8VGV4dCo+KG5l eHRTaWJsaW5nKTsKIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTI4MzkpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMS0wNSAgRGFy aW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ0RBVEEgc2VjdGlvbnMgYXJlIG1lcmdlZCBpbnRvIFRleHQg bm9kZXMgd2hlbiBub3JtYWxpemUoKSBpcyB1c2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzE5MQorCisgICAgICAgICogZmFzdC9kb20vTm9kZS9u b3JtYWxpemUtd2l0aC1jZGF0YS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv ZG9tL05vZGUvbm9ybWFsaXplLXdpdGgtY2RhdGEuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFz dC9kb20vTm9kZS9zY3JpcHQtdGVzdHMvbm9ybWFsaXplLXdpdGgtY2RhdGEuanM6IEFkZGVkLgor CiAyMDEwLTAxLTA1ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBnb29nbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20v Tm9kZS9ub3JtYWxpemUtd2l0aC1jZGF0YS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9kb20vTm9kZS9ub3JtYWxpemUtd2l0aC1jZGF0YS1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL25vcm1hbGl6ZS13aXRo LWNkYXRhLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNSBAQAorVGVzdCBv ZiBub3JtYWxpemUgb24gYW4gWE1MIGRvY3VtZW50IHdpdGggQ0RBVEEuCisKK09uIHN1Y2Nlc3Ms IHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJU RVNUIENPTVBMRVRFIi4KKworCitCZWZvcmUgbm9ybWFsaXplCitQQVNTIHNlcmlhbGl6ZXIuc2Vy aWFsaXplVG9TdHJpbmcoeG1sQ2h1bmspIGlzICI8Zm9vPlRoaXMgaXMgc29tZSB0ZXh0IGJlZm9y ZSB0aGUgQ0RBVEE8IVtDREFUQVtUaGlzIGlzIHNvbWUgPGJvbGQ+bWFya3VwPC9ib2xkPiBpbnNp ZGUgb2YgYSBDREFUQV1dPlRoaXMgaXMgc29tZSB0ZXh0IGFmdGVyIHRoZSBDREFUQTwvZm9vPiIK K1BBU1MgeG1sQ2h1bmsuZG9jdW1lbnRFbGVtZW50LmNoaWxkTm9kZXMubGVuZ3RoIGlzIDMKK0Fm dGVyIG5vcm1hbGl6ZQorUEFTUyBzZXJpYWxpemVyLnNlcmlhbGl6ZVRvU3RyaW5nKHhtbENodW5r KSBpcyAiPGZvbz5UaGlzIGlzIHNvbWUgdGV4dCBiZWZvcmUgdGhlIENEQVRBPCFbQ0RBVEFbVGhp cyBpcyBzb21lIDxib2xkPm1hcmt1cDwvYm9sZD4gaW5zaWRlIG9mIGEgQ0RBVEFdXT5UaGlzIGlz IHNvbWUgdGV4dCBhZnRlciB0aGUgQ0RBVEE8L2Zvbz4iCitQQVNTIHhtbENodW5rLmRvY3VtZW50 RWxlbWVudC5jaGlsZE5vZGVzLmxlbmd0aCBpcyAzCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVz dHMvZmFzdC9kb20vTm9kZS9ub3JtYWxpemUtd2l0aC1jZGF0YS1leHBlY3RlZC50eHQKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpBZGRlZDogc3ZuOmVvbC1zdHlsZQogICArIG5hdGl2ZQoKSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvZG9tL05vZGUvbm9ybWFsaXplLXdpdGgtY2RhdGEuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL25vcm1hbGl6ZS13aXRoLWNkYXRhLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL25vcm1hbGl6ZS13aXRoLWNkYXRh Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJ QyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0 eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8 c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K KzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25z b2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMvbm9ybWFsaXplLXdpdGgtY2Rh dGEuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0 LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgoKUHJvcGVydHkgY2hhbmdlcyBv bjogTGF5b3V0VGVzdHMvZmFzdC9kb20vTm9kZS9ub3JtYWxpemUtd2l0aC1jZGF0YS5odG1sCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KQWRkZWQ6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0L2h0bWwKQWRkZWQ6IHN2bjpl b2wtc3R5bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL3Nj cmlwdC10ZXN0cy9ub3JtYWxpemUtd2l0aC1jZGF0YS5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9Ob2RlL3NjcmlwdC10ZXN0cy9ub3JtYWxpemUtd2l0aC1jZGF0YS5qcwko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL05vZGUvc2NyaXB0LXRlc3RzL25v cm1hbGl6ZS13aXRoLWNkYXRhLmpzCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIyIEBACitkZXNj cmlwdGlvbignVGVzdCBvZiBub3JtYWxpemUgb24gYW4gWE1MIGRvY3VtZW50IHdpdGggQ0RBVEEu Jyk7CisKK3ZhciBwYXJzZXIgPSBuZXcgRE9NUGFyc2VyKCk7Cit2YXIgc2VyaWFsaXplciA9IG5l dyBYTUxTZXJpYWxpemVyKCk7CisKK3ZhciB4bWxDaHVuayA9IHBhcnNlci5wYXJzZUZyb21TdHJp bmcoCisgICAgJzxmb28+JyArCisgICAgJ1RoaXMgaXMgc29tZSB0ZXh0IGJlZm9yZSB0aGUgQ0RB VEEnICsKKyAgICAnPCFbQ0RBVEFbVGhpcyBpcyBzb21lIDxib2xkPm1hcmt1cDwvYm9sZD4gaW5z aWRlIG9mIGEgQ0RBVEFdXT4nICsKKyAgICAnVGhpcyBpcyBzb21lIHRleHQgYWZ0ZXIgdGhlIENE QVRBJyArCisgICAgJzwvZm9vPicsCisgICAgJ2FwcGxpY2F0aW9uL3htbCcpOworCitkZWJ1Zygn QmVmb3JlIG5vcm1hbGl6ZScpOworc2hvdWxkQmUoJ3NlcmlhbGl6ZXIuc2VyaWFsaXplVG9TdHJp bmcoeG1sQ2h1bmspJywgJyI8Zm9vPlRoaXMgaXMgc29tZSB0ZXh0IGJlZm9yZSB0aGUgQ0RBVEE8 IVtDREFUQVtUaGlzIGlzIHNvbWUgPGJvbGQ+bWFya3VwPC9ib2xkPiBpbnNpZGUgb2YgYSBDREFU QV1dPlRoaXMgaXMgc29tZSB0ZXh0IGFmdGVyIHRoZSBDREFUQTwvZm9vPiInKTsKK3Nob3VsZEJl KCd4bWxDaHVuay5kb2N1bWVudEVsZW1lbnQuY2hpbGROb2Rlcy5sZW5ndGgnLCAnMycpOworeG1s Q2h1bmsuZG9jdW1lbnRFbGVtZW50Lm5vcm1hbGl6ZSgpOworZGVidWcoJ0FmdGVyIG5vcm1hbGl6 ZScpOworc2hvdWxkQmUoJ3NlcmlhbGl6ZXIuc2VyaWFsaXplVG9TdHJpbmcoeG1sQ2h1bmspJywg JyI8Zm9vPlRoaXMgaXMgc29tZSB0ZXh0IGJlZm9yZSB0aGUgQ0RBVEE8IVtDREFUQVtUaGlzIGlz IHNvbWUgPGJvbGQ+bWFya3VwPC9ib2xkPiBpbnNpZGUgb2YgYSBDREFUQV1dPlRoaXMgaXMgc29t ZSB0ZXh0IGFmdGVyIHRoZSBDREFUQTwvZm9vPiInKTsKK3Nob3VsZEJlKCd4bWxDaHVuay5kb2N1 bWVudEVsZW1lbnQuY2hpbGROb2Rlcy5sZW5ndGgnLCAnMycpOworCit2YXIgc3VjY2Vzc2Z1bGx5 UGFyc2VkID0gdHJ1ZTsK