33190 2010-01-04 18:13:14 -0800 Missing commas in IDL extended attributes 2010-01-07 03:36:02 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 33193 32854 1 tkent tkent commit-queue darin dglazkov eric webkit.review.bot oldest_to_newest 176987 0 tkent 2010-01-04 18:13:14 -0800 Some IDL files lack "," delimiters for multiple extended attributes. For example, WebCore/css/WebKitCSSTransformValue.idl interface [ HasIndexGetter InterfaceUUID=303fe632-5dcf-4472-b977-33a5481e1d12, ImplementationUUID=eb49e5c6-6075-45b8-b5c4-7e775c01e7c4 ] WebKitCSSTransformValue : CSSValueList { There is no "," which should follow HasIndexGetter. In this case, both of HasIndexGetter and InterfaceUUID are not processed because they are recognized as a single attribute with spaces like "HasIndexGetter InterfaceUUID". 177485 1 45946 tkent 2010-01-05 17:24:07 -0800 Created attachment 45946 Proposed patch - Fix commas - Check such attributes by IDLParser.pm Note: This patch will break Chromium build because of Bug#33193. 177489 2 45946 darin 2010-01-05 17:34:59 -0800 Comment on attachment 45946 Proposed patch Thanks for finding this. I would like to see test cases to demonstrate the bad thing that was happening due to HasIndexGetter and OmitConstructor being ignored in these two classes. 177498 3 webkit.review.bot 2010-01-05 17:56:44 -0800 style-queue ran check-webkit-style on attachment 45946 without any errors. 177504 4 tkent 2010-01-05 18:07:14 -0800 (In reply to comment #2) > (From update of attachment 45946 [details]) > Thanks for finding this. I would like to see test cases to demonstrate the bad > thing that was happening due to HasIndexGetter and OmitConstructor being > ignored in these two classes. This issue is not causing any real problems at this moment. WebKitCSSTransformValue is missing HasIndexGetter and generated code for it had no code for index getter. Fortunately the parent interface of WebKitCSSTransformValue has HasIndexGetter code. So WebKitCSSTransformValue objects supprot index getter. OmitConstructor is used only by CodeGeneratorJS. But JS binding excludes EventTarget.idl. (See JS_DOM_HEADERS in WebCore/DerivedSources.make) 177516 5 webkit.review.bot 2010-01-05 18:38:31 -0800 Attachment 45946 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/163557 177606 6 45946 eric 2010-01-06 09:21:01 -0800 Comment on attachment 45946 Proposed patch OK. Please don't land until the chromium build fix is in. Won't this patch fail to apply now anyway? I thoguth we killed all of the COM stuff? 177612 7 eric 2010-01-06 09:31:06 -0800 Attachment 45946 was posted by a committer and has review+, assigning to Kent Tamura for commit. 177960 8 tkent 2010-01-06 20:55:00 -0800 (In reply to comment #6) > (From update of attachment 45946 [details]) > OK. Please don't land until the chromium build fix is in. > > Won't this patch fail to apply now anyway? I thoguth we killed all of the COM > stuff? We can apply this patch for now because the patch of Bug#32854 (Kill COM stuff) is not landed yet. Both of this and Bug#32854 trigger a Chromium build failure. I'll commit Bug#33193 first, then this, and Bug#32854. 178120 9 45946 commit-queue 2010-01-07 03:35:50 -0800 Comment on attachment 45946 Proposed patch Clearing flags on attachment: 45946 Committed r52915: <http://trac.webkit.org/changeset/52915> 178121 10 commit-queue 2010-01-07 03:36:02 -0800 All reviewed patches have been landed. Closing bug. 45946 2010-01-05 17:24:07 -0800 2010-01-07 03:35:49 -0800 Proposed patch 0001-idl-comma-1.patch text/plain 2699 tkent RnJvbSAyY2Y0Mzg5MzA2Y2VlMjA4NGNiYThmMGIyOWIyMjkwZGY3MDU4MTAwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW50IFRhbXVyYSA8dGtlbnRAY2hyb21pdW0ub3JnPgpEYXRl OiBUdWUsIDUgSmFuIDIwMTAgMTI6MDc6NTUgKzA5MDAKU3ViamVjdDogW1BBVENIXSBpZGwtY29t bWEtMQoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE1 ICsrKysrKysrKysrKysrKwogV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbSAg IHwgICAgMSArCiBXZWJDb3JlL2Nzcy9XZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZS5pZGwgfCAgICAy ICstCiBXZWJDb3JlL2RvbS9FdmVudFRhcmdldC5pZGwgICAgICAgICAgICAgfCAgICAyICstCiA0 IGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwMTlhMjVj Li43ZGQwYWM5IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTAxLTA0ICBLZW50IFRhbXVyYSAgPHRrZW50 QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBTb21lIElETCBmaWxlcyBsYWNrICIsIiBzZXBhcmF0b3JzIGZvciBleHRlbmRlZCBh dHRyaWJ1dGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzMxOTAKKworICAgICAgICBUbyBmaW5kIHN1Y2ggbWlzdGFrZXMsIElETFBhcnNlci5wbSBy ZWplY3RzIHdoaXRlc3BhY2UgY2hhcmFjdGVycyBpbgorICAgICAgICBleHRlbmRlZCBhdHRyaWJ1 dGUgbmFtZXMuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbToKKyAg ICAgICAgICBwYXJzZUV4dGVuZGVkQXR0cmlidXRlcyByZWplY3RzIHdoaXRlc3BhY2UgaW4gYSBu YW1lLgorICAgICAgICAqIGNzcy9XZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZS5pZGw6IEFkZCBtaXNz aW5nICIsIi4KKyAgICAgICAgKiBkb20vRXZlbnRUYXJnZXQuaWRsOiBkaXR0by4KKwogMjAxMC0w MS0wNCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvSURMUGFyc2VyLnBtIGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbQpp bmRleCA1YWZmZTk0Li43NGJlOGE0IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvSURMUGFyc2VyLnBtCisrKyBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9JRExQYXJzZXIu cG0KQEAgLTE1OCw2ICsxNTgsNyBAQCBzdWIgcGFyc2VFeHRlbmRlZEF0dHJpYnV0ZXMKICAgICAg ICAgIyBBdHRyaWJ1dGVzIHdpdGggbm8gdmFsdWUgYXJlIHNldCB0byBiZSB0cnVlCiAgICAgICAg ICR2YWx1ZSA9IDEgdW5sZXNzIGRlZmluZWQgJHZhbHVlOwogICAgICAgICAkYXR0cnN7JG5hbWV9 ID0gJHZhbHVlOworICAgICAgICBkaWUoIkludmFsaWQgZXh0ZW5kZWQgYXR0cmlidXRlIG5hbWU6 ICckbmFtZSdcbiIpIGlmICRuYW1lID1+IC9ccy87CiAgICAgfQogCiAgICAgcmV0dXJuIFwlYXR0 cnM7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZS5pZGwg Yi9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZS5pZGwKaW5kZXggNjc0MDZmOC4u MDY5YzU4OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWUu aWRsCisrKyBiL1dlYkNvcmUvY3NzL1dlYktpdENTU1RyYW5zZm9ybVZhbHVlLmlkbApAQCAtMjks NyArMjksNyBAQAogbW9kdWxlIGNzcyB7CiAKICAgICBpbnRlcmZhY2UgWwotICAgICAgICAgICAg SGFzSW5kZXhHZXR0ZXIKKyAgICAgICAgICAgIEhhc0luZGV4R2V0dGVyLAogICAgICAgICAgICAg SW50ZXJmYWNlVVVJRD0zMDNmZTYzMi01ZGNmLTQ0NzItYjk3Ny0zM2E1NDgxZTFkMTIsCiAgICAg ICAgICAgICBJbXBsZW1lbnRhdGlvblVVSUQ9ZWI0OWU1YzYtNjA3NS00NWI4LWI1YzQtN2U3NzVj MDFlN2M0CiAgICAgXSBXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZSA6IENTU1ZhbHVlTGlzdCB7CmRp ZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9FdmVudFRhcmdldC5pZGwgYi9XZWJDb3JlL2RvbS9FdmVu dFRhcmdldC5pZGwKaW5kZXggYjZlZmMzNy4uYmFhYjAyMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9k b20vRXZlbnRUYXJnZXQuaWRsCisrKyBiL1dlYkNvcmUvZG9tL0V2ZW50VGFyZ2V0LmlkbApAQCAt MjQsNyArMjQsNyBAQCBtb2R1bGUgZXZlbnRzIHsKICAgICBpbnRlcmZhY2UgWwogICAgICAgICBP YmpDUHJvdG9jb2wsCiAgICAgICAgIFB1cmVJbnRlcmZhY2UsCi0gICAgICAgIE9taXRDb25zdHJ1 Y3RvcgorICAgICAgICBPbWl0Q29uc3RydWN0b3IsCiAgICAgICAgIEludGVyZmFjZVVVSUQ9MUQ3 MUM3RUMtMEJBMC00MDQ0LUJERkQtNTZCM0U4RjVGOUQ0CiAgICAgXSBFdmVudFRhcmdldCB7CiAg ICAgICAgIFtPbGRTdHlsZU9iakNdIHZvaWQgYWRkRXZlbnRMaXN0ZW5lcihpbiBET01TdHJpbmcg dHlwZSwgCi0tIAoxLjYuMy4zCgo=