33173 2010-01-04 12:13:14 -0800 style-queue complains about one-line macros that include multiple statements 2010-01-17 19:28:22 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aroben webkit-unassigned abarth commit-queue eric oldest_to_newest 176799 0 aroben 2010-01-04 12:13:14 -0800 The style-queue complains about one-line macros that include multiple statements, but shouldn't. See bug 33167 comment 1. I guess the style guide should mention this, too. 181639 1 46766 abarth 2010-01-17 16:04:23 -0800 Created attachment 46766 Patch 181704 2 46766 commit-queue 2010-01-17 19:28:16 -0800 Comment on attachment 46766 Patch Clearing flags on attachment: 46766 Committed r53387: <http://trac.webkit.org/changeset/53387> 181705 3 commit-queue 2010-01-17 19:28:22 -0800 All reviewed patches have been landed. Closing bug. 46766 2010-01-17 16:04:23 -0800 2010-01-17 19:28:16 -0800 Patch bug-33173-20100117160422.patch text/plain 2325 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUzMzczKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEtMTcgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBzdHlsZS1xdWV1ZSBjb21wbGFpbnMgYWJvdXQgb25lLWxpbmUgbWFjcm9zIHRoYXQg aW5jbHVkZSBtdWx0aXBsZSBzdGF0ZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMzE3MworCisgICAgICAgIEFkZCBhbiBleGNlcHRpb24gZm9y IG11bHRpcGxlIHN0YXRlbWVudHMgb24gYSBsaW5lIHRoYXQgc3RhcnRzIGEgbWFjcm8uCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weToKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZV91bml0dGVzdC5weToKKwogMjAxMC0wMS0x NSAgSm9uIEhvbmV5Y3V0dCAgPGpob25leWN1dHRAYXBwbGUuY29tPgogCiAgICAgICAgIGdldF9h Y2NQYXJlbnQgc2hvdWxkIHRyeSB0byByZXRyaWV2ZSBwYXJlbnQgQWNjZXNzaWJpbGl0eU9iamVj dCwgYmVmb3JlCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9z dHlsZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NwcF9zdHlsZS5weQkocmV2aXNpb24gNTMzNzIpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weQkod29ya2luZyBjb3B5KQpAQCAtMTk3Miw3ICsxOTcy LDggQEAgZGVmIGNoZWNrX3N0eWxlKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbAogICAgICAgICAj IEl0J3Mgb2sgdG8gaGF2ZSBtYW55IGNvbW1hbmRzIGluIGEgc3dpdGNoIGNhc2UgdGhhdCBmaXRz IGluIDEgbGluZQogICAgICAgICBhbmQgbm90ICgoY2xlYW5zZWRfbGluZS5maW5kKCdjYXNlICcp ICE9IC0xCiAgICAgICAgICAgICAgICAgICBvciBjbGVhbnNlZF9saW5lLmZpbmQoJ2RlZmF1bHQ6 JykgIT0gLTEpCi0gICAgICAgICAgICAgICAgIGFuZCBjbGVhbnNlZF9saW5lLmZpbmQoJ2JyZWFr OycpICE9IC0xKSk6CisgICAgICAgICAgICAgICAgIGFuZCBjbGVhbnNlZF9saW5lLmZpbmQoJ2Jy ZWFrOycpICE9IC0xKQorICAgICAgICBhbmQgbm90IGNsZWFuc2VkX2xpbmUuc3RhcnRzd2l0aCgn I2RlZmluZSAnKSk6CiAgICAgICAgIGVycm9yKGZpbGVuYW1lLCBsaW5lX251bWJlciwgJ3doaXRl c3BhY2UvbmV3bGluZScsIDQsCiAgICAgICAgICAgICAgICdNb3JlIHRoYW4gb25lIGNvbW1hbmQg b24gdGhlIHNhbWUgbGluZScpCiAKSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA1MzM3 MikKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0 ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMDAxLDcgKzMwMDEsOSBAQCBjbGFzcyBXZWJLaXRT dHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAnICAgIGRvU29tZXRoaW5n RWxzZUFnYWluKCk7XG4nCiAgICAgICAgICAgICAnfVxuJywKICAgICAgICAgICAgICcnKQotCisg ICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKKyAgICAgICAgICAgICcjZGVmaW5l IFRFU1RfQVNTRVJUKGV4cHJlc3Npb24pIGRvIHsgaWYgKCEoZXhwcmVzc2lvbikpIHsgVGVzdHND b250cm9sbGVyOjpzaGFyZWQoKS50ZXN0RmFpbGVkKF9fRklMRV9fLCBfX0xJTkVfXywgI2V4cHJl c3Npb24pOyByZXR1cm47IH0gfSB3aGlsZSAoMClcbicsCisgICAgICAgICAgICAnJykKICAgICAg ICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAogICAgICAgICAgICAgJ2lmIChjb25kaXRp b24pIHtcbicKICAgICAgICAgICAgICcgICAgZG9Tb21ldGhpbmcoKTtcbicK