<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>33147</bug_id>
          
          <creation_ts>2010-01-04 03:53:58 -0800</creation_ts>
          <short_desc>Document CPU() macros in comments.</short_desc>
          <delta_ts>2010-01-04 08:11:05 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Maciej Stachowiak">mjs</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>176662</commentid>
    <comment_count>0</comment_count>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2010-01-04 03:53:58 -0800</bug_when>
    <thetext>Document CPU() macros in comments.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>176663</commentid>
    <comment_count>1</comment_count>
      <attachid>45796</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2010-01-04 03:54:30 -0800</bug_when>
    <thetext>Created attachment 45796
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>176664</commentid>
    <comment_count>2</comment_count>
      <attachid>45796</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-01-04 03:55:38 -0800</bug_when>
    <thetext>Comment on attachment 45796
Patch

looks reasonable</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>176665</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-01-04 03:55:59 -0800</bug_when>
    <thetext>style-queue ran check-webkit-style on attachment 45796 without any errors.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>176666</commentid>
    <comment_count>4</comment_count>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2010-01-04 04:01:55 -0800</bug_when>
    <thetext>Committed r52730: &lt;http://trac.webkit.org/changeset/52730&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>176703</commentid>
    <comment_count>5</comment_count>
      <attachid>45796</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-01-04 08:11:05 -0800</bug_when>
    <thetext>Comment on attachment 45796
Patch

COMPILER macros, not CPU macros.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>45796</attachid>
            <date>2010-01-04 03:54:30 -0800</date>
            <delta_ts>2010-01-04 08:11:05 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-33147-20100104035428.patch</filename>
            <type>text/plain</type>
            <size>1812</size>
            <attacher name="Maciej Stachowiak">mjs</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUyNzI5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDEtMDQgIE1hY2llaiBT
dGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBEb2N1bWVudCBDUFUoKSBtYWNyb3MgaW4gY29tbWVudHMuCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzE0NworCisg
ICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTAtMDEtMDQgIE1hY2llaiBTdGFjaG93aWFr
ICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRl
eDogSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlw
dENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDUyNzI5KQorKysgSmF2YVNjcmlwdENvcmUv
d3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTU3LDggKzU3LDggQEAKIAogLyogPT09
PSBDT01QSUxFUigpIC0gdGhlIGNvbXBpbGVyIGJlaW5nIHVzZWQgdG8gYnVpbGQgdGhlIHByb2pl
Y3QgPT09PSAqLwogCi0vKiBDT01QSUxFUihNU1ZDKSAqLwotLyogQ09NUElMRVIoTVNWQzcpICov
CisvKiBDT01QSUxFUihNU1ZDKSBNaWNyb3NvZnQgVmlzdWFsIEMrKyAqLworLyogQ09NUElMRVIo
TVNWQzcpIE1pY3Jvc29mdCBWaXN1YWwgQysrIHY3IG9yIGxvd2VyKi8KICNpZiBkZWZpbmVkKF9N
U0NfVkVSKQogI2RlZmluZSBXVEZfQ09NUElMRVJfTVNWQyAxCiAjaWYgX01TQ19WRVIgPCAxNDAw
CkBAIC02NiwyNCArNjYsMjQgQEAKICNlbmRpZgogI2VuZGlmCiAKLS8qIENPTVBJTEVSKFJWQ1Qp
ICovCisvKiBDT01QSUxFUihSVkNUKSAgLSBBUk0gUmVhbFZpZXcgQ29tcGlsYXRpb24gVG9vbHMg
Ki8KICNpZiBkZWZpbmVkKF9fQ0NfQVJNKSB8fCBkZWZpbmVkKF9fQVJNQ0NfXykKICNkZWZpbmUg
V1RGX0NPTVBJTEVSX1JWQ1QgMQogI2VuZGlmCiAKLS8qIENPTVBJTEVSKEdDQykgKi8KKy8qIENP
TVBJTEVSKEdDQykgLSBHTlUgQ29tcGlsZXIgQ29sbGVjdGlvbiAqLwogLyogLS1nbnUgb3B0aW9u
IG9mIHRoZSBSVkNUIGNvbXBpbGVyIGFsc28gZGVmaW5lcyBfX0dOVUNfXyAqLwogI2lmIGRlZmlu
ZWQoX19HTlVDX18pICYmICFDT01QSUxFUihSVkNUKQogI2RlZmluZSBXVEZfQ09NUElMRVJfR0ND
IDEKICNkZWZpbmUgR0NDX1ZFUlNJT04gKF9fR05VQ19fICogMTAwMDAgKyBfX0dOVUNfTUlOT1Jf
XyAqIDEwMCArIF9fR05VQ19QQVRDSExFVkVMX18pCiAjZW5kaWYKIAotLyogQ09NUElMRVIoTUlO
R1cpICovCisvKiBDT01QSUxFUihNSU5HVykgLSBNaW5HVyBHQ0MgKi8KICNpZiBkZWZpbmVkKE1J
TkdXKSB8fCBkZWZpbmVkKF9fTUlOR1czMl9fKQogI2RlZmluZSBXVEZfQ09NUElMRVJfTUlOR1cg
MQogI2VuZGlmCiAKLS8qIENPTVBJTEVSKFdJTlNDVykgKi8KKy8qIENPTVBJTEVSKFdJTlNDVykg
LSBDb2RlV2FycmlvciBmb3IgU3ltYmlhbiBlbXVsYXRvciAqLwogI2lmIGRlZmluZWQoX19XSU5T
Q1dfXykKICNkZWZpbmUgV1RGX0NPTVBJTEVSX1dJTlNDVyAxCiAjZW5kaWYK
</data>
<flag name="review"
          id="27925"
          type_id="1"
          status="+"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>