33142 2010-01-04 02:39:47 -0800 Add unit test for MarkBugFixed 2010-01-06 13:52:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth ddkilzer eric oldest_to_newest 176620 0 abarth 2010-01-04 02:39:47 -0800 Add unit test for MarkBugFixed 176622 1 45788 abarth 2010-01-04 02:40:46 -0800 Created attachment 45788 Patch 176623 2 45788 eric 2010-01-04 02:43:26 -0800 Comment on attachment 45788 Patch Looks good. The ChangeLog should be better. You should note that you're demoting create-bug and mark fixed from the main help and indicate why. 177611 3 eric 2010-01-06 09:30:40 -0800 Attachment 45788 was posted by a committer and has review+, assigning to Adam Barth for commit. 177743 4 abarth 2010-01-06 13:52:55 -0800 I landed this already 45788 2010-01-04 02:40:46 -0800 2010-01-04 02:43:26 -0800 Patch bug-33142-20100104024045.patch text/plain 5952 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxNGFjYmM2Li5mYjU4YjE5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTAtMDEt MDQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdW5pdCB0ZXN0IGZvciBNYXJrQnVnRml4 ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMTQy CisKKyAgICAgICAgTWFya0J1Z0ZpeGVkIGlzIHdheSBiZWhpbmQgaW4gY29tbWFuZCB0ZWNobm9s b2d5LCBidXQgaXQgc3RpbGwgbmVlZHMgYQorICAgICAgICB1bml0IHRlc3QsIGFzIHRoZSBGSVhN RSBjb21tYW5kcy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbWFuZHMvdXBsb2Fk LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbWFuZHMvdXBsb2FkX3VuaXR0ZXN0 LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbW9ja19idWd6aWxsYXRvb2wucHk6CisK KzIwMTAtMDEtMDQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwogICAgICAgICBS ZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KIAogICAgICAgICBBZGQgbWlzc2luZyB1bml0IHRlc3Qg Zm9yIENvbW1pdE1lc3NhZ2VGb3JDdXJyZW50RGlmZgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy91cGxvYWQucHkgYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1hbmRzL3VwbG9hZC5weQppbmRleCA3YTIxNmEzLi5hYmZkMGE0IDEwMDY0 NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL3VwbG9hZC5weQor KysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL3VwbG9hZC5weQpAQCAt MjI2LDEwICsyMjYsOCBAQCBjbGFzcyBQb3N0Q29tbWl0cyhBYnN0cmFjdERlY2xhcmF0aXZlQ29t bW1hbmQpOgogICAgICAgICAgICAgdG9vbC5idWdzLmFkZF9wYXRjaF90b19idWcoYnVnX2lkLCBk aWZmX2ZpbGUsIGRlc2NyaXB0aW9uLCBjb21tZW50X3RleHQsIG1hcmtfZm9yX3Jldmlldz1vcHRp b25zLnJldmlldywgbWFya19mb3JfY29tbWl0X3F1ZXVlPW9wdGlvbnMucmVxdWVzdF9jb21taXQp CiAKIAotIyBGSVhNRTogUmVxdWlyZXMgdW5pdCB0ZXN0LiAgQmxvY2tpbmcgaXNzdWU6IHRvbyBj b21wbGV4IGZvciBub3cuCiBjbGFzcyBNYXJrQnVnRml4ZWQoQWJzdHJhY3REZWNsYXJhdGl2ZUNv bW1tYW5kKToKICAgICBuYW1lID0gIm1hcmstYnVnLWZpeGVkIgotICAgIHNob3dfaW5fbWFpbl9o ZWxwID0gVHJ1ZQogICAgIGhlbHBfdGV4dCA9ICJNYXJrIHRoZSBzcGVjaWZpZWQgYnVnIGFzIGZp eGVkIgogICAgIGFyZ3VtZW50X25hbWVzID0gIltTVk5fUkVWSVNJT05dIgogICAgIGRlZiBfX2lu aXRfXyhzZWxmKToKQEAgLTI2OCwxNyArMjY2LDYgQEAgY2xhc3MgTWFya0J1Z0ZpeGVkKEFic3Ry YWN0RGVjbGFyYXRpdmVDb21tbWFuZCk6CiAKICAgICAgICAgcmV0dXJuIChidWdfaWQsIHN2bl9y ZXZpc2lvbikKIAotICAgIGRlZiBfb3Blbl9idWdfaW5fd2ViX2Jyb3dzZXIoc2VsZiwgdG9vbCwg YnVnX2lkKToKLSAgICAgICAgaWYgc3lzLnBsYXRmb3JtID09ICJkYXJ3aW4iOgotICAgICAgICAg ICAgdG9vbC5leGVjdXRpdmUucnVuX2NvbW1hbmQoWyJvcGVuIiwgdG9vbC5idWdzLnNob3J0X2J1 Z191cmxfZm9yX2J1Z19pZChidWdfaWQpXSkKLSAgICAgICAgICAgIHJldHVybgotICAgICAgICBs b2coIldBUk5JTkc6IC0tb3BlbiBpcyBvbmx5IHN1cHBvcnRlZCBvbiBNYWMgT1MgWC4iKQotCi0g ICAgZGVmIF9wcm9tcHRfdXNlcl9mb3JfY29ycmVjdG5lc3Moc2VsZiwgYnVnX2lkLCBzdm5fcmV2 aXNpb24pOgotICAgICAgICBhbnN3ZXIgPSByYXdfaW5wdXQoIklzIHRoaXMgY29ycmVjdCAoeS9O KT8gIikKLSAgICAgICAgaWYgbm90IHJlLm1hdGNoKCJeXHMqeShlcyk/IiwgYW5zd2VyLCByZS5J R05PUkVDQVNFKToKLSAgICAgICAgICAgIGV4aXQoMSkKLQogICAgIGRlZiBleGVjdXRlKHNlbGYs IG9wdGlvbnMsIGFyZ3MsIHRvb2wpOgogICAgICAgICBidWdfaWQgPSBvcHRpb25zLmJ1Z19pZAog CkBAIC0yOTQsMTQgKzI4MSwxNSBAQCBjbGFzcyBNYXJrQnVnRml4ZWQoQWJzdHJhY3REZWNsYXJh dGl2ZUNvbW1tYW5kKToKICAgICAgICAgICAgIG5lZWRzX3Byb21wdCA9IFRydWUKICAgICAgICAg ICAgIChidWdfaWQsIHN2bl9yZXZpc2lvbikgPSBzZWxmLl9kZXRlcm1pbmVfYnVnX2lkX2FuZF9z dm5fcmV2aXNpb24odG9vbCwgYnVnX2lkLCBzdm5fcmV2aXNpb24pCiAKLSAgICAgICAgbG9nKCJC dWc6IDwlcz4gJXMiICUgKHRvb2wuYnVncy5zaG9ydF9idWdfdXJsX2Zvcl9idWdfaWQoYnVnX2lk KSwgdG9vbC5idWdzLmZldGNoX2J1Z19kaWN0aW9uYXJ5KGJ1Z19pZClbInRpdGxlIl0pKQorICAg ICAgICBsb2coIkJ1ZzogPCVzPiAlcyIgJSAodG9vbC5idWdzLmJ1Z191cmxfZm9yX2J1Z19pZChi dWdfaWQpLCB0b29sLmJ1Z3MuZmV0Y2hfYnVnX2RpY3Rpb25hcnkoYnVnX2lkKVsidGl0bGUiXSkp CiAgICAgICAgIGxvZygiUmV2aXNpb246ICVzIiAlIHN2bl9yZXZpc2lvbikKIAogICAgICAgICBp ZiBvcHRpb25zLm9wZW5fYnVnOgotICAgICAgICAgICAgc2VsZi5fb3Blbl9idWdfaW5fd2ViX2Jy b3dzZXIodG9vbCwgYnVnX2lkKQorICAgICAgICAgICAgdG9vbC51c2VyLm9wZW5fdXJsKHRvb2wu YnVncy5idWdfdXJsX2Zvcl9idWdfaWQoYnVnX2lkKSkKIAogICAgICAgICBpZiBuZWVkc19wcm9t cHQ6Ci0gICAgICAgICAgICBzZWxmLl9wcm9tcHRfdXNlcl9mb3JfY29ycmVjdG5lc3MoYnVnX2lk LCBzdm5fcmV2aXNpb24pCisgICAgICAgICAgICBpZiBub3QgdG9vbC51c2VyLmNvbmZpcm0oIklz IHRoaXMgY29ycmVjdD8iKToKKyAgICAgICAgICAgICAgICBleGl0KDEpCiAKICAgICAgICAgYnVn X2NvbW1lbnQgPSBidWdfY29tbWVudF9mcm9tX3N2bl9yZXZpc2lvbihzdm5fcmV2aXNpb24pCiAg ICAgICAgIGlmIG9wdGlvbnMuY29tbWVudDoKQEAgLTMxOCw3ICszMDYsNiBAQCBjbGFzcyBNYXJr QnVnRml4ZWQoQWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1tYW5kKToKICMgRklYTUU6IFJlcXVpcmVz IHVuaXQgdGVzdC4gIEJsb2NraW5nIGlzc3VlOiB0b28gY29tcGxleCBmb3Igbm93LgogY2xhc3Mg Q3JlYXRlQnVnKEFic3RyYWN0RGVjbGFyYXRpdmVDb21tbWFuZCk6CiAgICAgbmFtZSA9ICJjcmVh dGUtYnVnIgotICAgIHNob3dfaW5fbWFpbl9oZWxwID0gVHJ1ZQogICAgIGhlbHBfdGV4dCA9ICJD cmVhdGUgYSBidWcgZnJvbSBsb2NhbCBjaGFuZ2VzIG9yIGxvY2FsIGNvbW1pdHMiCiAgICAgYXJn dW1lbnRfbmFtZXMgPSAiW0NPTU1JVElTSF0iCiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvY29tbWFuZHMvdXBsb2FkX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy91cGxvYWRfdW5pdHRlc3QucHkKaW5kZXggYjMwOTM1 Zi4uMjE3YzJkMiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t YW5kcy91cGxvYWRfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tYW5kcy91cGxvYWRfdW5pdHRlc3QucHkKQEAgLTMwLDYgKzMwLDcgQEAgaW1wb3J0IHVu aXR0ZXN0CiAKIGZyb20gd2Via2l0cHkuY29tbWFuZHMuY29tbWFuZHRlc3QgaW1wb3J0IENvbW1h bmRzVGVzdAogZnJvbSB3ZWJraXRweS5jb21tYW5kcy51cGxvYWQgaW1wb3J0ICoKK2Zyb20gd2Vi a2l0cHkubW9jayBpbXBvcnQgTW9jawogZnJvbSB3ZWJraXRweS5tb2NrX2J1Z3ppbGxhdG9vbCBp bXBvcnQgTW9ja0J1Z3ppbGxhVG9vbAogCiBjbGFzcyBVcGxvYWRDb21tYW5kc1Rlc3QoQ29tbWFu ZHNUZXN0KToKQEAgLTY1LDUgKzY2LDEzIEBAIGNsYXNzIFVwbG9hZENvbW1hbmRzVGVzdChDb21t YW5kc1Rlc3QpOgogICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiT2Jzb2xldGluZyAyIG9sZCBw YXRjaGVzIG9uIGJ1ZyA0MlxuIgogICAgICAgICBzZWxmLmFzc2VydF9leGVjdXRlX291dHB1dHMo U3VibWl0UGF0Y2goKSwgWzQyXSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKIAor ICAgIGRlZiB0ZXN0X21hcmtfYnVnX2ZpeGVkKHNlbGYpOgorICAgICAgICB0b29sID0gTW9ja0J1 Z3ppbGxhVG9vbCgpCisgICAgICAgIHRvb2wuX3NjbS5sYXN0X3N2bl9jb21taXRfbG9nID0gbGFt YmRhOiAicjk4NzYgfCIKKyAgICAgICAgb3B0aW9ucyA9IE1vY2soKQorICAgICAgICBvcHRpb25z LmJ1Z19pZCA9IDQyCisgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJCdWc6IDxodHRwOi8vZXhh bXBsZS5jb20vNDI+IFRoZSBmaXJzdCBidWdcblJldmlzaW9uOiA5ODc2XG5BZGRpbmcgY29tbWVu dCB0byBCdWcgNDIuXG4iCisgICAgICAgIHNlbGYuYXNzZXJ0X2V4ZWN1dGVfb3V0cHV0cyhNYXJr QnVnRml4ZWQoKSwgW10sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIsIHRvb2w9dG9v bCwgb3B0aW9ucz1vcHRpb25zKQorCiAgICAgZGVmIHRlc3RfZWRpdF9jaGFuZ2Vsb2coc2VsZik6 CiAgICAgICAgIHNlbGYuYXNzZXJ0X2V4ZWN1dGVfb3V0cHV0cyhFZGl0Q2hhbmdlTG9nKCksIFtd KQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9tb2NrX2J1Z3ppbGxh dG9vbC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbW9ja19idWd6aWxsYXRvb2wu cHkKaW5kZXggMzlkYmE3ZC4uZjgzOTJhYSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9tb2NrX2J1Z3ppbGxhdG9vbC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L21vY2tfYnVnemlsbGF0b29sLnB5CkBAIC02NCwxNiArNjQsMTkgQEAgX3VuYXNz aWduZWRfZW1haWwgPSAidW5hc3NpZ25lZEBleGFtcGxlLmNvbSIKICMgRklYTUU6IFRoZSBpZHMg c2hvdWxkIGJlIDEsIDIsIDMgaW5zdGVhZCBvZiBjcmF6eSBudW1iZXJzLgogX2J1ZzEgPSB7CiAg ICAgImlkIiA6IDQyLAorICAgICJ0aXRsZSIgOiAiVGhlIGZpcnN0IGJ1ZyIsCiAgICAgImFzc2ln bmVkX3RvX2VtYWlsIiA6IF91bmFzc2lnbmVkX2VtYWlsLAogICAgICJhdHRhY2htZW50cyIgOiBb X3BhdGNoMSwgX3BhdGNoMl0sCiB9CiBfYnVnMiA9IHsKICAgICAiaWQiIDogNzUsCisgICAgInRp dGxlIiA6ICJUaGUgc2Vjb25kIGJ1ZyIsCiAgICAgImFzc2lnbmVkX3RvX2VtYWlsIiA6ICJmb29A Zm9vLmNvbSIsCiAgICAgImF0dGFjaG1lbnRzIiA6IFtdLAogfQogX2J1ZzMgPSB7CiAgICAgImlk IiA6IDc2LAorICAgICJ0aXRsZSIgOiAiVGhlIHRoaXJkIGJ1ZyIsCiAgICAgImFzc2lnbmVkX3Rv X2VtYWlsIiA6IF91bmFzc2lnbmVkX2VtYWlsLAogICAgICJhdHRhY2htZW50cyIgOiBbXSwKIH0K QEAgLTExOCw2ICsxMjEsOSBAQCBjbGFzcyBNb2NrQnVnemlsbGEoTW9jayk6CiAgICAgZGVmIGJ1 Z191cmxfZm9yX2J1Z19pZChzZWxmLCBidWdfaWQpOgogICAgICAgICByZXR1cm4gIiVzLyVzIiAl IChzZWxmLmJ1Z19zZXJ2ZXJfdXJsLCBidWdfaWQpCiAKKyAgICBkZWYgZmV0Y2hfYnVnX2RpY3Rp b25hcnkoc2VsZiwgYnVnX2lkKToKKyAgICAgICAgcmV0dXJuIHNlbGYuYnVnX2NhY2hlLmdldChi dWdfaWQpCisKICAgICBkZWYgYXR0YWNobWVudF91cmxfZm9yX2lkKHNlbGYsIGF0dGFjaG1lbnRf aWQsIGFjdGlvbik6CiAgICAgICAgIGFjdGlvbl9wYXJhbSA9ICIiCiAgICAgICAgIGlmIGFjdGlv biBhbmQgYWN0aW9uICE9ICJ2aWV3IjoK