33141 2010-01-04 01:46:52 -0800 Add missing unit test for CommitMessageForCurrentDiff 2010-01-04 01:49:34 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned oldest_to_newest 176604 0 abarth 2010-01-04 01:46:52 -0800 Add missing unit test for CommitMessageForCurrentDiff 176605 1 45786 abarth 2010-01-04 01:47:14 -0800 Created attachment 45786 Patch 176606 2 45786 eric 2010-01-04 01:48:12 -0800 Comment on attachment 45786 Patch LGTM. 176609 3 45786 abarth 2010-01-04 01:49:28 -0800 Comment on attachment 45786 Patch Clearing flags on attachment: 45786 Committed r52720: <http://trac.webkit.org/changeset/52720> 176610 4 abarth 2010-01-04 01:49:34 -0800 All reviewed patches have been landed. Closing bug. 45786 2010-01-04 01:47:14 -0800 2010-01-04 01:49:28 -0800 Patch bug-33141-20100104014712.patch text/plain 2521 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2NWFhMzRhLi4wZDc0YmIzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTAtMDEt MDQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbWlzc2luZyB1bml0IHRlc3QgZm9yIENv bW1pdE1lc3NhZ2VGb3JDdXJyZW50RGlmZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzMxNDEKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29t bWFuZHMvdXBsb2FkLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbWFuZHMvdXBs b2FkX3VuaXR0ZXN0LnB5OgorCisyMDEwLTAxLTA0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtp dC5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCiAKICAgICAgICAgW2J6 dF0gTW92ZSBBYnN0cmFjdFNlcXVlbmNlZENvbW1hbmQgdG8gYSBtb3JlIGdlbmVyYWwgbG9jYXRp b24KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbWFuZHMvdXBs b2FkLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy91cGxvYWQucHkK aW5kZXggM2FmYjFlMi4uN2EyMTZhMyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9jb21tYW5kcy91cGxvYWQucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tYW5kcy91cGxvYWQucHkKQEAgLTQzLDkgKzQzLDkgQEAgZnJvbSB3ZWJraXRweS5j b21tZW50cyBpbXBvcnQgYnVnX2NvbW1lbnRfZnJvbV9zdm5fcmV2aXNpb24KIGZyb20gd2Via2l0 cHkuY29tbWl0dGVycyBpbXBvcnQgQ29tbWl0dGVyTGlzdAogZnJvbSB3ZWJraXRweS5ncmFtbWFy IGltcG9ydCBwbHVyYWxpemUKIGZyb20gd2Via2l0cHkud2Via2l0X2xvZ2dpbmcgaW1wb3J0IGVy cm9yLCBsb2cKK2Zyb20gd2Via2l0cHkubW9jayBpbXBvcnQgTW9jawogZnJvbSB3ZWJraXRweS5t dWx0aWNvbW1hbmR0b29sIGltcG9ydCBBYnN0cmFjdERlY2xhcmF0aXZlQ29tbW1hbmQKIAotIyBG SVhNRTogUmVxdWlyZXMgdW5pdCB0ZXN0LgogY2xhc3MgQ29tbWl0TWVzc2FnZUZvckN1cnJlbnRE aWZmKEFic3RyYWN0RGVjbGFyYXRpdmVDb21tbWFuZCk6CiAgICAgbmFtZSA9ICJjb21taXQtbWVz c2FnZSIKICAgICBoZWxwX3RleHQgPSAiUHJpbnQgYSBjb21taXQgbWVzc2FnZSBzdWl0YWJsZSBm b3IgdGhlIHVuY29tbWl0dGVkIGNoYW5nZXMiCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1hbmRzL3VwbG9hZF91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvY29tbWFuZHMvdXBsb2FkX3VuaXR0ZXN0LnB5CmluZGV4IDRhN2YxY2Qu LmIzMDkzNWYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbWFu ZHMvdXBsb2FkX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbWFuZHMvdXBsb2FkX3VuaXR0ZXN0LnB5CkBAIC0zMyw2ICszMywxNCBAQCBmcm9tIHdlYmtp dHB5LmNvbW1hbmRzLnVwbG9hZCBpbXBvcnQgKgogZnJvbSB3ZWJraXRweS5tb2NrX2J1Z3ppbGxh dG9vbCBpbXBvcnQgTW9ja0J1Z3ppbGxhVG9vbAogCiBjbGFzcyBVcGxvYWRDb21tYW5kc1Rlc3Qo Q29tbWFuZHNUZXN0KToKKyAgICBkZWYgdGVzdF9jb21taXRfbWVzc2FnZV9mb3JfY3VycmVudF9k aWZmKHNlbGYpOgorICAgICAgICB0b29sID0gTW9ja0J1Z3ppbGxhVG9vbCgpCisgICAgICAgIG1v Y2tfY29tbWl0X21lc3NhZ2VfZm9yX3RoaXNfY29tbWl0ID0gTW9jaygpCisgICAgICAgIG1vY2tf Y29tbWl0X21lc3NhZ2VfZm9yX3RoaXNfY29tbWl0Lm1lc3NhZ2UgPSBsYW1iZGE6ICJNb2NrIG1l c3NhZ2UiCisgICAgICAgIHRvb2wuX3NjbS5jb21taXRfbWVzc2FnZV9mb3JfdGhpc19jb21taXQg PSBsYW1iZGE6IG1vY2tfY29tbWl0X21lc3NhZ2VfZm9yX3RoaXNfY29tbWl0CisgICAgICAgIGV4 cGVjdGVkX3N0ZG91dCA9ICJNb2NrIG1lc3NhZ2VcbiIKKyAgICAgICAgc2VsZi5hc3NlcnRfZXhl Y3V0ZV9vdXRwdXRzKENvbW1pdE1lc3NhZ2VGb3JDdXJyZW50RGlmZigpLCBbXSwgZXhwZWN0ZWRf c3Rkb3V0PWV4cGVjdGVkX3N0ZG91dCwgdG9vbD10b29sKQorCiAgICAgZGVmIHRlc3RfYXNzaWdu X3RvX2NvbW1pdHRlcihzZWxmKToKICAgICAgICAgdG9vbCA9IE1vY2tCdWd6aWxsYVRvb2woKQog ICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiQnVnIDc1IGlzIGFscmVhZHkgYXNzaWduZWQgdG8g Zm9vQGZvby5jb20gKE5vbmUpLlxuQnVnIDc2IGhhcyBubyBub24tb2Jzb2xldGUgcGF0Y2hlcywg aWdub3JpbmcuXG4iCg==