<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>33138</bug_id>
          
          <creation_ts>2010-01-04 01:19:05 -0800</creation_ts>
          <short_desc>ExecutableAllocatorSymbian appears to have buggy ARM version check</short_desc>
          <delta_ts>2010-01-04 03:45:27 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>S60 3rd edition</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Maciej Stachowiak">mjs</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>176586</commentid>
    <comment_count>0</comment_count>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2010-01-04 01:19:05 -0800</bug_when>
    <thetext>ExecutableAllocatorSymbian has this code:

#if PLATFORM_ARM_ARCH(5)
    // The moving memory model (as used in ARMv5 and earlier platforms)                                      
    // on Symbian OS limits the number of chunks for each process to 16.                                     
    // To mitigate this limitation increase the pagesize to                                                  
    // allocate less of larger chunks.                                                                       
    ExecutableAllocator::pageSize = MOVING_MEM_PAGE_SIZE;
#else
    TInt page_size;
    UserHal::PageSizeInBytes(page_size);
    ExecutableAllocator::pageSize = page_size;
#endif

But PLATFORM_ARM_ARCH(5) checks for ARM achitecture greater than or equal to 5, not less than or equal to 5. I believe what is intended is this:

#if PLATFORM_ARM_ARCH(6)
    TInt page_size;
    UserHal::PageSizeInBytes(page_size);
    ExecutableAllocator::pageSize = page_size;
#else
    // The moving memory model (as used in ARMv5 and earlier platforms)                                      
    // on Symbian OS limits the number of chunks for each process to 16.                                     
    // To mitigate this limitation increase the pagesize to                                                  
    // allocate less of larger chunks.                                                                       
    ExecutableAllocator::pageSize = MOVING_MEM_PAGE_SIZE;
#endif</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>176661</commentid>
    <comment_count>1</comment_count>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2010-01-04 03:45:27 -0800</bug_when>
    <thetext>I fixed this in r52729.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>