33134 2010-01-04 00:29:06 -0800 Create a unit tested parsePatchHeader() subroutine for svn-apply and svn-unapply 2010-01-10 12:49:07 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED DUPLICATE 33447 P2 Normal --- 1 cjerdonek cjerdonek abarth aroben cjerdonek darin ddkilzer eric hamaji oldest_to_newest 176557 0 cjerdonek 2010-01-04 00:29:06 -0800 Create a unit tested parsePatchHeader() subroutine for svn-apply and svn-unapply. In addition to providing more test coverage, this will result in more code sharing between svn-apply and svn-unapply. This affects the code in the main while(<>) loop of both scripts: while (<>) { s/([\n\r]+)$//mg; my $eol = $1; if (!defined($indexPath) && m#^diff --git a/#) { $filter = \&gitdiff2svndiff; } $_ = &$filter($_) if $filter; if (/^Index: (.+)/) { ... } if ($indexPath) { # Fix paths on diff, ---, and +++ lines to match preceding Index: line. s/^--- \S+/--- $indexPath/; if (/^--- .+\(from (\S+):\d+\)$/) { $copiedFromPath = $1; } if (s/^\+\+\+ \S+/+++ $indexPath/) { $indexPath = ""; } 179162 1 cjerdonek 2010-01-10 12:49:07 -0800 *** This bug has been marked as a duplicate of bug 33447 ***