33111 2010-01-02 11:54:20 -0800 Mark more filter effect as alphaImage if possible 2010-01-03 17:42:31 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 krit webkit-unassigned commit-queue eric webkit.review.bot zimmermann oldest_to_newest 176350 0 krit 2010-01-02 11:54:20 -0800 Mark more filter effect as alphaImage if possible. 176360 1 45744 krit 2010-01-02 12:31:53 -0800 Created attachment 45744 Mark more effects as alphaImage if previous effect is alphaImage Mark more effects as alphaImage if previous effect is alphaImage. 176361 2 webkit.review.bot 2010-01-02 12:34:38 -0800 style-queue ran check-webkit-style on attachment 45744 without any errors. 176362 3 webkit.review.bot 2010-01-02 12:40:15 -0800 Attachment 45744 did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/159572 176390 4 45751 krit 2010-01-02 14:27:17 -0800 Created attachment 45751 Mark more effects as alphaImage if previous effect is alphaImage should build on qt now. 176391 5 webkit.review.bot 2010-01-02 14:28:16 -0800 style-queue ran check-webkit-style on attachment 45751 without any errors. 176400 6 45751 zimmermann 2010-01-02 16:33:05 -0800 Comment on attachment 45751 Mark more effects as alphaImage if previous effect is alphaImage LGTM, r=me. 176401 7 45751 commit-queue 2010-01-02 16:42:11 -0800 Comment on attachment 45751 Mark more effects as alphaImage if previous effect is alphaImage Rejecting patch 45751 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests Testing 11861 test cases. fast/canvas/webgl/index-validation-copies-indices.html -> failed Exiting early after 1 failures. 5000 tests run. 97.47s total testing time 4999 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/160510 176415 8 45751 krit 2010-01-03 07:33:38 -0800 Comment on attachment 45751 Mark more effects as alphaImage if previous effect is alphaImage The code doesn't touch anything else than SVG Filters. 176416 9 45751 commit-queue 2010-01-03 07:41:33 -0800 Comment on attachment 45751 Mark more effects as alphaImage if previous effect is alphaImage Rejecting patch 45751 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests Testing 11861 test cases. fast/canvas/webgl/index-validation-copies-indices.html -> failed Exiting early after 1 failures. 5000 tests run. 79.05s total testing time 4999 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/161006 176422 10 krit 2010-01-03 09:42:44 -0800 (In reply to comment #9) > (From update of attachment 45751 [details]) > Rejecting patch 45751 from commit-queue. > > Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', > '--exit-after-n-failures=1', '--quiet']" exit_code: 1 > Running build-dumprendertree > Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests > Testing 11861 test cases. > fast/canvas/webgl/index-validation-copies-indices.html -> failed > > Exiting early after 1 failures. 5000 tests run. > 79.05s total testing time > > 4999 test cases (99%) succeeded > 1 test case (<1%) had incorrect layout > 1 test case (<1%) had stderr output > > Full output: http://webkit-commit-queue.appspot.com/results/161006 Hehe. There is no test with this name in the repository :-P 176425 11 krit 2010-01-03 09:57:24 -0800 landed in r52689. Closing bug. 176469 12 eric 2010-01-03 17:42:31 -0800 This patch was a victim of bug 28603. 45744 2010-01-02 12:31:53 -0800 2010-01-02 14:27:17 -0800 Mark more effects as alphaImage if previous effect is alphaImage set-effect-property-alphaImage.patch text/plain 3266 krit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjY4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTAtMDEtMDIgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYXJr IG1vcmUgZmlsdGVyIGVmZmVjdCBhcyBhbHBoYUltYWdlIGlmIHBvc3NpYmxlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzExMQorCisgICAgICAgIE1h cmsgbW9yZSBlZmZlY3RzIGFzIGFscGhhSW1hZ2UgaWYgdGhlIHByZXZpb3VzIHBhdGNoIGlzIGEK KyAgICAgICAgYWxwaGFJbWFnZS4gVGhpcyBjYW4gcmVkdWNlIHRoZSBjYWxjdWxhdGlvbiBvbiB0 aGUgbmV4dCBlZmZlY3QKKyAgICAgICAgbGlrZSBmZUdhdXNzaWFuQmx1ci4KKyAgICAgICAgCisg ICAgICAgIFRlc3Q6IFRoaXMgY2hhbmdlcyBkb24ndCBhZmZlY3QgYW55IExheW91dFRlc3RzIGFu ZCBjYW4ndCBiZSB0ZXN0ZWQKKyAgICAgICAgICAgICAgc29tZWhvdywgc2luY2UgdGhlIGNoYW5n ZXMgYXJlICdpbnZpc2libGUnLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVy cy9GRUNvbG9yTWF0cml4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmVmZmVjdFR5cGUpOgorICAg ICAgICAqIHN2Zy9ncmFwaGljcy9maWx0ZXJzL1NWR0ZFTW9ycGhvbG9neS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpGRU1vcnBob2xvZ3k6OmFwcGx5KToKKyAgICAgICAgKiBzdmcvZ3JhcGhpY3Mv ZmlsdGVycy9TVkdGRU9mZnNldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGRU9mZnNldDo6YXBw bHkpOgorICAgICAgICAqIHN2Zy9ncmFwaGljcy9maWx0ZXJzL1NWR0ZFVGlsZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGRVRpbGU6OmFwcGx5KToKKwogMjAxMC0wMS0wMSAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVy bnN0ZWluLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFQ29sb3JN YXRyaXguY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVy cy9GRUNvbG9yTWF0cml4LmNwcAkocmV2aXNpb24gNTI2NzApCisrKyBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2ZpbHRlcnMvRkVDb2xvck1hdHJpeC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0 NCw2ICsxNDQsNyBAQCB2b2lkIGVmZmVjdFR5cGUoY29uc3QgUGFzc1JlZlB0cjxDYW52YXNQCiAg ICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNlIEZFQ09MT1JNQVRSSVhfVFlQ RV9MVU1JTkFOQ0VUT0FMUEhBOgogICAgICAgICAgICAgICAgIGx1bWluYW5jZShyZWQsIGdyZWVu LCBibHVlLCBhbHBoYSk7CisgICAgICAgICAgICAgICAgc2V0SXNBbHBoYUltYWdlKHRydWUpOwog ICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKSW5kZXg6IFdlYkNvcmUvc3ZnL2dy YXBoaWNzL2ZpbHRlcnMvU1ZHRkVNb3JwaG9sb2d5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3N2Zy9ncmFwaGljcy9maWx0ZXJzL1NWR0ZFTW9ycGhvbG9neS5jcHAJKHJldmlzaW9uIDUyNjcw KQorKysgV2ViQ29yZS9zdmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdGRU1vcnBob2xvZ3kuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC05MCw2ICs5MCw4IEBAIHZvaWQgRkVNb3JwaG9sb2d5OjphcHBseShG aWx0ZXIqIGZpbHRlcikKICAgICBpZiAoIWdldEVmZmVjdENvbnRleHQoKSkKICAgICAgICAgcmV0 dXJuOwogCisgICAgc2V0SXNBbHBoYUltYWdlKG1faW4tPmlzQWxwaGFJbWFnZSgpKTsKKwogICAg IGlmICghbV9yYWRpdXNYIHx8ICFtX3JhZGl1c1kpCiAgICAgICAgIHJldHVybjsKIApJbmRleDog V2ViQ29yZS9zdmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdGRU9mZnNldC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9zdmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdGRU9mZnNldC5jcHAJKHJldmlzaW9u IDUyNjcwKQorKysgV2ViQ29yZS9zdmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdGRU9mZnNldC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTc0LDYgKzc0LDggQEAgdm9pZCBGRU9mZnNldDo6YXBwbHkoRmls dGVyKiBmaWx0ZXIpCiAgICAgaWYgKCFmaWx0ZXJDb250ZXh0KQogICAgICAgICByZXR1cm47CiAK KyAgICBzZXRJc0FscGhhSW1hZ2UobV9pbi0+aXNBbHBoYUltYWdlKCkpOworCiAgICAgRmxvYXRS ZWN0IHNvdXJjZUltYWdlUmVjdCA9IGZpbHRlci0+c291cmNlSW1hZ2VSZWN0KCk7CiAgICAgc291 cmNlSW1hZ2VSZWN0LnNjYWxlKGZpbHRlci0+ZmlsdGVyUmVzb2x1dGlvbigpLndpZHRoKCksIGZp bHRlci0+ZmlsdGVyUmVzb2x1dGlvbigpLmhlaWdodCgpKTsKIApJbmRleDogV2ViQ29yZS9zdmcv Z3JhcGhpY3MvZmlsdGVycy9TVkdGRVRpbGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3Zn L2dyYXBoaWNzL2ZpbHRlcnMvU1ZHRkVUaWxlLmNwcAkocmV2aXNpb24gNTI2NzApCisrKyBXZWJD b3JlL3N2Zy9ncmFwaGljcy9maWx0ZXJzL1NWR0ZFVGlsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTU4LDYgKzU4LDggQEAgdm9pZCBGRVRpbGU6OmFwcGx5KEZpbHRlciogZmlsdGVyKQogICAgIGlm ICghZmlsdGVyQ29udGV4dCkKICAgICAgICAgcmV0dXJuOwogCisgICAgc2V0SXNBbHBoYUltYWdl KG1faW4tPmlzQWxwaGFJbWFnZSgpKTsKKwogICAgIEludFJlY3QgdGlsZVJlY3QgPSBlbmNsb3Np bmdJbnRSZWN0KG1faW4tPnNjYWxlZFN1YlJlZ2lvbigpKTsKIAogICAgIC8vIFNvdXJjZSBpbnB1 dCBuZWVkcyBtb3JlIGF0dGVudGlvbi4gSXQgaGFzIHRoZSBzaXplIG9mIHRoZSBmaWx0ZXJSZWdp b24gYnV0IGdpdmVzIHRoZQo= 45751 2010-01-02 14:27:17 -0800 2010-01-03 07:41:32 -0800 Mark more effects as alphaImage if previous effect is alphaImage set-effect-property-alphaImage.patch text/plain 3302 krit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjY4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTAtMDEtMDIgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYXJr IG1vcmUgZmlsdGVyIGVmZmVjdCBhcyBhbHBoYUltYWdlIGlmIHBvc3NpYmxlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzExMQorCisgICAgICAgIE1h cmsgbW9yZSBlZmZlY3RzIGFzIGFscGhhSW1hZ2UgaWYgdGhlIHByZXZpb3VzIGVmZmVjdCBpcyBh CisgICAgICAgIGFscGhhSW1hZ2UuIFRoaXMgY2FuIHJlZHVjZSB0aGUgY2FsY3VsYXRpb24gb24g dGhlIG5leHQgZWZmZWN0CisgICAgICAgIGxpa2UgZmVHYXVzc2lhbkJsdXIuCisgICAgICAgIAor ICAgICAgICBUZXN0OiBUaGlzIGNoYW5nZXMgZG9uJ3QgYWZmZWN0IGFueSBMYXlvdXRUZXN0cyBh bmQgY2FuJ3QgYmUgdGVzdGVkCisgICAgICAgICAgICAgIHNvbWVob3csIHNpbmNlIHRoZSBjaGFu Z2VzIGFyZSAnaW52aXNpYmxlJy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRl cnMvRkVDb2xvck1hdHJpeC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGRUNvbG9yTWF0cml4Ojph cHBseSk6CisgICAgICAgICogc3ZnL2dyYXBoaWNzL2ZpbHRlcnMvU1ZHRkVNb3JwaG9sb2d5LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkZFTW9ycGhvbG9neTo6YXBwbHkpOgorICAgICAgICAqIHN2 Zy9ncmFwaGljcy9maWx0ZXJzL1NWR0ZFT2Zmc2V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZF T2Zmc2V0OjphcHBseSk6CisgICAgICAgICogc3ZnL2dyYXBoaWNzL2ZpbHRlcnMvU1ZHRkVUaWxl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZFVGlsZTo6YXBwbHkpOgorCiAyMDEwLTAxLTAxICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRl cnMvRkVDb2xvck1hdHJpeC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9maWx0ZXJzL0ZFQ29sb3JNYXRyaXguY3BwCShyZXZpc2lvbiA1MjY3MCkKKysrIFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRUNvbG9yTWF0cml4LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTg0LDYgKzE4NCw3IEBAIHZvaWQgRkVDb2xvck1hdHJpeDo6YXBwbHkoRmlsdGVy KiBmaWx0ZXIKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIEZFQ09MT1JNQVRSSVhf VFlQRV9MVU1JTkFOQ0VUT0FMUEhBOgogICAgICAgICAgICAgZWZmZWN0VHlwZTxGRUNPTE9STUFU UklYX1RZUEVfTFVNSU5BTkNFVE9BTFBIQT4oc3JjUGl4ZWxBcnJheSwgaW1hZ2VEYXRhLCBtX3Zh bHVlcyk7CisgICAgICAgICAgICBzZXRJc0FscGhhSW1hZ2UodHJ1ZSk7CiAgICAgICAgICAgICBi cmVhazsKICAgICB9CiAKSW5kZXg6IFdlYkNvcmUvc3ZnL2dyYXBoaWNzL2ZpbHRlcnMvU1ZHRkVN b3JwaG9sb2d5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3N2Zy9ncmFwaGljcy9maWx0ZXJz L1NWR0ZFTW9ycGhvbG9neS5jcHAJKHJldmlzaW9uIDUyNjcwKQorKysgV2ViQ29yZS9zdmcvZ3Jh cGhpY3MvZmlsdGVycy9TVkdGRU1vcnBob2xvZ3kuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MCw2 ICs5MCw4IEBAIHZvaWQgRkVNb3JwaG9sb2d5OjphcHBseShGaWx0ZXIqIGZpbHRlcikKICAgICBp ZiAoIWdldEVmZmVjdENvbnRleHQoKSkKICAgICAgICAgcmV0dXJuOwogCisgICAgc2V0SXNBbHBo YUltYWdlKG1faW4tPmlzQWxwaGFJbWFnZSgpKTsKKwogICAgIGlmICghbV9yYWRpdXNYIHx8ICFt X3JhZGl1c1kpCiAgICAgICAgIHJldHVybjsKIApJbmRleDogV2ViQ29yZS9zdmcvZ3JhcGhpY3Mv ZmlsdGVycy9TVkdGRU9mZnNldC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9zdmcvZ3JhcGhp Y3MvZmlsdGVycy9TVkdGRU9mZnNldC5jcHAJKHJldmlzaW9uIDUyNjcwKQorKysgV2ViQ29yZS9z dmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdGRU9mZnNldC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc0 LDYgKzc0LDggQEAgdm9pZCBGRU9mZnNldDo6YXBwbHkoRmlsdGVyKiBmaWx0ZXIpCiAgICAgaWYg KCFmaWx0ZXJDb250ZXh0KQogICAgICAgICByZXR1cm47CiAKKyAgICBzZXRJc0FscGhhSW1hZ2Uo bV9pbi0+aXNBbHBoYUltYWdlKCkpOworCiAgICAgRmxvYXRSZWN0IHNvdXJjZUltYWdlUmVjdCA9 IGZpbHRlci0+c291cmNlSW1hZ2VSZWN0KCk7CiAgICAgc291cmNlSW1hZ2VSZWN0LnNjYWxlKGZp bHRlci0+ZmlsdGVyUmVzb2x1dGlvbigpLndpZHRoKCksIGZpbHRlci0+ZmlsdGVyUmVzb2x1dGlv bigpLmhlaWdodCgpKTsKIApJbmRleDogV2ViQ29yZS9zdmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdG RVRpbGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3ZnL2dyYXBoaWNzL2ZpbHRlcnMvU1ZH RkVUaWxlLmNwcAkocmV2aXNpb24gNTI2NzApCisrKyBXZWJDb3JlL3N2Zy9ncmFwaGljcy9maWx0 ZXJzL1NWR0ZFVGlsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU4LDYgKzU4LDggQEAgdm9pZCBG RVRpbGU6OmFwcGx5KEZpbHRlciogZmlsdGVyKQogICAgIGlmICghZmlsdGVyQ29udGV4dCkKICAg ICAgICAgcmV0dXJuOwogCisgICAgc2V0SXNBbHBoYUltYWdlKG1faW4tPmlzQWxwaGFJbWFnZSgp KTsKKwogICAgIEludFJlY3QgdGlsZVJlY3QgPSBlbmNsb3NpbmdJbnRSZWN0KG1faW4tPnNjYWxl ZFN1YlJlZ2lvbigpKTsKIAogICAgIC8vIFNvdXJjZSBpbnB1dCBuZWVkcyBtb3JlIGF0dGVudGlv bi4gSXQgaGFzIHRoZSBzaXplIG9mIHRoZSBmaWx0ZXJSZWdpb24gYnV0IGdpdmVzIHRoZQo=