33097 2010-01-01 15:45:53 -0800 [Qt] Clean up File menu in QtLauncher and QGVLauncher and make keyboard shortcuts similar to Safari 2010-01-04 00:44:20 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates ariya.hidayat eric hausmann kenneth webkit.review.bot zoltan oldest_to_newest 176286 0 dbates 2010-01-01 15:45:53 -0800 We should reorganize the File menu in QtLauncher and QGVLauncher as well as assign keyboard shortcuts that are similar to Safari. We should also add a "Quit" menu option that closes all open windows. 176287 1 45736 dbates 2010-01-01 15:51:06 -0800 Created attachment 45736 Patch Added a "Quit" menu option to close all open windows. Also, renamed the Tools menu to Develop to conform to the menu with the same name in Safari that contains the Show Web Inspector option. 176289 2 webkit.review.bot 2010-01-01 15:54:02 -0800 style-queue ran check-webkit-style on attachment 45736 without any errors. 176356 3 45736 eric 2010-01-02 12:20:54 -0800 Comment on attachment 45736 Patch Looks fine by my eyes. But a Qt person should probably r+ this. I assume that all of these QKeySequence's are available in all versions of Qt that WKQt targets? I seem to remember another patch with QKeySequence's where they were guarded or something. 176490 4 45736 eric 2010-01-03 18:16:46 -0800 Comment on attachment 45736 Patch r+'ing this change to the test tool seems very low risk. The change looks fine to me. We can always roll this out if Dan and I both missed something. 176504 5 eric 2010-01-03 18:48:14 -0800 Attachment 45736 was posted by a committer and has review+, assigning to Daniel Bates for commit. 176565 6 45736 dbates 2010-01-04 00:44:13 -0800 Comment on attachment 45736 Patch Clearing flags on attachment: 45736 Committed r52713: <http://trac.webkit.org/changeset/52713> 176566 7 dbates 2010-01-04 00:44:20 -0800 All reviewed patches have been landed. Closing bug. 45736 2010-01-01 15:51:06 -0800 2010-01-04 00:44:13 -0800 Patch Bug33097.patch text/plain 5883 dbates SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTI2ODUpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMDEgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3 ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzA5NworCisgICAg ICAgIENsZWFucyB1cCB0aGUgRmlsZSBtZW51IHRvIGJldHRlciBjb25mb3JtIHRvIHRoZSBGaWxl IG1lbnUgaW4gU2FmYXJpCisgICAgICAgIGJvdGggaW4gdGVybXMgb2Ygb3B0aW9ucyBhbmQga2V5 Ym9hcmQgc2hvcnRjdXRzLiBBZGRzIGEgIlF1aXQiIG1lbnUKKyAgICAgICAgb3B0aW9ucyB0byBj bG9zZSBhbGwgb3BlbiB3aW5kb3dzLgorCisgICAgICAgICogUUdWTGF1bmNoZXIvbWFpbi5jcHA6 CisgICAgICAgIChNYWluV2luZG93OjpidWlsZFVJKToKKwogMjAwOS0xMi0zMCAgTGFzemxvIEdv bWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg U2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJLaXQvcXQvUUdWTGF1bmNoZXIvbWFpbi5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViS2l0L3F0L1FHVkxhdW5jaGVyL21haW4uY3BwCShyZXZpc2lvbiA1MjY4 NSkKKysrIFdlYktpdC9xdC9RR1ZMYXVuY2hlci9tYWluLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NDA5LDEwICs0MDksMTIgQEAgcHJpdmF0ZToKICAgICAgICAgYmFyLT5hZGRXaWRnZXQodXJsRWRp dCk7CiAKICAgICAgICAgUU1lbnUqIGZpbGVNZW51ID0gbWVudUJhcigpLT5hZGRNZW51KCImRmls ZSIpOwotICAgICAgICBmaWxlTWVudS0+YWRkQWN0aW9uKCJOZXcgV2luZG93IiwgdGhpcywgU0xP VChuZXdXaW5kb3coKSkpOwotICAgICAgICBmaWxlTWVudS0+YWRkQWN0aW9uKCJPcGVuIEZpbGUu Li4iLCB0aGlzLCBTTE9UKG9wZW5GaWxlKCkpLCBRS2V5U2VxdWVuY2UoUXQ6OkNUUkwgfCBRdDo6 S2V5X08pKTsKLSAgICAgICAgZmlsZU1lbnUtPmFkZEFjdGlvbigiQ2xvbmUgdmlldyIsIHRoaXMs IFNMT1QoY2xvbmUoKSkpOwotICAgICAgICBmaWxlTWVudS0+YWRkQWN0aW9uKCJDbG9zZSIsIHRo aXMsIFNMT1QoY2xvc2UoKSkpOworICAgICAgICBmaWxlTWVudS0+YWRkQWN0aW9uKCJOZXcgV2lu ZG93IiwgdGhpcywgU0xPVChuZXdXaW5kb3coKSksIFFLZXlTZXF1ZW5jZTo6TmV3KTsKKyAgICAg ICAgZmlsZU1lbnUtPmFkZEFjdGlvbigiT3BlbiBGaWxlLi4uIiwgdGhpcywgU0xPVChvcGVuRmls ZSgpKSwgUUtleVNlcXVlbmNlOjpPcGVuKTsKKyAgICAgICAgZmlsZU1lbnUtPmFkZEFjdGlvbigi Q2xvbmUgV2luZG93IiwgdGhpcywgU0xPVChjbG9uZSgpKSk7CisgICAgICAgIGZpbGVNZW51LT5h ZGRBY3Rpb24oIkNsb3NlIFdpbmRvdyIsIHRoaXMsIFNMT1QoY2xvc2UoKSksIFFLZXlTZXF1ZW5j ZTo6Q2xvc2UpOworICAgICAgICBmaWxlTWVudS0+YWRkU2VwYXJhdG9yKCk7CisgICAgICAgIGZp bGVNZW51LT5hZGRBY3Rpb24oIlF1aXQiLCBRQXBwbGljYXRpb246Omluc3RhbmNlKCksIFNMT1Qo Y2xvc2VBbGxXaW5kb3dzKCkpLCBRS2V5U2VxdWVuY2UoUXQ6OkNUUkwgfCBRdDo6S2V5X1EpKTsK IAogICAgICAgICBRTWVudSogdmlld01lbnUgPSBtZW51QmFyKCktPmFkZE1lbnUoIiZWaWV3Iik7 CiAgICAgICAgIHZpZXdNZW51LT5hZGRBY3Rpb24ocGFnZS0+YWN0aW9uKFFXZWJQYWdlOjpTdG9w KSk7CkluZGV4OiBXZWJLaXRUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9v bHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MjY4NSkKKysrIFdlYktpdFRvb2xzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEwLTAxLTAxICBEYW5pZWwgQmF0ZXMg IDxkYmF0ZXNAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMw OTcKKworICAgICAgICBDbGVhbnMgdXAgdGhlIEZpbGUgbWVudSB0byBiZXR0ZXIgY29uZm9ybSB0 byB0aGUgRmlsZSBtZW51IGluIFNhZmFyaQorICAgICAgICBib3RoIGluIHRlcm1zIG9mIG9wdGlv bnMgYW5kIGtleWJvYXJkIHNob3J0Y3V0cy4gQWRkcyBhICJRdWl0IiBtZW51CisgICAgICAgIG9w dGlvbnMgdG8gY2xvc2UgYWxsIG9wZW4gd2luZG93cy4gQWxzbywgcmVuYW1lcyB0aGUgVG9vbHMg bWVudSB0bworICAgICAgICBEZXZlbG9wLgorCisgICAgICAgICogUXRMYXVuY2hlci9tYWluLmNw cDoKKyAgICAgICAgKE1haW5XaW5kb3c6OnNldHVwVUkpOgorCiAyMDA5LTEyLTMxICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlk ZWwuCkluZGV4OiBXZWJLaXRUb29scy9RdExhdW5jaGVyL21haW4uY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdFRvb2xzL1F0TGF1bmNoZXIvbWFpbi5jcHAJKHJldmlzaW9uIDUyNjg1KQorKysgV2Vi S2l0VG9vbHMvUXRMYXVuY2hlci9tYWluLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTM4LDExICs1 MzgsMTQgQEAgcHJpdmF0ZToKICAgICAgICAgYmFyLT5hZGRXaWRnZXQodXJsRWRpdCk7CiAKICAg ICAgICAgUU1lbnUqIGZpbGVNZW51ID0gbWVudUJhcigpLT5hZGRNZW51KCImRmlsZSIpOwotICAg ICAgICBRQWN0aW9uKiBuZXdXaW5kb3cgPSBmaWxlTWVudS0+YWRkQWN0aW9uKCJOZXcgV2luZG93 IiwgdGhpcywgU0xPVChuZXdXaW5kb3coKSkpOwotICAgICAgICBmaWxlTWVudS0+YWRkQWN0aW9u KHRyKCJPcGVuIEZpbGUuLi4iKSwgdGhpcywgU0xPVChvcGVuRmlsZSgpKSwgUUtleVNlcXVlbmNl KFF0OjpDVFJMIHwgUXQ6OktleV9PKSk7Ci0gICAgICAgIGZpbGVNZW51LT5hZGRBY3Rpb24odHIo IlByaW50IiksIHRoaXMsIFNMT1QocHJpbnQoKSksIFFLZXlTZXF1ZW5jZTo6UHJpbnQpOwotICAg ICAgICBRQWN0aW9uKiBzY3JlZW5zaG90ID0gZmlsZU1lbnUtPmFkZEFjdGlvbigiU2NyZWVuc2hv dCIsIHRoaXMsIFNMT1Qoc2NyZWVuc2hvdCgpKSk7Ci0gICAgICAgIGZpbGVNZW51LT5hZGRBY3Rp b24oIkNsb3NlIiwgdGhpcywgU0xPVChjbG9zZSgpKSk7CisgICAgICAgIGZpbGVNZW51LT5hZGRB Y3Rpb24oIk5ldyBXaW5kb3ciLCB0aGlzLCBTTE9UKG5ld1dpbmRvdygpKSwgUUtleVNlcXVlbmNl OjpOZXcpOworICAgICAgICBmaWxlTWVudS0+YWRkQWN0aW9uKHRyKCJPcGVuIEZpbGUuLi4iKSwg dGhpcywgU0xPVChvcGVuRmlsZSgpKSwgUUtleVNlcXVlbmNlOjpPcGVuKTsKKyAgICAgICAgZmls ZU1lbnUtPmFkZEFjdGlvbigiQ2xvc2UgV2luZG93IiwgdGhpcywgU0xPVChjbG9zZSgpKSwgUUtl eVNlcXVlbmNlOjpDbG9zZSk7CisgICAgICAgIGZpbGVNZW51LT5hZGRTZXBhcmF0b3IoKTsKKyAg ICAgICAgZmlsZU1lbnUtPmFkZEFjdGlvbigiVGFrZSBTY3JlZW4gU2hvdC4uLiIsIHRoaXMsIFNM T1Qoc2NyZWVuc2hvdCgpKSk7CisgICAgICAgIGZpbGVNZW51LT5hZGRBY3Rpb24odHIoIlByaW50 Li4uIiksIHRoaXMsIFNMT1QocHJpbnQoKSksIFFLZXlTZXF1ZW5jZTo6UHJpbnQpOworICAgICAg ICBmaWxlTWVudS0+YWRkU2VwYXJhdG9yKCk7CisgICAgICAgIGZpbGVNZW51LT5hZGRBY3Rpb24o IlF1aXQiLCBRQXBwbGljYXRpb246Omluc3RhbmNlKCksIFNMT1QoY2xvc2VBbGxXaW5kb3dzKCkp LCBRS2V5U2VxdWVuY2UoUXQ6OkNUUkwgfCBRdDo6S2V5X1EpKTsKIAogICAgICAgICBRTWVudSog ZWRpdE1lbnUgPSBtZW51QmFyKCktPmFkZE1lbnUoIiZFZGl0Iik7CiAgICAgICAgIGVkaXRNZW51 LT5hZGRBY3Rpb24odmlldy0+cGFnZUFjdGlvbihRV2ViUGFnZTo6VW5kbykpOwpAQCAtNTgwLDgg KzU4Myw2IEBAIHByaXZhdGU6CiAgICAgICAgIHdyaXRpbmdNZW51LT5hZGRBY3Rpb24odmlldy0+ cGFnZUFjdGlvbihRV2ViUGFnZTo6U2V0VGV4dERpcmVjdGlvbkxlZnRUb1JpZ2h0KSk7CiAgICAg ICAgIHdyaXRpbmdNZW51LT5hZGRBY3Rpb24odmlldy0+cGFnZUFjdGlvbihRV2ViUGFnZTo6U2V0 VGV4dERpcmVjdGlvblJpZ2h0VG9MZWZ0KSk7CiAKLSAgICAgICAgbmV3V2luZG93LT5zZXRTaG9y dGN1dChRS2V5U2VxdWVuY2UoUXQ6OkNUUkwgfCBRdDo6S2V5X04pKTsKLSAgICAgICAgc2NyZWVu c2hvdC0+c2V0U2hvcnRjdXQoUUtleVNlcXVlbmNlKFF0OjpDVFJMIHwgUXQ6OktleV9TKSk7CiAg ICAgICAgIHZpZXctPnBhZ2VBY3Rpb24oUVdlYlBhZ2U6OkJhY2spLT5zZXRTaG9ydGN1dChRS2V5 U2VxdWVuY2U6OkJhY2spOwogICAgICAgICB2aWV3LT5wYWdlQWN0aW9uKFFXZWJQYWdlOjpTdG9w KS0+c2V0U2hvcnRjdXQoUXQ6OktleV9Fc2NhcGUpOwogICAgICAgICB2aWV3LT5wYWdlQWN0aW9u KFFXZWJQYWdlOjpGb3J3YXJkKS0+c2V0U2hvcnRjdXQoUUtleVNlcXVlbmNlOjpGb3J3YXJkKTsK QEAgLTU5OCwxMSArNTk5LDEwIEBAIHByaXZhdGU6CiAgICAgICAgIHZpZXctPnBhZ2VBY3Rpb24o UVdlYlBhZ2U6OlRvZ2dsZUl0YWxpYyktPnNldFNob3J0Y3V0KFFLZXlTZXF1ZW5jZShRdDo6Q1RS TCB8IFF0OjpLZXlfSSkpOwogICAgICAgICB2aWV3LT5wYWdlQWN0aW9uKFFXZWJQYWdlOjpUb2dn bGVVbmRlcmxpbmUpLT5zZXRTaG9ydGN1dChRS2V5U2VxdWVuY2UoUXQ6OkNUUkwgfCBRdDo6S2V5 X1UpKTsKIAotICAgICAgICBRTWVudSogdG9vbHNNZW51ID0gbWVudUJhcigpLT5hZGRNZW51KCIm VG9vbHMiKTsKLSAgICAgICAgdG9vbHNNZW51LT5hZGRBY3Rpb24oIlNlbGVjdCBlbGVtZW50cy4u LiIsIHRoaXMsIFNMT1Qoc2VsZWN0RWxlbWVudHMoKSkpOwotICAgICAgICBRQWN0aW9uKiBzaG93 SW5zcGVjdG9yQWN0aW9uID0gdG9vbHNNZW51LT5hZGRBY3Rpb24oIlNob3cgaW5zcGVjdG9yIiwg aW5zcGVjdG9yLCBTTE9UKHNldFZpc2libGUoYm9vbCkpKTsKKyAgICAgICAgUU1lbnUqIHRvb2xz TWVudSA9IG1lbnVCYXIoKS0+YWRkTWVudSgiJkRldmVsb3AiKTsKKyAgICAgICAgdG9vbHNNZW51 LT5hZGRBY3Rpb24oIlNlbGVjdCBFbGVtZW50cy4uLiIsIHRoaXMsIFNMT1Qoc2VsZWN0RWxlbWVu dHMoKSkpOworICAgICAgICBRQWN0aW9uKiBzaG93SW5zcGVjdG9yQWN0aW9uID0gdG9vbHNNZW51 LT5hZGRBY3Rpb24oIlNob3cgV2ViIEluc3BlY3RvciIsIGluc3BlY3RvciwgU0xPVChzZXRWaXNp YmxlKGJvb2wpKSwgUUtleVNlcXVlbmNlKFF0OjpDVFJMIHwgUXQ6OkFMVCB8IFF0OjpLZXlfSSkp OwogICAgICAgICBzaG93SW5zcGVjdG9yQWN0aW9uLT5zZXRDaGVja2FibGUodHJ1ZSk7Ci0gICAg ICAgIHNob3dJbnNwZWN0b3JBY3Rpb24tPnNldFNob3J0Y3V0cyhRTGlzdDxRS2V5U2VxdWVuY2U+ KCkgPDwgUUtleVNlcXVlbmNlKHRyKCJGMTIiKSkpOwogICAgICAgICBzaG93SW5zcGVjdG9yQWN0 aW9uLT5jb25uZWN0KGluc3BlY3RvciwgU0lHTkFMKHZpc2libGVDaGFuZ2VkKGJvb2wpKSwgU0xP VChzZXRDaGVja2VkKGJvb2wpKSk7CiAKICNpZiBRVF9WRVJTSU9OID49IFFUX1ZFUlNJT05fQ0hF Q0soNCwgNiwgMCkK