33093 2010-01-01 06:55:30 -0800 [Qt] LayoutTests/fast/html/text-field-input-types.html 2010-02-14 23:47:09 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 robert cshu abarth commit-queue cshu ossy oldest_to_newest 176267 0 robert 2010-01-01 06:55:30 -0800 This test is skipped on Qt because it's output is: A B C DE F rather than A B C D E F. In the dumped text the spaces represent an <input> text field. The reason for the difference is that on Mac all the input fields fit on a single line, whereas on Qt 'D' starts on a new line. This happens because the width() of each of the <input> controls on Qt is 175, which must be larger than it is on Mac. The 175 is arrived at by taking the avgCharWidth of the render style's font (8) and multiplying it by InputElement::s_defaultSize (20), then adding the padding/margins. So the difference must stem from a different avgCharWidth between Mac and Qt. What's the right thing to do here? Is it a bug that the text dump does not begin on a new line with E and F? The test itself can be fixed for all platforms by specifying a small size attribute in the <input> markup, maybe that's the right way to go. 188686 1 48344 cshu 2010-02-08 10:58:31 -0800 Created attachment 48344 fix patch 189126 2 48344 abarth 2010-02-09 12:38:41 -0800 Comment on attachment 48344 fix patch Hum... I think this patch is correct. There's a separate question of whether you want the Qt metrics to match Mac, but that's not what this test is trying to test, so I think that's better dealt with separately. I agree that it's possible we should improve the text dumping to be immune to these issues. If this issue recurs, we can revisit that question. BTW, it would be helpful if you'd copy more of your analysis from Comment #0 into the ChangeLog. I found Comment #0 quite informative but you ChangeLog somewhat mysterious. 190259 3 cshu 2010-02-13 00:08:23 -0800 (In reply to comment #2) > (From update of attachment 48344 [details]) > Hum... I think this patch is correct. There's a separate question of whether > you want the Qt metrics to match Mac, but that's not what this test is trying > to test, so I think that's better dealt with separately. > I agree that it's possible we should improve the text dumping to be immune to > these issues. If this issue recurs, we can revisit that question. > BTW, it would be helpful if you'd copy more of your analysis from Comment #0 > into the ChangeLog. I found Comment #0 quite informative but you ChangeLog > somewhat mysterious. Thanks for the review, Adam. And thanks to Robert, too. It is actually Robert who did all the analysis. I made this patch simply because this bug blocked my further work on making some of the input types working on Qt. And I also think the intention of the test case is somewhere else. Yes, I will add Robert's comment into the ChangLog. 190261 4 48701 cshu 2010-02-13 00:43:32 -0800 Created attachment 48701 fix patch 2 190263 5 48701 abarth 2010-02-13 00:48:55 -0800 Comment on attachment 48701 fix patch 2 Thanks. 190379 6 48701 commit-queue 2010-02-14 21:14:57 -0800 Comment on attachment 48701 fix patch 2 Clearing flags on attachment: 48701 Committed r54761: <http://trac.webkit.org/changeset/54761> 190380 7 commit-queue 2010-02-14 21:15:07 -0800 All reviewed patches have been landed. Closing bug. 48344 2010-02-08 10:58:31 -0800 2010-02-13 00:43:32 -0800 fix patch bug33093_1.patch text/plain 1824 cshu SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU0NDk2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMDggIFNodSBDaGFuZyAgPENoYW5n LlNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1F0XSBTaHJpbmsgdGhlIHNpemUgb2YgZm9udCB0byBtYWtlIGFsbCBpbnB1dCBm aWVsZHMgc3RheSBpbiBvbmUgbGluZS4KKyAgICAgICAgT3RoZXJ3aXNlLCB0aGUgdGVzdCBjYXNl IGZhaWxzIG9uIFF0IExpbnV4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzMwOTMKKworICAgICAgICAqIGZhc3QvaHRtbC90ZXh0LWZpZWxkLWlucHV0 LXR5cGVzLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKwogMjAxMC0wMi0w OCAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBO b3QgcmV2aWV3ZWQuIEZpeCBsYXN0IHByb2JsZW1hdGljIFNWRyB0ZXN0Y2FzZSwgdXBkYXRlIGNv b3Jkcy10cmFucy0wMS1iLnN2ZyB3aW4gcmVzdWx0cywgbWFya2luZyB0aGUgZW5kIG9mIHRoZSBi YXNlbGluZSByZWdlbmVyYXRpb24gZm9yIGFsbCBwbGF0Zm9ybXMuCkluZGV4OiBMYXlvdXRUZXN0 cy9mYXN0L2h0bWwvdGV4dC1maWVsZC1pbnB1dC10eXBlcy5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvaHRtbC90ZXh0LWZpZWxkLWlucHV0LXR5cGVzLmh0bWwJKHJldmlzaW9u IDUzODc4KQorKysgTGF5b3V0VGVzdHMvZmFzdC9odG1sL3RleHQtZmllbGQtaW5wdXQtdHlwZXMu aHRtbAkod29ya2luZyBjb3B5KQpAQCAtMSw2ICsxLDkgQEAKIDxodG1sPgogPGhlYWQ+CiAgICAg PHRpdGxlPkhUTUw1IElucHV0IFR5cGVzIGZvciBUZXh0IENvbnRyb2xzPC90aXRsZT4KKyAgICA8 c3R5bGU+CisgICAgICAgIGJvZHkge2ZvbnQtc2l6ZTogNjAlO30KKyAgICA8L3N0eWxlPgogICAg IDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KICAgICAgICAgZnVuY3Rpb24gdGVzdCgp CiAgICAgICAgIHsKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2aXNpb24gNTM4Nzgp CisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC03 LDcgKzcsNiBAQCBlZGl0aW5nL3Bhc3RlYm9hcmQvNTc4MDY5Ny0yLmh0bWwKIGZhc3QvY3NzL2dl dENvbXB1dGVkU3R5bGUvY29tcHV0ZWQtc3R5bGUtd2l0aG91dC1yZW5kZXJlci5odG1sCiBmYXN0 L2Nzcy9nZXRDb21wdXRlZFN0eWxlL2NvbXB1dGVkLXN0eWxlLmh0bWwKIGZhc3QvaGlzdG9yeS9o aXN0b3J5X3JlbG9hZC5odG1sCi1mYXN0L2h0bWwvdGV4dC1maWVsZC1pbnB1dC10eXBlcy5odG1s CiBzdmcvYmF0aWsvZmlsdGVycy9mZVRpbGUuc3ZnCiAKICMgPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ICMK 48701 2010-02-13 00:43:32 -0800 2010-02-14 21:14:56 -0800 fix patch 2 bug33093_2.patch text/plain 2066 cshu SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU0NjU0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDItMTMgIFNodSBDaGFuZyAgPENoYW5n LlNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1F0XSBUaGUgb3JpZ2luYWwgdGVzdCBjYXNlIGZhaWxlZCBvbiBRdCBiZWNhdXNl IGl0cyByZWFsIG91dHB1dAorICAgICAgICAiQSBCIEMgREUgRiIgZGlkIG5vdCBtYXRjaCB0aGUg ZXhwZWN0ZWQgIkEgQiBDIEQgRSBGIi4gVGhlIGlucHV0CisgICAgICAgIGZpZWxkIGJldHdlZW4g RCBhbmQgRSBmYWlsZWQgdG8gZ2VuZXJhdGUgdGhlIHNwYWNlIGluIHRoZSBkdW1wZWQKKyAgICAg ICAgdGV4dCBhcyBpdCBub3JtYWxseSB3b3VsZCBpZiBpdCB3YXMgYnJva2VuIGludG8gYSBuZXcg bGluZS4KKyAgICAgICAgVGhpcyBEUlQgaXNzdWUgY2FuIGJlIGFkZHJlc3NlZCBpbiBhIHNlcGVy YXRlIGJ1ZyBpZiBuZWNlc3NhcnkKKyAgICAgICAgYnV0IHNocmlua2luZyB0aGUgc2l6ZSBvZiBm b250IHNvIGFzIHRvIGZpdCBhbGwgZmllbGRzIGludG8gb25lCisgICAgICAgIGxpbmUgaXMgYW4g aW1tZWRpYXRlIGZpeCB0byBwYXNzIHRoZSB0ZXN0IGNhc2UuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzA5MworCisgICAgICAgICogZmFzdC9odG1s L3RleHQtZmllbGQtaW5wdXQtdHlwZXMuaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lw cGVkOgorCiAyMDEwLTAyLTExICBBbmRyYXMgQmVjc2kgIDxhYmVjc2lAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvaHRtbC90ZXh0LWZpZWxkLWlucHV0LXR5cGVzLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9odG1sL3RleHQtZmllbGQtaW5wdXQtdHlwZXMu aHRtbAkocmV2aXNpb24gNTQ2NTQpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2h0bWwvdGV4dC1maWVs ZC1pbnB1dC10eXBlcy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDYgKzEsOSBAQAogPGh0bWw+ CiA8aGVhZD4KICAgICA8dGl0bGU+SFRNTDUgSW5wdXQgVHlwZXMgZm9yIFRleHQgQ29udHJvbHM8 L3RpdGxlPgorICAgIDxzdHlsZT4KKyAgICAgICAgYm9keSB7Zm9udC1zaXplOiA2MCU7fQorICAg IDwvc3R5bGU+CiAgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgogICAgICAgICBm dW5jdGlvbiB0ZXN0KCkKICAgICAgICAgewpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQv U2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCShy ZXZpc2lvbiA1NDY1NCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJKHdvcmtp bmcgY29weSkKQEAgLTcsNyArNyw2IEBAIGVkaXRpbmcvcGFzdGVib2FyZC81NzgwNjk3LTIuaHRt bAogZmFzdC9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS9jb21wdXRlZC1zdHlsZS13aXRob3V0LXJlbmRl cmVyLmh0bWwKIGZhc3QvY3NzL2dldENvbXB1dGVkU3R5bGUvY29tcHV0ZWQtc3R5bGUuaHRtbAog ZmFzdC9oaXN0b3J5L2hpc3RvcnlfcmVsb2FkLmh0bWwKLWZhc3QvaHRtbC90ZXh0LWZpZWxkLWlu cHV0LXR5cGVzLmh0bWwKIHN2Zy9iYXRpay9maWx0ZXJzL2ZlVGlsZS5zdmcKIAogIyA9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0gIwo=