33082 2009-12-31 08:36:42 -0800 Do not include Frame.h under WebCore/html/canvas 2010-01-05 00:55:33 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 32988 1 laszlo.gombos webkit-unassigned commit-queue hausmann webkit.review.bot oldest_to_newest 176193 0 laszlo.gombos 2009-12-31 08:36:42 -0800 I change in JavaScriptCore/runtime/Structure.h prompted a rebuild of WebCore/html/canvas/CanvasRenderingContext2D.cpp. I found this a bit strange and after looking into it, it turned out that this dependency can be easily broken by not including Frame.h in WebCore/html/canvas/CanvasRenderingContext2D.cpp (which is the only file under WebCore/html/canvas which includes Frame.h). Here is the ChangeSet that removed the Frame dependency but failed to remove the Frame.h include - http://trac.webkit.org/changeset/21749/trunk/WebCore/html/CanvasRenderingContext2D.cpp. 176196 1 45711 laszlo.gombos 2009-12-31 08:39:08 -0800 Created attachment 45711 proposed patch 176197 2 webkit.review.bot 2009-12-31 08:42:33 -0800 style-queue ran check-webkit-style on attachment 45711 without any errors. 176204 3 45711 kenneth 2009-12-31 09:25:47 -0800 Comment on attachment 45711 proposed patch LGTM 176213 4 45711 laszlo.gombos 2009-12-31 09:56:15 -0800 Comment on attachment 45711 proposed patch Thanks for the review ! 176214 5 45711 commit-queue 2009-12-31 10:07:13 -0800 Comment on attachment 45711 proposed patch Clearing flags on attachment: 45711 Committed r52682: <http://trac.webkit.org/changeset/52682> 176215 6 commit-queue 2009-12-31 10:07:18 -0800 All reviewed patches have been landed. Closing bug. 176216 7 laszlo.gombos 2009-12-31 10:14:58 -0800 just a note - unrelated bot failure on "SnowLeopard Intel Leaks" bot; as the the bot seemed to run out of disk space. Failed to open temp file in /var/folders/Qe/QejWyO1eEHebyJWD9dE3TU+++TM/-Tmp-//, error: No space left on device Command /Developer/usr/bin/g++-4.2 failed with exit code 1 Command /Developer/usr/bin/g++-4.2 failed with exit code 1 ** BUILD FAILED ** The following build commands failed: WebKit: Ld /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit normal x86_64 (1 failure) 177072 8 hausmann 2010-01-05 00:55:33 -0800 Cherry-picked into qtwebkit-4.6 as 75ab03a8db2cc638957ba2c3c7accfb7723eebb1 45711 2009-12-31 08:39:08 -0800 2009-12-31 10:07:12 -0800 proposed patch 33082.patch text/plain 1070 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjY4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMTItMzEgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIERvIG5vdCBpbmNsdWRlIEZyYW1lLmggdW5kZXIgV2ViQ29yZS9odG1sL2NhbnZhcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMwODIKKwor ICAgICAgICBObyBuZXcgdGVzdHMsIGFzIHRoZXJlIGlzIG5vIG5ldyBmdW5jdGlvbmFsaXR5Lgor CisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKwog MjAwOS0xMi0zMCAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhdmlkIExldmluLgpJbmRleDogV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52 YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9jYW52 YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAkocmV2aXNpb24gNTI2ODApCisrKyBXZWJD b3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTQyLDcgKzQyLDYgQEAKICNpbmNsdWRlICJEb2N1bWVudC5oIgogI2luY2x1ZGUgIkV4 Y2VwdGlvbkNvZGUuaCIKICNpbmNsdWRlICJGbG9hdENvbnZlcnNpb24uaCIKLSNpbmNsdWRlICJG cmFtZS5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUgIkhUTUxDYW52 YXNFbGVtZW50LmgiCiAjaW5jbHVkZSAiSFRNTEltYWdlRWxlbWVudC5oIgo=