33052 2009-12-30 05:44:31 -0800 [Qt] http/tests/plugins/post-url-file.html failure 2009-12-30 06:58:45 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC All RESOLVED FIXED P3 Normal --- 0 jwieczorek webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 175887 0 jwieczorek 2009-12-30 05:44:31 -0800 The test fails because of the FIXME in PluginView::handlePostReadFile(): // FIXME - read the file data into buffer 175893 1 45660 jwieczorek 2009-12-30 05:55:09 -0800 Created attachment 45660 proposed patch Depends on https://bugs.webkit.org/show_bug.cgi?id=33051. 175894 2 webkit.review.bot 2009-12-30 05:56:51 -0800 style-queue ran check-webkit-style on attachment 45660 without any errors. 175906 3 45660 hausmann 2009-12-30 06:50:29 -0800 Comment on attachment 45660 proposed patch r=me, nice! Another option would be to rewrite this code to use QFile or even share an implementation across ports if possible... 175911 4 45660 commit-queue 2009-12-30 06:58:39 -0800 Comment on attachment 45660 proposed patch Clearing flags on attachment: 45660 Committed r52660: <http://trac.webkit.org/changeset/52660> 175912 5 commit-queue 2009-12-30 06:58:45 -0800 All reviewed patches have been landed. Closing bug. 45660 2009-12-30 05:55:09 -0800 2009-12-30 06:58:39 -0800 proposed patch 0001-Qt-Fix-PluginView-handlePostReadFile.patch text/plain 3821 jwieczorek RnJvbSBiZjAzMGE3MGEwZGUwYjM2MmNkMzJkNzVmNDAyNTU1ZDliZGU0NTVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWt1YiBXaWVjem9yZWsgPGZhdzIxN0BnbWFpbC5jb20+CkRh dGU6IFdlZCwgMzAgRGVjIDIwMDkgMTM6NDQ6NTggKzAwMDAKU3ViamVjdDogW1BBVENIXSBbUXRd IEZpeCBQbHVnaW5WaWV3OjpoYW5kbGVQb3N0UmVhZEZpbGUoKS4KIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzA1MgoKVGhlIGZ1bmN0aW9uIHNob3VsZCBhY3R1YWxs eSByZXdyaXRlIHRoZSBnaXZlbiBmaWxlIHRvIHRoZSBidWZmZXIuCgpUaGlzIGNoYW5nZSBmaXhl cyBodHRwL3Rlc3RzL3BsdWdpbnMvcG9zdC11cmwtZmlsZS5odG1sLCB3aGljaCBjYW4gYmUgdW5z a2lwcGVkCm5vdyBhbG9uZyB3aXRoIG90aGVyIHBhc3NpbmcgaHR0cC9wbHVnaW5zIHRlc3RzLgot LS0KIExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysr KysrKwogTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCAgICAgfCAgICA0ICsrKy0KIFdl YkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysK IFdlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwIHwgICAxMCArKysrLS0tLS0tCiA0 IGZpbGVzIGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IDQxZmQ0MDQuLjJmNGM5ZGMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMi0zMCAgSmFr dWIgV2llY3pvcmVrICA8ZmF3MjE3QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEZpeCBQbHVnaW5WaWV3OjpoYW5kbGVQb3N0 UmVhZEZpbGUoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMzMDUyCisKKyAgICAgICAgVGhlIGZ1bmN0aW9uIHNob3VsZCBhY3R1YWxseSByZXdyaXRl IHRoZSBnaXZlbiBmaWxlIHRvIHRoZSBidWZmZXIuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgZml4 ZXMgaHR0cC90ZXN0cy9wbHVnaW5zL3Bvc3QtdXJsLWZpbGUuaHRtbCwgd2hpY2ggY2FuIGJlIHVu c2tpcHBlZAorICAgICAgICBub3cgYWxvbmcgd2l0aCBvdGhlciBwYXNzaW5nIGh0dHAvcGx1Z2lu cyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6CisKIDIwMDktMTItMzAg IERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIHRl c3QgcmVzdWx0IGZpeC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCmluZGV4IGFiYTk5ZTIuLmQ3ZmVl ZTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApAQCAtMjEsNyArMjEsNiBAQCBodHRwL3Rlc3Rz L2dsb2JhbGhpc3RvcnkKIGh0dHAvdGVzdHMvaGlzdG9yeQogaHR0cC90ZXN0cy9pbmNyZW1lbnRh bAogaHR0cC90ZXN0cy9tZWRpYQotaHR0cC90ZXN0cy9wbHVnaW5zCiBodHRwL3Rlc3RzL3dlYmFy Y2hpdmUKIGh0dHAvdGVzdHMvd21sCiAKQEAgLTM1LDYgKzM0LDkgQEAgaHR0cC90ZXN0cy9sb2Fk aW5nL3JlZGlyZWN0LW1ldGhvZHMuaHRtbAogaHR0cC90ZXN0cy9sb2FkaW5nL3NpbXBsZS1zdWJm cmFtZS5odG1sCiBodHRwL3Rlc3RzL2xvYWRpbmcvdGV4dC1jb250ZW50LXR5cGUtd2l0aC1iaW5h cnktZXh0ZW5zaW9uLmh0bWwKIAorIyBGYWlsaW5nIHBsdWdpbnMgdGVzdHMKK2h0dHAvdGVzdHMv cGx1Z2lucy9ucGFwaS1yZXNwb25zZS1oZWFkZXJzLmh0bWwKKwogIyBGYWlsaW5nIExvY2FsIHRl c3RzCiBodHRwL3Rlc3RzL2xvY2FsL2RyYWctb3Zlci1yZW1vdGUtY29udGVudC5odG1sCiBodHRw L3Rlc3RzL2xvY2FsL3NlbmQtZHJhZ2dlZC1maWxlLmh0bWwKZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTNiYjQ3Yy4uZmJjNTA1MiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAwOS0xMi0zMCAgSmFrdWIgV2llY3pvcmVrICA8ZmF3MjE3QGdtYWlsLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRd IEZpeCBQbHVnaW5WaWV3OjpoYW5kbGVQb3N0UmVhZEZpbGUoKS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMDUyCisKKyAgICAgICAgVGhlIGZ1bmN0 aW9uIHNob3VsZCBhY3R1YWxseSByZXdyaXRlIHRoZSBnaXZlbiBmaWxlIHRvIHRoZSBidWZmZXIu CisKKyAgICAgICAgVGhpcyBjaGFuZ2UgZml4ZXMgaHR0cC90ZXN0cy9wbHVnaW5zL3Bvc3QtdXJs LWZpbGUuaHRtbCwgd2hpY2ggY2FuIGJlIHVuc2tpcHBlZAorICAgICAgICBub3cgYWxvbmcgd2l0 aCBvdGhlciBwYXNzaW5nIGh0dHAvcGx1Z2lucyB0ZXN0cy4KKworICAgICAgICAqIHBsdWdpbnMv cXQvUGx1Z2luVmlld1F0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OmhhbmRs ZVBvc3RSZWFkRmlsZSk6CisKIDIwMDktMTItMzAgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5n b21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAgYi9XZWJDb3Jl L3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAppbmRleCBiNGVlNDhlLi5mYjhiYTA4IDEwMDY0 NAotLS0gYS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAorKysgYi9XZWJDb3Jl L3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcApAQCAtNTI5LDE4ICs1MjksMTYgQEAgTlBFcnJv ciBQbHVnaW5WaWV3OjpoYW5kbGVQb3N0UmVhZEZpbGUoVmVjdG9yPGNoYXI+JiBidWZmZXIsIHVp bnQzMiBsZW4sIGNvbnN0IGMKICAgICBpZiAoZmlsZW5hbWUuc3RhcnRzV2l0aCgiZmlsZTovLy8i KSkKICAgICAgICAgZmlsZW5hbWUgPSBmaWxlbmFtZS5zdWJzdHJpbmcoOCk7CiAKLSAgICBpZiAo IWZpbGVFeGlzdHMoZmlsZW5hbWUpKQorICAgIGxvbmcgbG9uZyBzaXplOworICAgIGlmICghZ2V0 RmlsZVNpemUoZmlsZW5hbWUsIHNpemUpKQogICAgICAgICByZXR1cm4gTlBFUlJfRklMRV9OT1Rf Rk9VTkQ7CiAKLSAgICAvLyBGSVhNRSAtIHJlYWQgdGhlIGZpbGUgZGF0YSBpbnRvIGJ1ZmZlcgog ICAgIEZJTEUqIGZpbGVIYW5kbGUgPSBmb3BlbigoZmlsZW5hbWUudXRmOCgpKS5kYXRhKCksICJy Iik7Ci0KICAgICBpZiAoIWZpbGVIYW5kbGUpCiAgICAgICAgIHJldHVybiBOUEVSUl9GSUxFX05P VF9GT1VORDsKIAotICAgIC8vYnVmZmVyLnJlc2l6ZSgpOwotCi0gICAgaW50IGJ5dGVzUmVhZCA9 IGZyZWFkKGJ1ZmZlci5kYXRhKCksIDEsIDAsIGZpbGVIYW5kbGUpOworICAgIGJ1ZmZlci5yZXNp emUoc2l6ZSk7CisgICAgaW50IGJ5dGVzUmVhZCA9IGZyZWFkKGJ1ZmZlci5kYXRhKCksIDEsIHNp emUsIGZpbGVIYW5kbGUpOwogCiAgICAgZmNsb3NlKGZpbGVIYW5kbGUpOwogCi0tIAoxLjYuNS41 Cgo=