33050 2009-12-30 04:44:26 -0800 [GTK] ASSERTs on fast/inline/inline-body-with-scrollbar-crash.html 2011-02-08 12:33:03 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned hyatt mrobinson zecke oldest_to_newest 175876 0 gustavo 2009-12-30 04:44:26 -0800 I have investigate this to find out that the problem lies on readjusting the size of the view, here (FrameView.cpp::layout around line 679): if (!subtree && !toRenderView(root)->printing()) adjustViewSize(); This ends up in a call to updateScrollbars, in GTK+, which ends up triggering a resize of the view (because the parent widget's scroll bars take up space), which requests a relayout. So the ASSERT ends up being hit: ASSERT(!root->needsLayout()); I have investigated a bunch of solutions, such as having our own implementation of ScrollView::setContentsSize, but I always end up in having to either reimplement almost all of the updateScrollbars logic, or triggering a relayout anyway. I feel like the call to updateScrollbars is correct, and that triggering the resize of the view is an expected outcome - so the assert would not be correct for GTK+ - but I am not sure enough, so I decided to open this bug report and request help/advice from layout/scrolling wizards. 287918 1 mrobinson 2010-09-30 16:30:06 -0700 This seems to be passing locally (perhaps because of the scrollbar changes). I'll unskip it and close, reopening if there are any problems. 347600 2 mrobinson 2011-02-08 12:33:03 -0800 Unskipped and this doesn't appear to be an issue any longer. Closing.