<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>33040</bug_id>
          
          <creation_ts>2009-12-29 21:14:21 -0800</creation_ts>
          <short_desc>[Qt] Disable HTML DataGrid support by default</short_desc>
          <delta_ts>2009-12-30 00:52:54 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Laszlo Gombos">laszlo.gombos</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>hausmann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>175785</commentid>
    <comment_count>0</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-12-29 21:14:21 -0800</bug_when>
    <thetext>Apple (r52507) and than the Gtk port (r52605) disabled datagrid implementation as it is not ready for general web use yet. In general trunk is meant for development and features under development are expected to be turned on, so I&apos;m not sure if Qt port should follow other ports as well on the trunk to turn this feature off by default.

However I would propose to turn off datagrid support on the 4.6 productization branch. Patch is attached, but not put up for review as at this point this is not for trunk.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>175786</commentid>
    <comment_count>1</comment_count>
      <attachid>45637</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-12-29 21:17:42 -0800</bug_when>
    <thetext>Created attachment 45637
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>175836</commentid>
    <comment_count>2</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2009-12-30 00:47:30 -0800</bug_when>
    <thetext>Yeah, we should turn it off, the layout tests are also disabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>175838</commentid>
    <comment_count>3</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2009-12-30 00:48:25 -0800</bug_when>
    <thetext>Committed r52648: &lt;http://trac.webkit.org/changeset/52648&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>175839</commentid>
    <comment_count>4</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2009-12-30 00:52:54 -0800</bug_when>
    <thetext>Cherry-picked into qtwebkit-4.6 as commit da94856dacd1a6a5a788def840255a6fdc1f85b7</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>45637</attachid>
            <date>2009-12-29 21:17:42 -0800</date>
            <delta_ts>2009-12-29 21:17:42 -0800</delta_ts>
            <desc>patch</desc>
            <filename>datagrid.patch</filename>
            <type>text/plain</type>
            <size>1144</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA1MjY0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMDktMTItMjkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i
b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIFR1cm4gb2ZmIERhdGFHcmlkIHN1cHBvcnQgYnkgZGVmYXVsdC4KKworICAgICAgICBO
byBuZXcgdGVzdHMsIGFzIHRoZXJlIGlzIG5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAg
ICogV2ViQ29yZS5wcm86CisKIDIwMDktMTItMjkgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBn
b29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJD
b3JlL1dlYkNvcmUucHJvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvV2ViQ29yZS5wcm8JKHJldmlz
aW9uIDUyNjQxKQorKysgV2ViQ29yZS9XZWJDb3JlLnBybwkod29ya2luZyBjb3B5KQpAQCAtMTQ2
LDcgKzE0Niw3IEBAIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9TSU5HTEVfVEhSRUFERUQKICFj
b250YWlucyhERUZJTkVTLCBFTkFCTEVfU0hBUkVEX1dPUktFUlM9Lik6IERFRklORVMgKz0gRU5B
QkxFX1NIQVJFRF9XT1JLRVJTPTEKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfV09SS0VSUz0u
KTogREVGSU5FUyArPSBFTkFCTEVfV09SS0VSUz0xCiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxF
X1hIVE1MTVA9Lik6IERFRklORVMgKz0gRU5BQkxFX1hIVE1MTVA9MAotIWNvbnRhaW5zKERFRklO
RVMsIEVOQUJMRV9EQVRBR1JJRD0uKTogREVGSU5FUyArPSBFTkFCTEVfREFUQUdSSUQ9MQorIWNv
bnRhaW5zKERFRklORVMsIEVOQUJMRV9EQVRBR1JJRD0uKTogREVGSU5FUyArPSBFTkFCTEVfREFU
QUdSSUQ9MAogCiAjIFNWRyBzdXBwb3J0CiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1NWRz0w
KSB7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>