33037 2009-12-29 18:35:02 -0800 [check-webkit-style] Include order should understand uppercase 2009-12-30 17:34:34 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED INVALID P2 Normal --- 1 abarth webkit-unassigned webkit.review.bot oldest_to_newest 175745 0 abarth 2009-12-29 18:35:02 -0800 [check-webkit-style] Include order should understand uppercase 175746 1 45627 abarth 2009-12-29 18:36:06 -0800 Created attachment 45627 Patch 175748 2 webkit.review.bot 2009-12-29 18:39:15 -0800 style-queue ran check-webkit-style on attachment 45627 without any errors. 175832 3 45627 eric 2009-12-29 23:52:55 -0800 Comment on attachment 45627 Patch I'm slightly confused by this. I think the sort order sorta defined to be whatever XCode's "sort lines" applescript thing does. This makes our sort order looser, which is probably good, but I'm not sure which editors will care. 176040 4 abarth 2009-12-30 14:02:04 -0800 Oh, we could do that. The current thing is very braindead. It thinks that capital letter always go ahead (or behind) their lowercase compatriots. Ab aa So, it wants things sorted as above, which is nonsensical to me. 176084 5 mrowe 2009-12-30 16:42:07 -0800 Our style guide says: > Other #include statements should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command). This patch appears to be trying to enforce case-insensitive ordering. 176095 6 45627 abarth 2009-12-30 17:32:41 -0800 Comment on attachment 45627 Patch Ah, so this patch is wrong then. I think the current behavior is wrong too, but I'll check against the "sort" command. 176096 7 abarth 2009-12-30 17:34:34 -0800 According to "sort", the script is currently correct. Wacky, but correct. $ echo "aa > Ab" | sort Ab aa 45627 2009-12-29 18:36:06 -0800 2009-12-30 17:32:40 -0800 Patch bug-33037-20091229183604.patch text/plain 2778 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmMzc4ZGM1Li42NjlhNmEwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hlY2std2Via2l0LXN0eWxlXSBJbmNsdWRl IG9yZGVyIHNob3VsZCB1bmRlcnN0YW5kIHVwcGVyY2FzZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMwMzcKKworICAgICAgICBQcmV2aW91c2x5IGNo ZWNrLXdlYmtpdC1zdHlsZSBnb3QgY29uZnVzZWQgYWJvdXQgdGhlIGluY2x1ZGUgb3JkZXIKKyAg ICAgICAgZm9yIGhlYWRlcnMgdGhhdCB1c2VkIGNhcGl0YWwgbGV0dGVycy4gIFRoaXMgcGF0Y2gg dW5jb25mdXNlcyBpdC4KKworICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHk6 CisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91bml0dGVzdC5weToKKwogMjAw OS0xMi0yOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1 bGVzL2NwcF9zdHlsZS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUu cHkKaW5kZXggYTBlNDAyMi4uZWI0YjUxYSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy9tb2R1bGVzL2NwcF9zdHlsZS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMv Y3BwX3N0eWxlLnB5CkBAIC0yMzE5LDcgKzIzMTksNyBAQCBkZWYgY2hlY2tfaW5jbHVkZV9saW5l KGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGluY2x1ZGVfc3RhdGUsIGVycm9y KQogICAgICAgICAgICAgcHJldmlvdXNfbWF0Y2ggPSBfUkVfUEFUVEVSTl9JTkNMVURFLnNlYXJj aChwcmV2aW91c19saW5lKQogICAgICAgICAgaWYgcHJldmlvdXNfbWF0Y2g6CiAgICAgICAgICAg ICBwcmV2aW91c19oZWFkZXJfdHlwZSA9IGluY2x1ZGVfc3RhdGUuaGVhZGVyX3R5cGVzW3ByZXZp b3VzX2xpbmVfbnVtYmVyXQotICAgICAgICAgICAgaWYgcHJldmlvdXNfaGVhZGVyX3R5cGUgPT0g X09USEVSX0hFQURFUiBhbmQgcHJldmlvdXNfbGluZS5zdHJpcCgpID4gbGluZS5zdHJpcCgpOgor ICAgICAgICAgICAgaWYgcHJldmlvdXNfaGVhZGVyX3R5cGUgPT0gX09USEVSX0hFQURFUiBhbmQg cHJldmlvdXNfbGluZS5zdHJpcCgpLmxvd2VyKCkgPiBsaW5lLnN0cmlwKCkubG93ZXIoKToKICAg ICAgICAgICAgICAgICBlcnJvcihmaWxlbmFtZSwgbGluZV9udW1iZXIsICdidWlsZC9pbmNsdWRl X29yZGVyJywgNCwKICAgICAgICAgICAgICAgICAgICAgICAnQWxwaGFiZXRpY2FsIHNvcnRpbmcg cHJvYmxlbS4nKQogCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3Bw X3N0eWxlX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHls ZV91bml0dGVzdC5weQppbmRleCA4YjFiMTdkLi4yYjY2ZDk4IDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRv b2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHkKQEAgLTIwOTUsNiArMjA5 NSwxOCBAQCBjbGFzcyBPcmRlck9mSW5jbHVkZXNUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnJykKIAogICAgICAgICBzZWxm LmFzc2VydF9sYW5ndWFnZV9ydWxlc19jaGVjaygnZm9vLmgnLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgImEuaCJcbicKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlICJCYS5oIlxuJworICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgImJjLmgiXG4nLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnJykKKworICAgICAgICBzZWxm LmFzc2VydF9sYW5ndWFnZV9ydWxlc19jaGVjaygnZm9vLmgnLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgImEuaCJcbicKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlICJiYS5oIlxuJworICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgIkJjLmgiXG4nLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnJykKKworICAgICAgICBzZWxm LmFzc2VydF9sYW5ndWFnZV9ydWxlc19jaGVjaygnZm9vLmgnLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgPGFzc2VydC5oPlxuJwogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgImJhci5oIlxuJywKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ0FscGhhYmV0aWNhbCBzb3J0 aW5nIHByb2JsZW0uICBbYnVpbGQvaW5jbHVkZV9vcmRlcl0gWzRdJykK