33030 2009-12-29 14:54:13 -0800 Add a test for window.top and isolated worlds 2009-12-29 16:48:32 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue dglazkov webkit.review.bot oldest_to_newest 175717 0 abarth 2009-12-29 14:54:13 -0800 Add a test for window.top and isolated worlds 175718 1 45623 abarth 2009-12-29 14:56:46 -0800 Created attachment 45623 Patch 175720 2 webkit.review.bot 2009-12-29 14:59:59 -0800 style-queue ran check-webkit-style on attachment 45623 without any errors. 175727 3 45623 sam 2009-12-29 15:30:56 -0800 Comment on attachment 45623 Patch Looks fine, though I wouldn't mind the expected file having a little bit of explanatory text for future me to read. 175728 4 dglazkov 2009-12-29 15:34:21 -0800 And future me too! 175733 5 45623 abarth 2009-12-29 16:36:36 -0800 Comment on attachment 45623 Patch Ok. There are a bunch of tests in this style in this directory. We should update them all with explanations. 175735 6 45623 commit-queue 2009-12-29 16:48:24 -0800 Comment on attachment 45623 Patch Clearing flags on attachment: 45623 Committed r52638: <http://trac.webkit.org/changeset/52638> 175736 7 commit-queue 2009-12-29 16:48:32 -0800 All reviewed patches have been landed. Closing bug. 45623 2009-12-29 14:56:46 -0800 2009-12-29 16:48:24 -0800 Patch bug-33030-20091229145644.patch text/plain 1837 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUyNjM1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTItMjkgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGQgYSB0ZXN0IGZvciB3aW5kb3cudG9wIGFuZCBpc29sYXRlZCB3b3JsZHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMDMwCisKKyAg ICAgICAgSSB3cm90ZSB0aGlzIHRlc3QgdG8gaW52ZXN0aWdhdGUgYW4gaXNzdWUgdGhhdCB0dXJu cyBvdXQgaXMgd29ya2luZworICAgICAgICBwcm9wZXJseS4gIE5vIHNlbnNlIHdhc3RpbmcgYSBw ZXJmZWN0bHkgZ29vZCB0ZXN0LCBzbyB3ZSBzaG91bGQgYWRkIGl0LgorCisgICAgICAgICogaHR0 cC90ZXN0cy9zZWN1cml0eS9pc29sYXRlZFdvcmxkL3RvcC1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS9pc29sYXRlZFdvcmxkL3Rv cC1wcm9wZXJ0aWVzLmh0bWw6IEFkZGVkLgorCiAyMDA5LTEyLTI5ICBDc2FiYSBPc3p0cm9nb27D oWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgU2ltb24g SGF1c21hbm4uCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2lzb2xhdGVk V29ybGQvdG9wLXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvaXNvbGF0ZWRXb3JsZC90b3AtcHJvcGVydGllcy1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5 L2lzb2xhdGVkV29ybGQvdG9wLXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxIEBACit1bmRlZmluZWQKSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2Vj dXJpdHkvaXNvbGF0ZWRXb3JsZC90b3AtcHJvcGVydGllcy5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvaXNvbGF0ZWRXb3JsZC90b3AtcHJvcGVydGll cy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9p c29sYXRlZFdvcmxkL3RvcC1wcm9wZXJ0aWVzLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs MTUgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxkaXYgaWQ9ImNvbnNvbGUi PjwvZGl2PgorPHNjcmlwdD4KK3RvcC5mb28gPSAiRkFJTDogVmlzaWJsZSBpbiBpc29sYXRlZCB3 b3JsZC4iOworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICBsYXlvdXRUZXN0 Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgIGxheW91dFRlc3RDb250cm9sbGVyLmV2YWx1YXRl U2NyaXB0SW5Jc29sYXRlZFdvcmxkKAorICAgIDAsCisgICAgImRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdjb25zb2xlJykuaW5uZXJIVE1MID0gdG9wLmZvbyIpOworfQorPC9zY3JpcHQ+Cis8L2Jv ZHk+Cis8L2h0bWw+Cg==