33019 2009-12-29 07:06:23 -0800 [Qt] Fix warnings in MediaPlayerPrivatePhonon.cpp 2009-12-29 07:33:10 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue oldest_to_newest 175545 0 laszlo.gombos 2009-12-29 07:06:23 -0800 In debug builds: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: In member function ‘void WebCore::MediaPlayerPrivate::totalTimeChanged(qint64)’: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:505: warning: format ‘%d’ expects type ‘int’, but argument 3 has type ‘qint64’ In release builds: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:511: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:49: warning: ‘QByteArray debugMediaObject(WebCore::MediaPlayerPrivate*, const Phonon::MediaObject&)’ defined but not used 175548 1 45601 laszlo.gombos 2009-12-29 07:23:03 -0800 Created attachment 45601 proposed patch 175549 2 45601 commit-queue 2009-12-29 07:33:05 -0800 Comment on attachment 45601 proposed patch Clearing flags on attachment: 45601 Committed r52621: <http://trac.webkit.org/changeset/52621> 175550 3 commit-queue 2009-12-29 07:33:10 -0800 All reviewed patches have been landed. Closing bug. 45601 2009-12-29 07:23:03 -0800 2009-12-29 07:33:05 -0800 proposed patch 33019.patch text/plain 1716 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjYwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTItMjkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gRml4IHdhcm5pbmdzIGluIE1lZGlhUGxheWVyUHJpdmF0ZVBob25vbi5jcHAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMDE5CisK KyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIHRoZXJlIGlzIG5vIG5ldyBmdW5jdGlvbmFsaXR5Lgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5ZXJQcml2YXRlUGhvbm9u LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6dG90YWxUaW1lQ2hh bmdlZCk6CisKIDIwMDktMTItMjggIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9y b25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgWGFuIExv cGV6LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXllclByaXZh dGVQaG9ub24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQv TWVkaWFQbGF5ZXJQcml2YXRlUGhvbm9uLmNwcAkocmV2aXNpb24gNTI2MDYpCisrKyBXZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxheWVyUHJpdmF0ZVBob25vbi5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTQ2LDYgKzQ2LDcgQEAgdXNpbmcgbmFtZXNwYWNlIFBob25vbjsKIAogI2Rl ZmluZSBMT0dfTUVESUFPQkpFQ1QoKSAoTE9HKE1lZGlhLCAiJXMiLCBkZWJ1Z01lZGlhT2JqZWN0 KHRoaXMsICptX21lZGlhT2JqZWN0KS5jb25zdERhdGEoKSkpCiAKKyNpZiAhTE9HX0RJU0FCTEVE CiBzdGF0aWMgUUJ5dGVBcnJheSBkZWJ1Z01lZGlhT2JqZWN0KFdlYkNvcmU6Ok1lZGlhUGxheWVy UHJpdmF0ZSogbWVkaWFQbGF5ZXIsIGNvbnN0IE1lZGlhT2JqZWN0JiBtZWRpYU9iamVjdCkKIHsK ICAgICBRQnl0ZUFycmF5IGJ5dGVBcnJheTsKQEAgLTczLDYgKzc0LDcgQEAgc3RhdGljIFFCeXRl QXJyYXkgZGVidWdNZWRpYU9iamVjdChXZWJDbwogCiAgICAgcmV0dXJuIGJ5dGVBcnJheTsKIH0K KyNlbmRpZgogCiB1c2luZyBuYW1lc3BhY2UgV1RGOwogCkBAIC01MDIsNyArNTA0LDcgQEAgdm9p ZCBNZWRpYVBsYXllclByaXZhdGU6OmFib3V0VG9GaW5pc2goKQogCiB2b2lkIE1lZGlhUGxheWVy UHJpdmF0ZTo6dG90YWxUaW1lQ2hhbmdlZChxaW50NjQgdG90YWxUaW1lKQogewotICAgIExPRyhN ZWRpYSwgIk1lZGlhUGxheWVyUHJpdmF0ZVBob25vbjo6dG90YWxUaW1lQ2hhbmdlZCglZCkiLCB0 b3RhbFRpbWUpOworICAgIExPRyhNZWRpYSwgIk1lZGlhUGxheWVyUHJpdmF0ZVBob25vbjo6dG90 YWxUaW1lQ2hhbmdlZCglbGxkKSIsIHRvdGFsVGltZSk7CiAgICAgTE9HX01FRElBT0JKRUNUKCk7 CiB9CiAK