33017 2009-12-29 06:06:11 -0800 [Qt] Fix crash on LayoutTests/fast/loader/empty-embed-src-attribute.html 2009-12-29 09:44:47 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 robert webkit-unassigned abarth beidson commit-queue eric webkit.review.bot oldest_to_newest 175528 0 robert 2009-12-29 06:06:11 -0800 Related to https://bugs.webkit.org/show_bug.cgi?id=23806 If an embedded document is loaded within a page and it has an empty URL, use a blank URL for the load request. 175530 1 45599 robert 2009-12-29 06:13:25 -0800 Created attachment 45599 Patch 175532 2 webkit.review.bot 2009-12-29 06:17:05 -0800 style-queue ran check-webkit-style on attachment 45599 without any errors. 175596 3 45599 eric 2009-12-29 09:32:05 -0800 Comment on attachment 45599 Patch Seems sane. 175597 4 eric 2009-12-29 09:32:24 -0800 CCing loader-related folks so they can see this go by. 175604 5 45599 commit-queue 2009-12-29 09:44:42 -0800 Comment on attachment 45599 Patch Clearing flags on attachment: 45599 Committed r52625: <http://trac.webkit.org/changeset/52625> 175605 6 commit-queue 2009-12-29 09:44:47 -0800 All reviewed patches have been landed. Closing bug. 45599 2009-12-29 06:13:25 -0800 2009-12-29 09:44:42 -0800 Patch 0001-Qt-Fix-crash-on-LayoutTests-fast-loader-empty-embed-.patch text/plain 3534 robert RnJvbSA3N2ExNWY0YjYwNjZjM2I2ZjUzODk4YTRhOGMxNWNmNTFiYzU2NjFlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2JlcnQgSG9nYW4gPHJvYmVydEByb2JlcnRob2dhbi5uZXQ+ CkRhdGU6IFR1ZSwgMjkgRGVjIDIwMDkgMTQ6MDY6NDkgKzAwMDAKU3ViamVjdDogW1BBVENIXSBb UXRdIEZpeCBjcmFzaCBvbiBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9lbXB0eS1lbWJlZC1zcmMt YXR0cmlidXRlLmh0bWwKClJlbGF0ZWQgdG8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIzODA2CgpJZiBhbiBlbWJlZGRlZCBkb2N1bWVudCBpcyBsb2FkZWQgd2l0aGlu IGEgcGFnZSBhbmQgaXQgaGFzIGFuIGVtcHR5ClVSTCwgdXNlIGEgYmxhbmsgVVJMIGZvciB0aGUg bG9hZCByZXF1ZXN0LgoKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMz MDE3Ci0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAg IHwgICAxNSArKysrKysrKysrKysrKysKIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQg ICAgICAgICAgICAgICAgICB8ICAgIDEgLQogV2ViS2l0L3F0L0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysrCiBXZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAgfCAgICA3ICsrKysrKy0KIDQgZmls ZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDY2 NDFlMC4uNzIyZmYyYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDA5LTEyLTI5ICBSb2JlcnQg SG9nYW4gIDxyb2JlcnRAcm9iZXJ0aG9nYW4ubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRml4IGNyYXNoIG9uIExheW91dFRlc3RzL2Zh c3QvbG9hZGVyL2VtcHR5LWVtYmVkLXNyYy1hdHRyaWJ1dGUuaHRtbAorICAgICAgICAKKyAgICAg ICAgUmVsYXRlZCB0byBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4 MDYKKyAgICAgICAgCisgICAgICAgIElmIGFuIGVtYmVkZGVkIGRvY3VtZW50IGlzIGxvYWRlZCB3 aXRoaW4gYSBwYWdlIGFuZCBpdCBoYXMgYW4gZW1wdHkKKyAgICAgICAgVVJMLCB1c2UgYSBibGFu ayBVUkwgZm9yIHRoZSBsb2FkIHJlcXVlc3QuCisgICAgICAgIAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMwMTcKKworICAgICAgICAqIHBsYXRmb3Jt L3F0L1NraXBwZWQ6CisKIDIwMDktMTItMjggIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L3F0L1NraXBwZWQKaW5kZXggMmJiZGNlNS4uYjE3ZmQ2NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lw cGVkCkBAIC0xMzQsNyArMTM0LDYgQEAgc3ZnL2N1c3RvbS9nbHlwaC1zZXR0aW5nLWQtYXR0cmli dXRlLnN2ZwogZmFzdC9jYW52YXMvY2FudmFzLWdldEltYWdlRGF0YS5odG1sCiAKICMgLS0tLS0t LSBjcmFzaGVzCi1mYXN0L2xvYWRlci9lbXB0eS1lbWJlZC1zcmMtYXR0cmlidXRlLmh0bWwKIGZh c3QvdGV4dC9maW5kLWhpZGRlbi10ZXh0Lmh0bWwKIAogIyA9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ICMKZGlm ZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4 IDQwMjkwMjkuLjllMjM4NjIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIv V2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDA5LTEyLTI5ICBSb2JlcnQg SG9nYW4gIDxyb2JlcnRAcm9iZXJ0aG9nYW4ubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRml4IGNyYXNoIG9uIExheW91dFRlc3RzL2Zh c3QvbG9hZGVyL2VtcHR5LWVtYmVkLXNyYy1hdHRyaWJ1dGUuaHRtbAorICAgICAgICAKKyAgICAg ICAgUmVsYXRlZCB0byBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM4 MDYKKyAgICAgICAgCisgICAgICAgIElmIGFuIGVtYmVkZGVkIGRvY3VtZW50IGlzIGxvYWRlZCB3 aXRoaW4gYSBwYWdlIGFuZCBpdCBoYXMgYW4gZW1wdHkKKyAgICAgICAgVVJMLCB1c2UgYSBibGFu ayBVUkwgZm9yIHRoZSBsb2FkIHJlcXVlc3QuCisgICAgICAgIAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMwMTcKKworICAgICAgICAqIFdlYkNvcmVT dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVM b2FkZXJDbGllbnRRdDo6Y3JlYXRlRnJhbWUpOgorCiAyMDA5LTEyLTI0ICBHaXJpc2ggUmFtYWty aXNobmFuICA8Z2lyaXNoQGZvcndhcmRiaWFzLmluPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEd1 c3Rhdm8gTm9yb25oYS4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFt ZUxvYWRlckNsaWVudFF0LmNwcCBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRl ckNsaWVudFF0LmNwcAppbmRleCAzYzMwYWI1Li41ODc4YmI2IDEwMDY0NAotLS0gYS9XZWJLaXQv cXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAKKysrIGIvV2ViS2l0L3F0 L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwCkBAIC0xMDM2LDcgKzEwMzYs MTIgQEAgUGFzc1JlZlB0cjxGcmFtZT4gRnJhbWVMb2FkZXJDbGllbnRRdDo6Y3JlYXRlRnJhbWUo Y29uc3QgS1VSTCYgdXJsLCBjb25zdCBTdHJpbmcKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBR V2ViRnJhbWVEYXRhIGZyYW1lRGF0YShtX2ZyYW1lLT5wYWdlKCksIG1fZnJhbWUsIG93bmVyRWxl bWVudCwgbmFtZSk7Ci0gICAgZnJhbWVEYXRhLnVybCA9IHVybDsKKworICAgIGlmICh1cmwuaXNF bXB0eSgpKQorICAgICAgICBmcmFtZURhdGEudXJsID0gYmxhbmtVUkwoKTsKKyAgICBlbHNlCisg ICAgICAgIGZyYW1lRGF0YS51cmwgPSB1cmw7CisKICAgICBmcmFtZURhdGEucmVmZXJyZXIgPSBy ZWZlcnJlcjsKICAgICBmcmFtZURhdGEuYWxsb3dzU2Nyb2xsaW5nID0gYWxsb3dzU2Nyb2xsaW5n OwogICAgIGZyYW1lRGF0YS5tYXJnaW5XaWR0aCA9IG1hcmdpbldpZHRoOwotLSAKMS42LjMuMwoK