33003 2009-12-28 18:43:23 -0800 Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings 2009-12-29 05:22:11 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 175366 0 laszlo.gombos 2009-12-28 18:43:23 -0800 Warnings found in debug builds only. This patch is similar to the previously committed r42002 and r50675. List of warnings: WebCore/editing/CompositeEditCommand.cpp: In member function ‘bool WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph()’: WebCore/editing/CompositeEditCommand.cpp:1093: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/page/animation/ImplicitAnimation.cpp: In member function ‘bool WebCore::ImplicitAnimation::sendTransitionEvent(const WebCore::AtomicString&, double)’: WebCore/page/animation/ImplicitAnimation.cpp:164: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/page/animation/KeyframeAnimation.cpp: In member function ‘bool WebCore::KeyframeAnimation::sendAnimationEvent(const WebCore::AtomicString&, double)’: WebCore/page/animation/KeyframeAnimation.cpp:284: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/rendering/RenderSVGContainer.h: In function ‘WebCore::RenderSVGContainer* WebCore::toRenderSVGContainer(WebCore::RenderObject*)’: WebCore/rendering/RenderSVGContainer.h:81: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/rendering/RenderSVGContainer.h: In function ‘const WebCore::RenderSVGContainer* WebCore::toRenderSVGContainer(const WebCore::RenderObject*)’: WebCore/rendering/RenderSVGContainer.h:88: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/rendering/style/RenderStyle.cpp: In member function ‘void WebCore::RenderStyle::setTextShadow(WebCore::ShadowData*, bool)’: WebCore/rendering/style/RenderStyle.cpp:705: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/svg/graphics/SVGPaintServerGradient.cpp: In member function ‘virtual bool WebCore::SVGPaintServerGradient::setup(WebCore::GraphicsContext*&, const WebCore::RenderObject*, WebCore::SVGPaintTargetType, bool) const’: WebCore/svg/graphics/SVGPaintServerGradient.cpp:196: warning: suggest parentheses around ‘&&’ within ‘||’ WebCore/svg/graphics/SVGPaintServerPattern.cpp: In member function ‘virtual bool WebCore::SVGPaintServerPattern::setup(WebCore::GraphicsContext*&, const WebCore::RenderObject*, WebCore::SVGPaintTargetType, bool) const’: WebCore/svg/graphics/SVGPaintServerPattern.cpp:106: warning: suggest parentheses around ‘&&’ within ‘||’ 175369 1 45583 laszlo.gombos 2009-12-28 18:47:46 -0800 Created attachment 45583 proposed patch 175372 2 webkit.review.bot 2009-12-28 18:53:21 -0800 style-queue ran check-webkit-style on attachment 45583 without any errors. 175458 3 45583 eric 2009-12-28 23:58:42 -0800 Comment on attachment 45583 proposed patch This looks right to me. 175510 4 45583 commit-queue 2009-12-29 05:22:06 -0800 Comment on attachment 45583 proposed patch Clearing flags on attachment: 45583 Committed r52618: <http://trac.webkit.org/changeset/52618> 175511 5 commit-queue 2009-12-29 05:22:11 -0800 All reviewed patches have been landed. Closing bug. 45583 2009-12-28 18:47:46 -0800 2009-12-29 05:22:06 -0800 proposed patch 33003.patch text/plain 6588 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjYwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjcgQEAKKzIwMDktMTItMjggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFVzZSBleHBsaWNpdCBwYXJlbnRoZXNlcyB0byBzaWxlbmNlIGdjYyA0LjQgLVdwYXJl bnRoZXNlcyB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzMwMDMKKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gbmV3 IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBlZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5k LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBvc2l0ZUVkaXRDb21tYW5kOjpicmVha091dE9m RW1wdHlNYWlsQmxvY2txdW90ZWRQYXJhZ3JhcGgpOgorICAgICAgICAqIHBhZ2UvYW5pbWF0aW9u L0ltcGxpY2l0QW5pbWF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltcGxpY2l0QW5pbWF0 aW9uOjpzZW5kVHJhbnNpdGlvbkV2ZW50KToKKyAgICAgICAgKiBwYWdlL2FuaW1hdGlvbi9LZXlm cmFtZUFuaW1hdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpLZXlmcmFtZUFuaW1hdGlvbjo6 c2VuZEFuaW1hdGlvbkV2ZW50KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyU1ZHQ29udGFp bmVyLmg6CisgICAgICAgIChXZWJDb3JlOjp0b1JlbmRlclNWR0NvbnRhaW5lcik6CisgICAgICAg ICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlclN0eWxlOjpzZXRUZXh0U2hhZG93KToKKyAgICAgICAgKiBzdmcvZ3JhcGhpY3MvU1ZHUGFp bnRTZXJ2ZXJHcmFkaWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdQYWludFNlcnZlckdy YWRpZW50OjpzZXR1cCk6CisgICAgICAgICogc3ZnL2dyYXBoaWNzL1NWR1BhaW50U2VydmVyUGF0 dGVybi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdQYWludFNlcnZlclBhdHRlcm46OnNldHVw KToKKwogMjAwOS0xMi0yOCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3Jvbmhh QGNvbGxhYm9yYS5jby51az4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBYYW4gTG9wZXou CkluZGV4OiBXZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAJKHJldmlzaW9u IDUyNjA2KQorKysgV2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTA5MCw3ICsxMDkwLDcgQEAgYm9vbCBDb21wb3NpdGVFZGl0Q29tbWFu ZDo6YnJlYWtPdXRPZkVtcAogICAgIAogICAgIFBvc2l0aW9uIGNhcmV0UG9zKGNhcmV0LmRlZXBF cXVpdmFsZW50KCkpOwogICAgIC8vIEEgbGluZSBicmVhayBpcyBlaXRoZXIgYSBiciBvciBhIHBy ZXNlcnZlZCBuZXdsaW5lLgotICAgIEFTU0VSVChjYXJldFBvcy5ub2RlKCktPmhhc1RhZ05hbWUo YnJUYWcpIHx8IGNhcmV0UG9zLm5vZGUoKS0+aXNUZXh0Tm9kZSgpICYmIGNhcmV0UG9zLm5vZGUo KS0+cmVuZGVyZXIoKS0+c3R5bGUoKS0+cHJlc2VydmVOZXdsaW5lKCkpOworICAgIEFTU0VSVChj YXJldFBvcy5ub2RlKCktPmhhc1RhZ05hbWUoYnJUYWcpIHx8IChjYXJldFBvcy5ub2RlKCktPmlz VGV4dE5vZGUoKSAmJiBjYXJldFBvcy5ub2RlKCktPnJlbmRlcmVyKCktPnN0eWxlKCktPnByZXNl cnZlTmV3bGluZSgpKSk7CiAgICAgCiAgICAgaWYgKGNhcmV0UG9zLm5vZGUoKS0+aGFzVGFnTmFt ZShiclRhZykpIHsKICAgICAgICAgUG9zaXRpb24gYmVmb3JlQlIocG9zaXRpb25JblBhcmVudEJl Zm9yZU5vZGUoY2FyZXRQb3Mubm9kZSgpKSk7CkluZGV4OiBXZWJDb3JlL3BhZ2UvYW5pbWF0aW9u L0ltcGxpY2l0QW5pbWF0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvYW5pbWF0 aW9uL0ltcGxpY2l0QW5pbWF0aW9uLmNwcAkocmV2aXNpb24gNTI2MDYpCisrKyBXZWJDb3JlL3Bh Z2UvYW5pbWF0aW9uL0ltcGxpY2l0QW5pbWF0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYx LDcgKzE2MSw3IEBAIGJvb2wgSW1wbGljaXRBbmltYXRpb246OnNlbmRUcmFuc2l0aW9uRXYKICAg ICAgICAgICAgIGlmIChtX29iamVjdC0+bm9kZSgpICYmIG1fb2JqZWN0LT5ub2RlKCktPmlzRWxl bWVudE5vZGUoKSkKICAgICAgICAgICAgICAgICBlbGVtZW50ID0gc3RhdGljX2Nhc3Q8RWxlbWVu dCo+KG1fb2JqZWN0LT5ub2RlKCkpOwogCi0gICAgICAgICAgICBBU1NFUlQoIWVsZW1lbnQgfHwg ZWxlbWVudC0+ZG9jdW1lbnQoKSAmJiAhZWxlbWVudC0+ZG9jdW1lbnQoKS0+aW5QYWdlQ2FjaGUo KSk7CisgICAgICAgICAgICBBU1NFUlQoIWVsZW1lbnQgfHwgKGVsZW1lbnQtPmRvY3VtZW50KCkg JiYgIWVsZW1lbnQtPmRvY3VtZW50KCktPmluUGFnZUNhY2hlKCkpKTsKICAgICAgICAgICAgIGlm ICghZWxlbWVudCkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKSW5kZXg6IFdlYkNv cmUvcGFnZS9hbmltYXRpb24vS2V5ZnJhbWVBbmltYXRpb24uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGFnZS9hbmltYXRpb24vS2V5ZnJhbWVBbmltYXRpb24uY3BwCShyZXZpc2lvbiA1MjYw NikKKysrIFdlYkNvcmUvcGFnZS9hbmltYXRpb24vS2V5ZnJhbWVBbmltYXRpb24uY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0yODEsNyArMjgxLDcgQEAgYm9vbCBLZXlmcmFtZUFuaW1hdGlvbjo6c2Vu ZEFuaW1hdGlvbkV2ZQogICAgICAgICBpZiAobV9vYmplY3QtPm5vZGUoKSAmJiBtX29iamVjdC0+ bm9kZSgpLT5pc0VsZW1lbnROb2RlKCkpCiAgICAgICAgICAgICBlbGVtZW50ID0gc3RhdGljX2Nh c3Q8RWxlbWVudCo+KG1fb2JqZWN0LT5ub2RlKCkpOwogCi0gICAgICAgIEFTU0VSVCghZWxlbWVu dCB8fCBlbGVtZW50LT5kb2N1bWVudCgpICYmICFlbGVtZW50LT5kb2N1bWVudCgpLT5pblBhZ2VD YWNoZSgpKTsKKyAgICAgICAgQVNTRVJUKCFlbGVtZW50IHx8IChlbGVtZW50LT5kb2N1bWVudCgp ICYmICFlbGVtZW50LT5kb2N1bWVudCgpLT5pblBhZ2VDYWNoZSgpKSk7CiAgICAgICAgIGlmICgh ZWxlbWVudCkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIApJbmRleDogV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyU1ZHQ29udGFpbmVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyU1ZHQ29udGFpbmVyLmgJKHJldmlzaW9uIDUyNjA2KQorKysgV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyU1ZHQ29udGFpbmVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTc4LDE0ICs3OCwx NCBAQCBwcml2YXRlOgogaW5saW5lIFJlbmRlclNWR0NvbnRhaW5lciogdG9SZW5kZXJTVkdDb250 YWluZXIoUmVuZGVyT2JqZWN0KiBvYmplY3QpCiB7CiAgICAgLy8gTm90ZTogaXNTVkdDb250YWlu ZXIgaXMgYWxzbyB0cnVlIGZvciBSZW5kZXJTVkdWaWV3cG9ydENvbnRhaW5lciwgd2hpY2ggaXMg bm90IGRlcml2ZWQgZnJvbSB0aGlzLgotICAgIEFTU0VSVCghb2JqZWN0IHx8IG9iamVjdC0+aXNT VkdDb250YWluZXIoKSAmJiBzdHJjbXAob2JqZWN0LT5yZW5kZXJOYW1lKCksICJSZW5kZXJTVkdW aWV3cG9ydENvbnRhaW5lciIpKTsKKyAgICBBU1NFUlQoIW9iamVjdCB8fCAob2JqZWN0LT5pc1NW R0NvbnRhaW5lcigpICYmIHN0cmNtcChvYmplY3QtPnJlbmRlck5hbWUoKSwgIlJlbmRlclNWR1Zp ZXdwb3J0Q29udGFpbmVyIikpKTsKICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8UmVuZGVyU1ZHQ29u dGFpbmVyKj4ob2JqZWN0KTsKIH0KIAogaW5saW5lIGNvbnN0IFJlbmRlclNWR0NvbnRhaW5lciog dG9SZW5kZXJTVkdDb250YWluZXIoY29uc3QgUmVuZGVyT2JqZWN0KiBvYmplY3QpCiB7CiAgICAg Ly8gTm90ZTogaXNTVkdDb250YWluZXIgaXMgYWxzbyB0cnVlIGZvciBSZW5kZXJTVkdWaWV3cG9y dENvbnRhaW5lciwgd2hpY2ggaXMgbm90IGRlcml2ZWQgZnJvbSB0aGlzLgotICAgIEFTU0VSVCgh b2JqZWN0IHx8IG9iamVjdC0+aXNTVkdDb250YWluZXIoKSAmJiBzdHJjbXAob2JqZWN0LT5yZW5k ZXJOYW1lKCksICJSZW5kZXJTVkdWaWV3cG9ydENvbnRhaW5lciIpKTsKKyAgICBBU1NFUlQoIW9i amVjdCB8fCAob2JqZWN0LT5pc1NWR0NvbnRhaW5lcigpICYmIHN0cmNtcChvYmplY3QtPnJlbmRl ck5hbWUoKSwgIlJlbmRlclNWR1ZpZXdwb3J0Q29udGFpbmVyIikpKTsKICAgICByZXR1cm4gc3Rh dGljX2Nhc3Q8Y29uc3QgUmVuZGVyU1ZHQ29udGFpbmVyKj4ob2JqZWN0KTsKIH0KIApJbmRleDog V2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAkocmV2aXNpb24gNTI2MDYpCisr KyBXZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTcwMiw3ICs3MDIsNyBAQCB2b2lkIFJlbmRlclN0eWxlOjphZGRCaW5kaW5nVVJJKFN0cmlu Z0ltCiAKIHZvaWQgUmVuZGVyU3R5bGU6OnNldFRleHRTaGFkb3coU2hhZG93RGF0YSogdmFsLCBi b29sIGFkZCkKIHsKLSAgICBBU1NFUlQoIXZhbCB8fCAhdmFsLT5zcHJlYWQgJiYgdmFsLT5zdHls ZSA9PSBOb3JtYWwpOworICAgIEFTU0VSVCghdmFsIHx8ICghdmFsLT5zcHJlYWQgJiYgdmFsLT5z dHlsZSA9PSBOb3JtYWwpKTsKIAogICAgIFN0eWxlUmFyZUluaGVyaXRlZERhdGEqIHJhcmVEYXRh ID0gcmFyZUluaGVyaXRlZERhdGEuYWNjZXNzKCk7CiAgICAgaWYgKCFhZGQpIHsKSW5kZXg6IFdl YkNvcmUvc3ZnL2dyYXBoaWNzL1NWR1BhaW50U2VydmVyR3JhZGllbnQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR1BhaW50U2VydmVyR3JhZGllbnQuY3BwCShyZXZp c2lvbiA1MjYwNikKKysrIFdlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR1BhaW50U2VydmVyR3JhZGll bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTMsNyArMTkzLDcgQEAgYm9vbCBTVkdQYWludFNl cnZlckdyYWRpZW50OjpzZXR1cChHcmFwaAogICAgIGJvb2wgaXNGaWxsZWQgPSAodHlwZSAmIEFw cGx5VG9GaWxsVGFyZ2V0VHlwZSkgJiYgc3R5bGUtPmhhc0ZpbGwoKTsKICAgICBib29sIGlzU3Ry b2tlZCA9ICh0eXBlICYgQXBwbHlUb1N0cm9rZVRhcmdldFR5cGUpICYmIHN0eWxlLT5oYXNTdHJv a2UoKTsKIAotICAgIEFTU0VSVChpc0ZpbGxlZCAmJiAhaXNTdHJva2VkIHx8ICFpc0ZpbGxlZCAm JiBpc1N0cm9rZWQpOworICAgIEFTU0VSVCgoaXNGaWxsZWQgJiYgIWlzU3Ryb2tlZCkgfHwgKCFp c0ZpbGxlZCAmJiBpc1N0cm9rZWQpKTsKIAogICAgIGNvbnRleHQtPnNhdmUoKTsKIApJbmRleDog V2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHUGFpbnRTZXJ2ZXJQYXR0ZXJuLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdQYWludFNlcnZlclBhdHRlcm4uY3BwCShyZXZp c2lvbiA1MjYwNikKKysrIFdlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR1BhaW50U2VydmVyUGF0dGVy bi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMyw3ICsxMDMsNyBAQCBib29sIFNWR1BhaW50U2Vy dmVyUGF0dGVybjo6c2V0dXAoR3JhcGhpCiAgICAgYm9vbCBpc0ZpbGxlZCA9ICh0eXBlICYgQXBw bHlUb0ZpbGxUYXJnZXRUeXBlKSAmJiBzdHlsZS0+aGFzRmlsbCgpOwogICAgIGJvb2wgaXNTdHJv a2VkID0gKHR5cGUgJiBBcHBseVRvU3Ryb2tlVGFyZ2V0VHlwZSkgJiYgc3R5bGUtPmhhc1N0cm9r ZSgpOwogCi0gICAgQVNTRVJUKGlzRmlsbGVkICYmICFpc1N0cm9rZWQgfHwgIWlzRmlsbGVkICYm IGlzU3Ryb2tlZCk7CisgICAgQVNTRVJUKChpc0ZpbGxlZCAmJiAhaXNTdHJva2VkKSB8fCAoIWlz RmlsbGVkICYmIGlzU3Ryb2tlZCkpOwogCiAgICAgbV9vd25lckVsZW1lbnQtPmJ1aWxkUGF0dGVy bih0YXJnZXRSZWN0KTsKICAgICBpZiAoIXRpbGUoKSkK