32994 2009-12-28 14:29:19 -0800 [V8] IsRefPtrType() in CodeGeneratorV8.pm increases maintenance burden. 2010-01-11 09:18:35 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 32630 1 dglazkov dglazkov webkit.review.bot oldest_to_newest 175307 0 dglazkov 2009-12-28 14:29:19 -0800 We should work to eliminate it. 177873 1 46009 dglazkov 2010-01-06 17:01:07 -0800 Created attachment 46009 Reverse IsRefPtrType test, v1. 177874 2 webkit.review.bot 2010-01-06 17:03:37 -0800 style-queue ran check-webkit-style on attachment 46009 without any errors. 177920 3 46009 zimmermann 2010-01-06 19:18:09 -0800 Comment on attachment 46009 Reverse IsRefPtrType test, v1. LGTM, r=me. 179390 4 dglazkov 2010-01-11 09:18:35 -0800 Landed as http://trac.webkit.org/changeset/53083. 46009 2010-01-06 17:01:07 -0800 2010-01-06 19:18:08 -0800 Reverse IsRefPtrType test, v1. bug-32994-20100106170103.patch text/plain 5129 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzYxZDQyMS4uNzk3MWRiYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMS0wNiAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtWOF0gSXNSZWZQdHJUeXBlKCkgaW4gQ29kZUdlbmVyYXRv clY4LnBtIGluY3JlYXNlcyBtYWludGVuYW5jZSBidXJkZW4uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjk5NAorCisgICAgICAgIFJlZmFjdG9yaW5n LCBjb3ZlcmVkIGJ5IGV4aXN0aW5ncyB0ZXN0cy4KKworICAgICAgICAqIGJpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvclY4LnBtOiBSZXZlcnNlZCB0ZXN0aW5nIGZvciByZWYtY291bnRlZCBv YmplY3RzLAorICAgICAgICAgICAgc2luY2UgdGhlcmUncyBhIG11Y2ggc21hbGxlciAoYW5kIG1v cmUgc3RhYmxlKSBzZXQgb2Ygbm9uLXJlZi1jb3VudGVkIG9uZXMuCisKIDIwMTAtMDEtMDYgIE5p a29sYXMgWmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGlyayBTY2h1bHplLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JWOC5wbSBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yVjgucG0KaW5kZXggYjk5OWFhNi4uOGRlN2RlNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0yMDA2LDEwMCArMjAwNiwyMCBAQCBzdWIgR2V0 TmF0aXZlVHlwZUZyb21TaWduYXR1cmUKIHN1YiBJc1JlZlB0clR5cGUKIHsKICAgICBteSAkdHlw ZSA9IHNoaWZ0OwotICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJBdHRyIjsKLSAgICByZXR1cm4g MSBpZiAkdHlwZSBlcSAiQ2FudmFzQm9vbGVhbkFycmF5IjsKLSAgICByZXR1cm4gMSBpZiAkdHlw ZSBlcSAiQ2FudmFzR3JhZGllbnQiOwotICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJDYW52YXNP YmplY3QiOwotICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJDbGllbnRSZWN0IjsKLSAgICByZXR1 cm4gMSBpZiAkdHlwZSBlcSAiQ2xpZW50UmVjdExpc3QiOwotICAgIHJldHVybiAxIGlmICR0eXBl IGVxICJDREFUQVNlY3Rpb24iOwotICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJDb21tZW50IjsK LSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiQ1NTUnVsZSI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5 cGUgZXEgIkNTU1N0eWxlUnVsZSI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIkNTU0NoYXJz ZXRSdWxlIjsKLSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiQ1NTSW1wb3J0UnVsZSI7Ci0gICAg cmV0dXJuIDEgaWYgJHR5cGUgZXEgIkNTU01lZGlhUnVsZSI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5 cGUgZXEgIkNTU0ZvbnRGYWNlUnVsZSI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIkNTU1Bh Z2VSdWxlIjsKLSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiQ1NTUHJpbWl0aXZlVmFsdWUiOwot ICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJDU1NTdHlsZVNoZWV0IjsKLSAgICByZXR1cm4gMSBp ZiAkdHlwZSBlcSAiQ1NTU3R5bGVEZWNsYXJhdGlvbiI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUg ZXEgIkNTU1ZhbHVlIjsKLSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiQ1NTUnVsZUxpc3QiOwot ICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJEYXRhYmFzZSI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5 cGUgZXEgIkRvY3VtZW50IjsKLSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiRG9jdW1lbnRGcmFn bWVudCI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIkRvY3VtZW50VHlwZSI7Ci0gICAgcmV0 dXJuIDEgaWYgJHR5cGUgZXEgIkVsZW1lbnQiOwotICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJF bnRpdHlSZWZlcmVuY2UiOwotICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJFdmVudCI7Ci0gICAg cmV0dXJuIDEgaWYgJHR5cGUgZXEgIkV2ZW50TGlzdGVuZXIiOwotICAgIHJldHVybiAxIGlmICR0 eXBlIGVxICJGaWxlTGlzdCI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIkhUTUxDb2xsZWN0 aW9uIjsKLSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiSFRNTEFsbENvbGxlY3Rpb24iOwotICAg IHJldHVybiAxIGlmICR0eXBlIGVxICJIVE1MRG9jdW1lbnQiOwotICAgIHJldHVybiAxIGlmICR0 eXBlIGVxICJIVE1MRWxlbWVudCI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIkhUTUxPcHRp b25zQ29sbGVjdGlvbiI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIkltYWdlRGF0YSI7Ci0g ICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIk1lZGlhIjsKLSAgICByZXR1cm4gMSBpZiAkdHlwZSBl cSAiTWVkaWFFcnJvciI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIk1pbWVUeXBlIjsKLSAg ICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiTm9kZSI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEg Ik5vZGVMaXN0IjsKLSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiTm9kZUZpbHRlciI7Ci0gICAg cmV0dXJuIDEgaWYgJHR5cGUgZXEgIk5vZGVJdGVyYXRvciI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5 cGUgZXEgIk5TUmVzb2x2ZXIiOwotICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJQbHVnaW4iOwot ICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJQcm9jZXNzaW5nSW5zdHJ1Y3Rpb24iOwotICAgIHJl dHVybiAxIGlmICR0eXBlIGVxICJSYW5nZSI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIlJH QkNvbG9yIjsKLSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiVGV4dCI7Ci0gICAgcmV0dXJuIDEg aWYgJHR5cGUgZXEgIlRleHRNZXRyaWNzIjsKLSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiVGlt ZVJhbmdlcyI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIlRyZWVXYWxrZXIiOwotICAgIHJl dHVybiAxIGlmICR0eXBlIGVxICJXZWJHTEFjdGl2ZUluZm8iOwotICAgIHJldHVybiAxIGlmICR0 eXBlIGVxICJXZWJHTEFycmF5IjsKLSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiV2ViR0xBcnJh eUJ1ZmZlciI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIldlYkdMQnl0ZUFycmF5IjsKLSAg ICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiV2ViR0xCdWZmZXIiOwotICAgIHJldHVybiAxIGlmICR0 eXBlIGVxICJXZWJHTEZsb2F0QXJyYXkiOwotICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJXZWJH TEZyYW1lYnVmZmVyIjsKLSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiV2ViR0xJbnRBcnJheSI7 Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIldlYkdMUHJvZ3JhbSI7Ci0gICAgcmV0dXJuIDEg aWYgJHR5cGUgZXEgIldlYkdMUmVuZGVyYnVmZmVyIjsKLSAgICByZXR1cm4gMSBpZiAkdHlwZSBl cSAiV2ViR0xTaGFkZXIiOwotICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJXZWJHTFNob3J0QXJy YXkiOwotICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJXZWJHTFRleHR1cmUiOwotICAgIHJldHVy biAxIGlmICR0eXBlIGVxICJXZWJHTFVuaWZvcm1Mb2NhdGlvbiI7Ci0gICAgcmV0dXJuIDEgaWYg JHR5cGUgZXEgIldlYkdMVW5zaWduZWRCeXRlQXJyYXkiOwotICAgIHJldHVybiAxIGlmICR0eXBl IGVxICJXZWJHTFVuc2lnbmVkSW50QXJyYXkiOwotICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJX ZWJHTFVuc2lnbmVkU2hvcnRBcnJheSI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIldlYktp dENTU01hdHJpeCI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIldlYktpdFBvaW50IjsKLSAg ICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiWFBhdGhFeHByZXNzaW9uIjsKLSAgICByZXR1cm4gMSBp ZiAkdHlwZSBlcSAiWFBhdGhOU1Jlc29sdmVyIjsKLSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAi WFBhdGhSZXN1bHQiOwotCi0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIlNWR0VsZW1lbnRJbnN0 YW5jZSI7Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIlNWR0VsZW1lbnRJbnN0YW5jZUxpc3Qi OwotICAgIHJldHVybiAxIGlmICR0eXBlID1+IC9eU1ZHUGF0aFNlZy87Ci0KLSAgICByZXR1cm4g MSBpZiAkdHlwZSA9fiAvXlNWR0FuaW1hdGVkLzsKIAotICAgIHJldHVybiAwOwotfQotCi1zdWIg SXNWaWRlb0NsYXNzTmFtZQotewotICAgIG15ICRjbGFzcyA9IHNoaWZ0OwotICAgIHJldHVybiAx IGlmICRjbGFzcyBlcSAiVjhIVE1MQXVkaW9FbGVtZW50IjsKLSAgICByZXR1cm4gMSBpZiAkY2xh c3MgZXEgIlY4SFRNTE1lZGlhRWxlbWVudCI7Ci0gICAgcmV0dXJuIDEgaWYgJGNsYXNzIGVxICJW OEhUTUxTb3VyY2VFbGVtZW50IjsKLSAgICByZXR1cm4gMSBpZiAkY2xhc3MgZXEgIlY4SFRNTFZp ZGVvRWxlbWVudCI7Ci0gICAgcmV0dXJuIDEgaWYgJGNsYXNzIGVxICJWOE1lZGlhRXJyb3IiOwot ICAgIHJldHVybiAxIGlmICRjbGFzcyBlcSAiVjhUaW1lUmFuZ2VzIjsKLQotICAgIHJldHVybiAw OworICAgIHJldHVybiAwIGlmICR0eXBlIGVxICJib29sZWFuIjsKKyAgICByZXR1cm4gMCBpZiAk dHlwZSBlcSAiZmxvYXQiOworICAgIHJldHVybiAwIGlmICR0eXBlIGVxICJpbnQiOworICAgIHJl dHVybiAwIGlmICR0eXBlIGVxICJEYXRlIjsKKyAgICByZXR1cm4gMCBpZiAkdHlwZSBlcSAiRE9N U3RyaW5nIjsKKyAgICByZXR1cm4gMCBpZiAkdHlwZSBlcSAiZG91YmxlIjsKKyAgICByZXR1cm4g MCBpZiAkdHlwZSBlcSAic2hvcnQiOworICAgIHJldHVybiAwIGlmICR0eXBlIGVxICJsb25nIjsK KyAgICByZXR1cm4gMCBpZiAkdHlwZSBlcSAidW5zaWduZWQiOworICAgIHJldHVybiAwIGlmICR0 eXBlIGVxICJ1bnNpZ25lZCBsb25nIjsKKyAgICByZXR1cm4gMCBpZiAkdHlwZSBlcSAidW5zaWdu ZWQgc2hvcnQiOworCisgICAgcmV0dXJuIDE7CiB9CiAKIHN1YiBJc1dvcmtlckNsYXNzTmFtZQo=