32989 2009-12-28 12:11:14 -0800 [Qt] DRT: Frame loader callbacks differ from the Mac port 2009-12-29 00:26:47 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P3 Normal --- 1 jwieczorek webkit-unassigned commit-queue tonikitoo webkit.review.bot oldest_to_newest 175272 0 jwieczorek 2009-12-28 12:11:14 -0800 In FrameLoaderClientQt, there is a couple of methods that print debug messages for the DRT, while the Mac equivalents do not. To match the expected results for tests that dump frame loader callbacks, those messages should be removed. 175273 1 45567 jwieczorek 2009-12-28 12:15:54 -0800 Created attachment 45567 proposed patch 175275 2 webkit.review.bot 2009-12-28 12:19:00 -0800 style-queue ran check-webkit-style on attachment 45567 without any errors. 175282 3 tonikitoo 2009-12-28 12:32:19 -0800 jakub, although "proposed patch" gets good results (many tests can be unskipped), I did not like the solution very much, mainly because these messages you are removing are useful for debugging. A better solution would be stop calling "qt_dump_frame_loader" (see quoted code below), imo. void DumpRenderTree::open(const QUrl& aurl) { (...) qt_dump_frame_loader(url.toString().contains("loading/")); setTextOutputEnabled(true); m_page->mainFrame()->load(url); } please consider this as well ... 175288 4 jwieczorek 2009-12-28 12:47:08 -0800 (In reply to comment #3) > jakub, although "proposed patch" gets good results (many tests can be > unskipped), I did not like the solution very much, mainly because these > messages you are removing are useful for debugging. I understand the point about having these messages for the sake of debugging but should they prevent the Qt port from passing loader tests against the cross-platform expected results? Do you think it would be fine to leave those messages commented out? > A better solution would be stop calling "qt_dump_frame_loader" (see quoted code > below), imo. > > void DumpRenderTree::open(const QUrl& aurl) > { > (...) > qt_dump_frame_loader(url.toString().contains("loading/")); > setTextOutputEnabled(true); > m_page->mainFrame()->load(url); > } > > > please consider this as well ... I'm sorry, I didn't get this. Can you elaborate a bit more please? 175295 5 tonikitoo 2009-12-28 12:56:21 -0800 > I'm sorry, I didn't get this. Can you elaborate a bit more please? by looking at the messages, they are mostly enclosed by an "if". e.g.: void FrameLoaderClientQt::dispatchDidHandleOnloadEvents() { // don't need this one if (dumpFrameLoaderCallbacks) printf("%s - didHandleOnloadEventsForFrame\n", qPrintable(drtDescriptionSuitableForTestResult(m_frame))); } "dumpFrameLoaderCallbacks" is a global var exported to DRT via "extern". Now in the DumpRenderThree::open code formely quoted, see "qt_dump_frame_loader" method call specifically. It is the method that enables dumping these debug message you want to remove. So another option would instead of removing all the messages from the code, we could just stop calling "qt_dump_frame_loader" at DumpRenderThree::open, then they would not dump and debuggers would still be happy :) make more sense now ? 175299 6 jwieczorek 2009-12-28 13:06:27 -0800 (In reply to comment #5) > > I'm sorry, I didn't get this. Can you elaborate a bit more please? > > by looking at the messages, they are mostly enclosed by an "if". e.g.: > > void FrameLoaderClientQt::dispatchDidHandleOnloadEvents() > { > // don't need this one > if (dumpFrameLoaderCallbacks) > printf("%s - didHandleOnloadEventsForFrame\n", > qPrintable(drtDescriptionSuitableForTestResult(m_frame))); > } > > > "dumpFrameLoaderCallbacks" is a global var exported to DRT via "extern". > > Now in the DumpRenderThree::open code formely quoted, see > "qt_dump_frame_loader" method call specifically. It is the method that enables > dumping these debug message you want to remove. So another option would instead > of removing all the messages from the code, we could just stop calling > "qt_dump_frame_loader" at DumpRenderThree::open, then they would not dump and > debuggers would still be happy :) > > make more sense now ? It is not about removing all of the frame loader callback messages but only those that are now printed as part of the DRT output in the Qt port but are not in the Mac and Win ports. We still want to dump all of the remaining callbacks. This is to match the loading test expectations. 175464 7 45567 eric 2009-12-29 00:09:56 -0800 Comment on attachment 45567 proposed patch Looks like at least some of these were removed in bug 16853. This looks sane to me. 175473 8 45567 commit-queue 2009-12-29 00:26:42 -0800 Comment on attachment 45567 proposed patch Clearing flags on attachment: 45567 Committed r52612: <http://trac.webkit.org/changeset/52612> 175474 9 commit-queue 2009-12-29 00:26:47 -0800 All reviewed patches have been landed. Closing bug. 45567 2009-12-28 12:15:54 -0800 2009-12-29 00:26:42 -0800 proposed patch 0001-Qt-DRT-Frame-loader-callbacks-differ-from-the-Mac-po.patch text/plain 7471 jwieczorek RnJvbSBiMmExNDIzNTY1YmNiNWE3ZDRlNDM5NGUwYjMyMzMzNDA5OTM3Y2UwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWt1YiBXaWVjem9yZWsgPGZhdzIxN0BnbWFpbC5jb20+CkRh dGU6IE1vbiwgMjggRGVjIDIwMDkgMjE6MDI6MDggKzAwMDAKU3ViamVjdDogW1BBVENIXSBbUXRd IERSVDogRnJhbWUgbG9hZGVyIGNhbGxiYWNrcyBkaWZmZXIgZnJvbSB0aGUgTWFjIHBvcnQKIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjk4OQoKUmVtb3ZlIG1lc3Nh Z2VzIGZyb20gdGhlIGNhbGxiYWNrcyB0aGF0IHNob3VsZCBub3QgZHVtcCB0aGVtIHRvIG1hdGNo CnRoZSBleHBlY3RlZCByZXN1bHRzIGZvciB0aGUgaHR0cC9sb2FkaW5nIHRlc3RzLgoKVW5za2lw IHNvbWUgaHR0cC9sb2FkaW5nIHRlc3RzIHdoaWNoIHN1Y2NlZWQgbm93LgotLS0KIExheW91dFRl c3RzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysr KysrKysrKwogTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCAgICAgICAgICAgICAgICAg ICAgfCAgIDEzICstLS0tLS0tLS0tLS0KIFdlYktpdC9xdC9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxOCArKysrKysrKysrKysrKysrKysKIFdlYktpdC9xdC9X ZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcCAgIHwgICAgOCAtLS0tLS0tLQog V2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE1 ICsrKysrKysrKysrKysrKwogV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRl clRyZWVRdC5jcHAgfCAgICAzICsrKwogNiBmaWxlcyBjaGFuZ2VkLCA1MSBpbnNlcnRpb25zKCsp LCAyMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDY2NDFlMC4uYmIzZGNlOSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE3IEBACisyMDA5LTEyLTI4ICBKYWt1YiBXaWVjem9yZWsgIDxmYXcyMTdAZ21haWwuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g RFJUOiBGcmFtZSBsb2FkZXIgY2FsbGJhY2tzIGRpZmZlciBmcm9tIHRoZSBNYWMgcG9ydAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI5ODkKKworICAg ICAgICBSZW1vdmUgbWVzc2FnZXMgZnJvbSB0aGUgY2FsbGJhY2tzIHRoYXQgc2hvdWxkIG5vdCBk dW1wIHRoZW0gdG8gbWF0Y2gKKyAgICAgICAgdGhlIGV4cGVjdGVkIHJlc3VsdHMgZm9yIHRoZSBo dHRwL2xvYWRpbmcgdGVzdHMuCisKKyAgICAgICAgVW5za2lwIHNvbWUgaHR0cC9sb2FkaW5nIHRl c3RzIHdoaWNoIHN1Y2NlZWQgbm93LgorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoK KwogMjAwOS0xMi0yOCAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApp bmRleCAyYmJkY2U1Li4wNWU4YTU5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9x dC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKQEAgLTI5LDIw ICsyOSwxMCBAQCBodHRwL3Rlc3RzL3dtbAogaHR0cC90ZXN0cy91cmkvZXNjYXBlZC1lbnRpdHku aHRtbAogCiAjIEZhaWxpbmcgSFRUUCBMb2FkaW5nIHRlc3RzCi1odHRwL3Rlc3RzL2xvYWRpbmcv YmFkLXNlcnZlci1zdWJmcmFtZS5odG1sCiBodHRwL3Rlc3RzL2xvYWRpbmcvYmFkLXNjaGVtZS1z dWJmcmFtZS5odG1sCi1odHRwL3Rlc3RzL2xvYWRpbmcvYmFzaWMtYXV0aC1yZXNlbmQtd3Jvbmct Y3JlZGVudGlhbHMuaHRtbAotaHR0cC90ZXN0cy9sb2FkaW5nL2Jhc2ljLmh0bWwKLWh0dHAvdGVz dHMvbG9hZGluZy9kZWxldGVkLWhvc3QtaW4tcmVzb3VyY2UtbG9hZC1kZWxlZ2F0ZS1jYWxsYmFj ay5odG1sCi1odHRwL3Rlc3RzL2xvYWRpbmcvZW1wdHktc3ViZnJhbWUuaHRtbAogaHR0cC90ZXN0 cy9sb2FkaW5nL2dtYWlsLWFzc2VydC1vbi1sb2FkLmh0bWwKLWh0dHAvdGVzdHMvbG9hZGluZy9s b2NhdGlvbi1oYXNoLXJlbG9hZC1jeWNsZS5odG1sCi1odHRwL3Rlc3RzL2xvYWRpbmcvb25sb2Fk LXZzLWltbWVkaWF0ZS1yZWZyZXNoLnBsCi1odHRwL3Rlc3RzL2xvYWRpbmcvcHJlbG9hZC1pbWct dGVzdC5odG1sCiBodHRwL3Rlc3RzL2xvYWRpbmcvcmVkaXJlY3QtbWV0aG9kcy5odG1sCi1odHRw L3Rlc3RzL2xvYWRpbmcvcmVkaXJlY3Qtd2l0aC1uby1sb2NhdGlvbi1jcmFzaC5odG1sCiBodHRw L3Rlc3RzL2xvYWRpbmcvc2ltcGxlLXN1YmZyYW1lLmh0bWwKLWh0dHAvdGVzdHMvbG9hZGluZy9z bG93LXBhcnNpbmctc3ViZnJhbWUuaHRtbAogaHR0cC90ZXN0cy9sb2FkaW5nL3RleHQtY29udGVu dC10eXBlLXdpdGgtYmluYXJ5LWV4dGVuc2lvbi5odG1sCiAKICMgRmFpbGluZyBMb2NhbCB0ZXN0 cwpAQCAtNDgzNCw3ICs0ODI0LDYgQEAgZmFzdC9sb2FkZXIvbWFpbi1kb2N1bWVudC11cmwtZm9y LW5vbi1odHRwLWxvYWRzLmh0bWwKIGZhc3QvbG9hZGVyL251bGwtcmVxdWVzdC1hZnRlci13aWxs U2VuZFJlcXVlc3QuaHRtbAogZmFzdC9sb2FkZXIvcG9saWN5LWRlbGVnYXRlLWFjdGlvbi1oaXQt dGVzdC16b29tZWQuaHRtbAogZmFzdC9sb2FkZXIvcmVsb2FkLXBvbGljeS1kZWxlZ2F0ZS5odG1s Ci1mYXN0L2xvYWRpbmcvc3ViZnJhbWUtcmVtb3Zlcy1pdHNlbGYuaHRtbAogcGxhdGZvcm0vcXQv ZmFzdC9ldmVudHMvZXZlbnQtc2VuZGVyLWtleWRvd24tZnJhbWUuaHRtbAogcGx1Z2lucy9uZXRz Y2FwZS1wbHVnaW4tc2V0d2luZG93LXNpemUtMi5odG1sCiBzZWN1cml0eS9zZXQtZm9ybS1hdXRv Y29tcGxldGUtYXR0cmlidXRlLmh0bWwKQEAgLTQ4ODQsNiArNDg3Myw3IEBAIHVzZXJzY3JpcHRz CiAKICMgTm8gYXV0aGVudGljYXRpb24gY2hhbGxlbmdlIGhhbmRsaW5nCiBodHRwL3Rlc3RzL2xv YWRpbmcvYmFzaWMtY3JlZGVudGlhbHMtc2VudC1hdXRvbWF0aWNhbGx5Lmh0bWwKK2h0dHAvdGVz dHMvbG9hZGluZy9iYXNpYy1hdXRoLXJlc2VuZC13cm9uZy1jcmVkZW50aWFscy5odG1sCiAKICMg VGhpcyBwb3J0IGRvZXNuJ3Qgc3VwcG9ydCBkZXRlY3Rpbmcgc2xvdyB1bmxvYWQgaGFuZGxlcnMu CiBmYXN0L2RvbS9XaW5kb3cvc2xvd191bmxvYWRfaGFuZGxlci5odG1sCkBAIC01MDkzLDcgKzUw ODMsNiBAQCBmYXN0L3JlcGFpbnQvYmxvY2stc2VsZWN0aW9uLWdhcC1zdGFsZS1jYWNoZS0yLmh0 bWwKIGZhc3QvcmVwYWludC9ibG9jay1zZWxlY3Rpb24tZ2FwLXN0YWxlLWNhY2hlLmh0bWwKIGZh c3QvcmVwYWludC9pbmxpbmUtb3ZlcmZsb3cuaHRtbAogZmFzdC9yZXBhaW50L2lubGluZS1yZWxh dGl2ZS1wb3NpdGlvbmVkLmh0bWwKLWh0dHAvdGVzdHMvbG9hZGluZy9zdGF0ZS1vYmplY3Qtc2Vj dXJpdHktZXhjZXB0aW9uLmh0bWwKIGh0dHAvdGVzdHMvbG9jYWwvZmlsZS11cmwtc2VudC1hcy1y ZWZlcmVyLmh0bWwKIGh0dHAvdGVzdHMvbWlzYy9idWJibGUtZHJhZy1ldmVudHMuaHRtbAogaHR0 cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1mcmFtZS1hY2Nlc3MtZ2V0T3duUHJvcGVydHlEZXNjcmlw dG9yLmh0bWwKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hh bmdlTG9nCmluZGV4IDQwMjkwMjkuLjZhNWI5MjcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDA5LTEy LTI4ICBKYWt1YiBXaWVjem9yZWsgIDxmYXcyMTdAZ21haWwuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRFJUOiBGcmFtZSBsb2FkZXIg Y2FsbGJhY2tzIGRpZmZlciBmcm9tIHRoZSBNYWMgcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI5ODkKKworICAgICAgICBSZW1vdmUgbWVzc2Fn ZXMgZnJvbSB0aGUgY2FsbGJhY2tzIHRoYXQgc2hvdWxkIG5vdCBkdW1wIHRoZW0gdG8gbWF0Y2gK KyAgICAgICAgdGhlIGV4cGVjdGVkIHJlc3VsdHMgZm9yIHRoZSBodHRwL2xvYWRpbmcgdGVzdHMu CisKKyAgICAgICAgVW5za2lwIHNvbWUgaHR0cC9sb2FkaW5nIHRlc3RzIHdoaWNoIHN1Y2NlZWQg bm93LgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudFF0OjpkaXNwYXRjaERpZFBvcFN0 YXRlV2l0aGluUGFnZSk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudFF0Ojpk aXNwYXRjaFdpbGxDbG9zZSk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudFF0 OjpkaXNwYXRjaERpZFJlY2VpdmVJY29uKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVy Q2xpZW50UXQ6OmRpc3BhdGNoRGlkQ2xlYXJXaW5kb3dPYmplY3RJbldvcmxkKToKKwogMjAwOS0x Mi0yNCAgR2lyaXNoIFJhbWFrcmlzaG5hbiAgPGdpcmlzaEBmb3J3YXJkYmlhcy5pbj4KIAogICAg ICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEuCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQv V2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAgYi9XZWJLaXQvcXQvV2ViQ29y ZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAKaW5kZXggM2MzMGFiNS4uMjNmYmVmNyAx MDA2NDQKLS0tIGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQu Y3BwCisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNw cApAQCAtMzMxLDggKzMzMSw2IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRRdDo6ZGlzcGF0Y2hE aWRQb3BTdGF0ZVdpdGhpblBhZ2UoKQogCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50UXQ6OmRpc3Bh dGNoV2lsbENsb3NlKCkKIHsKLSAgICBpZiAoZHVtcEZyYW1lTG9hZGVyQ2FsbGJhY2tzKQotICAg ICAgICBwcmludGYoIiVzIC0gd2lsbENsb3NlRnJhbWVcbiIsIHFQcmludGFibGUoZHJ0RGVzY3Jp cHRpb25TdWl0YWJsZUZvclRlc3RSZXN1bHQobV9mcmFtZSkpKTsKIH0KIAogCkBAIC01OTksOSAr NTk3LDYgQEAgU3RyaW5nIEZyYW1lTG9hZGVyQ2xpZW50UXQ6OnVzZXJBZ2VudChjb25zdCBLVVJM JiB1cmwpCiAKIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRRdDo6ZGlzcGF0Y2hEaWRSZWNlaXZlSWNv bigpCiB7Ci0gICAgaWYgKGR1bXBGcmFtZUxvYWRlckNhbGxiYWNrcykKLSAgICAgICAgcHJpbnRm KCIlcyAtIGRpZFJlY2VpdmVJY29uRm9yRnJhbWVcbiIsIHFQcmludGFibGUoZHJ0RGVzY3JpcHRp b25TdWl0YWJsZUZvclRlc3RSZXN1bHQobV9mcmFtZSkpKTsKLQogICAgIGlmIChtX3dlYkZyYW1l KSB7CiAgICAgICAgIGVtaXQgbV93ZWJGcmFtZS0+aWNvbkNoYW5nZWQoKTsKICAgICB9CkBAIC02 MjYsOSArNjIxLDYgQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudFF0OjpkaXNwYXRjaERpZENsZWFy V2luZG93T2JqZWN0SW5Xb3JsZChET01XcmFwcGVyV29ybGQqIHcKICAgICBpZiAod29ybGQgIT0g bWFpblRocmVhZE5vcm1hbFdvcmxkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmIChkdW1w RnJhbWVMb2FkZXJDYWxsYmFja3MpCi0gICAgICAgIHByaW50ZigiJXMgLSBkaWRDbGVhcldpbmRv d09iamVjdEZvckZyYW1lXG4iLCBxUHJpbnRhYmxlKGRydERlc2NyaXB0aW9uU3VpdGFibGVGb3JU ZXN0UmVzdWx0KG1fZnJhbWUpKSk7Ci0KICAgICBpZiAobV93ZWJGcmFtZSkKICAgICAgICAgZW1p dCBtX3dlYkZyYW1lLT5qYXZhU2NyaXB0V2luZG93T2JqZWN0Q2xlYXJlZCgpOwogfQpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4 IDA4YWE2ZTIuLjI5Nzc0ZmEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysg Yi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0xMi0yOCAgSmFr dWIgV2llY3pvcmVrICA8ZmF3MjE3QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERSVDogRnJhbWUgbG9hZGVyIGNhbGxiYWNr cyBkaWZmZXIgZnJvbSB0aGUgTWFjIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMyOTg5CisKKyAgICAgICAgUmVtb3ZlIG1lc3NhZ2VzIGZyb20g dGhlIGNhbGxiYWNrcyB0aGF0IHNob3VsZCBub3QgZHVtcCB0aGVtIHRvIG1hdGNoCisgICAgICAg IHRoZSBleHBlY3RlZCByZXN1bHRzIGZvciB0aGUgaHR0cC9sb2FkaW5nIHRlc3RzLgorCisgICAg ICAgIFVuc2tpcCBzb21lIGh0dHAvbG9hZGluZyB0ZXN0cyB3aGljaCBzdWNjZWVkIG5vdy4KKwor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RHVtcFJlbmRlclRyZWU6OmR1bXApOgorCiAyMDA5LTEyLTI4ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlk ZWwuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVy VHJlZVF0LmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVl UXQuY3BwCmluZGV4IGQ4NDY5ZGYuLjg4YTA2ODYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwCkBAIC02MDcsNiArNjA3LDkgQEAg c3RhdGljIGNvbnN0IGNoYXIgKm1ldGhvZE5hbWVTdHJpbmdGb3JGYWlsZWRUZXN0KExheW91dFRl c3RDb250cm9sbGVyICpjb250cm9sbGUKIAogdm9pZCBEdW1wUmVuZGVyVHJlZTo6ZHVtcCgpCiB7 CisgICAgLy8gUHJldmVudCBhbnkgZnVydGhlciBmcmFtZSBsb2FkIGNhbGxiYWNrcyBmcm9tIGFw cGVhcmluZyBhZnRlciB3ZSBkdW1wIHRoZSByZXN1bHQuCisgICAgcXRfZHVtcF9mcmFtZV9sb2Fk ZXIoZmFsc2UpOworCiAgICAgUVdlYkZyYW1lICptYWluRnJhbWUgPSBtX3BhZ2UtPm1haW5GcmFt ZSgpOwogCiAgICAgLy9mcHJpbnRmKHN0ZGVyciwgIiAgICBEdW1waW5nXG4iKTsKLS0gCjEuNi41 LjUKCg==