32975 2009-12-27 18:10:10 -0800 [check-webkit-style] does understand ResourceHandleWin.h 2010-01-18 02:13:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned cjerdonek eric hamaji levin oldest_to_newest 175118 0 abarth 2009-12-27 18:10:10 -0800 Comment #4 From Patrick R. Gansterer 2009-12-27 10:48:12 PST (-) [reply] (In reply to comment #2) > WebCore/platform/network/win/ResourceHandleWin.cpp:38: Found header this file > implements after other header. Should be: config.h, primary header, blank line, > and then alphabetically sorted. [build/include_order] [4] The primary header header is ResourceHandle.h. ResourceHandleWin.h is only an ugly helperfile. https://bugs.webkit.org/show_bug.cgi?id=32963#c4 181646 1 46768 abarth 2010-01-17 16:15:07 -0800 Created attachment 46768 Patch 181664 2 46768 hamaji 2010-01-17 17:29:13 -0800 Comment on attachment 46768 Patch > + # Thus far, we've only seen one example of these, but if we start > + # to see more, please consider abstracting this check somehow. Using FIXME would be better? 181773 3 46798 abarth 2010-01-18 01:11:15 -0800 Created attachment 46798 Patch for landing 181798 4 46798 abarth 2010-01-18 02:13:10 -0800 Comment on attachment 46798 Patch for landing Clearing flags on attachment: 46798 Committed r53398: <http://trac.webkit.org/changeset/53398> 181799 5 abarth 2010-01-18 02:13:18 -0800 All reviewed patches have been landed. Closing bug. 46768 2010-01-17 16:15:07 -0800 2010-01-18 01:11:53 -0800 Patch bug-32975-20100117161506.patch text/plain 2771 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUzMzc0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDEtMTcgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbY2hlY2std2Via2l0LXN0eWxlXSBkb2VzIHVuZGVyc3RhbmQgUmVzb3VyY2VIYW5k bGVXaW4uaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzI5NzUKKworICAgICAgICBJJ20gbm90IDEwMCUgY29udmluY2VkIHRoaXMgZml4IGlzIGNvcnJl Y3QsIGJ1dCB3aXRob3V0IG1vcmUgZXhhbXBsZXMsCisgICAgICAgIGl0J3MgaGFyZCB0byBnZW5l cmFsaXplLiAgV2UgY2FuIGFsd2F5cyBnZW5lcmFsaXplIHRoZSBmaXggaW4gdGhlCisgICAgICAg IGZ1dHVyZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlLnB5 OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5 OgorCiAyMDEwLTAxLTE3ICBDaHJpcyBKZXJkb25layAgPGNqZXJkb25la0B3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weQkocmV2aXNpb24gNTMzNzIpCisr KyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weQkod29ya2lu ZyBjb3B5KQpAQCAtMjEwMSw2ICsyMTAxLDEwIEBAIGRlZiBfY2xhc3NpZnlfaW5jbHVkZShmaWxl bmFtZSwgaW5jbHVkZSwKICAgICAjIEluIGNhc2UgdGhlIHR3byBmaWxlbmFtZSBiYXNlcyBhcmUg dGhlIHNhbWUgdGhlbiB0aGUgYWJvdmUgbGVuaWVudCBjaGVjawogICAgICMgcHJvYmFibHkgd2Fz IGEgZmFsc2UgcG9zaXRpdmUuCiAgICAgZWxpZiBpbmNsdWRlX3N0YXRlLnZpc2l0ZWRfcHJpbWFy eV9zZWN0aW9uKCkgYW5kIHRhcmdldF9iYXNlID09IGluY2x1ZGVfYmFzZToKKyAgICAgICAgaWYg aW5jbHVkZSA9PSAiUmVzb3VyY2VIYW5kbGVXaW4uaCI6CisgICAgICAgICAgICAjIFRodXMgZmFy LCB3ZSd2ZSBvbmx5IHNlZW4gb25lIGV4YW1wbGUgb2YgdGhlc2UsIGJ1dCBpZiB3ZSBzdGFydAor ICAgICAgICAgICAgIyB0byBzZWUgbW9yZSwgcGxlYXNlIGNvbnNpZGVyIGFic3RyYWN0aW5nIHRo aXMgY2hlY2sgc29tZWhvdy4KKyAgICAgICAgICAgIHJldHVybiBfT1RIRVJfSEVBREVSCiAgICAg ICAgIHJldHVybiBfUFJJTUFSWV9IRUFERVIKIAogICAgIHJldHVybiBfT1RIRVJfSEVBREVSCklu ZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZV91bml0dGVz dC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2Nw cF9zdHlsZV91bml0dGVzdC5weQkocmV2aXNpb24gNTMzNzIpCisrKyBXZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZV91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpA QCAtMjE2Nyw2ICsyMTY3LDEyIEBAIGNsYXNzIE9yZGVyT2ZJbmNsdWRlc1Rlc3QoQ3BwU3R5bGVU ZXN0QmEKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ0ZvdW5kIGhl YWRlciB0aGlzIGZpbGUgaW1wbGVtZW50cyBhZnRlciBhIGhlYWRlciB0aGlzIGZpbGUgaW1wbGVt ZW50cy4nCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcgU2hvdWxk IGJlOiBjb25maWcuaCwgcHJpbWFyeSBoZWFkZXIsIGJsYW5rIGxpbmUsIGFuZCB0aGVuIGFscGhh YmV0aWNhbGx5IHNvcnRlZC4nCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICcgIFtidWlsZC9pbmNsdWRlX29yZGVyXSBbNF0nKQorICAgICAgICBzZWxmLmFzc2VydF9s YW5ndWFnZV9ydWxlc19jaGVjaygnUmVzb3VyY2VIYW5kbGVXaW4uY3BwJywKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlICJjb25maWcuaCJcbicKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlICJSZXNvdXJj ZUhhbmRsZS5oIlxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAn XG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcjaW5jbHVkZSAi UmVzb3VyY2VIYW5kbGVXaW4uaCJcbicsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICcnKQogCiAgICAgZGVmIHRlc3RfdHJ5X2Ryb3BfY29tbW9uX3N1ZmZpeGVzKHNl bGYpOgogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKCdmb28vZm9vJywgY3BwX3N0eWxlLl9kcm9w X2NvbW1vbl9zdWZmaXhlcygnZm9vL2Zvby1pbmwuaCcpKQo= 46798 2010-01-18 01:11:15 -0800 2010-01-18 02:13:10 -0800 Patch for landing bug-32975-20100118011113.patch text/plain 2791 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUzMzk0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDEtMTggIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBTaGluaWNoaXJvIEhhbWFqaS4K KworICAgICAgICBbY2hlY2std2Via2l0LXN0eWxlXSBkb2VzIHVuZGVyc3RhbmQgUmVzb3VyY2VI YW5kbGVXaW4uaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzI5NzUKKworICAgICAgICBJJ20gbm90IDEwMCUgY29udmluY2VkIHRoaXMgZml4IGlzIGNv cnJlY3QsIGJ1dCB3aXRob3V0IG1vcmUgZXhhbXBsZXMsCisgICAgICAgIGl0J3MgaGFyZCB0byBn ZW5lcmFsaXplLiAgV2UgY2FuIGFsd2F5cyBnZW5lcmFsaXplIHRoZSBmaXggaW4gdGhlCisgICAg ICAgIGZ1dHVyZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxl LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0 LnB5OgorCiAyMDEwLTAxLTE3ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weQkocmV2aXNpb24gNTMzOTQpCisrKyBX ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weQkod29ya2luZyBj b3B5KQpAQCAtMjA2OCw2ICsyMDY4LDExIEBAIGRlZiBfY2xhc3NpZnlfaW5jbHVkZShmaWxlbmFt ZSwgaW5jbHVkZSwKICAgICAjIEluIGNhc2UgdGhlIHR3byBmaWxlbmFtZSBiYXNlcyBhcmUgdGhl IHNhbWUgdGhlbiB0aGUgYWJvdmUgbGVuaWVudCBjaGVjawogICAgICMgcHJvYmFibHkgd2FzIGEg ZmFsc2UgcG9zaXRpdmUuCiAgICAgZWxpZiBpbmNsdWRlX3N0YXRlLnZpc2l0ZWRfcHJpbWFyeV9z ZWN0aW9uKCkgYW5kIHRhcmdldF9iYXNlID09IGluY2x1ZGVfYmFzZToKKyAgICAgICAgaWYgaW5j bHVkZSA9PSAiUmVzb3VyY2VIYW5kbGVXaW4uaCI6CisgICAgICAgICAgICAjIEZJWE1FOiBUaHVz IGZhciwgd2UndmUgb25seSBzZWVuIG9uZSBleGFtcGxlIG9mIHRoZXNlLCBidXQgaWYgd2UKKyAg ICAgICAgICAgICMgc3RhcnQgdG8gc2VlIG1vcmUsIHBsZWFzZSBjb25zaWRlciBnZW5lcmFsaXpp bmcgdGhpcyBjaGVjaworICAgICAgICAgICAgIyBzb21laG93LgorICAgICAgICAgICAgcmV0dXJu IF9PVEhFUl9IRUFERVIKICAgICAgICAgcmV0dXJuIF9QUklNQVJZX0hFQURFUgogCiAgICAgcmV0 dXJuIF9PVEhFUl9IRUFERVIKSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA1MzM5NCkK KysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0 LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yMTg3LDYgKzIxODcsMTIgQEAgY2xhc3MgT3JkZXJPZklu Y2x1ZGVzVGVzdChDcHBTdHlsZVRlc3RCYQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAnRm91bmQgaGVhZGVyIHRoaXMgZmlsZSBpbXBsZW1lbnRzIGFmdGVyIGEgaGVh ZGVyIHRoaXMgZmlsZSBpbXBsZW1lbnRzLicKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJyBTaG91bGQgYmU6IGNvbmZpZy5oLCBwcmltYXJ5IGhlYWRlciwgYmxhbmsg bGluZSwgYW5kIHRoZW4gYWxwaGFiZXRpY2FsbHkgc29ydGVkLicKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgJyAgW2J1aWxkL2luY2x1ZGVfb3JkZXJdIFs0XScpCisg ICAgICAgIHNlbGYuYXNzZXJ0X2xhbmd1YWdlX3J1bGVzX2NoZWNrKCdSZXNvdXJjZUhhbmRsZVdp bi5jcHAnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2luY2x1 ZGUgImNvbmZpZy5oIlxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAnI2luY2x1ZGUgIlJlc291cmNlSGFuZGxlLmgiXG4nCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICdcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJyNpbmNsdWRlICJSZXNvdXJjZUhhbmRsZVdpbi5oIlxuJywKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJycpCiAKICAgICBkZWYgdGVzdF90cnlfZHJv cF9jb21tb25fc3VmZml4ZXMoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoJ2Zvby9m b28nLCBjcHBfc3R5bGUuX2Ryb3BfY29tbW9uX3N1ZmZpeGVzKCdmb28vZm9vLWlubC5oJykpCg==