32969 2009-12-27 12:56:00 -0800 [Qt] Support upload progress events in XMLHttpRequest 2009-12-28 04:03:17 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P3 Normal --- 0 jwieczorek webkit-unassigned commit-queue tonikitoo webkit.review.bot oldest_to_newest 175081 0 jwieczorek 2009-12-27 12:56:00 -0800 To achieve that, the network layer needs to report upload progress to the client if requested (ResourceRequest::reportUploadProgress). 175083 1 45531 jwieczorek 2009-12-27 13:01:35 -0800 Created attachment 45531 proposed patch 175084 2 webkit.review.bot 2009-12-27 13:07:29 -0800 style-queue ran check-webkit-style on attachment 45531 without any errors. 175136 3 45531 eric 2009-12-27 19:29:56 -0800 Comment on attachment 45531 proposed patch Looks right as far as I can tell. 175139 4 45531 commit-queue 2009-12-27 19:39:13 -0800 Comment on attachment 45531 proposed patch Clearing flags on attachment: 45531 Committed r52590: <http://trac.webkit.org/changeset/52590> 175140 5 commit-queue 2009-12-27 19:39:17 -0800 All reviewed patches have been landed. Closing bug. 175212 6 tonikitoo 2009-12-28 04:03:17 -0800 (In reply to comment #3) > (From update of attachment 45531 [details]) > Looks right as far as I can tell. lgtm too. good catch 45531 2009-12-27 13:01:35 -0800 2009-12-27 19:39:13 -0800 proposed patch 0001-Qt-Support-upload-progress-events-in-XMLHttpRequest.patch text/plain 5483 jwieczorek RnJvbSBhZGRiMTQ3NGI3ZjA0NDhiYTA5YjNkOGQ2MzMyZjhlZDA3MGJhODUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWt1YiBXaWVjem9yZWsgPGZhdzIxN0BnbWFpbC5jb20+CkRh dGU6IFN1biwgMjcgRGVjIDIwMDkgMjE6NTc6MTggKzAwMDAKU3ViamVjdDogW1BBVENIXSBbUXRd IFN1cHBvcnQgdXBsb2FkIHByb2dyZXNzIGV2ZW50cyBpbiBYTUxIdHRwUmVxdWVzdAogaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyOTY5CgpNYWtlIFFOZXR3b3JrUmVw bHlIYW5kbGVyIHJlcG9ydCB0aGUgdXBsb2FkIHByb2dyZXNzIHRvIHRoZSBjbGllbnQuCgpBbHJl YWR5IGNvdmVyZWQgYnkgdGVzdHM6Cmh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvdXBsb2FkLW9u bG9hZC1ldmVudC5odG1sCmh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvdXBsb2FkLW9ubG9hZHN0 YXJ0LWV2ZW50Lmh0bWwKaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC91cGxvYWQtcHJvZ3Jlc3Mt ZXZlbnRzLmh0bWwKaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC91cGxvYWQtb25wcm9ncmVzcy1l dmVudC5odG1sCgp3aGljaCBoYXZlIGJlZW4gdW5za2lwcGVkLgotLS0KIExheW91dFRlc3RzL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxOSArKysrKysrKysrKysr KysrKwogTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCAgICAgICAgICAgICAgICAgICAg fCAgICAzIC0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB8ICAgMjIgKysrKysrKysrKysrKysrKysrKysKIC4uLi9wbGF0Zm9ybS9uZXR3b3JrL3F0 L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcCAgIHwgICAxNyArKysrKysrKysrKysrKysKIFdlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5oIHwgICAgMSArCiA1 IGZpbGVzIGNoYW5nZWQsIDU5IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IGFlNDQyOTguLmZlZTZiOTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0xMi0yNyAgSmFr dWIgV2llY3pvcmVrICA8ZmF3MjE3QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFN1cHBvcnQgdXBsb2FkIHByb2dyZXNzIGV2 ZW50cyBpbiBYTUxIdHRwUmVxdWVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzI5NjkKKworICAgICAgICBNYWtlIFFOZXR3b3JrUmVwbHlIYW5kbGVy IHJlcG9ydCB0aGUgdXBsb2FkIHByb2dyZXNzIHRvIHRoZSBjbGllbnQuCisKKyAgICAgICAgQWxy ZWFkeSBjb3ZlcmVkIGJ5IHRlc3RzOgorICAgICAgICBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0 L3VwbG9hZC1vbmxvYWQtZXZlbnQuaHRtbAorICAgICAgICBodHRwL3Rlc3RzL3htbGh0dHByZXF1 ZXN0L3VwbG9hZC1vbmxvYWRzdGFydC1ldmVudC5odG1sCisgICAgICAgIGh0dHAvdGVzdHMveG1s aHR0cHJlcXVlc3QvdXBsb2FkLXByb2dyZXNzLWV2ZW50cy5odG1sCisgICAgICAgIGh0dHAvdGVz dHMveG1saHR0cHJlcXVlc3QvdXBsb2FkLW9ucHJvZ3Jlc3MtZXZlbnQuaHRtbAorCisgICAgICAg IHdoaWNoIGhhdmUgYmVlbiB1bnNraXBwZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lw cGVkOgorCiAyMDA5LTEyLTI3ICBEaXJrIFNjaHVsemUgIDxrcml0QHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTmlrb2xhcyBaaW1tZXJtYW5uLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQKaW5kZXggNGRkMmI0Zi4uMmJiZGNlNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCkBAIC00 OTk4LDkgKzQ5OTgsNiBAQCBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3JlLWxvZ2luLWFzeW5j Lmh0bWwKIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmUtbG9naW4uaHRtbAogaHR0cC90ZXN0 cy94bWxodHRwcmVxdWVzdC9yZWRpcmVjdC1jcm9zcy1vcmlnaW4tdHJpcG1pbmUuaHRtbAogaHR0 cC90ZXN0cy94bWxodHRwcmVxdWVzdC9zdGF0ZS1hZnRlci1uZXR3b3JrLWVycm9yLmh0bWwKLWh0 dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvdXBsb2FkLW9ubG9hZC1ldmVudC5odG1sCi1odHRwL3Rl c3RzL3htbGh0dHByZXF1ZXN0L3VwbG9hZC1vbnByb2dyZXNzLWV2ZW50Lmh0bWwKLWh0dHAvdGVz dHMveG1saHR0cHJlcXVlc3QvdXBsb2FkLXByb2dyZXNzLWV2ZW50cy5odG1sCiBodHRwL3Rlc3Rz L3htbGh0dHByZXF1ZXN0L3dvcmtlcnMvbWV0aG9kcy1hc3luYy5odG1sCiBodHRwL3Rlc3RzL3ht bGh0dHByZXF1ZXN0L3dvcmtlcnMvbWV0aG9kcy5odG1sCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1 ZXN0L3dvcmtlcnMvc2hhcmVkLXdvcmtlci1tZXRob2RzLWFzeW5jLmh0bWwKZGlmZiAtLWdpdCBh L1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTFmM2RkMC4uNmFl OTI3ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwyNSBAQAorMjAwOS0xMi0yNyAgSmFrdWIgV2llY3pvcmVrICA8ZmF3MjE3 QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbUXRdIFN1cHBvcnQgdXBsb2FkIHByb2dyZXNzIGV2ZW50cyBpbiBYTUxIdHRwUmVxdWVz dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI5NjkK KworICAgICAgICBNYWtlIFFOZXR3b3JrUmVwbHlIYW5kbGVyIHJlcG9ydCB0aGUgdXBsb2FkIHBy b2dyZXNzIHRvIHRoZSBjbGllbnQuCisKKyAgICAgICAgQWxyZWFkeSBjb3ZlcmVkIGJ5IHRlc3Rz OgorICAgICAgICBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3VwbG9hZC1vbmxvYWQtZXZlbnQu aHRtbAorICAgICAgICBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3VwbG9hZC1vbmxvYWRzdGFy dC1ldmVudC5odG1sCisgICAgICAgIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvdXBsb2FkLXBy b2dyZXNzLWV2ZW50cy5odG1sCisgICAgICAgIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvdXBs b2FkLW9ucHJvZ3Jlc3MtZXZlbnQuaHRtbAorCisgICAgICAgIHdoaWNoIGhhdmUgYmVlbiB1bnNr aXBwZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5k bGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlFOZXR3b3JrUmVwbHlIYW5kbGVyOjp1cGxvYWRQ cm9ncmVzcyk6CisgICAgICAgIChXZWJDb3JlOjpRTmV0d29ya1JlcGx5SGFuZGxlcjo6c3RhcnQp OgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuaDoK KwogMjAwOS0xMi0yNyAgQ2hyaXN0aWFuIER5d2FuICA8Y2hyaXN0aWFuQHR3b3RvYXN0cy5kZT4K IAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAgYi9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwCmluZGV4IDFlZGM1YzYu LjU1OWVmODQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29y a1JlcGx5SGFuZGxlci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3 b3JrUmVwbHlIYW5kbGVyLmNwcApAQCAtMzgzLDYgKzM4MywxOCBAQCB2b2lkIFFOZXR3b3JrUmVw bHlIYW5kbGVyOjpmb3J3YXJkRGF0YSgpCiAgICAgfQogfQogCit2b2lkIFFOZXR3b3JrUmVwbHlI YW5kbGVyOjp1cGxvYWRQcm9ncmVzcyhxaW50NjQgYnl0ZXNTZW50LCBxaW50NjQgYnl0ZXNUb3Rh bCkKK3sKKyAgICBpZiAoIW1fcmVzb3VyY2VIYW5kbGUpCisgICAgICAgIHJldHVybjsKKworICAg IFJlc291cmNlSGFuZGxlQ2xpZW50KiBjbGllbnQgPSBtX3Jlc291cmNlSGFuZGxlLT5jbGllbnQo KTsKKyAgICBpZiAoIWNsaWVudCkKKyAgICAgICAgcmV0dXJuOworCisgICAgY2xpZW50LT5kaWRT ZW5kRGF0YShtX3Jlc291cmNlSGFuZGxlLCBieXRlc1NlbnQsIGJ5dGVzVG90YWwpOworfQorCiB2 b2lkIFFOZXR3b3JrUmVwbHlIYW5kbGVyOjpzdGFydCgpCiB7CiAgICAgbV9zaG91bGRTdGFydCA9 IGZhbHNlOwpAQCAtNDUyLDYgKzQ2NCwxMSBAQCB2b2lkIFFOZXR3b3JrUmVwbHlIYW5kbGVyOjpz dGFydCgpCiAgICAgY29ubmVjdChtX3JlcGx5LCBTSUdOQUwocmVhZHlSZWFkKCkpLAogICAgICAg ICAgICAgdGhpcywgU0xPVChmb3J3YXJkRGF0YSgpKSwgU0lHTkFMX0NPTk4pOwogCisgICAgaWYg KG1fcmVzb3VyY2VIYW5kbGUtPnJlcXVlc3QoKS5yZXBvcnRVcGxvYWRQcm9ncmVzcygpKSB7Cisg ICAgICAgIGNvbm5lY3QobV9yZXBseSwgU0lHTkFMKHVwbG9hZFByb2dyZXNzKHFpbnQ2NCwgcWlu dDY0KSksCisgICAgICAgICAgICAgICAgdGhpcywgU0xPVCh1cGxvYWRQcm9ncmVzcyhxaW50NjQs IHFpbnQ2NCkpLCBTSUdOQUxfQ09OTik7CisgICAgfQorCiAgICAgLy8gTWFrZSB0aGlzIGEgZGly ZWN0IGZ1bmN0aW9uIGNhbGwgb25jZSB3ZSByZXF1aXJlIDQuNi4xKy4KICAgICBjb25uZWN0KHRo aXMsIFNJR05BTChwcm9jZXNzUXVldWVkSXRlbXMoKSksCiAgICAgICAgICAgICB0aGlzLCBTTE9U KHNlbmRRdWV1ZWRJdGVtcygpKSwgU0lHTkFMX0NPTk4pOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmggYi9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuaAppbmRleCAyMTcxMDgzLi5lYjVh ZTNjIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBs eUhhbmRsZXIuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBs eUhhbmRsZXIuaApAQCAtNjIsNiArNjIsNyBAQCBwcml2YXRlIHNsb3RzOgogICAgIHZvaWQgc2Vu ZFJlc3BvbnNlSWZOZWVkZWQoKTsKICAgICB2b2lkIGZvcndhcmREYXRhKCk7CiAgICAgdm9pZCBz ZW5kUXVldWVkSXRlbXMoKTsKKyAgICB2b2lkIHVwbG9hZFByb2dyZXNzKHFpbnQ2NCBieXRlc1Nl bnQsIHFpbnQ2NCBieXRlc1RvdGFsKTsKIAogcHJpdmF0ZToKICAgICB2b2lkIHN0YXJ0KCk7Ci0t IAoxLjYuNS41Cgo=