32964 2009-12-27 10:59:49 -0800 [bzt] Update unit test to check for added --makeargs="-j8" command-line argument 2009-12-27 11:13:42 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates webkit-unassigned abarth eric webkit.review.bot oldest_to_newest 175058 0 dbates 2009-12-27 10:59:49 -0800 In the patch for bug #32951, the command-line argument --makeargs="-j8" was added to the build-webkit command. However, the associated unit test was not updated. For reference, the error message output by run-webkit-unittests is: ====================================================================== FAIL: test_qt_port (modules.webkitport_unittest.WebKitPortTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dbates/Desktop/WebKit/WebKitTools/Scripts/modules/webkitport_unittest.py", line 51, in test_qt_port self.assertEquals(QtPort.build_webkit_command(), [WebKitPort.script_path("build-webkit"), "--qt"]) AssertionError: ['WebKitTools/Scripts/build-webkit', '--qt', '--makeargs="-j8"'] != ['WebKitTools/Scripts/build-webkit', '--qt'] 175059 1 45526 dbates 2009-12-27 11:01:25 -0800 Created attachment 45526 Patch 175063 2 webkit.review.bot 2009-12-27 11:03:32 -0800 style-queue ran check-webkit-style on attachment 45526 without any errors. 175068 3 45526 eric 2009-12-27 11:09:19 -0800 Comment on attachment 45526 Patch Eseidel and abarth fail. We need to make the commit queue call run-webkit-unittests 175070 4 dbates 2009-12-27 11:13:42 -0800 Committed in <http://trac.webkit.org/changeset/52582>. 45526 2009-12-27 11:01:25 -0800 2009-12-27 11:09:18 -0800 Patch Bug32964.patch text/plain 1621 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUyNTgxKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTItMjcgIERhbmllbCBCYXRlcyAgPGRi YXRlc0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjk2NAor CisgICAgICAgIFtienRdIFVwZGF0ZWQgdGhlIHVuaXQgdGVzdCBiYXNlZCBvbiB0aGUgY2hhbmdl IG1hZGUgaW4gYnVnICMzMjk1MS4KKworICAgICAgICBUaGUgY2hhbmdlIG1hZGUgaW4gYnVnICMz Mjk1MSBhZGRlZCB0aGUgY29tbWFuZC1saW5lIGFyZ3VtZW50OgorICAgICAgICAtLW1ha2Vhcmdz PSItajgiIHRvIHRoZSBidWlsZC13ZWJraXQgY29tbWFuZC4gSG93ZXZlciwgdGhlIGFzc29jaWF0 ZWQKKyAgICAgICAgdW5pdCB0ZXN0IHdhcyBub3QgdXBkYXRlZC4KKworICAgICAgICAqIFNjcmlw dHMvbW9kdWxlcy93ZWJraXRwb3J0X3VuaXR0ZXN0LnB5OgorCiAyMDA5LTEyLTI3ICBZYWVsIEFo YXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJp biBBZGxlci4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy93ZWJraXRwb3J0X3Vu aXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy93ZWJr aXRwb3J0X3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA1MjU4MSkKKysrIFdlYktpdFRvb2xzL1Njcmlw dHMvbW9kdWxlcy93ZWJraXRwb3J0X3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC00OCw3 ICs0OCw3IEBAIGNsYXNzIFdlYktpdFBvcnRUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAg ICAgc2VsZi5hc3NlcnRFcXVhbHMoUXRQb3J0Lm5hbWUoKSwgIlF0IikKICAgICAgICAgc2VsZi5h c3NlcnRFcXVhbHMoUXRQb3J0LmZsYWcoKSwgIi0tcG9ydD1xdCIpCiAgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWxzKFF0UG9ydC5ydW5fd2Via2l0X3Rlc3RzX2NvbW1hbmQoKSwgW1dlYktpdFBvcnQu c2NyaXB0X3BhdGgoInJ1bi13ZWJraXQtdGVzdHMiKV0pCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWxzKFF0UG9ydC5idWlsZF93ZWJraXRfY29tbWFuZCgpLCBbV2ViS2l0UG9ydC5zY3JpcHRfcGF0 aCgiYnVpbGQtd2Via2l0IiksICItLXF0Il0pCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKFF0 UG9ydC5idWlsZF93ZWJraXRfY29tbWFuZCgpLCBbV2ViS2l0UG9ydC5zY3JpcHRfcGF0aCgiYnVp bGQtd2Via2l0IiksICItLXF0IiwgJy0tbWFrZWFyZ3M9Ii1qOCInXSkKIAogICAgIGRlZiB0ZXN0 X2Nocm9taXVtX3BvcnQoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKENocm9taXVt UG9ydC5uYW1lKCksICJDaHJvbWl1bSIpCg==