32962 2009-12-27 06:57:25 -0800 HTML tags are wrongfully parsed when setting innerHTML of a SCRIPT element 2010-01-08 16:30:35 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED http://netro.fileave.com/webkitbug1.html P2 Major --- 1 jenseki.netro ap ap webkit.review.bot oldest_to_newest 175040 0 jenseki.netro 2009-12-27 06:57:25 -0800 Not working with Chrome 4 (dev channel) and Safari 3.2.2 Working with Firefox 3.5 Go to the URL. Check the DOM. Compare it with http://netro.fileave.com/webkitbug2.html. The bug is caused by the "<" character in webkitbug1.html's string variable temp. When the created script element is appended, its innerHTML treats /<.*>/ as HTML tags. And this causes the error. 175116 1 ap 2009-12-27 18:03:37 -0800 An obvious workaround is to use textContent instead of innerHTML (innerText also works, but it's not supported by Firefox). 175117 2 45539 ap 2009-12-27 18:04:13 -0800 Created attachment 45539 test case 178456 3 46100 ap 2010-01-07 17:22:21 -0800 Created attachment 46100 proposed fix This fixes the problem for SCRIPT and STLYE elements (actually, we didn't support setting innerHTML for style at all before). I'm not sure if any other elements need this treatment - Firefox behavior seems somewhat confused, as it applies it to NOSCRIPT for whatever reason. 178459 4 webkit.review.bot 2010-01-07 17:25:39 -0800 style-queue ran check-webkit-style on attachment 46100 without any errors. 178871 5 ap 2010-01-08 16:30:35 -0800 Committed <http://trac.webkit.org/changeset/53023>. 45539 2009-12-27 18:04:13 -0800 2009-12-27 18:04:13 -0800 test case webkitbug1.html text/html 220 ap PGJvZHk+DQo8cD5TaG91bGQgc2F5IFBBU1M6PC9wPg0KPGRpdiBpZD0idGVzdCI+PC9kaXY+DQo8 c2NyaXB0Pg0KdmFyIGU9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3NjcmlwdCcpOw0KZS5pbm5l ckhUTUw9ICJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdCcpLmlubmVySFRNTD0nPHA+UEFT Uyc7IjsNCmRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZSk7DQo8L3NjcmlwdD4NCg== 46100 2010-01-07 17:22:21 -0800 2010-01-08 16:11:53 -0800 proposed fix innerHTML-text.txt text/plain 6661 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Mjk2MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzEgQEAKKzIwMTAtMDEtMDcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyOTYyCisgICAgICAgIEhU TUwgdGFncyBhcmUgd3JvbmdmdWxseSBwYXJzZWQgd2hlbiBzZXR0aW5nIGlubmVySFRNTCBvZiBh IFNDUklQVCBlbGVtZW50CisKKyAgICAgICAgQWxzbyBmaXhlZCB0aGUgc2FtZSBmb3Igc3R5bGUg ZWxlbWVudHMuCisKKyAgICAgICAgVGVzdHM6IGZhc3QvZG9tL2Nzcy1pbm5lckhUTUwuaHRtbAor ICAgICAgICAgICAgICAgZmFzdC9kb20vc2NyaXB0LWlubmVySFRNTC14LnhodG1sCisgICAgICAg ICAgICAgICBmYXN0L2RvbS9zY3JpcHQtaW5uZXJIVE1MLmh0bWwKKworICAgICAgICAqIGh0bWwv SFRNTEVsZW1lbnQuY3BwOiAoV2ViQ29yZTo6SFRNTEVsZW1lbnQ6OnNldElubmVySFRNTCk6IERv bid0IHBhcnNlIEpTIG9yIENTUyBhcyBIVE1MLAorICAgICAgICBtYXRjaGluZyBGaXJlZm94Lgor CisyMDEwLTAxLTA3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBk ZXNjcmlwdGlvbiBhbmQgYnVnIFVSTCAoT09QUyEpCisKKyAgICAgICAgVGVzdHM6IGZhc3QvZG9t L2Nzcy1pbm5lckhUTUwuaHRtbAorICAgICAgICAgICAgICAgZmFzdC9kb20vc2NyaXB0LWlubmVy SFRNTC5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxFbGVtZW50OjpzZXRJbm5lckhUTUwpOgorCiAyMDEwLTAxLTA3ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdl aW5pZy4KSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNwcAkocmV2aXNpb24gNTI4NjcpCisrKyBXZWJDb3Jl L2h0bWwvSFRNTEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNDYsNiArMzQ2LDEzIEBA IHN0YXRpYyB2b2lkIHJlcGxhY2VDaGlsZHJlbldpdGhUZXh0KEhUTUwKIAogdm9pZCBIVE1MRWxl bWVudDo6c2V0SW5uZXJIVE1MKGNvbnN0IFN0cmluZyYgaHRtbCwgRXhjZXB0aW9uQ29kZSYgZWMp CiB7CisgICAgaWYgKGhhc0xvY2FsTmFtZShzY3JpcHRUYWcpIHx8IGhhc0xvY2FsTmFtZShzdHls ZVRhZykpIHsKKyAgICAgICAgLy8gU2NyaXB0IGFuZCBDU1Mgc291cmNlIHNob3VsZG4ndCBiZSBw YXJzZWQgYXMgSFRNTC4KKyAgICAgICAgcmVtb3ZlQ2hpbGRyZW4oKTsKKyAgICAgICAgYXBwZW5k Q2hpbGQoZG9jdW1lbnQoKS0+Y3JlYXRlVGV4dE5vZGUoaHRtbCksIGVjKTsKKyAgICAgICAgcmV0 dXJuOworICAgIH0KKwogICAgIFJlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBmcmFnbWVudCA9IGNy ZWF0ZUNvbnRleHR1YWxGcmFnbWVudChodG1sKTsKICAgICBpZiAoIWZyYWdtZW50KSB7CiAgICAg ICAgIGVjID0gTk9fTU9ESUZJQ0FUSU9OX0FMTE9XRURfRVJSOwpJbmRleDogTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g NTI5NjMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNyBAQAorMjAxMC0wMS0wNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI5NjIKKyAgICAgICAgSFRNTCB0YWdz IGFyZSB3cm9uZ2Z1bGx5IHBhcnNlZCB3aGVuIHNldHRpbmcgaW5uZXJIVE1MIG9mIGEgU0NSSVBU IGVsZW1lbnQKKworICAgICAgICAqIGZhc3QvZG9tL2Nzcy1pbm5lckhUTUwtZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9jc3MtaW5uZXJIVE1MLmh0bWw6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvZG9tL3NjcmlwdC1pbm5lckhUTUwtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBmYXN0L2RvbS9zY3JpcHQtaW5uZXJIVE1MLXgtZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBmYXN0L2RvbS9zY3JpcHQtaW5uZXJIVE1MLXgueGh0bWw6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvZG9tL3NjcmlwdC1pbm5lckhUTUwuaHRtbDogQWRkZWQuCisKIDIwMTAt MDEtMDcgIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGlyayBTY2h1bHplLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20v Y3NzLWlubmVySFRNTC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFz dC9kb20vY3NzLWlubmVySFRNTC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9jc3MtaW5uZXJIVE1MLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAg LTAsMCArMSwzIEBACitTaG91bGQgc2F5IFBBU1M6CisKK1BBU1MKClByb3BlcnR5IGNoYW5nZXMg b246IExheW91dFRlc3RzL2Zhc3QvZG9tL2Nzcy1pbm5lckhUTUwtZXhwZWN0ZWQudHh0Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KTmFtZTogc3ZuOm1pbWUtdHlwZQogICArIHRleHQvcGxhaW4KTmFtZTogc3ZuOmVvbC1z dHlsZQogICArIG5hdGl2ZQoKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL2Nzcy1pbm5lckhU TUwuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9jc3MtaW5uZXJIVE1M Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9jc3MtaW5uZXJIVE1M Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKzxib2R5PgorPHA+U2hvdWxkIHNh eSBQQVNTOjwvcD4KKzxkaXYgaWQ9InRlc3QiPjwvZGl2PgorPHNjcmlwdD4KK2lmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4 dCgpOworCit2YXIgZT0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnc3R5bGUnKTsKK2UuaW5uZXJI VE1MPSAiPHA+Zm9vYmFyPC9wPiI7IC8vIHllcywgdGhhdCdzIGludmFsaWQgQ1NTCitkb2N1bWVu dC5ib2R5LmFwcGVuZENoaWxkKGUpOworLy8gSWYgaXQgd2VyZSBwYXJzZWQsIGl0IHdvdWxkIGhh dmUgYmVlbiBqdXN0ICJmb29iYXIiLgorZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3QiKS5p bm5lckhUTUwgPSAoZS50ZXh0Q29udGVudCA9PSAiPHA+Zm9vYmFyPC9wPiIpID8gIlBBU1MiIDog IkZBSUwiOworPC9zY3JpcHQ+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0 L2RvbS9jc3MtaW5uZXJIVE1MLmh0bWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAg ICsgdGV4dC9odG1sCgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vc2NyaXB0LWlubmVySFRN TC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vc2NyaXB0 LWlubmVySFRNTC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2RvbS9zY3JpcHQtaW5uZXJIVE1MLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwzIEBACitTaG91bGQgc2F5IFBBU1M6CisKK1BBU1MKClByb3BlcnR5IGNoYW5nZXMgb246IExh eW91dFRlc3RzL2Zhc3QvZG9tL3NjcmlwdC1pbm5lckhUTUwtZXhwZWN0ZWQudHh0Cl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTmFtZTogc3ZuOm1pbWUtdHlwZQogICArIHRleHQvcGxhaW4KTmFtZTogc3ZuOmVvbC1zdHls ZQogICArIG5hdGl2ZQoKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL3NjcmlwdC1pbm5lckhU TUwteC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vc2Ny aXB0LWlubmVySFRNTC14LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2Zhc3QvZG9tL3NjcmlwdC1pbm5lckhUTUwteC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMyBAQAorU2hvdWxkIHNheSBQQVNTOgorCitQQVNTCgpQcm9wZXJ0eSBjaGFuZ2Vz IG9uOiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9zY3JpcHQtaW5uZXJIVE1MLXgtZXhwZWN0ZWQudHh0 Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KTmFtZTogc3ZuOm1pbWUtdHlwZQogICArIHRleHQvcGxhaW4KTmFtZTogc3Zu OmVvbC1zdHlsZQogICArIG5hdGl2ZQoKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL3Njcmlw dC1pbm5lckhUTUwteC54aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9z Y3JpcHQtaW5uZXJIVE1MLXgueGh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2RvbS9zY3JpcHQtaW5uZXJIVE1MLXgueGh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTcg QEAKKzxodG1sICB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+Cis8Ym9keT4K KzxwPlNob3VsZCBzYXkgUEFTUzo8L3A+Cis8ZGl2IGlkPSJ0ZXN0Ij48L2Rpdj4KKzxzY3JpcHQ+ PCFbQ0RBVEFbCitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRl c3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKwordmFyIHRhZ1N0cmluZyA9ICJkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgndGVzdCcpLmlubmVySFRNTD0nPHA+UEFTUzwvcD4nOyI7Cit2YXIgZT0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnc2NyaXB0Jyk7Citkb2N1bWVudC5ib2R5LmFwcGVuZENo aWxkKGUpOworCitlLmlubmVySFRNTCA9IHRhZ1N0cmluZzsKK11dPgorPC9zY3JpcHQ+Cis8L2Jv ZHk+Cis8L2h0bWw+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9z Y3JpcHQtaW5uZXJIVE1MLXgueGh0bWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAg ICsgdGV4dC94bWwKCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9zY3JpcHQtaW5uZXJIVE1M Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vc2NyaXB0LWlubmVySFRN TC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vc2NyaXB0LWlubmVy SFRNTC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDExIEBACis8Ym9keT4KKzxwPlNob3Vs ZCBzYXkgUEFTUzo8L3A+Cis8ZGl2IGlkPSJ0ZXN0Ij48L2Rpdj4KKzxzY3JpcHQ+CitpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBB c1RleHQoKTsKKwordmFyIGU9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3NjcmlwdCcpOworZS5p bm5lckhUTUw9ICJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdCcpLmlubmVySFRNTD0nPHA+ UEFTUyc7IjsKK2RvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZSk7Cis8L3NjcmlwdD4KClByb3Bl cnR5IGNoYW5nZXMgb246IExheW91dFRlc3RzL2Zhc3QvZG9tL3NjcmlwdC1pbm5lckhUTUwuaHRt bApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0L2h0bWwKCg==