32940 2009-12-25 13:27:38 -0800 [GTK] Progress notification update taking longer 2009-12-28 08:49:11 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 tevaum webkit-unassigned abarth commit-queue eric gustavo webkit.review.bot oldest_to_newest 174894 0 tevaum 2009-12-25 13:27:38 -0800 The progress notification in WebKit GTK implementation is throttled in order to consume less CPU. Although it's not updating properly. Sometimes it takes a long time to show statuses updates (only working after passing 3% of the download). To some file sizes it's a pain not to know if the download is properly occuring. 174903 1 45500 tevaum 2009-12-25 15:23:06 -0800 Created attachment 45500 Changing the download throttle conditions This patch is a proposal for changing the download notification throttle. The changes are quite simple: The code only updates lastElapsed when a progress notification occurs. If we passed the lastElapsed by more then 0.7 secs from now, we notify again. I added another static variable, lastNotifiedProgress, that holds the value of the last notified progress. If we passed more than 1% of the last notified progress, we notify again. I must state that this patch is not the final one. I think it's important that some of you guys try this patch to see if it's good or if we need to think a better way to do this throttle. 174904 2 webkit.review.bot 2009-12-25 15:27:53 -0800 Attachment 45500 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/gtk/webkit/webkitdownload.cpp:867: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebKit/gtk/webkit/webkitdownload.cpp:868: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 2 174909 3 45501 tevaum 2009-12-25 16:20:50 -0800 Created attachment 45501 New version of throttle conditions Another version of the patch respecting the coding conventions and calling less functions 174910 4 webkit.review.bot 2009-12-25 16:23:35 -0800 style-queue ran check-webkit-style on attachment 45501 without any errors. 174912 5 45501 gustavo 2009-12-25 16:50:57 -0800 Comment on attachment 45501 New version of throttle conditions ok, two more things - I would preffer if you said in the ChangeLog why you are doing the change (i.e., to fix the notification being bumpy), and second, the && operators should be at the end of the previous line, not at the beggining of the next line (I wrote it wrongly at first ;D). THanks. 174913 6 gustavo 2009-12-25 16:51:53 -0800 (In reply to comment #5) > (From update of attachment 45501 [details]) > ok, two more things - I would preffer if you said in the ChangeLog why you are > doing the change (i.e., to fix the notification being bumpy), and second, the > && operators should be at the end of the previous line, not at the beggining of > the next line (I wrote it wrongly at first ;D). THanks. ok, ignore the && one /me hits his head on the keyboard 174916 7 45503 tevaum 2009-12-25 17:04:57 -0800 Created attachment 45503 Conforming with comment #5 175014 8 45503 commit-queue 2009-12-27 01:03:49 -0800 Comment on attachment 45503 Conforming with comment #5 Rejecting patch 45503 from commit-queue. Unexpected failure when landing patch! Please file a bug against bugzilla-tool. Failed to run "['WebKitTools/Scripts/bugzilla-tool', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '45503']" exit_code: 1 Last 500 characters of output: ) File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/statusbot.py", line 73, in update_status response = self.browser.submit() File "build/bdist.macosx-10.5-i386/egg/mechanize/_mechanize.py", line 547, in submit File "build/bdist.macosx-10.5-i386/egg/mechanize/_mechanize.py", line 209, in open File "build/bdist.macosx-10.5-i386/egg/mechanize/_mechanize.py", line 261, in _mech_open mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error 175069 9 45503 gustavo 2009-12-27 11:10:46 -0800 Comment on attachment 45503 Conforming with comment #5 Let's see if that was a temporary problem. 175071 10 45503 commit-queue 2009-12-27 11:24:38 -0800 Comment on attachment 45503 Conforming with comment #5 Rejecting patch 45503 from commit-queue. Unexpected failure when landing patch! Please file a bug against bugzilla-tool. Failed to run "['WebKitTools/Scripts/bugzilla-tool', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '45503']" exit_code: 1 Last 500 characters of output: ) File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/statusbot.py", line 73, in update_status response = self.browser.submit() File "build/bdist.macosx-10.5-i386/egg/mechanize/_mechanize.py", line 547, in submit File "build/bdist.macosx-10.5-i386/egg/mechanize/_mechanize.py", line 209, in open File "build/bdist.macosx-10.5-i386/egg/mechanize/_mechanize.py", line 261, in _mech_open mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error 175121 11 abarth 2009-12-27 18:12:02 -0800 Eric, this is a strange commit-queue message 175122 12 45503 eric 2009-12-27 18:17:51 -0800 Comment on attachment 45503 Conforming with comment #5 This is just app engine giving us 500 errors as it does. We should be catching these, but I expect this is a temporary error. I'll file a bug about it. 175124 13 eric 2009-12-27 18:21:11 -0800 Filed bug 32976 about handling the 500 errors better. 175126 14 45503 commit-queue 2009-12-27 18:31:00 -0800 Comment on attachment 45503 Conforming with comment #5 Rejecting patch 45503 from commit-queue. Unexpected failure when landing patch! Please file a bug against bugzilla-tool. Failed to run "['WebKitTools/Scripts/bugzilla-tool', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '45503']" exit_code: 1 Last 500 characters of output: ) File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/statusbot.py", line 73, in update_status response = self.browser.submit() File "build/bdist.macosx-10.5-i386/egg/mechanize/_mechanize.py", line 547, in submit File "build/bdist.macosx-10.5-i386/egg/mechanize/_mechanize.py", line 209, in open File "build/bdist.macosx-10.5-i386/egg/mechanize/_mechanize.py", line 261, in _mech_open mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error 175127 15 eric 2009-12-27 18:38:25 -0800 Adam suggests the commit-queue might be trying to post a huge log to the server, or that in some way the log it is posting is causing a failure. I can look at the log on the server, sec. 175128 16 eric 2009-12-27 18:54:02 -0800 The failure it's actually hitting is: Failed to run "['svn', 'commit', '-m', '2009-12-27 Est\xc3\xaav\xc3\xa3o Samuel Proc\xc3\xb3pio <tevaum@gmail.com>\n\n Reviewed by noone (OOPS!).\n\n Bug 32940: [GTK] Changing the download throttle conditions.\n https://bugs.webkit.org/show_bug.cgi?id=32716\n\n The WebKitDownload progress notification was taking long to\n update. This fix makes notification happens each 0.7 secs\n or when the progress ups in 1%.\n\n * WebKit/gtk/webkit/webkitdownload.cpp:\n']" exit_code: 1 I suspect there may be an encoding issue. 175129 17 eric 2009-12-27 19:01:33 -0800 Bug 26927 and bug 32343 are related to this type of failure. 175131 18 eric 2009-12-27 19:03:02 -0800 I got my comments out of order, but here: Oh. Well, the ChangeLog has also been edited, so svn commit is likely rejecting it due to having OOPS! in the ChangeLog because it couldn't find "NOBODY(OOPS!)" to replace with the reviewer. So the cq- is correct, this can't be landed via the commit queue. There also might be encoding failures at play here, not sure. 175132 19 tevaum 2009-12-27 19:06:22 -0800 (In reply to comment #18) > So the cq- is correct, this can't be landed via the commit queue. There also > might be encoding failures at play here, not sure. Well... I'll take a look at the changelog and encoding stuff and submit another patch. I committed locally before running prepare-Changelog... That's why it's screwed. Sorry for the trouble... :] 175133 20 eric 2009-12-27 19:08:14 -0800 The only problem with this patch that I can see is that you changed the "Reviewed by" line from the default prepare-ChangeLog template. You replaced "NOBODY" with "noone". Yes, it's lame that our scripts depend on that, but for now they do. :( If you fix the NOBODY bit in the ChangeLog and re-submit a patch then the commit-queue should work just fine. 175134 21 45540 tevaum 2009-12-27 19:12:19 -0800 Created attachment 45540 patch with right ChangeLog 175135 22 webkit.review.bot 2009-12-27 19:13:44 -0800 style-queue ran check-webkit-style on attachment 45540 without any errors. 175214 23 45540 commit-queue 2009-12-28 05:46:55 -0800 Comment on attachment 45540 patch with right ChangeLog Rejecting patch 45540 from commit-queue. Unexpected failure when landing patch! Please file a bug against bugzilla-tool. Failed to run "['WebKitTools/Scripts/bugzilla-tool', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '45540']" exit_code: 1 Last 500 characters of output: 134, in fetch_attachments_from_bug bug = self.fetch_bug(bug_id) File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/bugzilla.py", line 130, in fetch_bug return self._parse_bug_page(page) File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/bugzilla.py", line 123, in _parse_bug_page bug["attachments"] = [self._parse_attachment_element(element, bug_id) for element in soup.findAll('attachment')] NameError: global name 'bug_id' is not defined 175228 24 abarth 2009-12-28 08:28:49 -0800 The rejection is due to a regression Eric introduced last night. The bug has been fixed but Eric might need to kick the commit-queue. 175232 25 45540 eric 2009-12-28 08:35:50 -0800 Comment on attachment 45540 patch with right ChangeLog Sorry, I broke the commit-queue, but Adam fixed it in http://trac.webkit.org/changeset/52595. Its working again now. Apologies for the trouble. 175234 26 45540 commit-queue 2009-12-28 08:49:05 -0800 Comment on attachment 45540 patch with right ChangeLog Clearing flags on attachment: 45540 Committed r52597: <http://trac.webkit.org/changeset/52597> 175235 27 commit-queue 2009-12-28 08:49:11 -0800 All reviewed patches have been landed. Closing bug. 45500 2009-12-25 15:23:06 -0800 2009-12-25 16:20:50 -0800 Changing the download throttle conditions 0001-Only-updates-time-and-progress-information-when-noti.patch text/plain 1937 tevaum RnJvbSA5ZWVkOWFiZTg4ZDBhMTIwYTRkMTg5Njc3NTAyOTNmOTdjYzlkYjY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RXN0PUMzPUFBdj1DMz1BM289MjBTYW11ZWw9 MjBQcm9jPUMzPUIzcGlvPz0gPHRldmF1bUBnbWFpbC5jb20+CkRhdGU6IEZyaSwgMjUgRGVjIDIw MDkgMTk6Mzc6NDEgLTAyMDAKU3ViamVjdDogW1BBVENIXSBPbmx5IHVwZGF0ZXMgdGltZSBhbmQg cHJvZ3Jlc3MgaW5mb3JtYXRpb24gd2hlbiBub3RpZmljYXRpb24gb2NjdXJzCgotLS0KIFdlYktp dC9ndGsvd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcCB8ICAgMTYgKysrKysrKysrKy0tLS0tLQog MSBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcCBiL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcAppbmRleCBhMWI2NGUwLi4wY2UzZTk2IDEwMDY0NAot LS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9hZC5jcHAKKysrIGIvV2ViS2l0L2d0 ay93ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwCkBAIC04NTcsMTkgKzg1NywyMyBAQCBzdGF0aWMg dm9pZCB3ZWJraXRfZG93bmxvYWRfcmVjZWl2ZWRfZGF0YShXZWJLaXREb3dubG9hZCogZG93bmxv YWQsIGNvbnN0IGdjaGFyKgogICAgIGdkb3VibGUgbGFzdFByb2dyZXNzID0gd2Via2l0X2Rvd25s b2FkX2dldF9wcm9ncmVzcyhkb3dubG9hZCk7CiAKICAgICAvLyBUaHJvdHRsZSBwcm9ncmVzcyBu b3RpZmljYXRpb24gdG8gbm90IGNvbnN1bWUgaGlnaCBhbW91bnRzIG9mCi0gICAgLy8gQ1BVIG9u IGZhc3QgbGlua3MsIGV4Y2VwdCB3aGVuIHRoZSBwcm9ncmVzcyBpcyA+PSAzJSwgb3Igd2UKLSAg ICAvLyByZWFjaGVkIHRoZSBlbmQuCisgICAgLy8gQ1BVIG9uIGZhc3QgbGlua3MsIGV4Y2VwdCB3 aGVuIHRoZSBsYXN0IG5vdGlmaWNhdGlvbiBvY2N1cmVkCisgICAgLy8gaW4gbW9yZSB0aGVuIDAu NyBzZWNzIGZyb20gbm93LCBvciB0aGUgbGFzdCBub3RpZmllZCBwcm9ncmVzcworICAgIC8vIGlz IHBhc3NlZCBpbiAxJSBvciB3ZSByZWFjaGVkIHRoZSBlbmQuCisgICAgc3RhdGljIGdkb3VibGUg bGFzdE5vdGlmaWVkUHJvZ3Jlc3MgPSAwOwogICAgIHN0YXRpYyBnZG91YmxlIGxhc3RFbGFwc2Vk ID0gMDsKICAgICBnZG91YmxlIGN1cnJlbnRFbGFwc2VkID0gZ190aW1lcl9lbGFwc2VkKHByaXYt PnRpbWVyLCBOVUxMKTsKIAotICAgIGlmIChsYXN0RWxhcHNlZAotICAgICAgICAmJiAoY3VycmVu dEVsYXBzZWQgLSBsYXN0RWxhcHNlZCkgPCAwLjEKLSAgICAgICAgJiYgKHdlYmtpdF9kb3dubG9h ZF9nZXRfcHJvZ3Jlc3MoZG93bmxvYWQpIC0gbGFzdFByb2dyZXNzKSA8IDAuMDMKKyAgICBpZiAo bGFzdEVsYXBzZWQgJiYKKyAgICAgICAgbGFzdE5vdGlmaWVkUHJvZ3Jlc3MgJiYKKyAgICAgICAg JiYgKGN1cnJlbnRFbGFwc2VkIC0gbGFzdEVsYXBzZWQpIDwgMC43CisgICAgICAgICYmICh3ZWJr aXRfZG93bmxvYWRfZ2V0X3Byb2dyZXNzKGRvd25sb2FkKSAtIGxhc3ROb3RpZmllZFByb2dyZXNz KSA8IDAuMDEKICAgICAgICAgJiYgd2Via2l0X2Rvd25sb2FkX2dldF9wcm9ncmVzcyhkb3dubG9h ZCkgPCAxLjApIHsKLSAgICAgICAgbGFzdEVsYXBzZWQgPSBjdXJyZW50RWxhcHNlZDsKICAgICAg ICAgcmV0dXJuOwogICAgIH0KICAgICBsYXN0RWxhcHNlZCA9IGN1cnJlbnRFbGFwc2VkOworICAg IGxhc3ROb3RpZmllZFByb2dyZXNzID0gbGFzdFByb2dyZXNzOworICAgIGxhc3RQcm9ncmVzcyA9 IHdlYmtpdF9kb3dubG9hZF9nZXRfcHJvZ3Jlc3MoZG93bmxvYWQpOwogCiAgICAgZ19vYmplY3Rf bm90aWZ5KEdfT0JKRUNUKGRvd25sb2FkKSwgInByb2dyZXNzIik7CiB9Ci0tIAoxLjYuNS43Cgo= 45501 2009-12-25 16:20:50 -0800 2009-12-25 17:04:57 -0800 New version of throttle conditions 0001-Only-updates-time-and-progress-information-when-noti.patch text/plain 2949 tevaum RnJvbSA5NmRmNTVkOWYzODIxZmFjZmQ1NWVmNGI4ZTc4MTVhOWI0YzcwZjFlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RXN0PUMzPUFBdj1DMz1BM289MjBTYW11ZWw9 MjBQcm9jPUMzPUIzcGlvPz0gPHRldmF1bUBnbWFpbC5jb20+CkRhdGU6IEZyaSwgMjUgRGVjIDIw MDkgMTk6Mzc6NDEgLTAyMDAKU3ViamVjdDogW1BBVENIXSBPbmx5IHVwZGF0ZXMgdGltZSBhbmQg cHJvZ3Jlc3MgaW5mb3JtYXRpb24gd2hlbiBub3RpZmljYXRpb24gb2NjdXJzCgotLS0KIENoYW5n ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKysrKysrKysrCiBX ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9hZC5jcHAgfCAgIDE4ICsrKysrKysrKystLS0t LS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzNTk1NTA4Li42NDRjOWEx IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMDktMTItMjUgIEVzdMOqdsOjbyBTYW11ZWwgUHJvY8OzcGlvICA8dGV2YXVtQGdtYWlsLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBub29uZSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAz Mjk0MDogW0dUS10gQ2hhbmdpbmcgdGhlIGRvd25sb2FkIHRocm90dGxlIGNvbmRpdGlvbnMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjcxNgorCisg ICAgICAgIFRoZSBjb2RlIG9ubHkgdXBkYXRlcyBsYXN0RWxhcHNlZCB3aGVuIGEgcHJvZ3Jlc3Mg bm90aWZpY2F0aW9uIG9jY3Vycy4KKyAgICAgICAgSWYgd2UgcGFzc2VkIHRoZSBsYXN0RWxhcHNl ZCBieSBtb3JlIHRoZW4gMC43IHNlY3MgZnJvbSBub3csIHdlIG5vdGlmeQorICAgICAgICBhZ2Fp bi4gVGhlIHZhcmlhYmxlIGxhc3RQcm9ncmVzcyB3YXMgbWFkZSBzdGF0aWMgYW5kIHVwZGF0ZWQg aW4gdGhlCisgICAgICAgIHNhbWUgd2F5IHRoYXQgbGFzdEVsYXNwZWQgaXMuIElmIHdlIHBhc3Nl ZCBtb3JlIHRoYW4gMSUgb2YgdGhlCisgICAgICAgIGxhc3RQcm9ncmVzcywgd2Ugbm90aWZ5IGFn YWluLgorCisgICAgICAgICogV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwOgor CiAyMDA5LTEyLTIyICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4K IAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBIb2xnZXIgRnJleXRoZXIuCmRpZmYgLS1naXQg YS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9hZC5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXRkb3dubG9hZC5jcHAKaW5kZXggYTFiNjRlMC4uMTkxMmExMiAxMDA2NDQKLS0tIGEv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Vi a2l0L3dlYmtpdGRvd25sb2FkLmNwcApAQCAtODU0LDIyICs4NTQsMjQgQEAgc3RhdGljIHZvaWQg d2Via2l0X2Rvd25sb2FkX3JlY2VpdmVkX2RhdGEoV2ViS2l0RG93bmxvYWQqIGRvd25sb2FkLCBj b25zdCBnY2hhcioKICAgICBpZiAocHJpdi0+Y3VycmVudFNpemUgPiB3ZWJraXRfZG93bmxvYWRf Z2V0X3RvdGFsX3NpemUoZG93bmxvYWQpKQogICAgICAgICBnX29iamVjdF9ub3RpZnkoR19PQkpF Q1QoZG93bmxvYWQpLCAidG90YWwtc2l6ZSIpOwogCi0gICAgZ2RvdWJsZSBsYXN0UHJvZ3Jlc3Mg PSB3ZWJraXRfZG93bmxvYWRfZ2V0X3Byb2dyZXNzKGRvd25sb2FkKTsKLQogICAgIC8vIFRocm90 dGxlIHByb2dyZXNzIG5vdGlmaWNhdGlvbiB0byBub3QgY29uc3VtZSBoaWdoIGFtb3VudHMgb2YK LSAgICAvLyBDUFUgb24gZmFzdCBsaW5rcywgZXhjZXB0IHdoZW4gdGhlIHByb2dyZXNzIGlzID49 IDMlLCBvciB3ZQotICAgIC8vIHJlYWNoZWQgdGhlIGVuZC4KKyAgICAvLyBDUFUgb24gZmFzdCBs aW5rcywgZXhjZXB0IHdoZW4gdGhlIGxhc3Qgbm90aWZpY2F0aW9uIG9jY3VyZWQKKyAgICAvLyBp biBtb3JlIHRoZW4gMC43IHNlY3MgZnJvbSBub3csIG9yIHRoZSBsYXN0IG5vdGlmaWVkIHByb2dy ZXNzCisgICAgLy8gaXMgcGFzc2VkIGluIDElIG9yIHdlIHJlYWNoZWQgdGhlIGVuZC4KKyAgICBz dGF0aWMgZ2RvdWJsZSBsYXN0UHJvZ3Jlc3MgPSAwOwogICAgIHN0YXRpYyBnZG91YmxlIGxhc3RF bGFwc2VkID0gMDsKICAgICBnZG91YmxlIGN1cnJlbnRFbGFwc2VkID0gZ190aW1lcl9lbGFwc2Vk KHByaXYtPnRpbWVyLCBOVUxMKTsKKyAgICBnZG91YmxlIGN1cnJlbnRQcm9ncmVzcyA9IHdlYmtp dF9kb3dubG9hZF9nZXRfcHJvZ3Jlc3MoZG93bmxvYWQpOwogCiAgICAgaWYgKGxhc3RFbGFwc2Vk Ci0gICAgICAgICYmIChjdXJyZW50RWxhcHNlZCAtIGxhc3RFbGFwc2VkKSA8IDAuMQotICAgICAg ICAmJiAod2Via2l0X2Rvd25sb2FkX2dldF9wcm9ncmVzcyhkb3dubG9hZCkgLSBsYXN0UHJvZ3Jl c3MpIDwgMC4wMwotICAgICAgICAmJiB3ZWJraXRfZG93bmxvYWRfZ2V0X3Byb2dyZXNzKGRvd25s b2FkKSA8IDEuMCkgewotICAgICAgICBsYXN0RWxhcHNlZCA9IGN1cnJlbnRFbGFwc2VkOworICAg ICAgICAmJiBsYXN0UHJvZ3Jlc3MKKyAgICAgICAgJiYgKGN1cnJlbnRFbGFwc2VkIC0gbGFzdEVs YXBzZWQpIDwgMC43CisgICAgICAgICYmIChjdXJyZW50UHJvZ3Jlc3MgLSBsYXN0UHJvZ3Jlc3Mp IDwgMC4wMQorICAgICAgICAmJiBjdXJyZW50UHJvZ3Jlc3MgPCAxLjApIHsKICAgICAgICAgcmV0 dXJuOwogICAgIH0KICAgICBsYXN0RWxhcHNlZCA9IGN1cnJlbnRFbGFwc2VkOworICAgIGxhc3RQ cm9ncmVzcyA9IGN1cnJlbnRQcm9ncmVzczsKIAogICAgIGdfb2JqZWN0X25vdGlmeShHX09CSkVD VChkb3dubG9hZCksICJwcm9ncmVzcyIpOwogfQotLSAKMS42LjUuNwoK 45503 2009-12-25 17:04:57 -0800 2009-12-27 19:12:19 -0800 Conforming with comment #5 0001-Only-updates-time-and-progress-information-when-noti.patch text/plain 2775 tevaum RnJvbSA4NGI5YjlmMmQ1YzRlZTNlMmM0ZTBlMjQ2MzcxZDQxODQyYTQyYzQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RXN0PUMzPUFBdj1DMz1BM289MjBTYW11ZWw9 MjBQcm9jPUMzPUIzcGlvPz0gPHRldmF1bUBnbWFpbC5jb20+CkRhdGU6IEZyaSwgMjUgRGVjIDIw MDkgMTk6Mzc6NDEgLTAyMDAKU3ViamVjdDogW1BBVENIXSBPbmx5IHVwZGF0ZXMgdGltZSBhbmQg cHJvZ3Jlc3MgaW5mb3JtYXRpb24gd2hlbiBub3RpZmljYXRpb24gb2NjdXJzCgotLS0KIENoYW5n ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwIHwgICAxOCArKysrKysrKysrLS0tLS0t LS0KIDIgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMzU5NTUwOC4uMjRmNzZiYSAx MDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisy MDA5LTEyLTI1ICBFc3TDqnbDo28gU2FtdWVsIFByb2PDs3BpbyAgPHRldmF1bUBnbWFpbC5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgbm9vbmUgKE9PUFMhKS4KKworICAgICAgICBCdWcgMzI5 NDA6IFtHVEtdIENoYW5naW5nIHRoZSBkb3dubG9hZCB0aHJvdHRsZSBjb25kaXRpb25zLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI3MTYKKworICAg ICAgICBUaGUgV2ViS2l0RG93bmxvYWQgcHJvZ3Jlc3Mgbm90aWZpY2F0aW9uIHdhcyB0YWtpbmcg bG9uZyB0bworICAgICAgICB1cGRhdGUuIFRoaXMgZml4IG1ha2VzIG5vdGlmaWNhdGlvbiBoYXBw ZW5zIGVhY2ggMC43IHNlY3MKKyAgICAgICAgb3Igd2hlbiB0aGUgcHJvZ3Jlc3MgdXBzIGluIDEl LgorCisgICAgICAgICogV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwOgorCiAy MDA5LTEyLTIyICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAog ICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBIb2xnZXIgRnJleXRoZXIuCmRpZmYgLS1naXQgYS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9hZC5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXRkb3dubG9hZC5jcHAKaW5kZXggYTFiNjRlMC4uMTkxMmExMiAxMDA2NDQKLS0tIGEvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdGRvd25sb2FkLmNwcApAQCAtODU0LDIyICs4NTQsMjQgQEAgc3RhdGljIHZvaWQgd2Vi a2l0X2Rvd25sb2FkX3JlY2VpdmVkX2RhdGEoV2ViS2l0RG93bmxvYWQqIGRvd25sb2FkLCBjb25z dCBnY2hhcioKICAgICBpZiAocHJpdi0+Y3VycmVudFNpemUgPiB3ZWJraXRfZG93bmxvYWRfZ2V0 X3RvdGFsX3NpemUoZG93bmxvYWQpKQogICAgICAgICBnX29iamVjdF9ub3RpZnkoR19PQkpFQ1Qo ZG93bmxvYWQpLCAidG90YWwtc2l6ZSIpOwogCi0gICAgZ2RvdWJsZSBsYXN0UHJvZ3Jlc3MgPSB3 ZWJraXRfZG93bmxvYWRfZ2V0X3Byb2dyZXNzKGRvd25sb2FkKTsKLQogICAgIC8vIFRocm90dGxl IHByb2dyZXNzIG5vdGlmaWNhdGlvbiB0byBub3QgY29uc3VtZSBoaWdoIGFtb3VudHMgb2YKLSAg ICAvLyBDUFUgb24gZmFzdCBsaW5rcywgZXhjZXB0IHdoZW4gdGhlIHByb2dyZXNzIGlzID49IDMl LCBvciB3ZQotICAgIC8vIHJlYWNoZWQgdGhlIGVuZC4KKyAgICAvLyBDUFUgb24gZmFzdCBsaW5r cywgZXhjZXB0IHdoZW4gdGhlIGxhc3Qgbm90aWZpY2F0aW9uIG9jY3VyZWQKKyAgICAvLyBpbiBt b3JlIHRoZW4gMC43IHNlY3MgZnJvbSBub3csIG9yIHRoZSBsYXN0IG5vdGlmaWVkIHByb2dyZXNz CisgICAgLy8gaXMgcGFzc2VkIGluIDElIG9yIHdlIHJlYWNoZWQgdGhlIGVuZC4KKyAgICBzdGF0 aWMgZ2RvdWJsZSBsYXN0UHJvZ3Jlc3MgPSAwOwogICAgIHN0YXRpYyBnZG91YmxlIGxhc3RFbGFw c2VkID0gMDsKICAgICBnZG91YmxlIGN1cnJlbnRFbGFwc2VkID0gZ190aW1lcl9lbGFwc2VkKHBy aXYtPnRpbWVyLCBOVUxMKTsKKyAgICBnZG91YmxlIGN1cnJlbnRQcm9ncmVzcyA9IHdlYmtpdF9k b3dubG9hZF9nZXRfcHJvZ3Jlc3MoZG93bmxvYWQpOwogCiAgICAgaWYgKGxhc3RFbGFwc2VkCi0g ICAgICAgICYmIChjdXJyZW50RWxhcHNlZCAtIGxhc3RFbGFwc2VkKSA8IDAuMQotICAgICAgICAm JiAod2Via2l0X2Rvd25sb2FkX2dldF9wcm9ncmVzcyhkb3dubG9hZCkgLSBsYXN0UHJvZ3Jlc3Mp IDwgMC4wMwotICAgICAgICAmJiB3ZWJraXRfZG93bmxvYWRfZ2V0X3Byb2dyZXNzKGRvd25sb2Fk KSA8IDEuMCkgewotICAgICAgICBsYXN0RWxhcHNlZCA9IGN1cnJlbnRFbGFwc2VkOworICAgICAg ICAmJiBsYXN0UHJvZ3Jlc3MKKyAgICAgICAgJiYgKGN1cnJlbnRFbGFwc2VkIC0gbGFzdEVsYXBz ZWQpIDwgMC43CisgICAgICAgICYmIChjdXJyZW50UHJvZ3Jlc3MgLSBsYXN0UHJvZ3Jlc3MpIDwg MC4wMQorICAgICAgICAmJiBjdXJyZW50UHJvZ3Jlc3MgPCAxLjApIHsKICAgICAgICAgcmV0dXJu OwogICAgIH0KICAgICBsYXN0RWxhcHNlZCA9IGN1cnJlbnRFbGFwc2VkOworICAgIGxhc3RQcm9n cmVzcyA9IGN1cnJlbnRQcm9ncmVzczsKIAogICAgIGdfb2JqZWN0X25vdGlmeShHX09CSkVDVChk b3dubG9hZCksICJwcm9ncmVzcyIpOwogfQotLSAKMS42LjUuNwoK 45540 2009-12-27 19:12:19 -0800 2009-12-28 08:49:04 -0800 patch with right ChangeLog 0001-Only-updates-time-and-progress-information-when-noti.patch text/plain 2776 tevaum RnJvbSA4NGI5YjlmMmQ1YzRlZTNlMmM0ZTBlMjQ2MzcxZDQxODQyYTQyYzQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/RXN0PUMzPUFBdj1DMz1BM289MjBTYW11ZWw9 MjBQcm9jPUMzPUIzcGlvPz0gPHRldmF1bUBnbWFpbC5jb20+CkRhdGU6IEZyaSwgMjUgRGVjIDIw MDkgMTk6Mzc6NDEgLTAyMDAKU3ViamVjdDogW1BBVENIXSBPbmx5IHVwZGF0ZXMgdGltZSBhbmQg cHJvZ3Jlc3MgaW5mb3JtYXRpb24gd2hlbiBub3RpZmljYXRpb24gb2NjdXJzCgotLS0KIENoYW5n ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwIHwgICAxOCArKysrKysrKysrLS0tLS0t LS0KIDIgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMzU5NTUwOC4uMjRmNzZiYSAx MDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisy MDA5LTEyLTI1ICBFc3TDqnbDo28gU2FtdWVsIFByb2PDs3BpbyAgPHRldmF1bUBnbWFpbC5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDMy OTQwOiBbR1RLXSBDaGFuZ2luZyB0aGUgZG93bmxvYWQgdGhyb3R0bGUgY29uZGl0aW9ucy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyNzE2CisKKyAg ICAgICAgVGhlIFdlYktpdERvd25sb2FkIHByb2dyZXNzIG5vdGlmaWNhdGlvbiB3YXMgdGFraW5n IGxvbmcgdG8KKyAgICAgICAgdXBkYXRlLiBUaGlzIGZpeCBtYWtlcyBub3RpZmljYXRpb24gaGFw cGVucyBlYWNoIDAuNyBzZWNzCisgICAgICAgIG9yIHdoZW4gdGhlIHByb2dyZXNzIHVwcyBpbiAx JS4KKworICAgICAgICAqIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcDoKKwog MjAwOS0xMi0yMiAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAK ICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgSG9sZ2VyIEZyZXl0aGVyLgpkaWZmIC0tZ2l0IGEv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0ZG93bmxvYWQuY3BwCmluZGV4IGExYjY0ZTAuLjE5MTJhMTIgMTAwNjQ0Ci0tLSBhL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXRkb3dubG9hZC5jcHAKQEAgLTg1NCwyMiArODU0LDI0IEBAIHN0YXRpYyB2b2lkIHdl YmtpdF9kb3dubG9hZF9yZWNlaXZlZF9kYXRhKFdlYktpdERvd25sb2FkKiBkb3dubG9hZCwgY29u c3QgZ2NoYXIqCiAgICAgaWYgKHByaXYtPmN1cnJlbnRTaXplID4gd2Via2l0X2Rvd25sb2FkX2dl dF90b3RhbF9zaXplKGRvd25sb2FkKSkKICAgICAgICAgZ19vYmplY3Rfbm90aWZ5KEdfT0JKRUNU KGRvd25sb2FkKSwgInRvdGFsLXNpemUiKTsKIAotICAgIGdkb3VibGUgbGFzdFByb2dyZXNzID0g d2Via2l0X2Rvd25sb2FkX2dldF9wcm9ncmVzcyhkb3dubG9hZCk7Ci0KICAgICAvLyBUaHJvdHRs ZSBwcm9ncmVzcyBub3RpZmljYXRpb24gdG8gbm90IGNvbnN1bWUgaGlnaCBhbW91bnRzIG9mCi0g ICAgLy8gQ1BVIG9uIGZhc3QgbGlua3MsIGV4Y2VwdCB3aGVuIHRoZSBwcm9ncmVzcyBpcyA+PSAz JSwgb3Igd2UKLSAgICAvLyByZWFjaGVkIHRoZSBlbmQuCisgICAgLy8gQ1BVIG9uIGZhc3QgbGlu a3MsIGV4Y2VwdCB3aGVuIHRoZSBsYXN0IG5vdGlmaWNhdGlvbiBvY2N1cmVkCisgICAgLy8gaW4g bW9yZSB0aGVuIDAuNyBzZWNzIGZyb20gbm93LCBvciB0aGUgbGFzdCBub3RpZmllZCBwcm9ncmVz cworICAgIC8vIGlzIHBhc3NlZCBpbiAxJSBvciB3ZSByZWFjaGVkIHRoZSBlbmQuCisgICAgc3Rh dGljIGdkb3VibGUgbGFzdFByb2dyZXNzID0gMDsKICAgICBzdGF0aWMgZ2RvdWJsZSBsYXN0RWxh cHNlZCA9IDA7CiAgICAgZ2RvdWJsZSBjdXJyZW50RWxhcHNlZCA9IGdfdGltZXJfZWxhcHNlZChw cml2LT50aW1lciwgTlVMTCk7CisgICAgZ2RvdWJsZSBjdXJyZW50UHJvZ3Jlc3MgPSB3ZWJraXRf ZG93bmxvYWRfZ2V0X3Byb2dyZXNzKGRvd25sb2FkKTsKIAogICAgIGlmIChsYXN0RWxhcHNlZAot ICAgICAgICAmJiAoY3VycmVudEVsYXBzZWQgLSBsYXN0RWxhcHNlZCkgPCAwLjEKLSAgICAgICAg JiYgKHdlYmtpdF9kb3dubG9hZF9nZXRfcHJvZ3Jlc3MoZG93bmxvYWQpIC0gbGFzdFByb2dyZXNz KSA8IDAuMDMKLSAgICAgICAgJiYgd2Via2l0X2Rvd25sb2FkX2dldF9wcm9ncmVzcyhkb3dubG9h ZCkgPCAxLjApIHsKLSAgICAgICAgbGFzdEVsYXBzZWQgPSBjdXJyZW50RWxhcHNlZDsKKyAgICAg ICAgJiYgbGFzdFByb2dyZXNzCisgICAgICAgICYmIChjdXJyZW50RWxhcHNlZCAtIGxhc3RFbGFw c2VkKSA8IDAuNworICAgICAgICAmJiAoY3VycmVudFByb2dyZXNzIC0gbGFzdFByb2dyZXNzKSA8 IDAuMDEKKyAgICAgICAgJiYgY3VycmVudFByb2dyZXNzIDwgMS4wKSB7CiAgICAgICAgIHJldHVy bjsKICAgICB9CiAgICAgbGFzdEVsYXBzZWQgPSBjdXJyZW50RWxhcHNlZDsKKyAgICBsYXN0UHJv Z3Jlc3MgPSBjdXJyZW50UHJvZ3Jlc3M7CiAKICAgICBnX29iamVjdF9ub3RpZnkoR19PQkpFQ1Qo ZG93bmxvYWQpLCAicHJvZ3Jlc3MiKTsKIH0KLS0gCjEuNi41LjcKCg==