32917 2009-12-24 05:17:07 -0800 [Qt] LayoutTests/storage/change-version.html now passes 2009-12-25 01:58:34 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 robert webkit-unassigned abecsi commit-queue webkit.review.bot oldest_to_newest 174761 0 robert 2009-12-24 05:17:07 -0800 Remove LayoutTests/storage/change-version.html from the skipped list as it now passes. 174764 1 45467 robert 2009-12-24 05:21:03 -0800 Created attachment 45467 Remove from Qt Skipped list 174767 2 webkit.review.bot 2009-12-24 05:26:20 -0800 style-queue ran check-webkit-style on attachment 45467 without any errors. 174794 3 45467 eric 2009-12-24 11:45:02 -0800 Comment on attachment 45467 Remove from Qt Skipped list LGTM. 174795 4 45467 commit-queue 2009-12-24 11:45:52 -0800 Comment on attachment 45467 Remove from Qt Skipped list Rejecting patch 45467 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1 Last 500 characters of output: 7. https://bugs.webkit.org/show_bug.cgi?id=32917 --- LayoutTests/ChangeLog | 13 +++++++++++++ LayoutTests/platform/qt/Skipped | 3 --- 2 files changed, 13 insertions(+), 3 deletions(-) ------------------------------------------------------------------- patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/qt/Skipped Hunk #1 FAILED at 1101. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/Skipped.rej Full output: http://webkit-commit-queue.appspot.com/results/143871 174816 5 45477 robert 2009-12-24 15:23:52 -0800 Created attachment 45477 Updated Patch Seems Andras moved this to a different place in the skipped list this afternoon. It definitely passes! 174817 6 webkit.review.bot 2009-12-24 15:25:14 -0800 style-queue ran check-webkit-style on attachment 45477 without any errors. 174826 7 45477 commit-queue 2009-12-24 17:15:12 -0800 Comment on attachment 45477 Updated Patch Clearing flags on attachment: 45477 Committed r52553: <http://trac.webkit.org/changeset/52553> 174827 8 commit-queue 2009-12-24 17:15:16 -0800 All reviewed patches have been landed. Closing bug. 174850 9 abecsi 2009-12-25 01:58:34 -0800 (In reply to comment #5) > Created an attachment (id=45477) [details] > Updated Patch > > Seems Andras moved this to a different place in the skipped list this > afternoon. It definitely passes! Sorry for the inconvenience, there was a redundant comment on layoutTestController.notifyDone(), and I've put the test to the place where the other notifyDone() stuff is, but this was obviously not related to the timeout problem. 45467 2009-12-24 05:21:03 -0800 2009-12-24 15:23:52 -0800 Remove from Qt Skipped list 0001-Remove-LayoutTests-storage-change-version.html-from-.patch text/plain 1902 robert RnJvbSBmY2ZjMGQ2MmYxYjkyYjJmMjZiZTBiZWY4Y2JjNWIwNmZmZjJhZDQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2JlcnQgSG9nYW4gPHJvYmVydEByb2JlcnRob2dhbi5uZXQ+ CkRhdGU6IFRodSwgMjQgRGVjIDIwMDkgMTM6MTc6NTUgKzAwMDAKU3ViamVjdDogW1BBVENIXSBS ZW1vdmUgTGF5b3V0VGVzdHMvc3RvcmFnZS9jaGFuZ2UtdmVyc2lvbi5odG1sIGZyb20gUXQgU2tp cHBlZCBsaXN0CgpMYXlvdXRUZXN0cy9zdG9yYWdlL2NoYW5nZS12ZXJzaW9uLmh0bWwgbm93IHBh c3Nlcy4KUHJvYmFibHkgcmVsYXRlZCB0byB0aGUgZml4IGluIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMjQzNy4KCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMjkxNwotLS0KIExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAgICAgICAgfCAg IDEzICsrKysrKysrKysrKysKIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQgfCAgICAz IC0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyN2I5NTA3Li43MmEzN2FjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MjQgIFJvYmVydCBIb2dhbiAgPHJvYmVydEByb2JlcnRob2dhbi5uZXQ+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIExheW91dFRlc3RzL3N0 b3JhZ2UvY2hhbmdlLXZlcnNpb24uaHRtbCBmcm9tIFF0IFNraXBwZWQgbGlzdAorICAgICAgICAK KyAgICAgICAgTGF5b3V0VGVzdHMvc3RvcmFnZS9jaGFuZ2UtdmVyc2lvbi5odG1sIG5vdyBwYXNz ZXMuCisgICAgICAgIFByb2JhYmx5IHJlbGF0ZWQgdG8gdGhlIGZpeCBpbiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI0MzcuCisgICAgICAgIAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI5MTcKKworICAgICAgICAqIHBs YXRmb3JtL3F0L1NraXBwZWQ6CisKIDIwMDktMTItMjQgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1h bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkOiBmb2xsb3cgdXAgdG8gcjUy NTQ1LCBhZGRpbmcgbWlzc2luZyB0ZXN0cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCmluZGV4IDYz YTY0NDQuLjVlNzE0ZTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApAQCAtMTEwMSw5ICsxMTAx LDYgQEAgc3ZnL2N1c3RvbS9pbWFnZS13aXRoLXByZWZpeC1pbi13ZWJhcmNoaXZlLnN2Zwogc3Rv cmFnZS9kb21zdG9yYWdlL2xvY2Fsc3RvcmFnZS9pZnJhbWUtZXZlbnRzLmh0bWwKIHN0b3JhZ2Uv ZG9tc3RvcmFnZS9zZXNzaW9uc3RvcmFnZS9pZnJhbWUtZXZlbnRzLmh0bWwKIAotIyAtLS0tLS0t IGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKSBkb2VzIG5vdCB3b3JrIGNvcnJlY3Rs eQotc3RvcmFnZS9jaGFuZ2UtdmVyc2lvbi5odG1sCi0KICMgVGVzdHMgdGhhdCBjdXJyZW50bHkg ZmFpbCBidXQgcGVyaGFwcyB1c2VkIHRvIHdvcmsgYXQgc29tZSBwb2ludC4KIGZhc3QvZG9tL29w ZW4tYW5kLWNsb3NlLWJ5LURPTS5odG1sCiBmYXN0L2RvbS9XaW5kb3cvbmV3LXdpbmRvdy1vcGVu ZXIuaHRtbAotLSAKMS42LjMuMwoK 45477 2009-12-24 15:23:52 -0800 2009-12-24 17:15:11 -0800 Updated Patch 0001-Remove-LayoutTests-storage-change-version.html-from-.patch text/plain 1914 robert RnJvbSAwMjUxZWQ1OThmNzQ2ZjI5OWU4NzNlYzQxMjE4OTdmMmRiNGM5MDdiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2JlcnQgSG9nYW4gPHJvYmVydEByb2JlcnRob2dhbi5uZXQ+ CkRhdGU6IFRodSwgMjQgRGVjIDIwMDkgMjM6MjA6NDMgKzAwMDAKU3ViamVjdDogW1BBVENIXSBS ZW1vdmUgTGF5b3V0VGVzdHMvc3RvcmFnZS9jaGFuZ2UtdmVyc2lvbi5odG1sIGZyb20gUXQgU2tp cHBlZCBsaXN0CgpMYXlvdXRUZXN0cy9zdG9yYWdlL2NoYW5nZS12ZXJzaW9uLmh0bWwgbm93IHBh c3Nlcy4KUHJvYmFibHkgcmVsYXRlZCB0byB0aGUgZml4IGluIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMjQzNy4KCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMjkxNwotLS0KIExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAgICAgICAgfCAg IDEzICsrKysrKysrKysrKysKIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQgfCAgICAx IC0KIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggNzM1OTI4Yi4uMWIzZmFlYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDA5LTEyLTI0 ICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRAcm9iZXJ0aG9nYW4ubmV0PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBMYXlvdXRUZXN0cy9zdG9y YWdlL2NoYW5nZS12ZXJzaW9uLmh0bWwgZnJvbSBRdCBTa2lwcGVkIGxpc3QKKyAgICAgICAgCisg ICAgICAgIExheW91dFRlc3RzL3N0b3JhZ2UvY2hhbmdlLXZlcnNpb24uaHRtbCBub3cgcGFzc2Vz LgorICAgICAgICBQcm9iYWJseSByZWxhdGVkIHRvIHRoZSBmaXggaW4gaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyNDM3LgorICAgICAgICAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyOTE3CisKKyAgICAgICAgKiBwbGF0 Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDA5LTEyLTI0ICBBbmRyYXMgQmVjc2kgIDxhYmVjc2lAaW5m LnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IFNpbW9uIEhhdXNtYW5u LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKaW5kZXggODJlYzBlMC4uZDZhYjNlOCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9xdC9Ta2lwcGVkCkBAIC01MTQ3LDcgKzUxNDcsNiBAQCBodHRwL3Rlc3RzL3NlY3VyaXR5 L2RhdGFVUkwveHNzLURFTklFRC1mcm9tLWRhdGEtdXJsLWluLWZvcmVpZ24tZG9tYWluLXdpbmRv dy1vcAogaHR0cC90ZXN0cy9zZWN1cml0eS9kYXRhVVJML3hzcy1ERU5JRUQtZnJvbS1qYXZhc2Ny aXB0LXVybC13aW5kb3ctb3Blbi5odG1sCiBodHRwL3Rlc3RzL3NlY3VyaXR5L2phdmFzY3JpcHRV UkwveHNzLUFMTE9XRUQtZnJvbS1qYXZhc2NyaXB0LXVybC13aW5kb3ctb3Blbi5odG1sCiBodHRw L3Rlc3RzL3NlY3VyaXR5L2phdmFzY3JpcHRVUkwveHNzLURFTklFRC1mcm9tLWphdmFzY3JpcHQt dXJsLWluLWZvcmVpZ24tZG9tYWluLXdpbmRvdy1vcGVuLmh0bWwKLXN0b3JhZ2UvY2hhbmdlLXZl cnNpb24uaHRtbAogCiAjIFRoaXMgdGVzdCByZXF1aXJlcyBvZ2cgY29kZWNzCiBtZWRpYS9tZWRp YS1jYW4tcGxheS1vZ2cuaHRtbAotLSAKMS42LjMuMwoK