32913 2009-12-23 17:08:35 -0800 Do not a new Database pointer to any structure until its version has been verified 2009-12-28 18:47:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 32955 1 dumi dumi dbates dglazkov ericu eric hamaji michaeln webkit.review.bot oldest_to_newest 174694 0 dumi 2009-12-23 17:08:35 -0800 We should add the pointer to a new Database to DatabaseTracker, Document, and DatabaseThread only after opening the database and successfully verifying its version. 174696 1 45458 dumi 2009-12-23 17:11:31 -0800 Created attachment 45458 patch 174698 2 webkit.review.bot 2009-12-23 17:17:02 -0800 style-queue ran check-webkit-style on attachment 45458 without any errors. 174700 3 45458 eric 2009-12-23 17:19:35 -0800 Comment on attachment 45458 patch Change looks great! How do we test this? 174703 4 45458 eric 2009-12-23 17:27:51 -0800 Comment on attachment 45458 patch Please update the ChangeLog when you land to point out: 1. What test this fixes. 2. What revision caused this regression. 3. That this is in fact a regression fix. A common way to do that is for the bug title to have REGRESSION(r12345): in it, and to link to the regrssion commit from the Changelog: http://trac.webkit.org/changeset/12345 And then just to list the test that it fixes! I certainly don't need to see this again. :) Thanks for the quick fix! 174706 5 dumi 2009-12-23 17:39:34 -0800 Sorry, didn't know that: REGRESSION(r52530). Updated the ChangeLog file accordingly too. Landed as r52536. 174836 6 hamaji 2009-12-24 19:25:24 -0800 Committed r52554: <http://trac.webkit.org/changeset/52554> 174900 7 dbates 2009-12-25 15:03:45 -0800 This change (r52554) caused layout test failures on the Leopard Intel Debug (Tests) bot. The following are the failing tests (*): storage/open-database-while-transaction-in-progress.html -> crashed svg/W3C-SVG-1.1/filters-conv-01-f.svg -> failed See <http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r52554%20(8651)/> for test output/stderrs. (*) From <http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/8651/steps/layout-test/logs/stdio> 174982 8 eric 2009-12-26 20:49:55 -0800 Shinichiro, what broke? Your rollout change does not mention what broke: http://trac.webkit.org/changeset/52554 Also please be sure to re-open bugs if you roll them out. Also, it looks like your rollout broke two tests. :( https://bugs.webkit.org/show_bug.cgi?id=32955 I'm sure you didn't mean to do all this, but it seems you were very unlucky this time. :( I'm not sure how the rollout could have caused the SVG failure, but it started failing after r52554 and has been failing since. 174985 9 eric 2009-12-26 21:14:10 -0800 I'm going to roll-out the rollout for now. I'll test it locally first to make sure all tests pass on Leopard. 175370 10 dumi 2009-12-28 18:47:47 -0800 I figured out the problem. My patch was technically correct (and that's why WebKit was happy with it). However, it changed the ordering of some actions in a subtle way and that broke an assumption on which the Chromium implementation was built. I opened bug 33005 to track this issue and will soon upload/commit a patch that should make both WebKit and Chromium happy. Closing this bug. 45458 2009-12-23 17:11:31 -0800 2009-12-23 17:27:51 -0800 patch patch text/plain 2682 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjUzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTItMjMgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBIG5ldyBkYXRhYmFzZSBzaG91bGQgYmUgcmVnaXN0ZXJlZCB3aXRoIHRoZSBEb2N1bWVudCwK KyAgICAgICAgRGF0YWJhc2VUcmFja2VyIGFuZCBEYXRhYmFzZVRocmVhZCBvbmx5IGFmdGVyIGl0 IHdhcyBzdWNjZXNzZnVsbHkKKyAgICAgICAgb3BlbmVkIGFuZCBpdHMgdmVyc2lvbiB3YXMgc3Vj Y2Vzc2Z1bGx5IHZlcmlmaWVkLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMjkxMworCisgICAgICAgICogc3RvcmFnZS9EYXRhYmFzZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZTo6b3BlbkRhdGFiYXNlKToKKyAgICAgICAgKFdlYkNv cmU6OkRhdGFiYXNlOjpEYXRhYmFzZSk6CisgICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZTo6cGVy Zm9ybU9wZW5BbmRWZXJpZnkpOgorCiAyMDA5LTEyLTIzICBOaWtvbGFzIFppbW1lcm1hbm4gIDxu emltbWVybWFubkByaW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJ bmRleDogV2ViQ29yZS9zdG9yYWdlL0RhdGFiYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3N0b3JhZ2UvRGF0YWJhc2UuY3BwCShyZXZpc2lvbiA1MjUzNCkKKysrIFdlYkNvcmUvc3RvcmFn ZS9EYXRhYmFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzMiwxMSArMTMyLDEyIEBAIFBhc3NS ZWZQdHI8RGF0YWJhc2U+IERhdGFiYXNlOjpvcGVuRGF0YWIKIAogICAgIGlmICghZGF0YWJhc2Ut Pm9wZW5BbmRWZXJpZnlWZXJzaW9uKGUpKSB7CiAgICAgICAgTE9HKFN0b3JhZ2VBUEksICJGYWls ZWQgdG8gb3BlbiBhbmQgdmVyaWZ5IHZlcnNpb24gKGV4cGVjdGVkICVzKSBvZiBkYXRhYmFzZSAl cyIsIGV4cGVjdGVkVmVyc2lvbi5hc2NpaSgpLmRhdGEoKSwgZGF0YWJhc2UtPmRhdGFiYXNlRGVi dWdOYW1lKCkuYXNjaWkoKS5kYXRhKCkpOwotICAgICAgIGRvY3VtZW50LT5yZW1vdmVPcGVuRGF0 YWJhc2UoZGF0YWJhc2UuZ2V0KCkpOwotICAgICAgIERhdGFiYXNlVHJhY2tlcjo6dHJhY2tlcigp LnJlbW92ZU9wZW5EYXRhYmFzZShkYXRhYmFzZS5nZXQoKSk7CiAgICAgICAgcmV0dXJuIDA7CiAg ICAgfQogCisgICAgRGF0YWJhc2VUcmFja2VyOjp0cmFja2VyKCkuYWRkT3BlbkRhdGFiYXNlKGRh dGFiYXNlLmdldCgpKTsKKyAgICBkb2N1bWVudC0+YWRkT3BlbkRhdGFiYXNlKGRhdGFiYXNlLmdl dCgpKTsKKwogICAgIERhdGFiYXNlVHJhY2tlcjo6dHJhY2tlcigpLnNldERhdGFiYXNlRGV0YWls cyhkb2N1bWVudC0+c2VjdXJpdHlPcmlnaW4oKSwgbmFtZSwgZGlzcGxheU5hbWUsIGVzdGltYXRl ZFNpemUpOwogCiAgICAgZG9jdW1lbnQtPnNldEhhc09wZW5EYXRhYmFzZXMoKTsKQEAgLTE4OCw5 ICsxODksNiBAQCBEYXRhYmFzZTo6RGF0YWJhc2UoRG9jdW1lbnQqIGRvY3VtZW50LCBjCiAgICAg QVNTRVJUKG1fZG9jdW1lbnQtPmRhdGFiYXNlVGhyZWFkKCkpOwogCiAgICAgbV9maWxlbmFtZSA9 IERhdGFiYXNlVHJhY2tlcjo6dHJhY2tlcigpLmZ1bGxQYXRoRm9yRGF0YWJhc2UobV9tYWluVGhy ZWFkU2VjdXJpdHlPcmlnaW4uZ2V0KCksIG1fbmFtZSk7Ci0KLSAgICBEYXRhYmFzZVRyYWNrZXI6 OnRyYWNrZXIoKS5hZGRPcGVuRGF0YWJhc2UodGhpcyk7Ci0gICAgbV9kb2N1bWVudC0+YWRkT3Bl bkRhdGFiYXNlKHRoaXMpOwogfQogCiBzdGF0aWMgdm9pZCBkZXJlZkRvY3VtZW50KHZvaWQqIGRv Y3VtZW50KQpAQCAtNDYyLDEwICs0NjAsNiBAQCBib29sIERhdGFiYXNlOjpwZXJmb3JtT3BlbkFu ZFZlcmlmeShFeGNlCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKLSAgICBtX29wZW5l ZCA9IHRydWU7Ci0gICAgaWYgKG1fZG9jdW1lbnQtPmRhdGFiYXNlVGhyZWFkKCkpCi0gICAgICAg IG1fZG9jdW1lbnQtPmRhdGFiYXNlVGhyZWFkKCktPnJlY29yZERhdGFiYXNlT3Blbih0aGlzKTsK LQogICAgIEFTU0VSVChtX2RhdGFiYXNlQXV0aG9yaXplcik7CiAgICAgbV9zcWxpdGVEYXRhYmFz ZS5zZXRBdXRob3JpemVyKG1fZGF0YWJhc2VBdXRob3JpemVyKTsKICAgICBtX3NxbGl0ZURhdGFi YXNlLnNldEJ1c3lUaW1lb3V0KG1heFNxbGl0ZUJ1c3lXYWl0VGltZSk7CkBAIC01MjUsNiArNTE5 LDEwIEBAIGJvb2wgRGF0YWJhc2U6OnBlcmZvcm1PcGVuQW5kVmVyaWZ5KEV4Y2UKICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgIH0KIAorICAgIG1fb3BlbmVkID0gdHJ1ZTsKKyAgICBpZiAobV9k b2N1bWVudC0+ZGF0YWJhc2VUaHJlYWQoKSkKKyAgICAgICAgbV9kb2N1bWVudC0+ZGF0YWJhc2VU aHJlYWQoKS0+cmVjb3JkRGF0YWJhc2VPcGVuKHRoaXMpOworCiAgICAgcmV0dXJuIHRydWU7CiB9 CiAK