32911 2009-12-23 15:51:14 -0800 commit-queue should mention bug 30084 when rejecting patches until it can be fixed 2009-12-23 18:31:41 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 30084 1 eric webkit-unassigned commit-queue oldest_to_newest 174675 0 eric 2009-12-23 15:51:14 -0800 commit-queue should mention bug 30084 when rejecting patches until it can be fixed I'll post a patch to fix this. 174678 1 45453 eric 2009-12-23 16:11:04 -0800 Created attachment 45453 Patch 174679 2 45453 abarth 2009-12-23 16:14:04 -0800 Comment on attachment 45453 Patch OK, i like the pretend abstractions 174713 3 45453 commit-queue 2009-12-23 18:31:36 -0800 Comment on attachment 45453 Patch Clearing flags on attachment: 45453 Committed r52540: <http://trac.webkit.org/changeset/52540> 174714 4 commit-queue 2009-12-23 18:31:41 -0800 All reviewed patches have been landed. Closing bug. 45453 2009-12-23 16:11:04 -0800 2009-12-23 18:31:36 -0800 Patch bug-32911-20091223181102.patch text/plain 4332 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlYjkyNGIyLi5hZDhhMTY5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTIt MjMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbW1pdC1xdWV1ZSBzaG91bGQgbWVudGlvbiBi dWcgMzAwODQgd2hlbiByZWplY3RpbmcgcGF0Y2hlcyB1bnRpbCBpdCBjYW4gYmUgZml4ZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyOTExCisKKyAg ICAgICAgKiBTY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHk6IE1ha2UgdGhlIG1lc3NhZ2UgZXZl biBtb3JlIGZhbmN5LgorICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9idWd6aWxsYV91bml0dGVz dC5weTogVGVzdCBvdXIgbmV3IGZhbmN5IG1lc3NhZ2UuCisKIDIwMDktMTItMjMgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIE5vdCByZXZpZXdl ZCwgYWRkaW5nIG15c2VsZiB0byB0aGUgcmV2aWV3ZXJzIGxpc3QuCmRpZmYgLS1naXQgYS9XZWJL aXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHkgYi9XZWJLaXRUb29scy9TY3JpcHRz L21vZHVsZXMvYnVnemlsbGEucHkKaW5kZXggOWE0NjdlZC4uNmI2MzMwOCAxMDA2NDQKLS0tIGEv V2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5CisrKyBiL1dlYktpdFRvb2xz L1NjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weQpAQCAtMTczLDExICsxNzMsMTYgQEAgY2xhc3Mg QnVnemlsbGEob2JqZWN0KToKICAgICAgICAgcmV0dXJuICJodHRwOi8vdHJhYy53ZWJraXQub3Jn L2Jyb3dzZXIvdHJ1bmsvJXMiICUgbG9jYWxfcGF0aAogCiAgICAgZGVmIF9mbGFnX3Blcm1pc3Np b25fcmVqZWN0aW9uX21lc3NhZ2Uoc2VsZiwgc2V0dGVyX2VtYWlsLCBmbGFnX25hbWUpOgotICAg ICAgICBjb21taXR0ZXJfbGlzdCA9ICJXZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWl0 dGVycy5weSIKLSAgICAgICAgY29udHJpYnV0aW9uX2d1aWRsaW5lc191cmwgPSAiaHR0cDovL3dl YmtpdC5vcmcvY29kaW5nL2NvbnRyaWJ1dGluZy5odG1sIgorICAgICAgICBjb21taXR0ZXJfbGlz dCA9ICJXZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWl0dGVycy5weSIgIyBUaGlzIGNv dWxkIGJlIGNvbXB1dGVkIGZyb20gQ29tbWl0dGVyTGlzdC5fX2ZpbGVfXworICAgICAgICBjb250 cmlidXRpb25fZ3VpZGxpbmVzX3VybCA9ICJodHRwOi8vd2Via2l0Lm9yZy9jb2RpbmcvY29udHJp YnV0aW5nLmh0bWwiICMgU2hvdWxkIGNvbWUgZnJvbSBzb21lIHdlYmtpdF9jb25maWcucHkKKyAg ICAgICAgcXVldWVfYWRtaW5pc3RyYXRvciA9ICJlc2VpZGVsQGNocm9taXVtLm9yZyIgIyBUaGlz IGNvdWxkIGJlIHF1ZXJpZWQgZnJvbSB0aGUgc3RhdHVzX2JvdC4KKyAgICAgICAgcXVldWVfbmFt ZSA9ICJjb21taXQtcXVldWUiICMgVGhpcyBjb3VsZCBiZSBxdWVyaWVkIGZyb20gdGhlIHRvb2wu CiAgICAgICAgIHJlamVjdGlvbl9tZXNzYWdlID0gIiVzIGRvZXMgbm90IGhhdmUgJXMgcGVybWlz c2lvbnMgYWNjb3JkaW5nIHRvICVzLiIgJSAoc2V0dGVyX2VtYWlsLCBmbGFnX25hbWUsIHNlbGYu X3ZpZXdfc291cmNlX2xpbmsoY29tbWl0dGVyX2xpc3QpKQotICAgICAgICByZWplY3Rpb25fbWVz c2FnZSArPSAiXG5cbi0gSWYgeW91IGhhdmUgJXMgcmlnaHRzIHBsZWFzZSBjb3JyZWN0IHRoZSBl cnJvciBpbiAlcyBieSBhZGRpbmcgeW91cnNlbGYgdG8gdGhlIGZpbGUgKG5vIHJldmlldyBuZWVk ZWQpIGFuZCB0aGVuIHNldCB0aGUgJXMgZmxhZyBhZ2Fpbi4iICUgKGZsYWdfbmFtZSwgY29tbWl0 dGVyX2xpc3QsIGZsYWdfbmFtZSkKICAgICAgICAgcmVqZWN0aW9uX21lc3NhZ2UgKz0gIlxuXG4t IElmIHlvdSBkbyBub3QgaGF2ZSAlcyByaWdodHMgcGxlYXNlIHJlYWQgJXMgZm9yIGluc3RydWN0 aW9ucyBvbiBob3cgdG8gdXNlIGJ1Z3ppbGxhIGZsYWdzLiIgJSAoZmxhZ19uYW1lLCBjb250cmli dXRpb25fZ3VpZGxpbmVzX3VybCkKKyAgICAgICAgcmVqZWN0aW9uX21lc3NhZ2UgKz0gIlxuXG4t IElmIHlvdSBoYXZlICVzIHJpZ2h0cyBwbGVhc2UgY29ycmVjdCB0aGUgZXJyb3IgaW4gJXMgYnkg YWRkaW5nIHlvdXJzZWxmIHRvIHRoZSBmaWxlIChubyByZXZpZXcgbmVlZGVkKS4iICUgKGZsYWdf bmFtZSwgY29tbWl0dGVyX2xpc3QpCisgICAgICAgIHJlamVjdGlvbl9tZXNzYWdlICs9ICIgIER1 ZSB0byBidWcgMzAwODQgdGhlICVzIHdpbGwgcmVxdWlyZSBhIHJlc3RhcnQgYWZ0ZXIgeW91ciBj aGFuZ2UuIiAlIHF1ZXVlX25hbWUKKyAgICAgICAgcmVqZWN0aW9uX21lc3NhZ2UgKz0gIiAgUGxl YXNlIGNvbnRhY3QgJXMgdG8gcmVxdWVzdCBhICVzIHJlc3RhcnQuIiAlIChxdWV1ZV9hZG1pbmlz dHJhdG9yLCBxdWV1ZV9uYW1lKQorICAgICAgICByZWplY3Rpb25fbWVzc2FnZSArPSAiICBBZnRl ciByZXN0YXJ0IHRoZSAlcyB3aWxsIGNvcnJlY3RseSByZXNwZWN0IHlvdXIgJXMgcmlnaHRzLiIg JSAocXVldWVfbmFtZSwgZmxhZ19uYW1lKQogICAgICAgICByZXR1cm4gcmVqZWN0aW9uX21lc3Nh Z2UKIAogICAgIGRlZiBfdmFsaWRhdGVfc2V0dGVyX2VtYWlsKHNlbGYsIHBhdGNoLCByZXN1bHRf a2V5LCBsb29rdXBfZnVuY3Rpb24sIHJlamVjdGlvbl9mdW5jdGlvbiwgcmVqZWN0X2ludmFsaWRf cGF0Y2hlcyk6CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemls bGFfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGFfdW5p dHRlc3QucHkKaW5kZXggY2E5MjcyMi4uMzI1ZWNlOSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv U2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvbW9kdWxlcy9idWd6aWxsYV91bml0dGVzdC5weQpAQCAtMTkyLDYgKzE5MiwxNSBAQCBj bGFzcyBCdWd6aWxsYVRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBleHBlY3RlZF9z dGRlcnIgPSAiQWRkaW5nIFsnYWRhbUBleGFtcGxlLmNvbSddIHRvIHRoZSBDQyBsaXN0IGZvciBi dWcgNDJcbiIKICAgICAgICAgT3V0cHV0Q2FwdHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIGJ1 Z3ppbGxhLmFkZF9jY190b19idWcsIFs0MiwgWyJhZGFtQGV4YW1wbGUuY29tIl1dLCBleHBlY3Rl ZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJyKQogCisgICAgZGVmIHRlc3RfZmxhZ19wZXJtaXNzaW9u X3JlamVjdGlvbl9tZXNzYWdlKHNlbGYpOgorICAgICAgICBidWd6aWxsYSA9IEJ1Z3ppbGxhKCkK KyAgICAgICAgZXhwZWN0ZWRfbWVzc3NhZ2U9IiIiZm9vQGZvby5jb20gZG9lcyBub3QgaGF2ZSBy ZXZpZXcgcGVybWlzc2lvbnMgYWNjb3JkaW5nIHRvIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvYnJv d3Nlci90cnVuay9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWl0dGVycy5weS4KKwor LSBJZiB5b3UgZG8gbm90IGhhdmUgcmV2aWV3IHJpZ2h0cyBwbGVhc2UgcmVhZCBodHRwOi8vd2Vi a2l0Lm9yZy9jb2RpbmcvY29udHJpYnV0aW5nLmh0bWwgZm9yIGluc3RydWN0aW9ucyBvbiBob3cg dG8gdXNlIGJ1Z3ppbGxhIGZsYWdzLgorCistIElmIHlvdSBoYXZlIHJldmlldyByaWdodHMgcGxl YXNlIGNvcnJlY3QgdGhlIGVycm9yIGluIFdlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21t aXR0ZXJzLnB5IGJ5IGFkZGluZyB5b3Vyc2VsZiB0byB0aGUgZmlsZSAobm8gcmV2aWV3IG5lZWRl ZCkuICBEdWUgdG8gYnVnIDMwMDg0IHRoZSBjb21taXQtcXVldWUgd2lsbCByZXF1aXJlIGEgcmVz dGFydCBhZnRlciB5b3VyIGNoYW5nZS4gIFBsZWFzZSBjb250YWN0IGVzZWlkZWxAY2hyb21pdW0u b3JnIHRvIHJlcXVlc3QgYSBjb21taXQtcXVldWUgcmVzdGFydC4gIEFmdGVyIHJlc3RhcnQgdGhl IGNvbW1pdC1xdWV1ZSB3aWxsIGNvcnJlY3RseSByZXNwZWN0IHlvdXIgcmV2aWV3IHJpZ2h0cy4i IiIKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChidWd6aWxsYS5fZmxhZ19wZXJtaXNzaW9uX3Jl amVjdGlvbl9tZXNzYWdlKCJmb29AZm9vLmNvbSIsICJyZXZpZXciKSwgZXhwZWN0ZWRfbWVzc3Nh Z2UpCisKIAogaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAgICB1bml0dGVzdC5tYWluKCkK