32900 2009-12-23 06:45:02 -0800 [GTK] Crashes cleaning clipboard contents 2010-01-19 11:11:58 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 gustavo gustavo danilo diegoe eric jonathon mrobinson pclouds slomo tevaum webkit.review.bot oldest_to_newest 174583 0 gustavo 2009-12-23 06:45:02 -0800 It looks like, with page cache enabled, the destruction of the EditorClient being delayed may end up with it crashing. That is because a callback is being called late - after the destruction of the client. 174584 1 45436 gustavo 2009-12-23 07:01:51 -0800 Created attachment 45436 stack trace How I reproduce it: I run Epiphany, go to a page, select some text, open a new tab, close the first tab, select some new text, rinse and repeat until you get a crash. 174585 2 45437 gustavo 2009-12-23 07:03:43 -0800 Created attachment 45437 Make EditorClientGtk refcounted, and use explict refs to protect it for the callbacks 174587 3 webkit.review.bot 2009-12-23 07:08:32 -0800 style-queue ran check-webkit-style on attachment 45437 without any errors. 174595 4 tevaum 2009-12-23 08:31:35 -0800 Having the same problem here. Waiting for the patch to be reviewed. Anyone?!? 175146 5 pclouds 2009-12-27 21:59:02 -0800 With Gustavo's patch, I got two stack traces (probably not reproducible). The latter may due to some other bug. (gdb) bt #0 0xb719af2b in WebKit::clipboard_clear_contents_cb () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #1 0xb6156843 in clipboard_unset () from /usr/lib/libgtk-x11-2.0.so.0 #2 0xb61568d1 in selection_clear_event_cb () from /usr/lib/libgtk-x11-2.0.so.0 #3 0xb603284b in _gtk_marshal_BOOLEAN__BOXED () from /usr/lib/libgtk-x11-2.0.so.0 #4 0xb53bb2eb in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 #5 0xb53cc388 in signal_emit_unlocked_R () from /usr/lib/libgobject-2.0.so.0 #6 0xb53cd5ac in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 #7 0xb53cdb8f in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 #8 0xb613b2b8 in gtk_widget_event_internal () from /usr/lib/libgtk-x11-2.0.so.0 #9 0xb602d304 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0 #10 0xb5ec75dd in gdk_event_dispatch () from /usr/lib/libgdk-x11-2.0.so.0 #11 0xb52ec3bf in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 #12 0xb52eccb6 in g_main_context_iterate () from /usr/lib/libglib-2.0.so.0 #13 0xb52eceb1 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0 #14 0xb602d5dc in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 #15 0x08072109 in main (argc=-2082109099, argv=0xbfc50984) at ephy-main.c:778 (gdb) bt #0 0x00610065 in ?? () #1 0xb751a138 in WebCore::Editor::clientIsEditable () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #2 0xb76b7288 in WebCore::Frame::isContentEditable () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #3 0xb75a9138 in WebCore::HTMLElement::isContentEditable () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #4 0xb74bfded in WebCore::Node::isContentEditable () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #5 0xb74c0942 in WebCore::Node::rootEditableElement () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #6 0xb7780b89 in WebCore::RenderBlock::isSelectionRoot () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #7 0xb7780c68 in WebCore::RenderBlock::shouldPaintSelectionGaps () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #8 0xb778cfda in WebCore::RenderBlock::paintSelection () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #9 0xb778d2fe in WebCore::RenderBlock::paintObject () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #10 0xb777fbbd in WebCore::RenderBlock::paint () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #11 0xb778688d in WebCore::RenderBlock::paintChildren () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #12 0xb7786a26 in WebCore::RenderBlock::paintContents () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #13 0xb778d1f3 in WebCore::RenderBlock::paintObject () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #14 0xb777fbbd in WebCore::RenderBlock::paint () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #15 0xb778688d in WebCore::RenderBlock::paintChildren () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #16 0xb7786a26 in WebCore::RenderBlock::paintContents () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #17 0xb778d1f3 in WebCore::RenderBlock::paintObject () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #18 0xb777fbbd in WebCore::RenderBlock::paint () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #19 0xb77d781c in WebCore::RenderLayer::paintLayer () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #20 0xb77d7921 in WebCore::RenderLayer::paintLayer () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #21 0xb77d81cb in WebCore::RenderLayer::paint () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #22 0xb76c6265 in WebCore::FrameView::paintContents () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #23 0xb770bbde in WebCore::ScrollView::paint () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #24 0xb71b780e in webkit_web_view_expose_event () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #25 0xb602c84b in _gtk_marshal_BOOLEAN__BOXED () from /usr/lib/libgtk-x11-2.0.so.0 #26 0xb53b4495 in g_type_class_meta_marshal () from /usr/lib/libgobject-2.0.so.0 #27 0xb53b62eb in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 #28 0xb53c7737 in signal_emit_unlocked_R () from /usr/lib/libgobject-2.0.so.0 #29 0xb53c85ac in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 #30 0xb53c8b8f in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 #31 0xb61352b8 in gtk_widget_event_internal () from /usr/lib/libgtk-x11-2.0.so.0 #32 0xb60273a9 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0 #33 0xb5eaa41c in _gdk_window_process_updates_recurse () from /usr/lib/libgdk-x11-2.0.so.0 #34 0xb5eaa3ce in _gdk_window_process_updates_recurse () from /usr/lib/libgdk-x11-2.0.so.0 #35 0xb5ecf944 in _gdk_windowing_window_process_updates_recurse () from /usr/lib/libgdk-x11-2.0.so.0 #36 0xb5ea6580 in gdk_window_process_updates_internal () from /usr/lib/libgdk-x11-2.0.so.0 #37 0xb5ea8745 in gdk_window_process_all_updates () from /usr/lib/libgdk-x11-2.0.so.0 #38 0xb5ea8764 in gdk_window_update_idle () from /usr/lib/libgdk-x11-2.0.so.0 #39 0xb5e87e1a in gdk_threads_dispatch () from /usr/lib/libgdk-x11-2.0.so.0 #40 0xb52e30c2 in g_idle_dispatch () from /usr/lib/libglib-2.0.so.0 #41 0xb52e73bf in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 #42 0xb52e7cb6 in g_main_context_iterate () from /usr/lib/libglib-2.0.so.0 #43 0xb52e7eb1 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0 #44 0xb60275dc in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 #45 0x08072109 in main (argc=159697152, argv=0xbf8dd694) at ephy-main.c:778 175655 6 gustavo 2009-12-29 11:30:24 -0800 Just a heads up - Martin Robinson has a patch to improve DND, and it essentially replaces/moves the code I am touching in my patch. See https://bugs.webkit.org/show_bug.cgi?id=30623 177370 7 eric 2010-01-05 13:45:01 -0800 Should this still be up for review then? 177569 8 45437 gustavo 2010-01-06 04:47:01 -0800 Comment on attachment 45437 Make EditorClientGtk refcounted, and use explict refs to protect it for the callbacks Removed from review queue for now. 180525 9 diegoe 2010-01-13 19:52:00 -0800 Happens also if you select text somewhere else (other apps). Fun :) 181012 10 46621 gustavo 2010-01-14 17:09:19 -0800 Created attachment 46621 Null-check the focus controller, because it may be null when the callback is called, leading to crash ok, I found what's wrong with Martin's approach, it seems; wasn't able to crash Epiphany anymore with this 181015 11 46621 eric 2010-01-14 17:11:53 -0800 Comment on attachment 46621 Null-check the focus controller, because it may be null when the callback is called, leading to crash OK. 181032 12 gustavo 2010-01-14 17:27:32 -0800 Patch landed as 53304. 181232 13 gustavo 2010-01-15 07:52:58 -0800 *** Bug 33387 has been marked as a duplicate of this bug. *** 181498 14 slomo 2010-01-16 05:01:55 -0800 Unfortunately this is not enough, still crashes for me with latest trunk of epiphany and webkit: #0 0x00007ffff4fa2353 in WebKit::clearClipboardContentsCallback(_GtkClipboard*, void*) () from /usr/local/lib/libwebkit-1.0.so.2 #1 0x00007ffff3f9438a in clipboard_unset (clipboard=0x813ba0) at /gtk+2.0-2.19.3/gtk/gtkclipboard.c:693 #2 0x00007ffff3f943fc in selection_clear_event_cb ( widget=<value optimized out>, event=<value optimized out>) at /gtk+2.0-2.19.3/gtk/gtkclipboard.c:349 #3 0x00007ffff3e483d3 in _gtk_marshal_BOOLEAN__BOXED (closure=0x85fa40, return_value=0x7fffffffcbe0, n_param_values=<value optimized out>, param_values=0xef8840, invocation_hint=<value optimized out>, marshal_data=0x7ffff3f943e0) at /gtk+2.0-2.19.3/gtk/gtkmarshalers.c:84 #4 0x00007ffff1e717ce in IA__g_closure_invoke (closure=0x85fa40, return_value=0x7fffffffcbe0, n_param_values=2, param_values=0xef8840, invocation_hint=0x7fffffffcba0) at /build/buildd/glib2.0-2.23.1/gobject/gclosure.c:767 #5 0x00007ffff1e86776 in signal_emit_unlocked_R (node=0x73f600, detail=<value optimized out>, instance=<value optimized out>, emission_return=<value optimized out>, instance_and_params=<value optimized out>) at /build/buildd/glib2.0-2.23.1/gobject/gsignal.c:3247 #6 0x00007ffff1e87a7e in IA__g_signal_emit_valist (instance=0x82f070, signal_id=<value optimized out>, detail=0, var_args=0x7fffffffcd90) ---Type <return> to continue, or q <return> to quit--- at /build/buildd/glib2.0-2.23.1/gobject/gsignal.c:2990 #7 0x00007ffff1e88453 in IA__g_signal_emit (instance=0x3f00000040, signal_id=4158854264, detail=3792310656) at /build/buildd/glib2.0-2.23.1/gobject/gsignal.c:3037 #8 0x00007ffff3f75d0f in gtk_widget_event_internal (widget=0x82f070, event=0x12f8920) at /gtk+2.0-2.19.3/gtk/gtkwidget.c:4941 #9 0x00007ffff3e403a5 in IA__gtk_main_do_event (event=0x12f8920) at /gtk+2.0-2.19.3/gtk/gtkmain.c:1601 #10 0x00007ffff384142c in gdk_event_dispatch (source=<value optimized out>, callback=<value optimized out>, user_data=<value optimized out>) at /gtk+2.0-2.19.3/gdk/x11/gdkevents-x11.c:2372 #11 0x00007ffff13c2a7e in g_main_dispatch (context=0x71b770) at /build/buildd/glib2.0-2.23.1/glib/gmain.c:1960 #12 IA__g_main_context_dispatch (context=0x71b770) at /build/buildd/glib2.0-2.23.1/glib/gmain.c:2513 #13 0x00007ffff13c6438 in g_main_context_iterate (context=0x71b770, block=<value optimized out>, dispatch=<value optimized out>, self=<value optimized out>) at /build/buildd/glib2.0-2.23.1/glib/gmain.c:2591 #14 0x00007ffff13c6895 in IA__g_main_loop_run (loop=0x7a54e0) at /build/buildd/glib2.0-2.23.1/glib/gmain.c:2799 #15 0x00007ffff3e40777 in IA__gtk_main () at /gtk+2.0-2.19.3/gtk/gtkmain.c:1219 #16 0x0000000000435b33 in main (argc=1, argv=0x7fffffffe2c8) at ephy-main.c:739 181515 15 tevaum 2010-01-16 10:09:02 -0800 Well... sure it's more stable with this patch. But I'm still getting some random segfaults and I think it's still related to clipboard. Here is a full bt: Program received signal SIGSEGV, Segmentation fault. 0xb5d609ff in WTF::RefCountedBase::derefBase (this=0x670072) at ./JavaScriptCore/wtf/RefCounted.h:67 67 ASSERT(!m_deletionHasBegun); Current language: auto The current source language is "auto; currently c++". (gdb) bt full #0 0xb5d609ff in WTF::RefCountedBase::derefBase (this=0x670072) at ./JavaScriptCore/wtf/RefCounted.h:67 __PRETTY_FUNCTION__ = "bool WTF::RefCountedBase::derefBase()" #1 0xb5d744d7 in WTF::RefCounted<WebCore::Range>::deref (this=0x670072) at ./JavaScriptCore/wtf/RefCounted.h:108 No locals. #2 0xb660bfa8 in WTF::RefPtr<WebCore::Range>::operator= (this=0xbcd777c, optr=0x0) at ./JavaScriptCore/wtf/RefPtr.h:132 ptr = 0x670072 #3 0xb660a058 in WebKit::clipboard_clear_contents_cb (clipboard=0x82304b8, data=0xbcd7748) at WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:209 client = 0xbcd7748 #4 0xb5a9dfef in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #5 0xb5a9e046 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #6 0xb593b322 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #7 0xb5447f62 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #8 0xb545c3a8 in ?? () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #9 0xb545d5b8 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #10 0xb545dba6 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #11 0xb5a7d1be in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #12 0xb593408f in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #13 0xb5757b2a in ?? () from /usr/lib/libgdk-x11-2.0.so.0 No symbol table info available. #14 0xb53a7b38 in g_main_context_dispatch () from /lib/libglib-2.0.so.0 No symbol table info available. #15 0xb53ab3d0 in ?? () from /lib/libglib-2.0.so.0 No symbol table info available. #16 0xb53ab83f in g_main_loop_run () from /lib/libglib-2.0.so.0 No symbol table info available. #17 0xb5934539 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #18 0x0806f7bb in main (argc=1, argv=0xbfffefd4) at ephy-main.c:739 option_context = <value optimized out> option_group = <value optimized out> proxy = <value optimized out> error = 0x0 user_time = 65083348 181519 16 danilo 2010-01-16 10:36:54 -0800 Yeah, it's definitely more stable. But I still get a different stacktrace myself with webkit r53331 from yesterday or so: #0 clearClipboardContentsCallback (clipboard=<value optimized out>, data=0x7f5b62f03b40) at ../WebKit/gtk/WebCoreSupport/PasteboardHelperGtk.cpp:137 frame = 0x3f00000040 dataObject = <value optimized out> #1 0x00007f5b85a5d8ea in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #2 0x00007f5b85a5eecd in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #3 0x00007f5b85a5f0b8 in gtk_clipboard_set_with_owner () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #4 0x00007f5b858bde9c in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #5 0x00000000004840ea in ephy_location_entry_activate (entry=<value optimized out>) at /build/buildd/epiphany-browser-2.29.5/lib/widgets/ephy-location-entry.c:1510 priv = 0x15a0af0 toplevel = 0x213a480 #6 0x000000000043b061 in ephy_toolbar_activate_location (toolbar=0x1c11180) at /build/buildd/epiphany-browser-2.29.5/src/ephy-toolbar.c:455 proxies = <value optimized out> entry = <value optimized out> visible = 1 #7 0x00007f5b8472d5ae in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #8 0x00007f5b84742983 in ?? () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #9 0x00007f5b84743d39 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #10 0x00007f5b84744283 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #11 0x00007f5b85874d13 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #12 0x00007f5b858772e9 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #13 0x00007f5b8472d5ae in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #14 0x00007f5b84742983 in ?? () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #15 0x00007f5b84743bcc in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #16 0x00007f5b84744283 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #17 0x00007f5b85871094 in gtk_accel_group_activate () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #18 0x00007f5b8587119d in gtk_accel_groups_activate () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #19 0x00007f5b85a59113 in gtk_window_activate_key () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #20 0x00007f5b85a59199 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #21 0x00007f5b8593c728 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #22 0x00007f5b8472d5ae in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #23 0x00007f5b8474264d in ?? () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #24 0x00007f5b84743bcc in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #25 0x00007f5b84744283 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #26 0x00007f5b85a4371f in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #27 0x00007f5b85934da4 in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #28 0x00007f5b85935ca3 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #29 0x00007f5b85355cdc in ?? () from /usr/lib/libgdk-x11-2.0.so.0 No symbol table info available. #30 0x00007f5b8408bbce in g_main_context_dispatch () from /lib/libglib-2.0.so.0 No symbol table info available. #31 0x00007f5b8408f598 in ?? () from /lib/libglib-2.0.so.0 No symbol table info available. #32 0x00007f5b8408f9f5 in g_main_loop_run () from /lib/libglib-2.0.so.0 No symbol table info available. #33 0x00007f5b85936177 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #34 0x0000000000435203 in main (argc=1, argv=0x7fff6214c698) at /build/buildd/epiphany-browser-2.29.5/src/ephy-main.c:741 option_context = <value optimized out> option_group = <value optimized out> proxy = <value optimized out> error = 0x0 user_time = 196643610 (excuse my lack of symbols in gtk+ and glib libraries) 181545 17 gustavo 2010-01-16 13:03:05 -0800 I posted a patch I think fixes these crashes to https://bugs.webkit.org/show_bug.cgi?id=33746. 181572 18 gustavo 2010-01-16 16:25:08 -0800 *** Bug 33746 has been marked as a duplicate of this bug. *** 181573 19 46753 gustavo 2010-01-16 16:28:28 -0800 Created attachment 46753 Fix crash by passing WebView object to the clipboard functions instead of Page This is the same patch I posted to 33746 (which I marked as duplicate to this one) with a couple changes: 1. adopting the recommendation of mrobinson about checking if data is NULL, because in the near future it might be (for non-X11 primary clipboards) 2. check the return of set_with_data, and unref the webView if the call failed, to avoid leaking Martin also raised the issue of the webView being unrefed in the get function - my original patch did that as well, and I couldn't see how it would be called twice, or in addition to clear yet (by looking at the GTK+ code), but I may be wrong. 181599 20 slomo 2010-01-17 00:11:09 -0800 Works good so far but I guess it needs some longer testing if it really fixes all clipboard issues :) 181604 21 mrobinson 2010-01-17 09:16:53 -0800 (In reply to comment #19) > Martin also raised the issue of the webView being unrefed in the get function - > my original patch did that as well, and I couldn't see how it would be called > twice, or in addition to clear yet (by looking at the GTK+ code), but I may be > wrong. The get function is actually called every time you middle button paste the contents of the clipboard. So if you middle button paste a bunch of times you'll actually see this cause critical warnings like: (GtkLauncher:13194): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed The only other change I would make to this patch is to change the order of these lines in PasteboardHelperGtk.cpp: > ASSERT(dataObject); > > // This will be true for clipboards other than X11 primary. > if (!data) > return; > > dataObject->clear(); In the future, we'll want dataObject->clear() to happen regardless of whether or not this is an X11 primary clipboard (data != NULL). Looks great otherwise! 181652 22 gustavo 2010-01-17 16:48:26 -0800 (In reply to comment #21) > (In reply to comment #19) > > Martin also raised the issue of the webView being unrefed in the get function - > > my original patch did that as well, and I couldn't see how it would be called > > twice, or in addition to clear yet (by looking at the GTK+ code), but I may be > > wrong. > > The get function is actually called every time you middle button paste the > contents of the clipboard. So if you middle button paste a bunch of times > you'll actually see this cause critical warnings like: > > (GtkLauncher:13194): GLib-GObject-CRITICAL **: g_object_unref: assertion > `G_IS_OBJECT (object)' failed I didn't get those here. Is it certain that clear will happen, though? > > ASSERT(dataObject); > > > > // This will be true for clipboards other than X11 primary. > > if (!data) > > return; > > > > dataObject->clear(); > > In the future, we'll want dataObject->clear() to happen regardless of whether > or not this is an X11 primary clipboard (data != NULL). > > Looks great otherwise! OK! 181654 23 46772 gustavo 2010-01-17 16:51:10 -0800 Created attachment 46772 Fix crash by passing WebView instead of Page OK, this addresses the comments Martin made about the patch. 181734 24 slomo 2010-01-17 22:25:13 -0800 (In reply to comment #22) > (In reply to comment #21) > > (In reply to comment #19) > > > Martin also raised the issue of the webView being unrefed in the get function - > > > my original patch did that as well, and I couldn't see how it would be called > > > twice, or in addition to clear yet (by looking at the GTK+ code), but I may be > > > wrong. > > > > The get function is actually called every time you middle button paste the > > contents of the clipboard. So if you middle button paste a bunch of times > > you'll actually see this cause critical warnings like: > > > > (GtkLauncher:13194): GLib-GObject-CRITICAL **: g_object_unref: assertion > > `G_IS_OBJECT (object)' failed > > I didn't get those here. Is it certain that clear will happen, though? From my understanding of the docs the clear function will only ever by called once and will always be called if the clipboard content changes. The get function can (and will) be called multiple times. 182189 25 slomo 2010-01-19 02:54:01 -0800 *** Bug 33422 has been marked as a duplicate of this bug. *** 182191 26 slomo 2010-01-19 02:54:11 -0800 *** Bug 33421 has been marked as a duplicate of this bug. *** 182202 27 46772 xan.lopez 2010-01-19 04:40:08 -0800 Comment on attachment 46772 Fix crash by passing WebView instead of Page I think the cool thing to do these days would be to use a GOwnPtr in the clear callback for the view? Looks fine to me otherwise, feel free to commit either way. 182331 28 gustavo 2010-01-19 11:11:58 -0800 Landed as r53477. 45436 2009-12-23 07:01:51 -0800 2009-12-23 07:01:51 -0800 stack trace gdb.txt text/plain 12904 gustavo IzAgIDB4MDAwMDdmZmZmNjk0MTIwNCBpbiBXVEY6OlJlZkNvdW50ZWRCYXNlOjpkZXJlZkJhc2Ug KHRoaXM9MHgxMmU0NWIwKQogICAgYXQgLi4vLi4vSmF2YVNjcmlwdENvcmUvd3RmL1JlZkNvdW50 ZWQuaDo2NwogICAgICAgIF9fUFJFVFRZX0ZVTkNUSU9OX18gPSAiYm9vbCBXVEY6OlJlZkNvdW50 ZWRCYXNlOjpkZXJlZkJhc2UoKSIKIzEgIDB4MDAwMDdmZmZmNjk0YTk5ZCBpbiBXVEY6OlJlZkNv dW50ZWQ8V2ViQ29yZTo6UmFuZ2U+OjpkZXJlZiAoCiAgICB0aGlzPTB4MTJlNDViMCkgYXQgLi4v Li4vSmF2YVNjcmlwdENvcmUvd3RmL1JlZkNvdW50ZWQuaDoxMDgKTm8gbG9jYWxzLgojMiAgMHgw MDAwN2ZmZmY2OTRhYTg0IGluIFdURjo6UmVmUHRyPFdlYkNvcmU6OlJhbmdlPjo6b3BlcmF0b3I9 ICgKICAgIHRoaXM9MHgxMTc4ZGU4LCBvcHRyPTB4MCkgYXQgLi4vLi4vSmF2YVNjcmlwdENvcmUv d3RmL1JlZlB0ci5oOjEzMgogICAgICAgIHB0ciA9IDB4MTJlNDViMAojMyAgMHgwMDAwN2ZmZmY2 OTQ2YzE0IGluIFdlYktpdDo6Y2xpcGJvYXJkX2NsZWFyX2NvbnRlbnRzX2NiICgKICAgIGNsaXBi b2FyZD0weDYzNmRhMCwgZGF0YT0weDExNzhkODApCiAgICBhdCAuLi8uLi9XZWJLaXQvZ3RrL1dl YkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0ay5jcHA6MjA5CiAgICAgICAgY2xpZW50ID0gMHgx MTc4ZDgwCiM0ICAweDAwMDA3ZmZmZjQ3NjUzMWMgaW4gY2xpcGJvYXJkX3Vuc2V0IChjbGlwYm9h cmQ9MHg2MzZkYTApCiAgICBhdCBndGtjbGlwYm9hcmQuYzo2OTMKICAgICAgICBvbGRfY2xlYXJf ZnVuYyA9IDB4N2ZmZmY2OTQ2YmU0IDxXZWJLaXQ6OmNsaXBib2FyZF9jbGVhcl9jb250ZW50c19j YihfR3RrQ2xpcGJvYXJkKiwgdm9pZCopPgogICAgICAgIG9sZF9kYXRhID0gMHgxMTc4ZDgwCiAg ICAgICAgb2xkX2hhdmVfb3duZXIgPSAwCiAgICAgICAgb2xkX25fc3RvcmFibGVfdGFyZ2V0cyA9 IC0xCiM1ICAweDAwMDA3ZmZmZjQ3NjY5NTEgaW4gZ3RrX2NsaXBib2FyZF9zZXRfY29udGVudHMg KGNsaXBib2FyZD0weDYzNmRhMCwgCiAgICB0YXJnZXRzPTB4MTI5NzVmMCwgbl90YXJnZXRzPTcs IAogICAgZ2V0X2Z1bmM9MHg3ZmZmZjY5NDdiMTAgPFdlYktpdDo6Y2xpcGJvYXJkX2dldF9jb250 ZW50c19jYihfR3RrQ2xpcGJvYXJkKiwgX0d0a1NlbGVjdGlvbkRhdGEqLCB1bnNpZ25lZCBpbnQs IHZvaWQqKT4sIAogICAgY2xlYXJfZnVuYz0weDdmZmZmNjk0NmJlNCA8V2ViS2l0OjpjbGlwYm9h cmRfY2xlYXJfY29udGVudHNfY2IoX0d0a0NsaXBib2FyZCosIHZvaWQqKT4sIHVzZXJfZGF0YT0w eDEyZTM0ZDAsIGhhdmVfb3duZXI9MCkgYXQgZ3RrY2xpcGJvYXJkLmM6NTI2CiAgICAgICAgY2xp cGJvYXJkX3dpZGdldCA9IDB4NWVjNjQwCiM2ICAweDAwMDA3ZmZmZjQ3NjZiZWYgaW4gSUFfX2d0 a19jbGlwYm9hcmRfc2V0X3dpdGhfZGF0YSAoCiAgICBjbGlwYm9hcmQ9MHg3ZmZmZmZmZmIwOTAs IHRhcmdldHM9MHgwLCBuX3RhcmdldHM9NDA0MTg3OTA3MiwgCiAgICBnZXRfZnVuYz0weDIsIGNs ZWFyX2Z1bmM9MHg3ZmZmZjdlNzU3ZjAsIHVzZXJfZGF0YT0weDY1NzM2MTQyNjQ2NTc0NmUpCiAg ICBhdCBndGtjbGlwYm9hcmQuYzo1OTYKICAgICAgICBfX1BSRVRUWV9GVU5DVElPTl9fID0gIklB X19ndGtfY2xpcGJvYXJkX3NldF93aXRoX2RhdGEiCiM3ICAweDAwMDA3ZmZmZjY5NDdhNzUgaW4g V2ViS2l0OjpFZGl0b3JDbGllbnQ6OnJlc3BvbmRUb0NoYW5nZWRTZWxlY3Rpb24gKAogICAgdGhp cz0weDEyZTM0ZDApIGF0IC4uLy4uL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xp ZW50R3RrLmNwcDoyMjkKICAgICAgICB0YXJnZXRMaXN0ID0gMHg5ZWFhNDAKICAgICAgICB0YXJn ZXRDb3VudCA9IDcKICAgICAgICB0YXJnZXRzID0gMHgxMjk3NWYwCiAgICAgICAgcHJpdiA9IDB4 MTE3YzQ0MAogICAgICAgIHRhcmdldEZyYW1lID0gMHgxMWNjN2MwCiAgICAgICAgY2xpcGJvYXJk ID0gMHg2MzZkYTAKICAgICAgICBzdGFydCA9IDAKICAgICAgICBlbmQgPSAyMjQ1MgojOCAgMHgw MDAwN2ZmZmY2ZDRkODgxIGluIFdlYkNvcmU6OkVkaXRvcjo6cmVzcG9uZFRvQ2hhbmdlZFNlbGVj dGlvbiAoCiAgICB0aGlzPTB4MTFjY2UwOCwgb2xkU2VsZWN0aW9uPS4uLikgYXQgLi4vLi4vV2Vi Q29yZS9lZGl0aW5nL0VkaXRvci5jcHA6Mzg4Ck5vIGxvY2Fscy4KIzkgIDB4MDAwMDdmZmZmNmYw ODc2OCBpbiBXZWJDb3JlOjpGcmFtZTo6cmVzcG9uZFRvQ2hhbmdlZFNlbGVjdGlvbiAoCiAgICB0 aGlzPTB4MTFjYzdjMCwgb2xkU2VsZWN0aW9uPS4uLiwgY2xvc2VUeXBpbmc9dHJ1ZSkKICAgIGF0 IC4uLy4uL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHA6MTc5NwogICAgICAgIGlzQ29udGludW91c1Nw ZWxsQ2hlY2tpbmdFbmFibGVkID0gZmFsc2UKICAgICAgICBpc0NvbnRpbnVvdXNHcmFtbWFyQ2hl Y2tpbmdFbmFibGVkID0gZmFsc2UKIzEwIDB4MDAwMDdmZmZmNmQ3MGFiMyBpbiBXZWJDb3JlOjpT ZWxlY3Rpb25Db250cm9sbGVyOjpzZXRTZWxlY3Rpb24gKAogICAgdGhpcz0weDExY2NjZTAsIHM9 Li4uLCBjbG9zZVR5cGluZz10cnVlLCBjbGVhclR5cGluZ1N0eWxlPXRydWUsIAogICAgdXNlclRy aWdnZXJlZD1mYWxzZSkgYXQgLi4vLi4vV2ViQ29yZS9lZGl0aW5nL1NlbGVjdGlvbkNvbnRyb2xs ZXIuY3BwOjE1NAogICAgICAgIGJhc2VOb2RlID0gMHgxNGNlYTkwCiAgICAgICAgZG9jdW1lbnQg PSAweDE0NmZjNTAKICAgICAgICBvbGRTZWxlY3Rpb24gPSB7bV9iYXNlID0gewogICAgICAgICAg ICBtX2FuY2hvck5vZGUgPSB7PFdURjo6RmFzdEFsbG9jQmFzZT4gPSB7PE5vIGRhdGEgZmllbGRz Pn0sIAogICAgICAgICAgICAgIG1fcHRyID0gMHgxNGNlYTkwfSwgbV9vZmZzZXQgPSAxMTQsIG1f YW5jaG9yVHlwZSA9IDAsIAogICAgICAgICAgICBtX2lzTGVnYWN5RWRpdGluZ1Bvc2l0aW9uID0g dHJ1ZX0sIG1fZXh0ZW50ID0gewogICAgICAgICAgICBtX2FuY2hvck5vZGUgPSB7PFdURjo6RmFz dEFsbG9jQmFzZT4gPSB7PE5vIGRhdGEgZmllbGRzPn0sIAogICAgICAgICAgICAgIG1fcHRyID0g MHgxNGNlYTkwfSwgbV9vZmZzZXQgPSAxMTQsIG1fYW5jaG9yVHlwZSA9IDAsIAogICAgICAgICAg ICBtX2lzTGVnYWN5RWRpdGluZ1Bvc2l0aW9uID0gdHJ1ZX0sIG1fc3RhcnQgPSB7CiAgICAgICAg ICAgIG1fYW5jaG9yTm9kZSA9IHs8V1RGOjpGYXN0QWxsb2NCYXNlPiA9IHs8Tm8gZGF0YSBmaWVs ZHM+fSwgCiAgICAgICAgICAgICAgbV9wdHIgPSAweDE0Y2VhOTB9LCBtX29mZnNldCA9IDExNCwg bV9hbmNob3JUeXBlID0gMCwgCiAgICAgICAgICAgIG1faXNMZWdhY3lFZGl0aW5nUG9zaXRpb24g PSB0cnVlfSwgbV9lbmQgPSB7CiAgICAgICAgICAgIG1fYW5jaG9yTm9kZSA9IHs8V1RGOjpGYXN0 QWxsb2NCYXNlPiA9IHs8Tm8gZGF0YSBmaWVsZHM+fSwgCiAgICAgICAgICAgICAgbV9wdHIgPSAw eDE0Y2VhOTB9LCBtX29mZnNldCA9IDExNCwgbV9hbmNob3JUeXBlID0gMCwgCiAgICAgICAgICAg IG1faXNMZWdhY3lFZGl0aW5nUG9zaXRpb24gPSB0cnVlfSwgCiAgICAgICAgICBtX2FmZmluaXR5 ID0gV2ViQ29yZTo6RE9XTlNUUkVBTSwgCiAgICAgICAgICBtX2dyYW51bGFyaXR5ID0gV2ViQ29y ZTo6Q2hhcmFjdGVyR3JhbnVsYXJpdHksIAogICAgICAgICAgbV9zZWxlY3Rpb25UeXBlID0gV2Vi Q29yZTo6VmlzaWJsZVNlbGVjdGlvbjo6Q2FyZXRTZWxlY3Rpb24sIAogICAgICAgICAgbV9iYXNl SXNGaXJzdCA9IHRydWV9CiMxMSAweDAwMDA3ZmZmZjZlZmY4ZGQgaW4gV2ViQ29yZTo6RXZlbnRI YW5kbGVyOjp1cGRhdGVTZWxlY3Rpb25Gb3JNb3VzZURyYWcgKAogICAgdGhpcz0weDExY2NlNTgs IHRhcmdldE5vZGU9MHgxNGNlYTkwLCBsb2NhbFBvaW50PS4uLikKICAgIGF0IC4uLy4uL1dlYkNv cmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwOjU3MgogICAgICAgIHRhcmdldFJlbmRlcmVyID0gMHgx NGNlYjA4CiAgICAgICAgdGFyZ2V0UG9zaXRpb24gPSB7bV9kZWVwUG9zaXRpb24gPSB7CiAgICAg ICAgICAgIG1fYW5jaG9yTm9kZSA9IHs8V1RGOjpGYXN0QWxsb2NCYXNlPiA9IHs8Tm8gZGF0YSBm aWVsZHM+fSwgCiAgICAgICAgICAgICAgbV9wdHIgPSAweDE0Y2VhOTB9LCBtX29mZnNldCA9IDEx NSwgbV9hbmNob3JUeXBlID0gMCwgCiAgICAgICAgICAgIG1faXNMZWdhY3lFZGl0aW5nUG9zaXRp b24gPSB0cnVlfSwgCiAgICAgICAgICBtX2FmZmluaXR5ID0gV2ViQ29yZTo6RE9XTlNUUkVBTX0K ICAgICAgICBuZXdTZWxlY3Rpb24gPSB7bV9iYXNlID0gewogICAgICAgICAgICBtX2FuY2hvck5v ZGUgPSB7PFdURjo6RmFzdEFsbG9jQmFzZT4gPSB7PE5vIGRhdGEgZmllbGRzPn0sIAogICAgICAg ICAgICAgIG1fcHRyID0gMHgxNGNlYTkwfSwgbV9vZmZzZXQgPSAxMTQsIG1fYW5jaG9yVHlwZSA9 IDAsIAogICAgICAgICAgICBtX2lzTGVnYWN5RWRpdGluZ1Bvc2l0aW9uID0gdHJ1ZX0sIG1fZXh0 ZW50ID0gewogICAgICAgICAgICBtX2FuY2hvck5vZGUgPSB7PFdURjo6RmFzdEFsbG9jQmFzZT4g PSB7PE5vIGRhdGEgZmllbGRzPn0sIAogICAgICAgICAgICAgIG1fcHRyID0gMHgxNGNlYTkwfSwg bV9vZmZzZXQgPSAxMTUsIG1fYW5jaG9yVHlwZSA9IDAsIAogICAgICAgICAgICBtX2lzTGVnYWN5 RWRpdGluZ1Bvc2l0aW9uID0gdHJ1ZX0sIG1fc3RhcnQgPSB7CiAgICAgICAgICAgIG1fYW5jaG9y Tm9kZSA9IHs8V1RGOjpGYXN0QWxsb2NCYXNlPiA9IHs8Tm8gZGF0YSBmaWVsZHM+fSwgCiAgICAg ICAgICAgICAgbV9wdHIgPSAweDE0Y2VhOTB9LCBtX29mZnNldCA9IDExNCwgbV9hbmNob3JUeXBl ID0gMCwgCiAgICAgICAgICAgIG1faXNMZWdhY3lFZGl0aW5nUG9zaXRpb24gPSB0cnVlfSwgbV9l bmQgPSB7CiAgICAgICAgICAgIG1fYW5jaG9yTm9kZSA9IHs8V1RGOjpGYXN0QWxsb2NCYXNlPiA9 IHs8Tm8gZGF0YSBmaWVsZHM+fSwgCiAgICAgICAgICAgICAgbV9wdHIgPSAweDE0Y2VhOTB9LCBt X29mZnNldCA9IDExNSwgbV9hbmNob3JUeXBlID0gMCwgCiAgICAgICAgICAgIG1faXNMZWdhY3lF ZGl0aW5nUG9zaXRpb24gPSB0cnVlfSwgCiAgICAgICAgICBtX2FmZmluaXR5ID0gV2ViQ29yZTo6 RE9XTlNUUkVBTSwgCiAgICAgICAgICBtX2dyYW51bGFyaXR5ID0gV2ViQ29yZTo6Q2hhcmFjdGVy R3JhbnVsYXJpdHksIAogICAgICAgICAgbV9zZWxlY3Rpb25UeXBlID0gV2ViQ29yZTo6VmlzaWJs ZVNlbGVjdGlvbjo6UmFuZ2VTZWxlY3Rpb24sIAogICAgICAgICAgbV9iYXNlSXNGaXJzdCA9IHRy dWV9CiMxMiAweDAwMDA3ZmZmZjZmMDEzM2YgaW4gV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpoYW5k bGVNb3VzZURyYWdnZWRFdmVudCAoCiAgICB0aGlzPTB4MTFjY2U1OCwgZXZlbnQ9Li4uKSBhdCAu Li8uLi9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcDo0NzMKICAgICAgICB0YXJnZXROb2Rl ID0gMHgxNGNlYTkwCiMxMyAweDAwMDA3ZmZmZjZmMDE5YzYgaW4gV2ViQ29yZTo6RXZlbnRIYW5k bGVyOjpoYW5kbGVNb3VzZU1vdmVFdmVudCAoCiAgICB0aGlzPTB4MTFjY2U1OCwgbW91c2VFdmVu dD0uLi4sIGhvdmVyZWROb2RlPTB4N2ZmZmZmZmZjMWYwKQogICAgYXQgLi4vLi4vV2ViQ29yZS9w YWdlL0V2ZW50SGFuZGxlci5jcHA6MTQxMwogICAgICAgIHByb3RlY3RvciA9IHs8V1RGOjpGYXN0 QWxsb2NCYXNlPiA9IHs8Tm8gZGF0YSBmaWVsZHM+fSwgCiAgICAgICAgICBtX3B0ciA9IDB4MTMw MjQwMH0KICAgICAgICBoaXRUeXBlID0gNwogICAgICAgIHJlcXVlc3QgPSB7bV9yZXF1ZXN0VHlw ZSA9IDd9CiAgICAgICAgbWV2ID0ge21fZXZlbnQgPSB7bV9wb3NpdGlvbiA9IHttX3ggPSA2MzUs IG1feSA9IDE3Mn0sIAogICAgICAgICAgICBtX2dsb2JhbFBvc2l0aW9uID0ge21feCA9IDIwNzYs IG1feSA9IDM2M30sIAogICAgICAgICAgICBtX2J1dHRvbiA9IFdlYkNvcmU6OkxlZnRCdXR0b24s IAogICAgICAgICAgICBtX2V2ZW50VHlwZSA9IFdlYkNvcmU6Ok1vdXNlRXZlbnRNb3ZlZCwgbV9j bGlja0NvdW50ID0gMCwgCiAgICAgICAgICAgIG1fc2hpZnRLZXkgPSBmYWxzZSwgbV9jdHJsS2V5 ID0gZmFsc2UsIG1fYWx0S2V5ID0gZmFsc2UsIAogICAgICAgICAgICBtX21ldGFLZXkgPSB0cnVl LCBtX3RpbWVzdGFtcCA9IDkzODA1MTY2LCAKICAgICAgICAgICAgbV9tb2RpZmllckZsYWdzID0g MTk0Mjc0NjR9LCBtX2hpdFRlc3RSZXN1bHQgPSB7CiAgICAgICAgICAgIG1faW5uZXJOb2RlID0g ezxXVEY6OkZhc3RBbGxvY0Jhc2U+ID0gezxObyBkYXRhIGZpZWxkcz59LCAKICAgICAgICAgICAg ICBtX3B0ciA9IDB4MTRjZWE5MH0sIAogICAgICAgICAgICBtX2lubmVyTm9uU2hhcmVkTm9kZSA9 IHs8V1RGOjpGYXN0QWxsb2NCYXNlPiA9IHs8Tm8gZGF0YSBmaWVsZHM+fSwgbV9wdHIgPSAweDE0 Y2VhOTB9LCBtX3BvaW50ID0ge21feCA9IDYzNSwgbV95ID0gMTcyfSwgbV9sb2NhbFBvaW50ID0g ewogICAgICAgICAgICAgIG1feCA9IDUwOSwgbV95ID0gMTh9LCAKICAgICAgICAgICAgbV9pbm5l clVSTEVsZW1lbnQgPSB7PFdURjo6RmFzdEFsbG9jQmFzZT4gPSB7PE5vIGRhdGEgZmllbGRzPn0s IAogICAgICAgICAgICAgIG1fcHRyID0gMHgwfSwgCiAgICAgICAgICAgIG1fc2Nyb2xsYmFyID0g ezxXVEY6OkZhc3RBbGxvY0Jhc2U+ID0gezxObyBkYXRhIGZpZWxkcz59LCAKICAgICAgICAgICAg ICBtX3B0ciA9IDB4MH0sIG1faXNPdmVyV2lkZ2V0ID0gZmFsc2V9fQogICAgICAgIHNjcm9sbGJh ciA9IDB4MAogICAgICAgIHN3YWxsb3dFdmVudCA9IGZhbHNlCiAgICAgICAgbmV3U3ViZnJhbWUg PSB7PFdURjo6RmFzdEFsbG9jQmFzZT4gPSB7PE5vIGRhdGEgZmllbGRzPn0sIG1fcHRyID0gMHgw fQogICAgICAgIF9fUFJFVFRZX0ZVTkNUSU9OX18gPSAiYm9vbCBXZWJDb3JlOjpFdmVudEhhbmRs ZXI6OmhhbmRsZU1vdXNlTW92ZUV2ZW50KGNvbnN0IFdlYkNvcmU6OlBsYXRmb3JtTW91c2VFdmVu dCYsIFdlYkNvcmU6OkhpdFRlc3RSZXN1bHQqKSIKIzE0IDB4MDAwMDdmZmZmNmYwMWE0MyBpbiBX ZWJDb3JlOjpFdmVudEhhbmRsZXI6Om1vdXNlTW92ZWQgKHRoaXM9MHgxMWNjZTU4LCAKICAgIGV2 ZW50PS4uLikgYXQgLi4vLi4vV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHA6MTMwOQogICAg ICAgIGhvdmVyZWROb2RlID0gewogICAgICAgICAgbV9pbm5lck5vZGUgPSB7PFdURjo6RmFzdEFs bG9jQmFzZT4gPSB7PE5vIGRhdGEgZmllbGRzPn0sIAogICAgICAgICAgICBtX3B0ciA9IDB4MTRj ZWE5MH0sIAogICAgICAgICAgbV9pbm5lck5vblNoYXJlZE5vZGUgPSB7PFdURjo6RmFzdEFsbG9j QmFzZT4gPSB7PE5vIGRhdGEgZmllbGRzPn0sIAogICAgICAgICAgICBtX3B0ciA9IDB4MTRjZWE5 MH0sIG1fcG9pbnQgPSB7bV94ID0gNjM1LCBtX3kgPSAxNzJ9LCAKICAgICAgICAgIG1fbG9jYWxQ b2ludCA9IHttX3ggPSA1MDksIG1feSA9IDE4fSwgCiAgICAgICAgICBtX2lubmVyVVJMRWxlbWVu dCA9IHs8V1RGOjpGYXN0QWxsb2NCYXNlPiA9IHs8Tm8gZGF0YSBmaWVsZHM+fSwgCiAgICAgICAg ICAgIG1fcHRyID0gMHgwfSwgCiAgICAgICAgICBtX3Njcm9sbGJhciA9IHs8V1RGOjpGYXN0QWxs b2NCYXNlPiA9IHs8Tm8gZGF0YSBmaWVsZHM+fSwgCiAgICAgICAgICAgIG1fcHRyID0gMHgwfSwg bV9pc092ZXJXaWRnZXQgPSBmYWxzZX0KICAgICAgICByZXN1bHQgPSBmYWxzZQogICAgICAgIHBh Z2UgPSAweDYxNWYxMAojMTUgMHgwMDAwN2ZmZmY2OTc2NDFmIGluIHdlYmtpdF93ZWJfdmlld19t b3Rpb25fZXZlbnQgKHdpZGdldD0weDExN2MzYzAsIAogICAgZXZlbnQ9MHgxMjkxMzEwKSBhdCAu Li8uLi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDo1ODgKICAgICAgICB3ZWJW aWV3ID0gMHgxMTdjM2MwCiAgICAgICAgZnJhbWUgPSAweDExY2M3YzAKIzE2IDB4MDAwMDdmZmZm NDYxN2ZmMyBpbiBfZ3RrX21hcnNoYWxfQk9PTEVBTl9fQk9YRUQgKGNsb3N1cmU9MHg1Njk4MzAs IAogICAgcmV0dXJuX3ZhbHVlPTB4N2ZmZmZmZmZjNGIwLCBuX3BhcmFtX3ZhbHVlcz08dmFsdWUg b3B0aW1pemVkIG91dD4sIAogICAgcGFyYW1fdmFsdWVzPTB4MTI4NzA3MCwgaW52b2NhdGlvbl9o aW50PTx2YWx1ZSBvcHRpbWl6ZWQgb3V0PiwgCiAgICBtYXJzaGFsX2RhdGE9MHg3ZmZmZjY5NzYz YTEpIGF0IGd0a21hcnNoYWxlcnMuYzo4NAogICAgICAgIGRhdGExID0gMHgxMTdjM2MwCiAgICAg ICAgZGF0YTIgPSAweDUzYzQ5MAogICAgICAgIHZfcmV0dXJuID0gPHZhbHVlIG9wdGltaXplZCBv dXQ+CiAgICAgICAgX19QUkVUVFlfRlVOQ1RJT05fXyA9ICJfZ3RrX21hcnNoYWxfQk9PTEVBTl9f Qk9YRUQiCiMxNyAweDAwMDA3ZmZmZjI1NmQ4MmQgaW4gSUFfX2dfY2xvc3VyZV9pbnZva2UgKGNs b3N1cmU9MHg1Njk4MzAsIAogICAgcmV0dXJuX3ZhbHVlPTB4N2ZmZmZmZmZjNGIwLCBuX3BhcmFt X3ZhbHVlcz0yLCBwYXJhbV92YWx1ZXM9MHgxMjg3MDcwLCAKICAgIGludm9jYXRpb25faGludD0w eDdmZmZmZmZmYzQ3MCkgYXQgZ2Nsb3N1cmUuYzo3NjcKICAgICAgICBtYXJzaGFsID0gMHg3ZmZm ZjI1NmJkNTAgPGdfdHlwZV9jbGFzc19tZXRhX21hcnNoYWw+CiAgICAgICAgbWFyc2hhbF9kYXRh ID0gMHgxNzAKICAgICAgICBfX1BSRVRUWV9GVU5DVElPTl9fID0gIklBX19nX2Nsb3N1cmVfaW52 b2tlIgojMTggMHgwMDAwN2ZmZmYyNTg0MWNhIGluIHNpZ25hbF9lbWl0X3VubG9ja2VkX1IgKG5v ZGU9MHg1NjlhZDAsIGRldGFpbD0wLCAKICAgIGluc3RhbmNlPTB4MTE3YzNjMCwgZW1pc3Npb25f cmV0dXJuPTB4N2ZmZmZmZmZjNWYwLCAKICAgIGluc3RhbmNlX2FuZF9wYXJhbXM9MHgxMjg3MDcw KSBhdCBnc2lnbmFsLmM6MzI4NQogICAgICAgIGFjY3VtdWxhdG9yID0gMHg1Njk5MjAKICAgICAg ICBlbWlzc2lvbiA9IHtuZXh0ID0gMHgwLCBpbnN0YW5jZSA9IDB4MTE3YzNjMCwgaWhpbnQgPSB7 CiAgICAgICAgICAgIHNpZ25hbF9pZCA9IDU3LCBkZXRhaWwgPSAwLCBydW5fdHlwZSA9IEdfU0lH TkFMX1JVTl9MQVNUfSwgCiAgICAgICAgICBzdGF0ZSA9IEVNSVNTSU9OX1JVTiwgY2hhaW5fdHlw ZSA9IDYzODEzMjh9CiAgICAgICAgY2xhc3NfY2xvc3VyZSA9IDB4NTY5ODMwCiAgICAgICAgaGFu ZGxlcl9saXN0ID0gMHgwCiAgICAgICAgcmV0dXJuX2FjY3UgPSAweDdmZmZmZmZmYzRiMAogICAg ICAgIGFjY3UgPSB7Z190eXBlID0gMjAsIGRhdGEgPSB7e3ZfaW50ID0gMCwgdl91aW50ID0gMCwg dl9sb25nID0gMCwgCiAgICAgICAgICAgICAgdl91bG9uZyA9IDAsIHZfaW50NjQgPSAwLCB2X3Vp bnQ2NCA9IDAsIHZfZmxvYXQgPSAwLCAKICAgICAgICAgICAgICB2X2RvdWJsZSA9IDAsIHZfcG9p bnRlciA9IDB4MH0sIHt2X2ludCA9IDAsIHZfdWludCA9IDAsIAogICAgICAgICAgICAgIHZfbG9u ZyA9IDAsIHZfdWxvbmcgPSAwLCB2X2ludDY0ID0gMCwgdl91aW50NjQgPSAwLCAKICAgICAgICAg ICAgICB2X2Zsb2F0ID0gMCwgdl9kb3VibGUgPSAwLCB2X3BvaW50ZXIgPSAweDB9fX0KICAgICAg ICBzaWduYWxfaWQgPSA1NwogICAgICAgIG1heF9zZXF1ZW50aWFsX2hhbmRsZXJfbnVtYmVyID0g MjA4OQogICAgICAgIHJldHVybl92YWx1ZV9hbHRlcmVkID0gMAojMTkgMHgwMDAwN2ZmZmYyNTg1 OTY2IGluIElBX19nX3NpZ25hbF9lbWl0X3ZhbGlzdCAoaW5zdGFuY2U9MHgxMTdjM2MwLCAKICAg IHNpZ25hbF9pZD08dmFsdWUgb3B0aW1pemVkIG91dD4sIGRldGFpbD0wLCB2YXJfYXJncz0weDdm ZmZmZmZmYzY1MCkKICAgIGF0IGdzaWduYWwuYzoyOTkwCiAgICAgICAgcmV0dXJuX3ZhbHVlID0g e2dfdHlwZSA9IDIwLCBkYXRhID0ge3t2X2ludCA9IDAsIHZfdWludCA9IDAsIAogICAgICAgICAg ICAgIHZfbG9uZyA9IDAsIHZfdWxvbmcgPSAwLCB2X2ludDY0ID0gMCwgdl91aW50NjQgPSAwLCAK ICAgICAgICAgICAgICB2X2Zsb2F0ID0gMCwgdl9kb3VibGUgPSAwLCB2X3BvaW50ZXIgPSAweDB9 LCB7dl9pbnQgPSAwLCAKICAgICAgICAgICAgICB2X3VpbnQgPSAwLCB2X2xvbmcgPSAwLCB2X3Vs b25nID0gMCwgdl9pbnQ2NCA9IDAsIHZfdWludDY0ID0gMCwgCiAgICAgICAgICAgICAgdl9mbG9h dCA9IDAsIHZfZG91YmxlID0gMCwgdl9wb2ludGVyID0gMHgwfX19CiAgICAgICAgZXJyb3IgPSA8 dmFsdWUgb3B0aW1pemVkIG91dD4KICAgICAgICBzaWduYWxfcmV0dXJuX3R5cGUgPSAyMAogICAg ICAgIHBhcmFtX3ZhbHVlcyA9IDB4MTI4NzA4OAogICAgICAgIG5vZGUgPSAweDU2OWFkMAogICAg ICAgIGkgPSAxCiAgICAgICAgbl9wYXJhbXMgPSAxCiAgICAgICAgX19QUkVUVFlfRlVOQ1RJT05f XyA9ICJJQV9fZ19zaWduYWxfZW1pdF92YWxpc3QiCiMyMCAweDAwMDA3ZmZmZjI1ODVmYTMgaW4g SUFfX2dfc2lnbmFsX2VtaXQgKGluc3RhbmNlPTB4N2ZmZmZmZmZiMDkwLCAKICAgIHNpZ25hbF9p ZD0wLCBkZXRhaWw9NDA0MTg3OTA3MikgYXQgZ3NpZ25hbC5jOjMwMzcKICAgICAgICB2YXJfYXJn cyA9IHt7Z3Bfb2Zmc2V0ID0gMzIsIGZwX29mZnNldCA9IDQ4LCAKICAgICAgICAgICAgb3ZlcmZs b3dfYXJnX2FyZWEgPSAweDdmZmZmZmZmYzczMCwgCiAgICAgICAgICAgIHJlZ19zYXZlX2FyZWEg PSAweDdmZmZmZmZmYzY3MH19CiMyMSAweDAwMDA3ZmZmZjQ3NDY1M2UgaW4gZ3RrX3dpZGdldF9l dmVudF9pbnRlcm5hbCAod2lkZ2V0PTB4MTE3YzNjMCwgCiAgICBldmVudD0weDEyOTEzMTApIGF0 IGd0a3dpZGdldC5jOjQ5MzgKICAgICAgICBzaWduYWxfbnVtID0gPHZhbHVlIG9wdGltaXplZCBv dXQ+CiAgICAgICAgcmV0dXJuX3ZhbCA9IDAKIzIyIDB4MDAwMDdmZmZmNDYwZWQyZCBpbiBJQV9f Z3RrX3Byb3BhZ2F0ZV9ldmVudCAod2lkZ2V0PTB4MTE3YzNjMCwgCiAgICBldmVudD0weDEyOTEz MTApIGF0IGd0a21haW4uYzoyNDM5CiAgICAgICAgdG1wID0gMHgxMjkxMzEwCiAgICAgICAgaGFu ZGxlZF9ldmVudCA9IDE5NDY5MDcyCiAgICAgICAgX19QUkVUVFlfRlVOQ1RJT05fXyA9ICJJQV9f Z3RrX3Byb3BhZ2F0ZV9ldmVudCIKIzIzIDB4MDAwMDdmZmZmNDYxMDA3MyBpbiBJQV9fZ3RrX21h aW5fZG9fZXZlbnQgKGV2ZW50PTB4MTI5MTMxMCkKICAgIGF0IGd0a21haW4uYzoxNjQ0CiAgICAg ICAgZXZlbnRfd2lkZ2V0ID0gMHgxMTdjM2MwCiAgICAgICAgZ3JhYl93aWRnZXQgPSAweDExN2Mz YzAKICAgICAgICB3aW5kb3dfZ3JvdXAgPSAweDYyOGQ2MAogICAgICAgIHJld3JpdHRlbl9ldmVu dCA9IDB4MAogICAgICAgIHRtcF9saXN0ID0gPHZhbHVlIG9wdGltaXplZCBvdXQ+CiAgICAgICAg X19QUkVUVFlfRlVOQ1RJT05fXyA9ICJJQV9fZ3RrX21haW5fZG9fZXZlbnQiCiMyNCAweDAwMDA3 ZmZmZjdmNzllZmMgaW4gZ2RrX2V2ZW50X2Rpc3BhdGNoIChzb3VyY2U9PHZhbHVlIG9wdGltaXpl ZCBvdXQ+LCAKICAgIGNhbGxiYWNrPTx2YWx1ZSBvcHRpbWl6ZWQgb3V0PiwgdXNlcl9kYXRhPTx2 YWx1ZSBvcHRpbWl6ZWQgb3V0PikKICAgIGF0IGdka2V2ZW50cy14MTEuYzoyMzcyCiAgICAgICAg ZGlzcGxheSA9IDx2YWx1ZSBvcHRpbWl6ZWQgb3V0PgogICAgICAgIGV2ZW50ID0gPHZhbHVlIG9w dGltaXplZCBvdXQ+CiMyNSAweDAwMDA3ZmZmZjIyYjZmZGEgaW4gZ19tYWluX2Rpc3BhdGNoIChj b250ZXh0PTB4NTFmNTUwKSBhdCBnbWFpbi5jOjE5NjAKICAgICAgICBfX1BSRVRUWV9GVU5DVElP Tl9fID0gImdfbWFpbl9kaXNwYXRjaCIKIzI2IElBX19nX21haW5fY29udGV4dF9kaXNwYXRjaCAo Y29udGV4dD0weDUxZjU1MCkgYXQgZ21haW4uYzoyNTEzCk5vIGxvY2Fscy4KIzI3IDB4MDAwMDdm ZmZmMjJiYTgzOCBpbiBnX21haW5fY29udGV4dF9pdGVyYXRlIChjb250ZXh0PTB4NTFmNTUwLCBi bG9jaz0xLCAKICAgIGRpc3BhdGNoPTEsIHNlbGY9PHZhbHVlIG9wdGltaXplZCBvdXQ+KSBhdCBn bWFpbi5jOjI1OTEKICAgICAgICBtYXhfcHJpb3JpdHkgPSAyMTQ3NDgzNjQ3CiAgICAgICAgdGlt ZW91dCA9IDM5CiAgICAgICAgc29tZV9yZWFkeSA9IDEKICAgICAgICBuZmRzID0gMTAKICAgICAg ICBhbGxvY2F0ZWRfbmZkcyA9IDx2YWx1ZSBvcHRpbWl6ZWQgb3V0PgogICAgICAgIGZkcyA9IDB4 MTI2NDRjMAogICAgICAgIF9fUFJFVFRZX0ZVTkNUSU9OX18gPSAiZ19tYWluX2NvbnRleHRfaXRl cmF0ZSIKIzI4IDB4MDAwMDdmZmZmMjJiYWQwZCBpbiBJQV9fZ19tYWluX2xvb3BfcnVuIChsb29w PTB4NWI4NTUwKSBhdCBnbWFpbi5jOjI3OTkKICAgICAgICBzZWxmID0gMHg0ZTRmMDAKICAgICAg ICBfX1BSRVRUWV9GVU5DVElPTl9fID0gIklBX19nX21haW5fbG9vcF9ydW4iCiMyOSAweDAwMDA3 ZmZmZjQ2MTA0YjcgaW4gSUFfX2d0a19tYWluICgpIGF0IGd0a21haW4uYzoxMjE5CiAgICAgICAg dG1wX2xpc3QgPSAweDU1NDA5MAogICAgICAgIGZ1bmN0aW9ucyA9IDB4MAogICAgICAgIGluaXQg PSAweDUzNzZhMAogICAgICAgIGxvb3AgPSA8dmFsdWUgb3B0aW1pemVkIG91dD4KIzMwIDB4MDAw MDAwMDAwMDQzMjFhZSBpbiBtYWluIChhcmdjPTEsIGFyZ3Y9MHg3ZmZmZmZmZmRjNzgpCiAgICBh dCAuLi8uLi9zcmMvZXBoeS1tYWluLmM6Nzc4CiAgICAgICAgb3B0aW9uX2NvbnRleHQgPSA8dmFs dWUgb3B0aW1pemVkIG91dD4KICAgICAgICBvcHRpb25fZ3JvdXAgPSA8dmFsdWUgb3B0aW1pemVk IG91dD4KICAgICAgICBwcm94eSA9IDx2YWx1ZSBvcHRpbWl6ZWQgb3V0PgogICAgICAgIGVycm9y ID0gMHgwCiAgICAgICAgdXNlcl90aW1lID0gOTM3ODQxMjgKQSBkZWJ1Z2dpbmcgc2Vzc2lvbiBp cyBhY3RpdmUuCgoJSW5mZXJpb3IgMSBbcHJvY2VzcyAyMjQ1Ml0gd2lsbCBiZSBraWxsZWQuCgpR dWl0IGFueXdheT8gKHkgb3IgbikgCg== 45437 2009-12-23 07:03:43 -0800 2010-01-16 16:24:51 -0800 Make EditorClientGtk refcounted, and use explict refs to protect it for the callbacks 0001-Avoid-crashing-with-page-cache.patch text/plain 4664 gustavo RnJvbSBlOTExZGY0NThiNjFhNWI3MDQ4NjgzOGNkN2VjMGMyYjZlNGMzNzMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IFdlZCwgMjMgRGVjIDIwMDkgMTI6NTE6MTAgLTAyMDAK U3ViamVjdDogW1BBVENIXSBBdm9pZCBjcmFzaGluZyB3aXRoIHBhZ2UgY2FjaGUKCi0tLQogV2Vi S2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxOCArKysrKysr KysrKysrKysrKysKIFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNw cCB8ICAgMjAgKysrKysrKysrKysrKysrLS0tLS0KIFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQv RWRpdG9yQ2xpZW50R3RrLmggICB8ICAgIDIgKy0KIDMgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0 aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxv ZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDZmZDJmZDMuLjY0NmM4NTMgMTAwNjQ0Ci0t LSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjEgQEAKKzIwMDktMTItMjMgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8u bm9yb25oYUBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW0dUS10gQ3Jhc2hlcyBjbGVhbmluZyBjbGlwYm9hcmQgY29udGVu dHMsIHdpdGggcGFnZSBjYWNoZSBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMjkwMAorCisgICAgICAgIE1ha2UgRWRpdG9yQ2xpZW50R3Rr IHJlZmNvdW50ZWQsIGFuZCB1c2UgZXhwbGljdCByZWZzIHRvIGF2b2lkCisgICAgICAgIGNhbGxp bmcgY2FsbGJhY2tzIG9uIGEgZGVhZCBjbGllbnQuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9y dC9FZGl0b3JDbGllbnRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpjbGlwYm9hcmRfZ2V0X2Nv bnRlbnRzX2NiKToKKyAgICAgICAgKFdlYktpdDo6Y2xpcGJvYXJkX2NsZWFyX2NvbnRlbnRzX2Ni KToKKyAgICAgICAgKFdlYktpdDo6RWRpdG9yQ2xpZW50OjpyZXNwb25kVG9DaGFuZ2VkU2VsZWN0 aW9uKToKKyAgICAgICAgKFdlYktpdDo6RWRpdG9yQ2xpZW50OjpwYWdlRGVzdHJveWVkKToKKyAg ICAgICAgKFdlYktpdDo6RWRpdG9yQ2xpZW50Ojp+RWRpdG9yQ2xpZW50KToKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuaDoKKwogMjAwOS0xMi0yMCAgR3VzdGF2byBO b3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KIAogICAgICAg ICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL1dlYkNvcmVT dXBwb3J0L0VkaXRvckNsaWVudEd0ay5jcHAgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Vk aXRvckNsaWVudEd0ay5jcHAKaW5kZXggYjg1NjZhMi4uOTlkMDgyOSAxMDA2NDQKLS0tIGEvV2Vi S2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwCisrKyBiL1dlYktpdC9n dGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcApAQCAtMTg5LDggKzE4OSwxMCBA QCB2b2lkIGNsaXBib2FyZF9nZXRfY29udGVudHNfY2IoR3RrQ2xpcGJvYXJkKiBjbGlwYm9hcmQs IEd0a1NlbGVjdGlvbkRhdGEqIHNlbGVjdAogewogICAgIEVkaXRvckNsaWVudCogY2xpZW50ID0g c3RhdGljX2Nhc3Q8RWRpdG9yQ2xpZW50Kj4oZGF0YSk7CiAKLSAgICBpZiAoIWNsaWVudC0+bV9y YW5nZSkKKyAgICBpZiAoIWNsaWVudC0+bV9yYW5nZSkgeworICAgICAgICBjbGllbnQtPmRlcmVm KCk7CiAgICAgICAgIHJldHVybjsKKyAgICB9CiAKICAgICBpZiAoc3RhdGljX2Nhc3Q8Z2ludD4o aW5mbykgPT0gV0VCS0lUX1dFQl9WSUVXX1RBUkdFVF9JTkZPX0hUTUwpIHsKICAgICAgICAgU3Ry aW5nIG1hcmt1cCA9IGNyZWF0ZU1hcmt1cChjbGllbnQtPm1fcmFuZ2UuZ2V0KCksIDAsIEFubm90 YXRlRm9ySW50ZXJjaGFuZ2UpOwpAQCAtMjAwLDYgKzIwMiw4IEBAIHZvaWQgY2xpcGJvYXJkX2dl dF9jb250ZW50c19jYihHdGtDbGlwYm9hcmQqIGNsaXBib2FyZCwgR3RrU2VsZWN0aW9uRGF0YSog c2VsZWN0CiAgICAgICAgIFN0cmluZyB0ZXh0ID0gY2xpZW50LT5tX3JhbmdlLT50ZXh0KCk7CiAg ICAgICAgIGd0a19zZWxlY3Rpb25fZGF0YV9zZXRfdGV4dChzZWxlY3Rpb25fZGF0YSwgdGV4dC51 dGY4KCkuZGF0YSgpLCB0ZXh0LnV0ZjgoKS5sZW5ndGgoKSk7CiAgICAgfQorCisgICAgY2xpZW50 LT5kZXJlZigpOwogfQogCiB2b2lkIGNsaXBib2FyZF9jbGVhcl9jb250ZW50c19jYihHdGtDbGlw Ym9hcmQqIGNsaXBib2FyZCwgZ3BvaW50ZXIgZGF0YSkKQEAgLTIwNyw2ICsyMTEsNyBAQCB2b2lk IGNsaXBib2FyZF9jbGVhcl9jb250ZW50c19jYihHdGtDbGlwYm9hcmQqIGNsaXBib2FyZCwgZ3Bv aW50ZXIgZGF0YSkKICAgICBFZGl0b3JDbGllbnQqIGNsaWVudCA9IHN0YXRpY19jYXN0PEVkaXRv ckNsaWVudCo+KGRhdGEpOwogCiAgICAgY2xpZW50LT5tX3JhbmdlID0gMDsKKyAgICBjbGllbnQt PmRlcmVmKCk7CiB9CiAKIHZvaWQgRWRpdG9yQ2xpZW50OjpyZXNwb25kVG9DaGFuZ2VkU2VsZWN0 aW9uKCkKQEAgLTIyOSw2ICsyMzQsOSBAQCB2b2lkIEVkaXRvckNsaWVudDo6cmVzcG9uZFRvQ2hh bmdlZFNlbGVjdGlvbigpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjbGlw Ym9hcmRfZ2V0X2NvbnRlbnRzX2NiLCBjbGlwYm9hcmRfY2xlYXJfY29udGVudHNfY2IsIHRoaXMp OwogICAgICAgICBtX3JhbmdlID0gdGFyZ2V0RnJhbWUtPnNlbGVjdGlvbigpLT50b05vcm1hbGl6 ZWRSYW5nZSgpOwogICAgICAgICBndGtfdGFyZ2V0X3RhYmxlX2ZyZWUodGFyZ2V0cywgdGFyZ2V0 Q291bnQpOworCisgICAgICAgIC8vIEJhbGFuY2VkIGluIGNsaXBib2FyZF9nZXRfY29udGVudHNf Y2IsIGFuZCBjbGlwYm9hcmRfY2xlYXJfY29udGVudHNfY2IuCisgICAgICAgIHRoaXMtPnJlZigp OwogICAgIH0KIAogICAgIGlmICghdGFyZ2V0RnJhbWUtPmVkaXRvcigpLT5oYXNDb21wb3NpdGlv bigpKQpAQCAtMzI1LDcgKzMzMywxMiBAQCBib29sIEVkaXRvckNsaWVudDo6c2hvdWxkSW5zZXJ0 Tm9kZShOb2RlKiwgUmFuZ2UqLCBFZGl0b3JJbnNlcnRBY3Rpb24pCiAKIHZvaWQgRWRpdG9yQ2xp ZW50OjpwYWdlRGVzdHJveWVkKCkKIHsKLSAgICBkZWxldGUgdGhpczsKKyAgICAvLyBXZSBuZWVk IHRvIGRvIHRoaXMgZWFybHksIGJlY2F1c2UgdGhlIFdlYlZpZXcgaXMgZ29pbmcgdG8gYmUgZGVz dHJveWVkLgorICAgIFdlYktpdFdlYlZpZXdQcml2YXRlKiBwcml2ID0gbV93ZWJWaWV3LT5wcml2 OworICAgIGdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3RfYnlfZnVuYyhwcml2LT5pbUNvbnRl eHQsIChncG9pbnRlcilpbUNvbnRleHRDb21taXR0ZWQsIHRoaXMpOworICAgIGdfc2lnbmFsX2hh bmRsZXJzX2Rpc2Nvbm5lY3RfYnlfZnVuYyhwcml2LT5pbUNvbnRleHQsIChncG9pbnRlcilpbUNv bnRleHRQcmVlZGl0Q2hhbmdlZCwgdGhpcyk7CisKKyAgICB0aGlzLT5kZXJlZigpOwogfQogCiBi b29sIEVkaXRvckNsaWVudDo6c21hcnRJbnNlcnREZWxldGVFbmFibGVkKCkKQEAgLTU1OSw5ICs1 NzIsNiBAQCBFZGl0b3JDbGllbnQ6OkVkaXRvckNsaWVudChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3 KQogCiBFZGl0b3JDbGllbnQ6On5FZGl0b3JDbGllbnQoKQogewotICAgIFdlYktpdFdlYlZpZXdQ cml2YXRlKiBwcml2ID0gbV93ZWJWaWV3LT5wcml2OwotICAgIGdfc2lnbmFsX2hhbmRsZXJzX2Rp c2Nvbm5lY3RfYnlfZnVuYyhwcml2LT5pbUNvbnRleHQsIChncG9pbnRlcilpbUNvbnRleHRDb21t aXR0ZWQsIHRoaXMpOwotICAgIGdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3RfYnlfZnVuYyhw cml2LT5pbUNvbnRleHQsIChncG9pbnRlcilpbUNvbnRleHRQcmVlZGl0Q2hhbmdlZCwgdGhpcyk7 CiB9CiAKIHZvaWQgRWRpdG9yQ2xpZW50Ojp0ZXh0RmllbGREaWRCZWdpbkVkaXRpbmcoRWxlbWVu dCopCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0 ay5oIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuaAppbmRleCAz M2VmYTRkLi45ZTUwNjU3IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Vk aXRvckNsaWVudEd0ay5oCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xp ZW50R3RrLmgKQEAgLTQ0LDcgKzQ0LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBuYW1lc3Bh Y2UgV2ViS2l0IHsKIAotICAgIGNsYXNzIEVkaXRvckNsaWVudCA6IHB1YmxpYyBXZWJDb3JlOjpF ZGl0b3JDbGllbnQgeworICAgIGNsYXNzIEVkaXRvckNsaWVudCA6IHB1YmxpYyBSZWZDb3VudGVk PEVkaXRvckNsaWVudD4sIHB1YmxpYyBXZWJDb3JlOjpFZGl0b3JDbGllbnQgewogICAgIHByb3Rl Y3RlZDoKICAgICAgICAgYm9vbCBtX2lzSW5SZWRvOwogCi0tIAoxLjYuNS4zCgo= 46621 2010-01-14 17:09:19 -0800 2010-01-16 16:24:34 -0800 Null-check the focus controller, because it may be null when the callback is called, leading to crash 0001-Null-check-focus-controller-when-clearing-clipboard-.patch text/plain 1908 gustavo RnJvbSA5OWQyOWNmYTIwNDBiMWVjNjA3ZThlY2U2NWIxOTNhZGVkZGVjNTRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IFRodSwgMTQgSmFuIDIwMTAgMjM6MDY6NTIgLTAyMDAKU3ViamVjdDogW1BBVENIXSBO dWxsIGNoZWNrIGZvY3VzIGNvbnRyb2xsZXIgd2hlbiBjbGVhcmluZyBjbGlwYm9hcmQgY29udGVu dHMKCi0tLQogV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB8ICAgMTMgKysrKysrKysrKysrKwogV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QYXN0ZWJv YXJkSGVscGVyR3RrLmNwcCB8ICAgIDQgKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRp b25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9n IGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggN2Y5ZjhlYi4uNWI2ZjcxMSAxMDA2NDQKLS0t IGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxMC0wMS0xNCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21l Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb R1RLXSBDcmFzaGVzIGNsZWFuaW5nIGNsaXBib2FyZCBjb250ZW50cywgd2l0aCBwYWdlIGNhY2hl IGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMyOTAwCisKKyAgICAgICAgTnVsbC1jaGVjayB0aGUgZm9jdXMgY29udHJvbGxlciB0byBhdm9p ZCBjcmFzaGluZy4gQ291bGQgbm90IGZpbmQKKyAgICAgICAgYSB3YXkgdG8gcmVwcm9kdWNlIHRo aXMgY29uc2lzdGVudGx5LCB0aHVzIG5vIHRlc3QuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9y dC9QYXN0ZWJvYXJkSGVscGVyR3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Y2xlYXJDbGlwYm9h cmRDb250ZW50c0NhbGxiYWNrKToKKworMjAxMC0wMS0xNCAgR3VzdGF2byBOb3JvbmhhIFNpbHZh ICA8Z25zQGdub21lLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudGVyLgog CiAgICAgICAgIFtHVEtdIGNvdXBsZSBmaXhlcyBmb3Igc2lnbmFsIGVtaXNzaW9ucywgYW5kIHBy b3BlcnR5IG5vdGlmaWNhdGlvbnMKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBv cnQvUGFzdGVib2FyZEhlbHBlckd0ay5jcHAgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L1Bh c3RlYm9hcmRIZWxwZXJHdGsuY3BwCmluZGV4IDRkYzJiNTAuLjM3ZjNiMTggMTAwNjQ0Ci0tLSBh L1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvUGFzdGVib2FyZEhlbHBlckd0ay5jcHAKKysrIGIv V2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QYXN0ZWJvYXJkSGVscGVyR3RrLmNwcApAQCAtMTI2 LDYgKzEyNiwxMCBAQCBzdGF0aWMgdm9pZCBjbGVhckNsaXBib2FyZENvbnRlbnRzQ2FsbGJhY2so R3RrQ2xpcGJvYXJkKiBjbGlwYm9hcmQsIGdwb2ludGVyIGRhdAogICAgIGRhdGFPYmplY3QtPmNs ZWFyKCk7CiAgICAgaWYgKGRhdGEpIHsKICAgICAgICAgV2ViQ29yZTo6UGFnZSogY29yZVBhZ2Ug PSByZWludGVycHJldF9jYXN0PFdlYkNvcmU6OlBhZ2UqPihkYXRhKTsKKworICAgICAgICBpZiAo IWNvcmVQYWdlLT5mb2N1c0NvbnRyb2xsZXIoKSkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAg ICAgICBGcmFtZSogZnJhbWUgPSBjb3JlUGFnZS0+Zm9jdXNDb250cm9sbGVyKCktPmZvY3VzZWRP ck1haW5GcmFtZSgpOwogCiAgICAgICAgIC8vIENvbGxhcHNlIHRoZSBzZWxlY3Rpb24gd2l0aG91 dCBjbGVhcmluZyBpdAotLSAKMS42LjUuNwoK 46753 2010-01-16 16:28:28 -0800 2010-01-17 16:51:10 -0800 Fix crash by passing WebView object to the clipboard functions instead of Page 0001-Fix-crash-by-passing-WebView-object-to-the-clipboard.patch text/plain 5426 gustavo RnJvbSBiMGI1OTg1NDRkZGYwMjUxOTMzM2U5NmZkMzZmZjc4ZmU3YTU0NzNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IEZyaSwgMTUgSmFuIDIwMTAgMjE6MDg6MjkgLTAyMDAKU3ViamVjdDogW1BBVENIXSBG aXggY3Jhc2ggYnkgcGFzc2luZyBXZWJWaWV3IG9iamVjdCB0byB0aGUgY2xpcGJvYXJkIGZ1bmN0 aW9ucyBpbnN0ZWFkIG9mIFBhZ2UKCi0tLQogV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTkgKysrKysrKysrCiBXZWJLaXQvZ3RrL1dlYkNvcmVT dXBwb3J0L0VkaXRvckNsaWVudEd0ay5jcHAgICAgIHwgICAgMiArLQogV2ViS2l0L2d0ay9XZWJD b3JlU3VwcG9ydC9QYXN0ZWJvYXJkSGVscGVyR3RrLmNwcCB8ICAgNDQgKysrKysrKysrKysrKysr LS0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDUyIGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VM b2cKaW5kZXggMDM3ZjI4ZC4uNjY1MDRjMCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wMS0x NSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBNb3JlIGNyYXNoZXMgcmVs YXRlZCB0byB0aGUgY2xpcGJvYXJkIG1hbmFnZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNzQ2CisKKyAgICAgICAgUGFzcyB0aGUgV2ViS2l0 V2ViVmlldyBvYmplY3QgKHdoaWNoIGlzIGEgR09iamVjdCwgdGh1cworICAgICAgICByZWYtY291 bnRlZCkgdG8gdGhlIGNsaXBib2FyZCBmdW5jdGlvbnMgaW5zdGVhZCBvZiBwYXNzaW5nIHRoZQor ICAgICAgICBQYWdlIC0gdGhpcyBhbGxvd3MgdXMgdG8gZXhwbGljaXRlbHkgcHJvdGVjdCB0aGUg b2JqZWN0IGluYmV0d2VlbgorICAgICAgICB0aGUgY2xpcGJvYXJkIGNhbGwgYW5kIGl0cyBjYWxs YmFja3MsIHdoaWNoIGZpeGVzIHRoZSBjcmFzaC4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0 L0VkaXRvckNsaWVudEd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OkVkaXRvckNsaWVudDo6cmVz cG9uZFRvQ2hhbmdlZFNlbGVjdGlvbik6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvUGFzdGVi b2FyZEhlbHBlckd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OmdldENsaXBib2FyZENvbnRlbnRz Q2FsbGJhY2spOgorICAgICAgICAoV2ViS2l0OjpjbGVhckNsaXBib2FyZENvbnRlbnRzQ2FsbGJh Y2spOgorICAgICAgICAoV2ViS2l0OjpQYXN0ZWJvYXJkSGVscGVyR3RrOjp3cml0ZUNsaXBib2Fy ZENvbnRlbnRzKToKKwogMjAxMC0wMS0xNCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdu b21lLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBh L1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcCBiL1dlYktpdC9n dGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcAppbmRleCAyNjY3MjNiLi4wMmQx YTUzIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0 ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3Bw CkBAIC0yMDYsNyArMjA2LDcgQEAgdm9pZCBFZGl0b3JDbGllbnQ6OnJlc3BvbmRUb0NoYW5nZWRT ZWxlY3Rpb24oKQogICAgIGlmICh0YXJnZXRGcmFtZS0+c2VsZWN0aW9uKCktPmlzUmFuZ2UoKSkg ewogICAgICAgICBkYXRhT2JqZWN0LT5jbGVhcigpOwogICAgICAgICBkYXRhT2JqZWN0LT5zZXRS YW5nZSh0YXJnZXRGcmFtZS0+c2VsZWN0aW9uKCktPnRvTm9ybWFsaXplZFJhbmdlKCkpOwotICAg ICAgICBwYXN0ZWJvYXJkSGVscGVySW5zdGFuY2UoKS0+d3JpdGVDbGlwYm9hcmRDb250ZW50cyhj bGlwYm9hcmQsIGNvcmVQYWdlKTsKKyAgICAgICAgcGFzdGVib2FyZEhlbHBlckluc3RhbmNlKCkt PndyaXRlQ2xpcGJvYXJkQ29udGVudHMoY2xpcGJvYXJkLCBtX3dlYlZpZXcpOwogICAgIH0KICNl bmRpZgogCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L1Bhc3RlYm9hcmRI ZWxwZXJHdGsuY3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QYXN0ZWJvYXJkSGVscGVy R3RrLmNwcAppbmRleCAzN2YzYjE4Li5hMmVjYmIzIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dl YkNvcmVTdXBwb3J0L1Bhc3RlYm9hcmRIZWxwZXJHdGsuY3BwCisrKyBiL1dlYktpdC9ndGsvV2Vi Q29yZVN1cHBvcnQvUGFzdGVib2FyZEhlbHBlckd0ay5jcHAKQEAgLTExMSw2ICsxMTEsOSBAQCBz dGF0aWMgdm9pZCBnZXRDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrKEd0a0NsaXBib2FyZCogY2xp cGJvYXJkLCBHdGtTZWxlY3Rpb25EYQogICAgIERhdGFPYmplY3RHdGsqIGRhdGFPYmplY3QgPSBE YXRhT2JqZWN0R3RrOjpmb3JDbGlwYm9hcmQoY2xpcGJvYXJkKTsKICAgICBBU1NFUlQoZGF0YU9i amVjdCk7CiAgICAgZmlsbFNlbGVjdGlvbkRhdGEoc2VsZWN0aW9uRGF0YSwgaW5mbywgZGF0YU9i amVjdCk7CisKKyAgICBXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3ID0gc3RhdGljX2Nhc3Q8V2ViS2l0 V2ViVmlldyo+KGRhdGEpOworICAgIGdfb2JqZWN0X3VucmVmKHdlYlZpZXcpOwogfQogCiBzdGF0 aWMgdm9pZCBjbGVhckNsaXBib2FyZENvbnRlbnRzQ2FsbGJhY2soR3RrQ2xpcGJvYXJkKiBjbGlw Ym9hcmQsIGdwb2ludGVyIGRhdGEpCkBAIC0xMjMsMTkgKzEyNiwyNiBAQCBzdGF0aWMgdm9pZCBj bGVhckNsaXBib2FyZENvbnRlbnRzQ2FsbGJhY2soR3RrQ2xpcGJvYXJkKiBjbGlwYm9hcmQsIGdw b2ludGVyIGRhdAogICAgIERhdGFPYmplY3RHdGsqIGRhdGFPYmplY3QgPSBEYXRhT2JqZWN0R3Rr Ojpmb3JDbGlwYm9hcmQoY2xpcGJvYXJkKTsKICAgICBBU1NFUlQoZGF0YU9iamVjdCk7CiAKKyAg ICAvLyBUaGlzIHdpbGwgYmUgdHJ1ZSBmb3IgY2xpcGJvYXJkcyBvdGhlciB0aGFuIFgxMSBwcmlt YXJ5LgorICAgIGlmICghZGF0YSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgZGF0YU9iamVjdC0+ Y2xlYXIoKTsKLSAgICBpZiAoZGF0YSkgewotICAgICAgICBXZWJDb3JlOjpQYWdlKiBjb3JlUGFn ZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8V2ViQ29yZTo6UGFnZSo+KGRhdGEpOworICAgIFdlYktpdFdl YlZpZXcqIHdlYlZpZXcgPSByZWludGVycHJldF9jYXN0PFdlYktpdFdlYlZpZXcqPihkYXRhKTsK KyAgICBXZWJDb3JlOjpQYWdlKiBjb3JlUGFnZSA9IGNvcmUod2ViVmlldyk7CisKKyAgICBpZiAo IWNvcmVQYWdlIHx8ICFjb3JlUGFnZS0+Zm9jdXNDb250cm9sbGVyKCkpIHsKKyAgICAgICAgZ19v YmplY3RfdW5yZWYod2ViVmlldyk7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAKLSAgICAgICAg aWYgKCFjb3JlUGFnZS0+Zm9jdXNDb250cm9sbGVyKCkpCi0gICAgICAgICAgICByZXR1cm47Cisg ICAgRnJhbWUqIGZyYW1lID0gY29yZVBhZ2UtPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JN YWluRnJhbWUoKTsKIAotICAgICAgICBGcmFtZSogZnJhbWUgPSBjb3JlUGFnZS0+Zm9jdXNDb250 cm9sbGVyKCktPmZvY3VzZWRPck1haW5GcmFtZSgpOworICAgIC8vIENvbGxhcHNlIHRoZSBzZWxl Y3Rpb24gd2l0aG91dCBjbGVhcmluZyBpdAorICAgIEFTU0VSVChmcmFtZSk7CisgICAgZnJhbWUt PnNlbGVjdGlvbigpLT5zZXRCYXNlKGZyYW1lLT5zZWxlY3Rpb24oKS0+ZXh0ZW50KCksIGZyYW1l LT5zZWxlY3Rpb24oKS0+YWZmaW5pdHkoKSk7CiAKLSAgICAgICAgLy8gQ29sbGFwc2UgdGhlIHNl bGVjdGlvbiB3aXRob3V0IGNsZWFyaW5nIGl0Ci0gICAgICAgIEFTU0VSVChmcmFtZSk7Ci0gICAg ICAgIGZyYW1lLT5zZWxlY3Rpb24oKS0+c2V0QmFzZShmcmFtZS0+c2VsZWN0aW9uKCktPmV4dGVu dCgpLCBmcmFtZS0+c2VsZWN0aW9uKCktPmFmZmluaXR5KCkpOwotICAgIH0KKyAgICBnX29iamVj dF91bnJlZih3ZWJWaWV3KTsKIH0KIAogdm9pZCBQYXN0ZWJvYXJkSGVscGVyR3RrOjp3cml0ZUNs aXBib2FyZENvbnRlbnRzKEd0a0NsaXBib2FyZCogY2xpcGJvYXJkLCBncG9pbnRlciBkYXRhKQpA QCAtMTQ4LDkgKzE1OCwxOSBAQCB2b2lkIFBhc3RlYm9hcmRIZWxwZXJHdGs6OndyaXRlQ2xpcGJv YXJkQ29udGVudHMoR3RrQ2xpcGJvYXJkKiBjbGlwYm9hcmQsIGdwb2ludAogCiAgICAgaWYgKG51 bWJlck9mVGFyZ2V0cyA+IDAgJiYgdGFibGUpIHsKICAgICAgICAgc2V0dGluZ0NsaXBib2FyZCA9 IHRydWU7Ci0gICAgICAgIGd0a19jbGlwYm9hcmRfc2V0X3dpdGhfZGF0YShjbGlwYm9hcmQsIHRh YmxlLCBudW1iZXJPZlRhcmdldHMsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBnZXRDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrLAotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY2xlYXJDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrLCBkYXRhKTsKKworICAg ICAgICAvLyBQcm90ZWN0IHRoZSB3ZWIgdmlldyBmcm9tIGJlaW5nIGRlc3Ryb3llZCBiZWZvcmUg b25lIG9mIHRoZSBjbGlwYm9hcmQgY2FsbGJhY2tzCisgICAgICAgIC8vIGlzIGNhbGxlZC4gQmFs YW5jZWQgaW4gYm90aCBnZXRDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrIGFuZAorICAgICAgICAv LyBjbGVhckNsaXBib2FyZENvbnRlbnRzQ2FsbGJhY2suCisgICAgICAgIFdlYktpdFdlYlZpZXcq IHdlYlZpZXcgPSBzdGF0aWNfY2FzdDxXZWJLaXRXZWJWaWV3Kj4oZGF0YSk7CisgICAgICAgIGdf b2JqZWN0X3JlZih3ZWJWaWV3KTsKKworICAgICAgICBnYm9vbGVhbiBzdWNjZWVkZWQgPSBndGtf Y2xpcGJvYXJkX3NldF93aXRoX2RhdGEoY2xpcGJvYXJkLCB0YWJsZSwgbnVtYmVyT2ZUYXJnZXRz LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZ2V0Q2xpcGJvYXJkQ29udGVudHNDYWxsYmFjaywKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsZWFyQ2xpcGJvYXJkQ29udGVudHND YWxsYmFjaywgZGF0YSk7CisgICAgICAgIGlmICghc3VjY2VlZGVkKQorICAgICAgICAgICAgZ19v YmplY3RfdW5yZWYod2ViVmlldyk7CisKICAgICAgICAgc2V0dGluZ0NsaXBib2FyZCA9IGZhbHNl OwogICAgIH0gZWxzZQogICAgICAgICBndGtfY2xpcGJvYXJkX2NsZWFyKGNsaXBib2FyZCk7Ci0t IAoxLjYuNS43Cgo= 46772 2010-01-17 16:51:10 -0800 2010-01-19 04:40:07 -0800 Fix crash by passing WebView instead of Page 0001-Fix-crash-by-passing-WebView-object-to-the-clipboard.patch text/plain 4982 gustavo RnJvbSBlOTAyYjc5ZGYzM2ZhZmE2ZDA1YTQ5YWFjODZjMTFiYTAxZjkzZGZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IEZyaSwgMTUgSmFuIDIwMTAgMjE6MDg6MjkgLTAyMDAKU3ViamVjdDogW1BBVENIXSBG aXggY3Jhc2ggYnkgcGFzc2luZyBXZWJWaWV3IG9iamVjdCB0byB0aGUgY2xpcGJvYXJkIGZ1bmN0 aW9ucyBpbnN0ZWFkIG9mIFBhZ2UKCi0tLQogV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTkgKysrKysrKysrKwogV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwICAgICB8ICAgIDIgKy0KIFdlYktpdC9ndGsvV2Vi Q29yZVN1cHBvcnQvUGFzdGVib2FyZEhlbHBlckd0ay5jcHAgfCAgIDQxICsrKysrKysrKysrKysr Ky0tLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCA0OSBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdl TG9nCmluZGV4IDAzN2YyOGQuLjY2NTA0YzAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdl TG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMDEt MTUgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gTW9yZSBjcmFzaGVzIHJl bGF0ZWQgdG8gdGhlIGNsaXBib2FyZCBtYW5hZ2VtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzc0NgorCisgICAgICAgIFBhc3MgdGhlIFdlYktp dFdlYlZpZXcgb2JqZWN0ICh3aGljaCBpcyBhIEdPYmplY3QsIHRodXMKKyAgICAgICAgcmVmLWNv dW50ZWQpIHRvIHRoZSBjbGlwYm9hcmQgZnVuY3Rpb25zIGluc3RlYWQgb2YgcGFzc2luZyB0aGUK KyAgICAgICAgUGFnZSAtIHRoaXMgYWxsb3dzIHVzIHRvIGV4cGxpY2l0ZWx5IHByb3RlY3QgdGhl IG9iamVjdCBpbmJldHdlZW4KKyAgICAgICAgdGhlIGNsaXBib2FyZCBjYWxsIGFuZCBpdHMgY2Fs bGJhY2tzLCB3aGljaCBmaXhlcyB0aGUgY3Jhc2guCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9y dC9FZGl0b3JDbGllbnRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpFZGl0b3JDbGllbnQ6OnJl c3BvbmRUb0NoYW5nZWRTZWxlY3Rpb24pOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1Bhc3Rl Ym9hcmRIZWxwZXJHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpnZXRDbGlwYm9hcmRDb250ZW50 c0NhbGxiYWNrKToKKyAgICAgICAgKFdlYktpdDo6Y2xlYXJDbGlwYm9hcmRDb250ZW50c0NhbGxi YWNrKToKKyAgICAgICAgKFdlYktpdDo6UGFzdGVib2FyZEhlbHBlckd0azo6d3JpdGVDbGlwYm9h cmRDb250ZW50cyk6CisKIDIwMTAtMDEtMTQgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bn bm9tZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQg YS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0ay5jcHAgYi9XZWJLaXQv Z3RrL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0ay5jcHAKaW5kZXggMjY2NzIzYi4uMDJk MWE1MyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRH dGsuY3BwCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNw cApAQCAtMjA2LDcgKzIwNiw3IEBAIHZvaWQgRWRpdG9yQ2xpZW50OjpyZXNwb25kVG9DaGFuZ2Vk U2VsZWN0aW9uKCkKICAgICBpZiAodGFyZ2V0RnJhbWUtPnNlbGVjdGlvbigpLT5pc1JhbmdlKCkp IHsKICAgICAgICAgZGF0YU9iamVjdC0+Y2xlYXIoKTsKICAgICAgICAgZGF0YU9iamVjdC0+c2V0 UmFuZ2UodGFyZ2V0RnJhbWUtPnNlbGVjdGlvbigpLT50b05vcm1hbGl6ZWRSYW5nZSgpKTsKLSAg ICAgICAgcGFzdGVib2FyZEhlbHBlckluc3RhbmNlKCktPndyaXRlQ2xpcGJvYXJkQ29udGVudHMo Y2xpcGJvYXJkLCBjb3JlUGFnZSk7CisgICAgICAgIHBhc3RlYm9hcmRIZWxwZXJJbnN0YW5jZSgp LT53cml0ZUNsaXBib2FyZENvbnRlbnRzKGNsaXBib2FyZCwgbV93ZWJWaWV3KTsKICAgICB9CiAj ZW5kaWYKIApkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QYXN0ZWJvYXJk SGVscGVyR3RrLmNwcCBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvUGFzdGVib2FyZEhlbHBl ckd0ay5jcHAKaW5kZXggMzdmM2IxOC4uODQwNmFkYSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9X ZWJDb3JlU3VwcG9ydC9QYXN0ZWJvYXJkSGVscGVyR3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dl YkNvcmVTdXBwb3J0L1Bhc3RlYm9hcmRIZWxwZXJHdGsuY3BwCkBAIC0xMjIsMjAgKzEyMiwyNyBA QCBzdGF0aWMgdm9pZCBjbGVhckNsaXBib2FyZENvbnRlbnRzQ2FsbGJhY2soR3RrQ2xpcGJvYXJk KiBjbGlwYm9hcmQsIGdwb2ludGVyIGRhdAogCiAgICAgRGF0YU9iamVjdEd0ayogZGF0YU9iamVj dCA9IERhdGFPYmplY3RHdGs6OmZvckNsaXBib2FyZChjbGlwYm9hcmQpOwogICAgIEFTU0VSVChk YXRhT2JqZWN0KTsKLQogICAgIGRhdGFPYmplY3QtPmNsZWFyKCk7Ci0gICAgaWYgKGRhdGEpIHsK LSAgICAgICAgV2ViQ29yZTo6UGFnZSogY29yZVBhZ2UgPSByZWludGVycHJldF9jYXN0PFdlYkNv cmU6OlBhZ2UqPihkYXRhKTsKIAotICAgICAgICBpZiAoIWNvcmVQYWdlLT5mb2N1c0NvbnRyb2xs ZXIoKSkKLSAgICAgICAgICAgIHJldHVybjsKKyAgICAvLyBUaGlzIHdpbGwgYmUgdHJ1ZSBmb3Ig Y2xpcGJvYXJkcyBvdGhlciB0aGFuIFgxMSBwcmltYXJ5LgorICAgIGlmICghZGF0YSkKKyAgICAg ICAgcmV0dXJuOwogCi0gICAgICAgIEZyYW1lKiBmcmFtZSA9IGNvcmVQYWdlLT5mb2N1c0NvbnRy b2xsZXIoKS0+Zm9jdXNlZE9yTWFpbkZyYW1lKCk7CisgICAgV2ViS2l0V2ViVmlldyogd2ViVmll dyA9IHJlaW50ZXJwcmV0X2Nhc3Q8V2ViS2l0V2ViVmlldyo+KGRhdGEpOworICAgIFdlYkNvcmU6 OlBhZ2UqIGNvcmVQYWdlID0gY29yZSh3ZWJWaWV3KTsKIAotICAgICAgICAvLyBDb2xsYXBzZSB0 aGUgc2VsZWN0aW9uIHdpdGhvdXQgY2xlYXJpbmcgaXQKLSAgICAgICAgQVNTRVJUKGZyYW1lKTsK LSAgICAgICAgZnJhbWUtPnNlbGVjdGlvbigpLT5zZXRCYXNlKGZyYW1lLT5zZWxlY3Rpb24oKS0+ ZXh0ZW50KCksIGZyYW1lLT5zZWxlY3Rpb24oKS0+YWZmaW5pdHkoKSk7CisgICAgaWYgKCFjb3Jl UGFnZSB8fCAhY29yZVBhZ2UtPmZvY3VzQ29udHJvbGxlcigpKSB7CisgICAgICAgIGdfb2JqZWN0 X3VucmVmKHdlYlZpZXcpOworICAgICAgICByZXR1cm47CiAgICAgfQorCisgICAgRnJhbWUqIGZy YW1lID0gY29yZVBhZ2UtPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JNYWluRnJhbWUoKTsK KworICAgIC8vIENvbGxhcHNlIHRoZSBzZWxlY3Rpb24gd2l0aG91dCBjbGVhcmluZyBpdAorICAg IEFTU0VSVChmcmFtZSk7CisgICAgZnJhbWUtPnNlbGVjdGlvbigpLT5zZXRCYXNlKGZyYW1lLT5z ZWxlY3Rpb24oKS0+ZXh0ZW50KCksIGZyYW1lLT5zZWxlY3Rpb24oKS0+YWZmaW5pdHkoKSk7CisK KyAgICBnX29iamVjdF91bnJlZih3ZWJWaWV3KTsKIH0KIAogdm9pZCBQYXN0ZWJvYXJkSGVscGVy R3RrOjp3cml0ZUNsaXBib2FyZENvbnRlbnRzKEd0a0NsaXBib2FyZCogY2xpcGJvYXJkLCBncG9p bnRlciBkYXRhKQpAQCAtMTQ4LDkgKzE1NSwxOSBAQCB2b2lkIFBhc3RlYm9hcmRIZWxwZXJHdGs6 OndyaXRlQ2xpcGJvYXJkQ29udGVudHMoR3RrQ2xpcGJvYXJkKiBjbGlwYm9hcmQsIGdwb2ludAog CiAgICAgaWYgKG51bWJlck9mVGFyZ2V0cyA+IDAgJiYgdGFibGUpIHsKICAgICAgICAgc2V0dGlu Z0NsaXBib2FyZCA9IHRydWU7Ci0gICAgICAgIGd0a19jbGlwYm9hcmRfc2V0X3dpdGhfZGF0YShj bGlwYm9hcmQsIHRhYmxlLCBudW1iZXJPZlRhcmdldHMsCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBnZXRDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrLAotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgY2xlYXJDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrLCBk YXRhKTsKKworICAgICAgICAvLyBQcm90ZWN0IHRoZSB3ZWIgdmlldyBmcm9tIGJlaW5nIGRlc3Ry b3llZCBiZWZvcmUgb25lIG9mIHRoZSBjbGlwYm9hcmQgY2FsbGJhY2tzCisgICAgICAgIC8vIGlz IGNhbGxlZC4gQmFsYW5jZWQgaW4gYm90aCBnZXRDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrIGFu ZAorICAgICAgICAvLyBjbGVhckNsaXBib2FyZENvbnRlbnRzQ2FsbGJhY2suCisgICAgICAgIFdl YktpdFdlYlZpZXcqIHdlYlZpZXcgPSBzdGF0aWNfY2FzdDxXZWJLaXRXZWJWaWV3Kj4oZGF0YSk7 CisgICAgICAgIGdfb2JqZWN0X3JlZih3ZWJWaWV3KTsKKworICAgICAgICBnYm9vbGVhbiBzdWNj ZWVkZWQgPSBndGtfY2xpcGJvYXJkX3NldF93aXRoX2RhdGEoY2xpcGJvYXJkLCB0YWJsZSwgbnVt YmVyT2ZUYXJnZXRzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZ2V0Q2xpcGJvYXJkQ29udGVudHNDYWxsYmFjaywKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsZWFyQ2xpcGJv YXJkQ29udGVudHNDYWxsYmFjaywgZGF0YSk7CisgICAgICAgIGlmICghc3VjY2VlZGVkKQorICAg ICAgICAgICAgZ19vYmplY3RfdW5yZWYod2ViVmlldyk7CisKICAgICAgICAgc2V0dGluZ0NsaXBi b2FyZCA9IGZhbHNlOwogICAgIH0gZWxzZQogICAgICAgICBndGtfY2xpcGJvYXJkX2NsZWFyKGNs aXBib2FyZCk7Ci0tIAoxLjYuNS43Cgo=