32891 2009-12-22 18:35:30 -0800 Include stddef.h for ptrdiff_t 2009-12-23 18:15:59 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned abarth commit-queue eric laszlo.gombos webkit.review.bot oldest_to_newest 174504 0 skyul 2009-12-22 18:35:30 -0800 [ 509/1814] cxx: JavaScriptCore\assembler\ARMAssembler.cpp -> build\default\JavaScriptCore\assembler\ARMAssembler_1.o "..\JavaScriptCore/jit/ExecutableAllocator.h", line 107: Error: #20: identifier "ptrdiff_t" is undefined if (static_cast<ptrdiff_t>(n) < (m_end - m_freePtr)) { ^ ..\JavaScriptCore\assembler\ARMAssembler.cpp: 0 warnings, 1 error In RVCT, ptrdiff_t is tyedefed in stddef.h, so we need to include stddef.h in JavaScriptCore/jit/ExecutableAllocator.h. 174505 1 45413 skyul 2009-12-22 18:39:28 -0800 Created attachment 45413 Include stddef.h 174506 2 webkit.review.bot 2009-12-22 18:42:59 -0800 style-queue ran check-webkit-style on attachment 45413 without any errors. 174525 3 45413 darin 2009-12-22 21:58:29 -0800 Comment on attachment 45413 Include stddef.h This include should not be inside an if statement. We should add <stddef.h> unconditionally for all compilers. It should be added to the main paragraph of includes at the top of the file. 174537 4 45420 skyul 2009-12-22 23:34:29 -0800 Created attachment 45420 Include stddef.h for ptrdiff_t without compiler guards 174538 5 webkit.review.bot 2009-12-22 23:36:35 -0800 style-queue ran check-webkit-style on attachment 45420 without any errors. 174599 6 45420 laszlo.gombos 2009-12-23 09:34:32 -0800 Comment on attachment 45420 Include stddef.h for ptrdiff_t without compiler guards Looks good, r=me 174600 7 45420 commit-queue 2009-12-23 09:37:55 -0800 Comment on attachment 45420 Include stddef.h for ptrdiff_t without compiler guards Rejecting patch 45420 from review queue. laszlo.1.gombos@nokia.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. - If you have reviewer rights please correct the error in WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no review needed) and then set the reviewer flag again. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. 174667 8 45420 laszlo.gombos 2009-12-23 15:36:12 -0800 Comment on attachment 45420 Include stddef.h for ptrdiff_t without compiler guards Try again, after I added myself to the reviewers list - http://trac.webkit.org/changeset/52531. 174668 9 45420 commit-queue 2009-12-23 15:36:31 -0800 Comment on attachment 45420 Include stddef.h for ptrdiff_t without compiler guards Rejecting patch 45420 from review queue. laszlo.1.gombos@nokia.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. - If you have reviewer rights please correct the error in WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no review needed) and then set the reviewer flag again. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. 174671 10 laszlo.gombos 2009-12-23 15:41:20 -0800 hmm.. Maybe I wait a bit more to let the Commit Bot pick up the change. 174672 11 abarth 2009-12-23 15:44:07 -0800 > hmm.. Maybe I wait a bit more to let the Commit Bot pick up the change. The commit bot won't land this because it's marked review-. You'll need to get a reviewer to change that flag to review+ first. 174677 12 eric 2009-12-23 15:52:15 -0800 Sorry. Due to bug 30084 the commit-queue does not immediately notice changes to committers.py. I have filed bug 32911 as a workaround until bug 30084 can be fixed. Sorry again for the confusion. The commit-queue has been restarted and will now recognize your r+ correctly. 174695 13 45420 laszlo.gombos 2009-12-23 17:08:41 -0800 Comment on attachment 45420 Include stddef.h for ptrdiff_t without compiler guards Thanks Eric. 174708 14 45420 commit-queue 2009-12-23 18:15:53 -0800 Comment on attachment 45420 Include stddef.h for ptrdiff_t without compiler guards Clearing flags on attachment: 45420 Committed r52538: <http://trac.webkit.org/changeset/52538> 174709 15 commit-queue 2009-12-23 18:15:59 -0800 All reviewed patches have been landed. Closing bug. 45413 2009-12-22 18:39:28 -0800 2009-12-22 23:34:29 -0800 Include stddef.h ptrdiff_t.patch text/plain 1134 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUyNTE4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTItMjIgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbmNsdWRlIHN0ZGRlZi5oIGZvciBwdHJkaWZmX3QgaW4g UlZDVAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI4 OTEKKworICAgICAgICBSVkNUIHR5cGVkZWZzIHB0cmRpZmZfdCBpbiBzdGRkZWYuaC4KKyAgICAg ICAgSW5jbHVkZSBzdGRkZWYuaCBpbiBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oIGZvciBSVkNU LgorCisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaDoKKwogMjAwOS0xMi0yMiAg RGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFy ayBSb3dlLgpJbmRleDogSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCShy ZXZpc2lvbiA1MjQ4NSkKKysrIEphdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9y LmgJKHdvcmtpbmcgY29weSkKQEAgLTQyLDYgKzQyLDEwIEBACiAjaW5jbHVkZSA8ZTMyc3RkLmg+ CiAjZW5kaWYKIAorI2lmIENPTVBJTEVSKFJWQ1QpCisjaW5jbHVkZSA8c3RkZGVmLmg+IC8vIGZv ciBwdHJkaWZmX3QKKyNlbmRpZgorCiAjZGVmaW5lIEpJVF9BTExPQ0FUT1JfUEFHRV9TSVpFIChF eGVjdXRhYmxlQWxsb2NhdG9yOjpwYWdlU2l6ZSkKICNkZWZpbmUgSklUX0FMTE9DQVRPUl9MQVJH RV9BTExPQ19TSVpFIChFeGVjdXRhYmxlQWxsb2NhdG9yOjpwYWdlU2l6ZSAqIDQpCiAK 45420 2009-12-22 23:34:29 -0800 2009-12-23 18:15:53 -0800 Include stddef.h for ptrdiff_t without compiler guards ptrdiff_t.patch text/plain 1053 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUyNTE4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTItMjIgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbmNsdWRlIHN0ZGRlZi5oIGZvciBwdHJkaWZmX3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyODkxCisKKyAg ICAgICAgcHRyZGlmZl90IGlzIHR5cGVkZWYtZWQgaW4gc3RkZGVmLmguCisgICAgICAgIEluY2x1 ZGUgc3RkZGVmLmggaW4gaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaC4KKworICAgICAgICAqIGpp dC9FeGVjdXRhYmxlQWxsb2NhdG9yLmg6CisKIDIwMDktMTItMjIgIERhcmluIEFkbGVyICA8ZGFy aW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93ZS4KSW5kZXg6IEph dmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2 YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaAkocmV2aXNpb24gNTI1MTgpCisr KyBKYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCSh3b3JraW5nIGNvcHkp CkBAIC0yNiw2ICsyNiw3IEBACiAjaWZuZGVmIEV4ZWN1dGFibGVBbGxvY2F0b3JfaAogI2RlZmlu ZSBFeGVjdXRhYmxlQWxsb2NhdG9yX2gKIAorI2luY2x1ZGUgPHN0ZGRlZi5oPiAvLyBmb3IgcHRy ZGlmZl90CiAjaW5jbHVkZSA8bGltaXRzPgogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CiAj aW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4K