32879 2009-12-22 13:08:21 -0800 [GTK] Only load dictionaries if spell check is enabled 2011-06-02 10:16:36 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 christian webkit-unassigned commit-queue joone.hur oldest_to_newest 174349 0 christian 2009-12-22 13:08:21 -0800 Currently enchant dictionaries are loaded unconditionally for any new WebKitWebSettings, regardless of whether enable-spell-checking is enabled or not. This has two side effects: enchant is initialized even when not used. And the languages are loaded twice if the application changes spell-checking-languages before enabling spell checking. I suggest the languages should only be initialized if spell checking is enabled. The dictionary loading should therefore be moved into a helper function and called as needed. 413908 1 joone.hur 2011-06-01 22:12:46 -0700 These is a case which WebKitGtk+ can't load dictionaries as follows: (gdb) bt #0 0x0012e416 in __kernel_vsyscall () #1 0x0409ee71 in raise () from /lib/i386-linux-gnu/libc.so.6 #2 0x040a234e in abort () from /lib/i386-linux-gnu/libc.so.6 #3 0x040d5577 in ?? () from /lib/i386-linux-gnu/libc.so.6 #4 0x04159df0 in __fortify_fail () from /lib/i386-linux-gnu/libc.so.6 #5 0x04158cca in __chk_fail () from /lib/i386-linux-gnu/libc.so.6 #6 0x0415805f in __strcpy_chk () from /lib/i386-linux-gnu/libc.so.6 #7 0x0437b412 in strcpy (this=0x80f0520, word=0x80f7090 "0", wbl=1, wcl=1, aff=0x80efd38, al=2, desc=0x0, onlyupcase=false) at /usr/include/bits/string3.h:105 #8 HashMgr::add_word (this=0x80f0520, word=0x80f7090 "0", wbl=1, wcl=1, aff=0x80efd38, al=2, desc=0x0, onlyupcase=false) at hashmgr.cxx:138 #9 0x0437bc6d in HashMgr::load_tables (this=0x80f0520, tpath=0x80eff38 "/home/joone/checkout/gnome/build/share/myspell/dicts/en_US.dic", key=0x0) at hashmgr.cxx:470 #10 0x0437becb in HashMgr::HashMgr (this=0x80f0520, tpath=0x80eff38 "/home/joone/checkout/gnome/build/share/myspell/dicts/en_US.dic", apath=0x80f0050 "/home/joone/checkout/gnome/build/share/myspell/dicts/en_US.aff", key=0x0) at hashmgr.cxx:52 #11 0x0437c233 in Hunspell::Hunspell (this=0x80f0160, affpath=0x80f0050 "/home/joone/checkout/gnome/build/share/myspell/dicts/en_US.aff", dpath=0x80eff38 "/home/joone/checkout/gnome/build/share/myspell/dicts/en_US.dic", key=0x0) at hunspell.cxx:34 #12 0x0438c2a9 in MySpellChecker::requestDictionary (this=0x80ec9e0, szLang=0x80f0328 "en_US") at myspell_checker.cpp:423 #13 0x0438c42f in myspell_provider_request_dict (me=0x80ecf78, tag=0x80f0328 "en_US") at myspell_checker.cpp:549 #14 0x02e5c745 in _enchant_broker_request_dict (broker=0x80ec4f0, tag=0x80f0328 "en_US") at enchant.c:1807 #15 0x02e5daf1 in enchant_broker_request_dict (broker=0x80ec4f0, tag=0x80c9fb4 "en-us") at enchant.c:1853 #16 0x009ebf43 in WebKit::TextCheckerClientEnchant::updateSpellCheckingLanguage (this=0x80b8198, spellCheckingLanguages=0x0) at ../../Source/WebKit/gtk/WebCoreSupport/TextCheckerClientEnchant.cpp:187 #17 0x00a414a3 in webkit_web_view_update_settings (webView=0x80b9020) at ../../Source/WebKit/gtk/webkit/webkitwebview.cpp:3292 #18 0x00a4257a in webkit_web_view_init (webView=0x80b9020) at ../../Source/WebKit/gtk/webkit/webkitwebview.cpp:3478 #19 0x038eb5a9 in g_type_create_instance (type=134919616) at gtype.c:1885 #20 0x038c7f65 in g_object_constructor (type=134919616, n_construct_properties=2, construct_params=0x80b6b58) at gobject.c:1615 #21 0x038caf64 in g_object_newv (object_type=134919616, n_parameters=0, parameters=0x0) at gobject.c:1479 #22 0x038cc330 in g_object_new (object_type=134919616, first_property_name=0x0) at gobject.c:1308 #23 0x00a42703 in webkit_web_view_new () at ../../Source/WebKit/gtk/webkit/webkitwebview.cpp:3491 #24 0x0804a1ce in createWindow (outWebView=0xbfffead0) at ../../Tools/GtkLauncher/main.c:202 #25 0x0804a3fe in main (argc=1, argv=0xbfffeba4) at ../../Tools/GtkLauncher/main.c:253 413953 2 95730 joone.hur 2011-06-02 00:02:35 -0700 Created attachment 95730 Proposed Patch This patch allows WebKitGtk+ to skip loading dictionaries when spell-checking is not enabled. 414130 3 95730 mrobinson 2011-06-02 08:10:52 -0700 Comment on attachment 95730 Proposed Patch Nice! 414235 4 95730 commit-queue 2011-06-02 10:16:31 -0700 Comment on attachment 95730 Proposed Patch Clearing flags on attachment: 95730 Committed r87925: <http://trac.webkit.org/changeset/87925> 414236 5 commit-queue 2011-06-02 10:16:36 -0700 All reviewed patches have been landed. Closing bug. 95730 2011-06-02 00:02:35 -0700 2011-06-02 10:16:31 -0700 Proposed Patch enchant.patch text/plain 3629 joone.hur ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCA0YzQ2MGE4Li5lYmZlYWQ2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMDIgIEpvb25lIEh1ciAgPGpvb25lLmh1ckBjb2xsYWJv cmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gT25seSBsb2FkIGRpY3Rpb25hcmllcyBpZiBzcGVsbCBjaGVjayBpcyBlbmFibGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjg3OQor CisgICAgICAgIFdlIGRvbid0IG5lZWQgdG8gY2FsbCBlbmNoYW50IGlmIGVuYWJsZS1zcGVsbC1j aGVja2luZyBpcyBmYWxzZS4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoK KyAgICAgICAgKHdlYmtpdF93ZWJfdmlld191cGRhdGVfc2V0dGluZ3MpOiBTa2lwIGxvYWRpbmcg ZGljdGlvbmFyaWVzIHdoZW4gZW5hYmxlLXNwZWxsLWNoZWNraW5nIGlzIGZhbHNlLiAKKyAgICAg ICAgKHdlYmtpdF93ZWJfdmlld19zZXR0aW5nc19ub3RpZnkpOiBEaXR0by4KKwogMjAxMS0wNi0w MSAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg TWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dl YmtpdHdlYnZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcu Y3BwCmluZGV4IDUxYzI4MjcuLjU2NDU5NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3Rr L3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0d2Vidmlldy5jcHAKQEAgLTMyMDEsNyArMzIwMSw4IEBAIHN0YXRpYyB2b2lkIHdlYmtp dF93ZWJfdmlld191cGRhdGVfc2V0dGluZ3MoV2ViS2l0V2ViVmlldyogd2ViVmlldykKICAgICAg ICAgZW5hYmxlVW5pdmVyc2FsQWNjZXNzRnJvbUZpbGVVUkksIGVuYWJsZUZpbGVBY2Nlc3NGcm9t RmlsZVVSSSwKICAgICAgICAgZW5hYmxlRE9NUGFzdGUsIHRhYktleUN5Y2xlc1Rocm91Z2hFbGVt ZW50cywgZW5hYmxlV2ViR0wsCiAgICAgICAgIGVuYWJsZVNpdGVTcGVjaWZpY1F1aXJrcywgdXNl UGFnZUNhY2hlLCBlbmFibGVKYXZhQXBwbGV0LAotICAgICAgICBlbmFibGVIeXBlcmxpbmtBdWRp dGluZywgZW5hYmxlRnVsbHNjcmVlbiwgZW5hYmxlRE5TUHJlZmV0Y2hpbmc7CisgICAgICAgIGVu YWJsZUh5cGVybGlua0F1ZGl0aW5nLCBlbmFibGVGdWxsc2NyZWVuLCBlbmFibGVETlNQcmVmZXRj aGluZywKKyAgICAgICAgZW5hYmxlU3BlbGxDaGVja2luZzsKIAogICAgIFdlYktpdEVkaXRpbmdC ZWhhdmlvciBlZGl0aW5nQmVoYXZpb3I7CiAKQEAgLTMyNDAsNiArMzI0MSw3IEBAIHN0YXRpYyB2 b2lkIHdlYmtpdF93ZWJfdmlld191cGRhdGVfc2V0dGluZ3MoV2ViS2l0V2ViVmlldyogd2ViVmll dykKICAgICAgICAgICAgICAgICAgImVuYWJsZS1wYWdlLWNhY2hlIiwgJnVzZVBhZ2VDYWNoZSwK ICAgICAgICAgICAgICAgICAgImVuYWJsZS1qYXZhLWFwcGxldCIsICZlbmFibGVKYXZhQXBwbGV0 LAogICAgICAgICAgICAgICAgICAiZW5hYmxlLWh5cGVybGluay1hdWRpdGluZyIsICZlbmFibGVI eXBlcmxpbmtBdWRpdGluZywKKyAgICAgICAgICAgICAgICAgImVuYWJsZS1zcGVsbC1jaGVja2lu ZyIsICZlbmFibGVTcGVsbENoZWNraW5nLAogICAgICAgICAgICAgICAgICAic3BlbGwtY2hlY2tp bmctbGFuZ3VhZ2VzIiwgJmRlZmF1bHRTcGVsbENoZWNraW5nTGFuZ3VhZ2VzLAogICAgICAgICAg ICAgICAgICAiZW5hYmxlLWZ1bGxzY3JlZW4iLCAmZW5hYmxlRnVsbHNjcmVlbiwKICAgICAgICAg ICAgICAgICAgImVuYWJsZS1kbnMtcHJlZmV0Y2hpbmciLCAmZW5hYmxlRE5TUHJlZmV0Y2hpbmcs CkBAIC0zMjg4LDggKzMyOTAsMTAgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3VwZGF0 ZV9zZXR0aW5ncyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogI2VuZGlmCiAKICNpZiBFTkFCTEUo U1BFTExDSEVDSykKLSAgICBXZWJLaXQ6OkVkaXRvckNsaWVudCogY2xpZW50ID0gc3RhdGljX2Nh c3Q8V2ViS2l0OjpFZGl0b3JDbGllbnQqPihjb3JlKHdlYlZpZXcpLT5lZGl0b3JDbGllbnQoKSk7 Ci0gICAgc3RhdGljX2Nhc3Q8V2ViS2l0OjpUZXh0Q2hlY2tlckNsaWVudEVuY2hhbnQqPihjbGll bnQtPnRleHRDaGVja2VyKCkpLT51cGRhdGVTcGVsbENoZWNraW5nTGFuZ3VhZ2UoZGVmYXVsdFNw ZWxsQ2hlY2tpbmdMYW5ndWFnZXMpOworICAgIGlmIChlbmFibGVTcGVsbENoZWNraW5nKSB7Cisg ICAgICAgIFdlYktpdDo6RWRpdG9yQ2xpZW50KiBjbGllbnQgPSBzdGF0aWNfY2FzdDxXZWJLaXQ6 OkVkaXRvckNsaWVudCo+KGNvcmUod2ViVmlldyktPmVkaXRvckNsaWVudCgpKTsKKyAgICAgICAg c3RhdGljX2Nhc3Q8V2ViS2l0OjpUZXh0Q2hlY2tlckNsaWVudEVuY2hhbnQqPihjbGllbnQtPnRl eHRDaGVja2VyKCkpLT51cGRhdGVTcGVsbENoZWNraW5nTGFuZ3VhZ2UoZGVmYXVsdFNwZWxsQ2hl Y2tpbmdMYW5ndWFnZXMpOworICAgIH0KICNlbmRpZgogCiAjaWYgRU5BQkxFKFdFQkdMKQpAQCAt MzQxNSw4ICszNDE5LDEyIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19zZXR0aW5nc19u b3RpZnkoV2ViS2l0V2ViU2V0dGluZ3MqIHdlYlNldHRpbmdzLCBHUGFyCiAKICNpZiBFTkFCTEUo U1BFTExDSEVDSykKICAgICBlbHNlIGlmIChuYW1lID09IGdfaW50ZXJuX3N0cmluZygic3BlbGwt Y2hlY2tpbmctbGFuZ3VhZ2VzIikpIHsKLSAgICAgICAgV2ViS2l0OjpFZGl0b3JDbGllbnQqIGNs aWVudCA9IHN0YXRpY19jYXN0PFdlYktpdDo6RWRpdG9yQ2xpZW50Kj4oY29yZSh3ZWJWaWV3KS0+ ZWRpdG9yQ2xpZW50KCkpOwotICAgICAgICBzdGF0aWNfY2FzdDxXZWJLaXQ6OlRleHRDaGVja2Vy Q2xpZW50RW5jaGFudCo+KGNsaWVudC0+dGV4dENoZWNrZXIoKSktPnVwZGF0ZVNwZWxsQ2hlY2tp bmdMYW5ndWFnZShnX3ZhbHVlX2dldF9zdHJpbmcoJnZhbHVlKSk7CisgICAgICAgIGdib29sZWFu IGVuYWJsZVNwZWxsQ2hlY2tpbmc7CisgICAgICAgIGdfb2JqZWN0X2dldChHX09CSkVDVCh3ZWJT ZXR0aW5ncyksICJlbmFibGUtc3BlbGwtY2hlY2tpbmciLCAmZW5hYmxlU3BlbGxDaGVja2luZywg TlVMTCk7CisgICAgICAgIGlmIChlbmFibGVTcGVsbENoZWNraW5nKSB7CisgICAgICAgICAgICBX ZWJLaXQ6OkVkaXRvckNsaWVudCogY2xpZW50ID0gc3RhdGljX2Nhc3Q8V2ViS2l0OjpFZGl0b3JD bGllbnQqPihjb3JlKHdlYlZpZXcpLT5lZGl0b3JDbGllbnQoKSk7CisgICAgICAgICAgICBzdGF0 aWNfY2FzdDxXZWJLaXQ6OlRleHRDaGVja2VyQ2xpZW50RW5jaGFudCo+KGNsaWVudC0+dGV4dENo ZWNrZXIoKSktPnVwZGF0ZVNwZWxsQ2hlY2tpbmdMYW5ndWFnZShnX3ZhbHVlX2dldF9zdHJpbmco JnZhbHVlKSk7CisgICAgICAgIH0KICAgICB9CiAjZW5kaWYKIAo=