32877 2009-12-22 12:28:16 -0800 [GTK] confirm dialog should show OK/Cancel instead of Yes/No for consistency 2010-08-25 18:39:45 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 grant_gayed webkit-unassigned mrobinson oldest_to_newest 174329 0 grant_gayed 2009-12-22 12:28:16 -0800 - using WebKitGTK 1.1.16 built from source on Ubuntu 9.10 Every other Browser I have access to, including Safari, labels the buttons in javascript confirm prompters as OK/Cancel, but WebKitGTK labels them Yes/No. I realize that there may not be a "correct" set of buttons spec'd for this type of prompter, but since all of the other Browsers are using OK/Cancel, there are JS authors that word their confirm messages accordingly (this is how I noticed this difference). 267521 1 mrobinson 2010-08-20 20:22:00 -0700 This is the fallback dialog, so this change would be pretty safe. I'm not sure how others feel about this, but I'm attaching a patch. If others dislike the change we can close the bug. 267522 2 65018 mrobinson 2010-08-20 20:25:44 -0700 Created attachment 65018 Patch 269350 3 65018 gustavo 2010-08-25 11:00:37 -0700 Comment on attachment 65018 Patch I do think it makes a lot of sense to use the commonly used terms. 269667 4 65018 mrobinson 2010-08-25 18:39:41 -0700 Comment on attachment 65018 Patch Clearing flags on attachment: 65018 Committed r66070: <http://trac.webkit.org/changeset/66070> 269668 5 mrobinson 2010-08-25 18:39:45 -0700 All reviewed patches have been landed. Closing bug. 65018 2010-08-20 20:25:44 -0700 2010-08-25 18:39:41 -0700 Patch bug-32877-20100820202548.patch text/plain 2098 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggMjA5ZmU1ODQ4NGM0NzAxMDgyOGVhMGVjOGNkNWFkYWFiZmEzOTYxOS4uY2E3NTZhZjUw MWIwNWJmYjI2OWEyNzcwYWVkMjQ2NjUwMzQxM2Y1NiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAx MC0wOC0yMCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgY29uZmlybSBkaWFsb2cg c2hvdWxkIHNob3cgT0svQ2FuY2VsIGluc3RlYWQgb2YgWWVzL05vIGZvciBjb25zaXN0ZW5jeQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI4NzcKKwor ICAgICAgICBDaGFuZ2UgdGhlIGJ1dHRvbiBsYWJlbHMgZm9yIHRoZSBmYWxsYmFjayBjb25maXJt YXRpb24gZGlhbG9nIHRvIGJlCisgICAgICAgIE9LIGFuZCBDYW5jZWwuCisKKyAgICAgICAgKiB3 ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfc2NyaXB0 X2RpYWxvZyk6CisKKzIwMTAtMDgtMjAgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2Fs aWEuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogSW5zcGVjdG9yIHRlc3RzIHdlcmUgZGlzYWJsZWQgZm9yIEdUSy4KZGlm ZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0L2d0 ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggNzVlZGQzNWI4Y2QyZDNkYTE4MjMzNDJl MWE0YWJiNmUxZTA4ZjBkMy4uNzZmZTZjYmQ3YjczYzMwOGQ3NzFjOTc0YzE1ZTE3MmYyOGUyMTUw ZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTk5Miw4ICs5OTIsOCBAQCBz dGF0aWMgZ2Jvb2xlYW4gd2Via2l0X3dlYl92aWV3X3NjcmlwdF9kaWFsb2coV2ViS2l0V2ViVmll dyogd2ViVmlldywgV2ViS2l0V2ViRgogICAgICAgICBicmVhazsKICAgICBjYXNlIFdFQktJVF9T Q1JJUFRfRElBTE9HX0NPTkZJUk06CiAgICAgICAgIG1lc3NhZ2VUeXBlID0gR1RLX01FU1NBR0Vf UVVFU1RJT047Ci0gICAgICAgIGJ1dHRvbnMgPSBHVEtfQlVUVE9OU19ZRVNfTk87Ci0gICAgICAg IGRlZmF1bHRSZXNwb25zZSA9IEdUS19SRVNQT05TRV9ZRVM7CisgICAgICAgIGJ1dHRvbnMgPSBH VEtfQlVUVE9OU19PS19DQU5DRUw7CisgICAgICAgIGRlZmF1bHRSZXNwb25zZSA9IEdUS19SRVNQ T05TRV9PSzsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBXRUJLSVRfU0NSSVBUX0RJQUxPR19Q Uk9NUFQ6CiAgICAgICAgIG1lc3NhZ2VUeXBlID0gR1RLX01FU1NBR0VfUVVFU1RJT047CkBAIC0x MDIzLDE3ICsxMDIzLDExIEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfc2NyaXB0 X2RpYWxvZyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJLaXRXZWJGCiAgICAgZ2ludCByZXNw b25zZSA9IGd0a19kaWFsb2dfcnVuKEdUS19ESUFMT0coZGlhbG9nKSk7CiAKICAgICBzd2l0Y2gg KHJlc3BvbnNlKSB7Ci0gICAgY2FzZSBHVEtfUkVTUE9OU0VfWUVTOgotICAgICAgICBkaWRDb25m aXJtID0gVFJVRTsKLSAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBHVEtfUkVTUE9OU0VfT0s6CiAg ICAgICAgIGRpZENvbmZpcm0gPSBUUlVFOwogICAgICAgICBpZiAoZW50cnkpCiAgICAgICAgICAg ICAqdmFsdWUgPSBnX3N0cmR1cChndGtfZW50cnlfZ2V0X3RleHQoR1RLX0VOVFJZKGVudHJ5KSkp OwotICAgICAgICBlbHNlCi0gICAgICAgICAgICAqdmFsdWUgPSAwOwogICAgICAgICBicmVhazsK LSAgICBjYXNlIEdUS19SRVNQT05TRV9OTzoKICAgICBjYXNlIEdUS19SRVNQT05TRV9DQU5DRUw6 CiAgICAgICAgIGRpZENvbmZpcm0gPSBGQUxTRTsKICAgICAgICAgYnJlYWs7Cg==