32874 2009-12-22 11:39:44 -0800 Typed text in table not correctly redrawn on page with compositing layers 2009-12-29 09:19:13 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://www.iquilezles.org/apps/shadertoy/ P2 Normal --- 1 simon.fraser simon.fraser mitz oldest_to_newest 174319 0 simon.fraser 2009-12-22 11:39:44 -0800 Visit http://www.iquilezles.org/apps/shadertoy/ with WebGL enabled, and try typing into Source text box. Note that your typing doesn't show correctly (but you do see some weird pixel dust). 174508 1 45414 simon.fraser 2009-12-22 18:46:23 -0800 Created attachment 45414 Reduced testcase This is related to table redraw in compositing mode, but, oddly, even when the table is not in a compositing layer. 174511 2 simon.fraser 2009-12-22 19:45:12 -0800 This is related to the code that walks up the container() chain in computeRectForRepaint(). RenderTableRow and RenderTableSection are both adding offsets? 174514 3 mitz 2009-12-22 19:51:10 -0800 Hmm… perhaps something needs to be done to compensate for <http://trac.webkit.org/changeset/51864>? Or just more of the same? 174515 4 mitz 2009-12-22 19:54:17 -0800 Actually RenderTableCell::computeRectForRepaint() appears to be doing the right thing. Are we starting the computation at the table row? 175381 5 simon.fraser 2009-12-28 20:06:41 -0800 Ah, we're getting a difference answer when RenderBox::computeRectForRepaint() goes through the LayoutState code path. 175386 6 45586 simon.fraser 2009-12-28 20:48:05 -0800 Created attachment 45586 Patch I wasn't able to create a repaint layoutTest that shows the problem, so no test here, alas. 175588 7 simon.fraser 2009-12-29 09:19:13 -0800 http://trac.webkit.org/changeset/52624 45414 2009-12-22 18:46:23 -0800 2009-12-22 18:46:23 -0800 Reduced testcase table-input-repaint.html text/html 410 simon.fraser PGh0bWw+CjxoZWFkPgogIDx0aXRsZT5FZGl0aW5nIHRhYmxlIHJlcGFpbnQ8L3RpdGxlPgogIDxz dHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9InNjcmVlbiI+CiAgICAuY29tcG9zaXRpbmcgewog ICAgICB3aWR0aDogMTAwcHg7CiAgICAgIGhlaWdodDogMTAwcHg7CiAgICAgIC13ZWJraXQtdHJh bnNmb3JtOiB0cmFuc2xhdGVaKDApOwogICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOwogICAg fQogIDwvc3R5bGU+CjwvaGVhZD4KCjxib2R5PgoKICA8dGFibGUgYm9yZGVyPSIxIj4KICAgIDx0 cj48dGQ+Q2VsbDwvdGQ+PC90cj4KICAgIDx0cj48dGQ+PGlucHV0IHR5cGU9InRleHQiPjwvdGQ+ PC90cj4KICA8L3RhYmxlPgoKICA8ZGl2IGNsYXNzPSJjb21wb3NpdGluZyI+PC9kaXY+Cgo8L2Jv ZHk+CjwvaHRtbD4= 45586 2009-12-28 20:48:05 -0800 2009-12-28 20:49:11 -0800 Patch 32874_patch.txt text/plain 1590 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTE2MzExZS4uYzU2NDMzNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0xMi0yOCAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUeXBlZCB0ZXh0IGluIHRhYmxlIG5vdCBjb3JyZWN0bHkgcmVk cmF3biBvbiBwYWdlIHdpdGggY29tcG9zaXRpbmcgbGF5ZXJzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjg3NAorICAgICAgICAKKyAgICAgICAgVXNl IHRoZSBzYW1lIHRlc3QgaW4gUmVuZGVyVGFibGVDZWxsOjpjb21wdXRlUmVjdEZvclJlcGFpbnQo KSB0aGF0IHdlIHVzZSBlbHNld2hlcmUKKyAgICAgICAgdG8gZGVjaWRlIHdoZW4gdG8gdXNlIGxh eW91dFN0YXRlLCB3aGljaCBpcyB0byB0ZXN0IGZvciBsYXlvdXRTdGF0ZUVuYWJsZWQoKQorICAg ICAgICBhbmQgbm8gcmVwYWludCBjb250YWluZXIuCisKKyAgICAgICAgTm90IHBvc3NpYmxlIHRv IG1ha2UgYSByZXBhaW50IHRlc3QgdGhhdCBleGVyY2lzZXMgdGhlIHByb2JsZW0sIHNvIG5vIHRl c3QuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlclRhYmxlQ2VsbDo6Y29tcHV0ZVJlY3RGb3JSZXBhaW50KToKKwogMjAw OS0xMi0yOCAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRhYmxlQ2VsbC5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNl bGwuY3BwCmluZGV4IGJiYWQ2MDUuLjE1NDU5Y2UgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRhYmxlQ2VsbC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFi bGVDZWxsLmNwcApAQCAtMjIzLDcgKzIyMyw3IEBAIHZvaWQgUmVuZGVyVGFibGVDZWxsOjpjb21w dXRlUmVjdEZvclJlcGFpbnQoUmVuZGVyQm94TW9kZWxPYmplY3QqIHJlcGFpbnRDb250YWluCiAg ICAgICAgIHJldHVybjsKICAgICByLnNldFkoci55KCkpOwogICAgIFJlbmRlclZpZXcqIHYgPSB2 aWV3KCk7Ci0gICAgaWYgKCghdiB8fCAhdi0+bGF5b3V0U3RhdGVFbmFibGVkKCkpICYmIHBhcmVu dCgpKQorICAgIGlmICgoIXYgfHwgIXYtPmxheW91dFN0YXRlRW5hYmxlZCgpIHx8IHJlcGFpbnRD b250YWluZXIpICYmIHBhcmVudCgpKQogICAgICAgICByLm1vdmUoLXBhcmVudEJveCgpLT54KCks IC1wYXJlbnRCb3goKS0+eSgpKTsgLy8gUm93cyBhcmUgaW4gdGhlIHNhbWUgY29vcmRpbmF0ZSBz cGFjZSwgc28gZG9uJ3QgYWRkIHRoZWlyIG9mZnNldCBpbi4KICAgICBSZW5kZXJCbG9jazo6Y29t cHV0ZVJlY3RGb3JSZXBhaW50KHJlcGFpbnRDb250YWluZXIsIHIsIGZpeGVkKTsKIH0K