32871 2009-12-22 08:01:49 -0800 [Android] Android is missing implementation of NetworkStateNotifier. 2009-12-29 14:50:48 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 0 andreip webkit-unassigned android-webkit-unforking commit-queue webkit.review.bot oldest_to_newest 174269 0 andreip 2009-12-22 08:01:49 -0800 Android doesn't currently support network state notifications. We need to add a platform hook into the NetworkStateNotifier class and have the hook be invoked by the Java side when the network state changes. 174271 1 45386 andreip 2009-12-22 08:11:34 -0800 Created attachment 45386 Add Android hook to NetworkStateNotifier class 174273 2 webkit.review.bot 2009-12-22 08:14:52 -0800 style-queue ran check-webkit-style on attachment 45386 without any errors. 175704 3 45386 abarth 2009-12-29 14:12:36 -0800 Comment on attachment 45386 Add Android hook to NetworkStateNotifier class ok 175713 4 45386 commit-queue 2009-12-29 14:50:42 -0800 Comment on attachment 45386 Add Android hook to NetworkStateNotifier class Clearing flags on attachment: 45386 Committed r52635: <http://trac.webkit.org/changeset/52635> 175714 5 commit-queue 2009-12-29 14:50:48 -0800 All reviewed patches have been landed. Closing bug. 45386 2009-12-22 08:11:34 -0800 2009-12-29 14:50:41 -0800 Add Android hook to NetworkStateNotifier class 32871.patch text/plain 3390 andreip SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjQ4NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTItMjIgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBBbmRyb2lkIGhvb2sgdG8gTmV0d29ya1N0YXRlTm90aWZpZXIgY2xhc3MKKyAgICAgICAg c28gdGhhdCB0aGUgSmF2YSBzaWRlIGNhbiBub3RpZnkgV2ViQ29yZSB3aGVuIHRoZQorICAgICAg ICBuZXR3b3JrIHN0YXRlIGNoYW5nZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMjg3MQorCisgICAgICAgIE5vIG5ldyB0ZXN0cyByZXF1aXJlZCwg dGhpcyBpcyBwbGF0Zm9ybSBjb2RlLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9OZXR3 b3JrU3RhdGVOb3RpZmllci5oOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYW5kcm9pZC9O ZXR3b3JrU3RhdGVOb3RpZmllckFuZHJvaWQuY3BwOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6 Ok5ldHdvcmtTdGF0ZU5vdGlmaWVyOjpuZXR3b3JrU3RhdGVDaGFuZ2UpOgorCiAyMDA5LTEyLTIx ICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29y a1N0YXRlTm90aWZpZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv TmV0d29ya1N0YXRlTm90aWZpZXIuaAkocmV2aXNpb24gNTI0ODYpCisrKyBXZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvTmV0d29ya1N0YXRlTm90aWZpZXIuaAkod29ya2luZyBjb3B5KQpAQCAtODUs NiArODUsMTAgQEAgcHJpdmF0ZTogICAgCiAjZWxpZiBQTEFURk9STShDSFJPTUlVTSkKICAgICBO ZXR3b3JrU3RhdGVOb3RpZmllclByaXZhdGUgcDsKIAorI2VsaWYgUExBVEZPUk0oQU5EUk9JRCkK K3B1YmxpYzoKKyAgICB2b2lkIG5ldHdvcmtTdGF0ZUNoYW5nZShib29sIG9ubGluZSk7CisKICNl bGlmIFBMQVRGT1JNKFFUKSAmJiBFTkFCTEUoUVRfQkVBUkVSKQogICAgIGZyaWVuZCBjbGFzcyBO ZXR3b3JrU3RhdGVOb3RpZmllclByaXZhdGU7CiAgICAgTmV0d29ya1N0YXRlTm90aWZpZXJQcml2 YXRlKiBwOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2FuZHJvaWQvTmV0d29ya1N0 YXRlTm90aWZpZXJBbmRyb2lkLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvYW5kcm9pZC9OZXR3b3JrU3RhdGVOb3RpZmllckFuZHJvaWQuY3BwCShyZXZpc2lvbiAw KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2FuZHJvaWQvTmV0d29ya1N0YXRlTm90aWZp ZXJBbmRyb2lkLmNwcAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0MiBAQAorLyoKKyAqIENvcHly aWdodCAyMDA5LCBUaGUgQW5kcm9pZCBPcGVuIFNvdXJjZSBQcm9qZWN0CisgKgorICogUmVkaXN0 cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRo b3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9s bG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Yg c291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNl LCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgor ICogICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBh Ym92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5k IHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5k L29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgor ICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgYGBB UyBJUycnIEFORCBBTlkKKyAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJ TkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFCisgKiBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVS Q0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKKyAqIFBVUlBPU0UgQVJF IERJU0NMQUlNRUQuICBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUIE9XTkVSIE9SCisg KiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURF TlRBTCwgU1BFQ0lBTCwKKyAqIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJ TkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyAqIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRV VEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgorICogUFJPRklUUzsg T1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9S WQorICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZ LCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5H IElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYg QURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1 ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIk5ldHdvcmtTdGF0ZU5vdGlmaWVyLmgiCisKK25hbWVz cGFjZSBXZWJDb3JlIHsKKwordm9pZCBOZXR3b3JrU3RhdGVOb3RpZmllcjo6bmV0d29ya1N0YXRl Q2hhbmdlKGJvb2wgb25saW5lKQoreyAgIAorICAgIGlmIChtX2lzT25MaW5lID09IG9ubGluZSkK KyAgICAgICAgcmV0dXJuOworICAgIAorICAgIG1faXNPbkxpbmUgPSBvbmxpbmU7CisKKyAgICBp ZiAobV9uZXR3b3JrU3RhdGVDaGFuZ2VkRnVuY3Rpb24pCisgICAgICAgIG1fbmV0d29ya1N0YXRl Q2hhbmdlZEZ1bmN0aW9uKCk7Cit9CisKK30K