32868 2009-12-22 07:07:40 -0800 IWebView::mainFrame crashes if called after IWebView::close 2016-07-22 05:43:21 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 aroben pvollan bfulgham peavo pvollan webkit-bug-importer oldest_to_newest 174256 0 aroben 2009-12-22 07:07:40 -0800 To reproduce: 1. Create a WebView 2. Call IWebView::close 3. Call IWebView::mainFrame You'll crash. 174257 1 aroben 2009-12-22 07:07:52 -0800 The problem is that IWebView::close deletes m_page, which ends up releasing the last reference to m_mainFrame, but we don't null-out m_mainFrame. 174258 2 aroben 2009-12-22 07:08:00 -0800 <rdar://problem/7472766> 1213098 3 284205 pvollan 2016-07-21 04:25:45 -0700 Created attachment 284205 Patch 1213179 4 284205 bfulgham 2016-07-21 10:26:37 -0700 Comment on attachment 284205 Patch Excellent! r=me. 1213207 5 pvollan 2016-07-21 11:33:03 -0700 (In reply to comment #4) > Comment on attachment 284205 [details] > Patch > > Excellent! r=me. Thanks for reviewing :) 1213550 6 pvollan 2016-07-22 05:43:21 -0700 Committed r203597: <https://trac.webkit.org/changeset/203597> 284205 2016-07-21 04:25:45 -0700 2016-07-21 10:26:37 -0700 Patch bug-32868-20160721042610.patch text/plain 2875 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMzQ1NikKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA3LTIx ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBJV2ViVmll dzo6bWFpbkZyYW1lIGNyYXNoZXMgaWYgY2FsbGVkIGFmdGVyIElXZWJWaWV3OjpjbG9zZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI4NjgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciBkZWxldGlu ZyB0aGUgcGFnZSBpbiBXZWJWaWV3OjpjbG9zZSB0aGUgbWFpbmZyYW1lIG9iamVjdCBtYXkgYmUg ZGVsZXRlZC4gCisgICAgICAgICAKKyAgICAgICAgVGVzdDogVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXQvd2luL1dlYlZpZXdEZXN0cnVjdGlvbi5jcHAgKENsb3NlVGhlbkdldE1haW5G cmFtZSkuCisKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZpZXc6OmNsb3Nl KTogc2V0IG1haW5mcmFtZSBwb2ludGVyIG1lbWJlciB0byBudWxsLiAKKwogMjAxNi0wNy0xOSAg UGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gVGhl IHRlc3QgZmFzdC9zY3JvbGxpbmcvb3ZlcmZsb3ctc2Nyb2xsLXBhc3QtbWF4Lmh0bWwgaXMgdGlt aW5nIG91dC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiAyMDM0NTYpCisrKyBT b3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzY5LDcgKzc2 OSw5IEBAIEhSRVNVTFQgV2ViVmlldzo6Y2xvc2UoKQogICAgICAgICBtX3dlYkluc3BlY3Rvci0+ aW5zcGVjdGVkV2ViVmlld0Nsb3NlZCgpOwogCiAgICAgZGVsZXRlIG1fcGFnZTsKLSAgICBtX3Bh Z2UgPSAwOworICAgIG1fcGFnZSA9IG51bGxwdHI7CisKKyAgICBtX21haW5GcmFtZSA9IG51bGxw dHI7CiAKICAgICByZWdpc3RlckZvckljb25Ob3RpZmljYXRpb24oZmFsc2UpOwogICAgIElXZWJO b3RpZmljYXRpb25DZW50ZXIqIG5vdGlmeUNlbnRlciA9IFdlYk5vdGlmaWNhdGlvbkNlbnRlcjo6 ZGVmYXVsdENlbnRlckludGVybmFsKCk7CkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDM1MDApCisrKyBUb29scy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNi0wNy0yMSAgUGVyIEFybmUg Vm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSVdlYlZpZXc6Om1haW5GcmFt ZSBjcmFzaGVzIGlmIGNhbGxlZCBhZnRlciBJV2ViVmlldzo6Y2xvc2UKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyODY4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdC93aW4vV2ViVmlld0Rlc3RydWN0aW9uLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6 OlRFU1RfRik6IEFkZGVkIHRlc3QuCisKIDIwMTYtMDctMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFdlYiB2aWV3IGJhY2tncm91 bmQgY29sb3JzIGRvbid0IHdvcmsgaW4gYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgbW9kZQpJbmRl eDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvd2luL1dlYlZpZXdEZXN0cnVjdGlv bi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvd2lu L1dlYlZpZXdEZXN0cnVjdGlvbi5jcHAJKHJldmlzaW9uIDIwMzQ1NikKKysrIFRvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0L3dpbi9XZWJWaWV3RGVzdHJ1Y3Rpb24uY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xNTQsNiArMTU0LDE1IEBAIFRFU1RfRihXZWJWaWV3RGVzdHJ1Y3Rpb25XaXRo SG9zdFdpbmRvdywKICAgICBFWFBFQ1RfSFJFU1VMVF9TVUNDRUVERUQobV93ZWJWaWV3LT5jbG9z ZSgpKTsKIH0KIAorLy8gVGVzdHMgdGhhdCBjYWxsaW5nIElXZWJWaWV3OjpjbG9zZSBmb2xsb3dl ZCBieSBJV2ViVmlldzo6bWFpbkZyYW1lIGRvZXMgbm90IGNyYXNoLgorVEVTVF9GKFdlYlZpZXdE ZXN0cnVjdGlvbldpdGhIb3N0V2luZG93LCBDbG9zZVRoZW5HZXRNYWluRnJhbWUpCit7CisgICAg RVhQRUNUX0hSRVNVTFRfU1VDQ0VFREVEKG1fd2ViVmlldy0+Y2xvc2UoKSk7CisKKyAgICBDT01Q dHI8SVdlYkZyYW1lPiBmcmFtZTsKKyAgICBFWFBFQ1RfSFJFU1VMVF9GQUlMRUQobV93ZWJWaWV3 LT5tYWluRnJhbWUoJmZyYW1lKSk7Cit9CisKIFRFU1RfRihXZWJWaWV3RGVzdHJ1Y3Rpb25XaXRo SG9zdFdpbmRvdywgRGVzdHJveVZpZXdXaW5kb3dXaXRob3V0Q2xvc2UpCiB7CiAgICAgOjpEZXN0 cm95V2luZG93KG1fdmlld1dpbmRvdyk7Cg==