32853 2009-12-21 23:33:25 -0800 Define ALWAYS_INLINE and WTF_PRIVATE_INLINE to __forceinline for RVCT 2009-12-22 10:36:53 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 174198 0 skyul 2009-12-21 23:33:25 -0800 In RVCT, __forceinline forces the compiler to compile a C or C++ function inline. The compiler attempts to inline the function, regardless of the characteristics of the function. I see no real performance gains in SunSpider after applying this patch, but I think being explicit about the intention is good. 174200 1 45367 skyul 2009-12-21 23:36:41 -0800 Created attachment 45367 Use __forceinline to force RVCT to inline functions. 174201 2 webkit.review.bot 2009-12-21 23:40:39 -0800 Attachment 45367 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/AlwaysInline.h:26: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 174295 3 45367 commit-queue 2009-12-22 10:36:48 -0800 Comment on attachment 45367 Use __forceinline to force RVCT to inline functions. Clearing flags on attachment: 45367 Committed r52490: <http://trac.webkit.org/changeset/52490> 174296 4 commit-queue 2009-12-22 10:36:53 -0800 All reviewed patches have been landed. Closing bug. 45367 2009-12-21 23:36:41 -0800 2009-12-22 10:36:48 -0800 Use __forceinline to force RVCT to inline functions. forceinline.patch text/plain 1956 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUyNDg0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTItMjEgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEZWZpbmUgQUxXQVlTX0lOTElORSBhbmQgV1RGX1BSSVZB VEVfSU5MSU5FIHRvIF9fZm9yY2VpbmxpbmUgZm9yIFJWQ1QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyODUzCisKKyAgICAgICAgVXNlIF9fZm9yY2Vp bmxpbmUgZm9yY2VzIFJWQ1QgdG8gY29tcGlsZSBhIEMgb3IgQysrIGZ1bmN0aW9uCisgICAgICAg IGlubGluZS4gVGhlIGNvbXBpbGVyIGF0dGVtcHRzIHRvIGlubGluZSB0aGUgZnVuY3Rpb24sIHJl Z2FyZGxlc3Mgb2YKKyAgICAgICAgdGhlIGNoYXJhY3RlcmlzdGljcyBvZiB0aGUgZnVuY3Rpb24u CisKKyAgICAgICAgKiB3dGYvQWx3YXlzSW5saW5lLmg6CisgICAgICAgICogd3RmL0Zhc3RNYWxs b2MuaDoKKwogMjAwOS0xMi0yMSAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tp YS5jb20+CiAKICAgICAgICAgUHJvc3BlY3RpdmUgR1RLIGJ1aWxkIGZpeDogQWRkIFVTdHJpbmdJ bXBsLmNwcC9oIHRvIHRoZSBidWlsZC4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9BbHdheXNJ bmxpbmUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvQWx3YXlzSW5saW5lLmgJ KHJldmlzaW9uIDUyNDgzKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL0Fsd2F5c0lubGluZS5oCSh3 b3JraW5nIGNvcHkpCkBAIC0yMyw3ICsyMyw3IEBACiAjaWZuZGVmIEFMV0FZU19JTkxJTkUKICNp ZiBDT01QSUxFUihHQ0MpICYmIGRlZmluZWQoTkRFQlVHKSAmJiAhQ09NUElMRVIoTUlOR1cpCiAj ZGVmaW5lIEFMV0FZU19JTkxJTkUgaW5saW5lIF9fYXR0cmlidXRlX18oKF9fYWx3YXlzX2lubGlu ZV9fKSkKLSNlbGlmIENPTVBJTEVSKE1TVkMpICYmIGRlZmluZWQoTkRFQlVHKQorI2VsaWYgKENP TVBJTEVSKE1TVkMpIHx8IENPTVBJTEVSKFJWQ1QpKSAmJiBkZWZpbmVkKE5ERUJVRykKICNkZWZp bmUgQUxXQVlTX0lOTElORSBfX2ZvcmNlaW5saW5lCiAjZWxzZQogI2RlZmluZSBBTFdBWVNfSU5M SU5FIGlubGluZQpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxvYy5oCShyZXZpc2lvbiA1MjQ4MykK KysrIEphdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmgJKHdvcmtpbmcgY29weSkKQEAgLTE5 OCw3ICsxOTgsNyBAQCB1c2luZyBXVEY6OmZhc3RNYWxsb2NBbGxvdzsKICNkZWZpbmUgV1RGX1BS SVZBVEVfSU5MSU5FIF9fcHJpdmF0ZV9leHRlcm5fXyBpbmxpbmUgX19hdHRyaWJ1dGVfXygoYWx3 YXlzX2lubGluZSkpCiAjZWxpZiBDT01QSUxFUihHQ0MpCiAjZGVmaW5lIFdURl9QUklWQVRFX0lO TElORSBpbmxpbmUgX19hdHRyaWJ1dGVfXygoYWx3YXlzX2lubGluZSkpCi0jZWxpZiBDT01QSUxF UihNU1ZDKQorI2VsaWYgQ09NUElMRVIoTVNWQykgfHwgQ09NUElMRVIoUlZDVCkKICNkZWZpbmUg V1RGX1BSSVZBVEVfSU5MSU5FIF9fZm9yY2VpbmxpbmUKICNlbHNlCiAjZGVmaW5lIFdURl9QUklW QVRFX0lOTElORSBpbmxpbmUK