32840 2009-12-21 13:57:40 -0800 [GTK] Drag gesture can take mouse grab indefinitely 2010-11-02 17:15:38 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Critical --- 40143 0 grant_gayed webkit-unassigned abarth eric gpocentek mrobinson pachoramos1 sam sa sebastian-keller tao webkit-bugs webkit.review.bot oldest_to_newest 174086 0 grant_gayed 2009-12-21 13:57:40 -0800 - using WebKit 1.1.16 built from source on Ubuntu 9.10 - run the GtkLauncher app and navigate to a page that shows a static image (eg.- the banner at the top of http://www.slis.indiana.edu/faculty/hrosenba/www/Demo/Demo5.html ) - click quickly and repeatedly on the image while moving the mouse a little bit, and you'll soon (within a few seconds) get into a state where WebKitGTK has taken mouse grab and there's no way to get it to let go - additionally, when this happens the following is written to stdout: (GtkLauncher:22437): Gdk-CRITICAL **: gdk_window_get_events: assertion `GDK_IS_WINDOW (window)' failed (GtkLauncher:22437): GLib-GObject-CRITICAL **: g_object_ref: assertion `G_IS_OBJECT (object)' failed (GtkLauncher:22437): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed 174089 1 grant_gayed 2009-12-21 13:59:31 -0800 To clarify, I equated repeated clicking with the drag gesture because when the problem occurs the cursor is left as the drag hand with '+', so I assume that the problem trigger is that a drag is being initiated while clicking and moving the mouse. 195834 2 tao 2010-03-03 17:55:08 -0800 I've experienced this too, several times. Seriously annoying bug. FWIW evolution used to have this kind of bug a long time ago; if you need help to figure out what's wrong, maybe some evolution developer might have some insight (that might of course a totally unrelated issue though). 199910 3 webkit-bugs 2010-03-15 16:07:43 -0700 Confirming present in 1.1.23. Locks up not just the embedding browser in question, but the entire desktop as a result, until epiphany is manually killed. 200730 4 grant_gayed 2010-03-17 06:48:23 -0700 Increasing severity to critical because this is easily hit, and locks the whole desktop. Surely this puts it among the most significant problems. 205209 5 webkit-bugs 2010-03-28 12:35:27 -0700 As a workaround, in epiphany anyways I seem to be able to usually get out of this by opening a gtk menu, as in alt+F to open the file menu. 221534 6 gpocentek 2010-05-06 00:23:30 -0700 Hi, The bug is still present in webkit 1.2.0. I've seen this on a slow machine, and the problem appears on all the system DND (not the JS ones). If the release event is received before the drag icon (the one that follows the cursor) is realized, then the lock happens. If I understand the code correctly, a workaround is implemented in firefox for this. It uses a GtkInvisible that is realized immediatly after creation, and dnd events are tracked on this widget (nsDragService constructor in widget/src/gtk2/nsDragService.cpp). HTH. 233830 7 mrobinson 2010-06-03 10:52:49 -0700 *** Bug 27840 has been marked as a duplicate of this bug. *** 233881 8 57806 mrobinson 2010-06-03 12:58:04 -0700 Created attachment 57806 Patch 233886 9 57806 xan.lopez 2010-06-03 13:03:38 -0700 Comment on attachment 57806 Patch Woot. 233890 10 mrobinson 2010-06-03 13:09:13 -0700 Committed r60632: <http://trac.webkit.org/changeset/60632> 233933 11 webkit.review.bot 2010-06-03 14:44:53 -0700 http://trac.webkit.org/changeset/60632 might have broken GTK Linux 64-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/60632 http://trac.webkit.org/changeset/60633 http://trac.webkit.org/changeset/60634 http://trac.webkit.org/changeset/60635 http://trac.webkit.org/changeset/60636 234385 12 57917 mrobinson 2010-06-04 14:40:36 -0700 Created attachment 57917 Start the drag with the current GTK+ event 234387 13 mrobinson 2010-06-04 14:42:19 -0700 Because of recent changes to the GTK+ event sender it is now possible to start the drag with the current GTK+ event. I've attached a patch using this method. 234394 14 57917 xan.lopez 2010-06-04 14:45:36 -0700 Comment on attachment 57917 Start the drag with the current GTK+ event Oh gods of GTK+, accept this offer. 234396 15 mrobinson 2010-06-04 14:47:47 -0700 Committed r60709: <http://trac.webkit.org/changeset/60709> 234409 16 webkit.review.bot 2010-06-04 15:58:36 -0700 http://trac.webkit.org/changeset/60709 might have broken GTK Linux 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/60712 http://trac.webkit.org/changeset/60713 http://trac.webkit.org/changeset/60709 http://trac.webkit.org/changeset/60710 http://trac.webkit.org/changeset/60711 57806 2010-06-03 12:58:04 -0700 2010-06-04 14:40:30 -0700 Patch bug-32840-20100603125803.patch text/plain 5694 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNDc1M2FlYTllZDUzZmFmZjVmMGM4ZWY0ZDRiNGYyNGNjMjU0ZWNjOS4uMjMzZmUxZDA4 NjlkOTM0NTNmMDE4YzYzNjYxZDRiN2FkMDU2Yzg4ZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAx MC0wNi0wMyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRHJhZyBnZXN0 dXJlIGNhbiB0YWtlIG1vdXNlIGdyYWIgaW5kZWZpbml0ZWx5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjg0MAorCisgICAgICAgIFN0YXJ0IEdUSysg ZHJhZ3Mgd2l0aCB0aGUgcHJldmlvdXMgbW91c2UgYnV0dG9uIGRvd24gZXZlbnQgaW5zdGVhZCBv ZgorICAgICAgICBzeW50aGVzaXppbmcgdGhlIGV2ZW50LiBUaGUgc3ludGhlc2l6ZWQgZXZlbnQg d2FzIG5vdCBjb21wbGV0ZWx5IHZhbGlkCisgICAgICAgIGFuZCBmcm96ZSBzb21lIGRyYWdzIGlu ZGVmaW5pdGVseS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0RyYWdDbGllbnRHdGsuY3Bw OgorICAgICAgICAoV2ViS2l0OjpidXR0b25QcmVzc0V2ZW50KTogQWRkZWQuCisgICAgICAgIChX ZWJLaXQ6OkRyYWdDbGllbnQ6OkRyYWdDbGllbnQpOgorICAgICAgICBDb25uZWN0IHRvIHRoZSAn YnV0dG9uLXByZXNzLWV2ZW50JyBzaWduYWwgb2YgdGhlIFdlYlZpZXcuCisgICAgICAgIChXZWJL aXQ6OkRyYWdDbGllbnQ6OnN0YXJ0RHJhZyk6CisgICAgICAgIEluc3RlYWQgb2Ygc3ludGhlc2l6 aW5nIGEgYnV0dG9uIHByZXNzIGV2ZW50IHVzZSB0aGUgbGFzdCByZWFsIG9uZS4KKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50R3RrLmg6CisgICAgICAgIChXZWJLaXQ6OkRyYWdD bGllbnQ6OnNldExhc3RCdXR0b25QcmVzc0V2ZW50KTogQWRkZWQuCisKIDIwMTAtMDYtMDEgIFhh biBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rh dm8gTm9yb25oYS4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHJhZ0Ns aWVudEd0ay5jcHAgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0RyYWdDbGllbnRHdGsuY3Bw CmluZGV4IGMxZThlNzQ2ZTY3YjE3ODA2YTM2NDk0MTNmNzk5MDVmMDMxYzQ3MWYuLmQxYmE3MWY3 MjIzMzAwZDI1ZWI3NDM3NjYyOGU5YmNjZjkxZDIxM2QgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsv V2ViQ29yZVN1cHBvcnQvRHJhZ0NsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9EcmFnQ2xpZW50R3RrLmNwcApAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmln aHQgKEMpIElnYWxpYSBTLkwuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTAgSWdhbGlhIFMuTC4KICAq CiAgKiAgVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRl IGl0IGFuZC9vcgogICogIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNz ZXIgR2VuZXJhbCBQdWJsaWMKQEAgLTI5LDcgKzI5LDYgQEAKICNpbmNsdWRlICJHUmVmUHRyR3Rr LmgiCiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKICNpbmNsdWRlICJQYXN0ZWJvYXJkSGVs cGVyLmgiCi0jaW5jbHVkZSAiUmVuZGVyT2JqZWN0LmgiCiAjaW5jbHVkZSAid2Via2l0cHJpdmF0 ZS5oIgogI2luY2x1ZGUgIndlYmtpdHdlYnZpZXcuaCIKIApAQCAtNDIsMTAgKzQxLDE3IEBAIHVz aW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAorc3RhdGljIGdi b29sZWFuIGJ1dHRvblByZXNzRXZlbnQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50QnV0dG9u KiBldmVudCwgRHJhZ0NsaWVudCogY2xpZW50KQoreworICAgIGNsaWVudC0+c2V0TGFzdEJ1dHRv blByZXNzRXZlbnQoZ2RrX2V2ZW50X2NvcHkocmVpbnRlcnByZXRfY2FzdDxHZGtFdmVudCo+KGV2 ZW50KSkpOworICAgIHJldHVybiBGQUxTRTsKK30KKwogRHJhZ0NsaWVudDo6RHJhZ0NsaWVudChX ZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogICAgIDogbV93ZWJWaWV3KHdlYlZpZXcpCiAgICAgLCBt X3N0YXJ0UG9zKDAsIDApCiB7CisgICAgZ19zaWduYWxfY29ubmVjdCh3ZWJWaWV3LCAiYnV0dG9u LXByZXNzLWV2ZW50IiwgR19DQUxMQkFDSyhidXR0b25QcmVzc0V2ZW50KSwgdGhpcyk7CiB9CiAK IHZvaWQgRHJhZ0NsaWVudDo6d2lsbFBlcmZvcm1EcmFnRGVzdGluYXRpb25BY3Rpb24oRHJhZ0Rl c3RpbmF0aW9uQWN0aW9uLCBEcmFnRGF0YSopCkBAIC03MiwyNSArNzgsMjcgQEAgRHJhZ1NvdXJj ZUFjdGlvbiBEcmFnQ2xpZW50OjpkcmFnU291cmNlQWN0aW9uTWFza0ZvclBvaW50KGNvbnN0IElu dFBvaW50JikKIHZvaWQgRHJhZ0NsaWVudDo6c3RhcnREcmFnKERyYWdJbWFnZVJlZiBpbWFnZSwg Y29uc3QgSW50UG9pbnQmIGRyYWdJbWFnZU9yaWdpbiwgY29uc3QgSW50UG9pbnQmIGV2ZW50UG9z LCBDbGlwYm9hcmQqIGNsaXBib2FyZCwgRnJhbWUqIGZyYW1lLCBib29sIGxpbmtEcmFnKQogewog ICAgIENsaXBib2FyZEd0ayogY2xpcGJvYXJkR3RrID0gcmVpbnRlcnByZXRfY2FzdDxDbGlwYm9h cmRHdGsqPihjbGlwYm9hcmQpOwotCi0gICAgV2ViS2l0V2ViVmlldyogd2ViVmlldyA9IHdlYmtp dF93ZWJfZnJhbWVfZ2V0X3dlYl92aWV3KGtpdChmcmFtZSkpOwogICAgIFJlZlB0cjxEYXRhT2Jq ZWN0R3RrPiBkYXRhT2JqZWN0ID0gY2xpcGJvYXJkR3RrLT5kYXRhT2JqZWN0KCk7Ci0KICAgICBH UmVmUHRyPEd0a1RhcmdldExpc3Q+IHRhcmdldExpc3QoY2xpcGJvYXJkR3RrLT5oZWxwZXIoKS0+ dGFyZ2V0TGlzdEZvckRhdGFPYmplY3QoZGF0YU9iamVjdC5nZXQoKSkpOwotICAgIEdka0V2ZW50 KiBldmVudCA9IGdka19ldmVudF9uZXcoR0RLX0JVVFRPTl9QUkVTUyk7Ci0gICAgLy8gVGhpcyB3 aWxsIGJlIGRlY3JlbWVudGVkIGJ5IGdka19ldmVudF9mcmVlKCkgYmVsb3cuCi0gICAgZXZlbnQt PmJ1dHRvbi53aW5kb3cgPSBzdGF0aWNfY2FzdDxHZGtXaW5kb3cqPihnX29iamVjdF9yZWYoZ3Rr X3dpZGdldF9nZXRfd2luZG93KEdUS19XSURHRVQobV93ZWJWaWV3KSkpKTsKLSAgICBldmVudC0+ YnV0dG9uLnRpbWUgPSBHREtfQ1VSUkVOVF9USU1FOwogCi0gICAgR2RrRHJhZ0NvbnRleHQqIGNv bnRleHQgPSBndGtfZHJhZ19iZWdpbihHVEtfV0lER0VUKG1fd2ViVmlldyksIHRhcmdldExpc3Qu Z2V0KCksIGRyYWdPcGVyYXRpb25Ub0dka0RyYWdBY3Rpb25zKGNsaXBib2FyZC0+c291cmNlT3Bl cmF0aW9uKCkpLCAxLCBldmVudCk7Ci0gICAgd2ViVmlldy0+cHJpdi0+ZHJhZ2dpbmdEYXRhT2Jq ZWN0cy5zZXQoY29udGV4dCwgZGF0YU9iamVjdCk7CisgICAgLy8gVGhlIERSVCBkb2VzIG5vdCB1 c2UgdGhlIEdUSysgZXZlbnQgcXVldWUgZm9yIG1vdXNlIGRvd24gYW5kIG1vdGlvbgorICAgIC8v IGV2ZW50cy4gSW5zdGVhZCBvZiB1c2luZyB0aGUgZ3RrX2dldF9jdXJyZW50X2V2ZW50LCB3ZSBs aXN0ZW4gZm9yIG1vdXNlCisgICAgLy8gYnV0dG9uLWRvd24tZXZlbnQgc2lnbmFscyBvbiB0aGUg V2ViVmlldyBhbmQgdXNlIHRob3NlIGV2ZW50cyBpbnN0ZWFkLgorICAgIGlmICghbV9sYXN0QnV0 dG9uUHJlc3NFdmVudCkKKyAgICAgICAgcmV0dXJuOworCisgICAgR2RrRHJhZ0NvbnRleHQqIGNv bnRleHQgPSBndGtfZHJhZ19iZWdpbihHVEtfV0lER0VUKG1fd2ViVmlldyksIHRhcmdldExpc3Qu Z2V0KCksIGRyYWdPcGVyYXRpb25Ub0dka0RyYWdBY3Rpb25zKGNsaXBib2FyZC0+c291cmNlT3Bl cmF0aW9uKCkpLCAxLCBtX2xhc3RCdXR0b25QcmVzc0V2ZW50LmdldCgpKTsKKyAgICBzZXRMYXN0 QnV0dG9uUHJlc3NFdmVudCgwKTsKKworICAgIGlmICghY29udGV4dCkKKyAgICAgICAgcmV0dXJu OworCisgICAgbV93ZWJWaWV3LT5wcml2LT5kcmFnZ2luZ0RhdGFPYmplY3RzLnNldChjb250ZXh0 LCBkYXRhT2JqZWN0KTsKIAogICAgIGlmIChpbWFnZSkKICAgICAgICAgZ3RrX2RyYWdfc2V0X2lj b25fcGl4YnVmKGNvbnRleHQsIGltYWdlLCBldmVudFBvcy54KCkgLSBkcmFnSW1hZ2VPcmlnaW4u eCgpLCBldmVudFBvcy55KCkgLSBkcmFnSW1hZ2VPcmlnaW4ueSgpKTsKICAgICBlbHNlCiAgICAg ICAgIGd0a19kcmFnX3NldF9pY29uX2RlZmF1bHQoY29udGV4dCk7Ci0KLSAgICBnZGtfZXZlbnRf ZnJlZShldmVudCk7CiB9CiAKIERyYWdJbWFnZVJlZiBEcmFnQ2xpZW50OjpjcmVhdGVEcmFnSW1h Z2VGb3JMaW5rKEtVUkwmLCBjb25zdCBTdHJpbmcmLCBGcmFtZSopCmRpZmYgLS1naXQgYS9XZWJL aXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0RyYWdDbGllbnRHdGsuaCBiL1dlYktpdC9ndGsvV2ViQ29y ZVN1cHBvcnQvRHJhZ0NsaWVudEd0ay5oCmluZGV4IDY2MDQ5NDBjYmQ4NzU3YmIzMjYzNTVkNzYx OWQ5MTkxOTlmNjgzZWYuLjYzODI4NjYxNTE2ZjIzNTg4Zjg1YjRkZWVkMWRmNTViNGM4M2IwOWEg MTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHJhZ0NsaWVudEd0ay5oCisr KyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHJhZ0NsaWVudEd0ay5oCkBAIC0xLDYgKzEs NyBAQAogLyoKICAqIENvcHlyaWdodCAoQykgMjAwNyBBcHBsZSBJbmMuICBBbGwgcmlnaHRzIHJl c2VydmVkLgogICogQ29weXJpZ2h0IChDKSAyMDA3IEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVy CisgKiBDb3B5cmlnaHQgKEMpIDIwMTAgSWdhbGlhIFMuTC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlv biBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAq IG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcg Y29uZGl0aW9ucwpAQCAtMzEsOCArMzIsMTAgQEAKICNkZWZpbmUgRHJhZ0NsaWVudEd0a19oCiAK ICNpbmNsdWRlICJEcmFnQ2xpZW50LmgiCisjaW5jbHVkZSAiR093blB0ckd0ay5oIgogCiB0eXBl ZGVmIHN0cnVjdCBfV2ViS2l0V2ViVmlldyBXZWJLaXRXZWJWaWV3OwordHlwZWRlZiB1bmlvbiBf R2RrRXZlbnQgR2RrRXZlbnQ7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCkBAIC01MCwxMCArNTMs MTIgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAgICAgICAgIHZpcnR1YWwgV2ViQ29yZTo6RHJhZ0lt YWdlUmVmIGNyZWF0ZURyYWdJbWFnZUZvckxpbmsoV2ViQ29yZTo6S1VSTCYsIGNvbnN0IFdlYkNv cmU6OlN0cmluZyYgbGFiZWwsIFdlYkNvcmU6OkZyYW1lKik7CiAKICAgICAgICAgdmlydHVhbCB2 b2lkIGRyYWdDb250cm9sbGVyRGVzdHJveWVkKCk7CisgICAgICAgIHZvaWQgc2V0TGFzdEJ1dHRv blByZXNzRXZlbnQoR2RrRXZlbnQqIHByZXNzKSB7IG1fbGFzdEJ1dHRvblByZXNzRXZlbnQuc2V0 KHByZXNzKTsgfQogCiAgICAgcHJpdmF0ZToKICAgICAgICAgV2ViS2l0V2ViVmlldyogbV93ZWJW aWV3OwogICAgICAgICBXZWJDb3JlOjpJbnRQb2ludCBtX3N0YXJ0UG9zOworICAgICAgICBHT3du UHRyPEdka0V2ZW50PiBtX2xhc3RCdXR0b25QcmVzc0V2ZW50OwogICAgIH07CiB9CiAK 57917 2010-06-04 14:40:36 -0700 2010-11-02 17:15:38 -0700 Start the drag with the current GTK+ event bug-32840-20100604144035.patch text/plain 2757 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggM2JjYWI0NGFkNjE5NDI1OThiMTM4MmJmNWQ5OTQ2OTVmODZkZGZjZS4uOWUwZTE3NGMw NTk5ZDgyNWM1Njg4OWMwNzZkYjgzNDYyOTExYWRhMyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAx MC0wNi0wNCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRHJhZyBnZXN0 dXJlIGNhbiB0YWtlIG1vdXNlIGdyYWIgaW5kZWZpbml0ZWx5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjg0MAorCisgICAgICAgIEluaXRpYXRlIGRy YWcgZXZlbnRzIHdpdGggdGhlIGN1cnJlbnQgR1RLKyBldmVudCBpbnN0ZWFkIG9mIHN5bnRoZXNp emluZworICAgICAgICBhbiBldmVudC4gU29tZXRoaW5nIGFib3V0IHN5bnRoZXNpemVkIGV2ZW50 cyBpcyBjYXVzaW5nIGEgZHJhZyBmcmVlemUgaW4KKyAgICAgICAgY2VydGFpbiBzaXR1YXRpb25z LgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRHJhZ0NsaWVudEd0ay5jcHA6CisgICAgICAg IChXZWJLaXQ6OkRyYWdDbGllbnQ6OnN0YXJ0RHJhZyk6IFN0YXJ0IHRoZSBkcmFnIHdpdGggdGhl IGN1cnJlbnQgR1RLKyBldmVudC4KKwogMjAxMC0wNi0wMyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQu cmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjYwNjMyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50 R3RrLmNwcCBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHJhZ0NsaWVudEd0ay5jcHAKaW5k ZXggYzFlOGU3NDZlNjdiMTc4MDZhMzY0OTQxM2Y3OTkwNWYwMzFjNDcxZi4uNjZmODFkZjU5MzBj OWJlNzY2NDJhYTc1N2YwMTZjYjA5ODUwN2FlZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJD b3JlU3VwcG9ydC9EcmFnQ2xpZW50R3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBw b3J0L0RyYWdDbGllbnRHdGsuY3BwCkBAIC0yNiw2ICsyNiw3IEBACiAjaW5jbHVkZSAiRHJhZ0Nv bnRyb2xsZXIuaCIKICNpbmNsdWRlICJFbGVtZW50LmgiCiAjaW5jbHVkZSAiRnJhbWUuaCIKKyNp bmNsdWRlICJHT3duUHRyR3RrLmgiCiAjaW5jbHVkZSAiR1JlZlB0ckd0ay5oIgogI2luY2x1ZGUg Ik5vdEltcGxlbWVudGVkLmgiCiAjaW5jbHVkZSAiUGFzdGVib2FyZEhlbHBlci5oIgpAQCAtNzUs MjIgKzc2LDE2IEBAIHZvaWQgRHJhZ0NsaWVudDo6c3RhcnREcmFnKERyYWdJbWFnZVJlZiBpbWFn ZSwgY29uc3QgSW50UG9pbnQmIGRyYWdJbWFnZU9yaWdpbiwKIAogICAgIFdlYktpdFdlYlZpZXcq IHdlYlZpZXcgPSB3ZWJraXRfd2ViX2ZyYW1lX2dldF93ZWJfdmlldyhraXQoZnJhbWUpKTsKICAg ICBSZWZQdHI8RGF0YU9iamVjdEd0az4gZGF0YU9iamVjdCA9IGNsaXBib2FyZEd0ay0+ZGF0YU9i amVjdCgpOwotCiAgICAgR1JlZlB0cjxHdGtUYXJnZXRMaXN0PiB0YXJnZXRMaXN0KGNsaXBib2Fy ZEd0ay0+aGVscGVyKCktPnRhcmdldExpc3RGb3JEYXRhT2JqZWN0KGRhdGFPYmplY3QuZ2V0KCkp KTsKLSAgICBHZGtFdmVudCogZXZlbnQgPSBnZGtfZXZlbnRfbmV3KEdES19CVVRUT05fUFJFU1Mp OwotICAgIC8vIFRoaXMgd2lsbCBiZSBkZWNyZW1lbnRlZCBieSBnZGtfZXZlbnRfZnJlZSgpIGJl bG93LgotICAgIGV2ZW50LT5idXR0b24ud2luZG93ID0gc3RhdGljX2Nhc3Q8R2RrV2luZG93Kj4o Z19vYmplY3RfcmVmKGd0a193aWRnZXRfZ2V0X3dpbmRvdyhHVEtfV0lER0VUKG1fd2ViVmlldykp KSk7Ci0gICAgZXZlbnQtPmJ1dHRvbi50aW1lID0gR0RLX0NVUlJFTlRfVElNRTsKKyAgICBHT3du UHRyPEdka0V2ZW50PiBjdXJyZW50RXZlbnQoZ3RrX2dldF9jdXJyZW50X2V2ZW50KCkpOwogCi0g ICAgR2RrRHJhZ0NvbnRleHQqIGNvbnRleHQgPSBndGtfZHJhZ19iZWdpbihHVEtfV0lER0VUKG1f d2ViVmlldyksIHRhcmdldExpc3QuZ2V0KCksIGRyYWdPcGVyYXRpb25Ub0dka0RyYWdBY3Rpb25z KGNsaXBib2FyZC0+c291cmNlT3BlcmF0aW9uKCkpLCAxLCBldmVudCk7CisgICAgR2RrRHJhZ0Nv bnRleHQqIGNvbnRleHQgPSBndGtfZHJhZ19iZWdpbihHVEtfV0lER0VUKG1fd2ViVmlldyksIHRh cmdldExpc3QuZ2V0KCksIGRyYWdPcGVyYXRpb25Ub0dka0RyYWdBY3Rpb25zKGNsaXBib2FyZC0+ c291cmNlT3BlcmF0aW9uKCkpLCAxLCBjdXJyZW50RXZlbnQuZ2V0KCkpOwogICAgIHdlYlZpZXct PnByaXYtPmRyYWdnaW5nRGF0YU9iamVjdHMuc2V0KGNvbnRleHQsIGRhdGFPYmplY3QpOwogCiAg ICAgaWYgKGltYWdlKQogICAgICAgICBndGtfZHJhZ19zZXRfaWNvbl9waXhidWYoY29udGV4dCwg aW1hZ2UsIGV2ZW50UG9zLngoKSAtIGRyYWdJbWFnZU9yaWdpbi54KCksIGV2ZW50UG9zLnkoKSAt IGRyYWdJbWFnZU9yaWdpbi55KCkpOwogICAgIGVsc2UKICAgICAgICAgZ3RrX2RyYWdfc2V0X2lj b25fZGVmYXVsdChjb250ZXh0KTsKLQotICAgIGdka19ldmVudF9mcmVlKGV2ZW50KTsKIH0KIAog RHJhZ0ltYWdlUmVmIERyYWdDbGllbnQ6OmNyZWF0ZURyYWdJbWFnZUZvckxpbmsoS1VSTCYsIGNv bnN0IFN0cmluZyYsIEZyYW1lKikK