<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>32827</bug_id>
          
          <creation_ts>2009-12-21 10:15:36 -0800</creation_ts>
          <short_desc>Crash when calling IWebView::close, then releasing the WebView, without calling DestroyWindow</short_desc>
          <delta_ts>2010-01-05 15:10:31 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit API</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, PlatformOnly</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Roben (:aroben)">aroben</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>sfalken</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>173994</commentid>
    <comment_count>0</comment_count>
      <attachid>45337</attachid>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2009-12-21 10:15:36 -0800</bug_when>
    <thetext>Created attachment 45337
Patch

WebKit clients can currently cleanly get rid of a WebView in two ways.
A)
1) DestroyWindow(webViewHWND)
2) webView-&gt;Release()
B)
1) webView-&gt;close()
2) DestroyWindow(webViewHWND) (can be swapped with (1))
3) webView-&gt;Release()

We&apos;d like clients to be able to get rid of a WebView just by releasing
the last reference to it. This patch gets us a little closer to that
by removing step B2 above (though calling DestroyWindow in this case
is harmless). A future patch will make steps A1 and B1 unnecessary, as
well.

Fixes &lt;rdar://problem/7374218&gt; Crash in WebView::updateActiveState
when closing &quot;Welcome to iTunes&quot; window

Reviewed by NOBODY (OOPS!).

* WebView.cpp:
(WebView::~WebView): Call setIsBeingDestroyed() so that we won&apos;t be
ref&apos;d by our WndProc, which would result in this destructor being
re-entered.
(WebView::close): Moved the call to revokeDragDrop here...
(WebView::WebViewWndProc): ...from here. This is important in order to
release the reference that OLE holds while we&apos;re registered as a drop
target. Otherwise, clients that call IWebView::close but not
DestroyWindow would leak the WebView.

* WebView.h:
(WebView::setIsBeingDestroyed):
(WebView::isBeingDestroyed):
Made these private, and added a comment about what isBeingDestroyed()
now means.
---
 3 files changed, 52 insertions(+), 5 deletions(-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>173996</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2009-12-21 10:17:34 -0800</bug_when>
    <thetext>&lt;rdar://problem/7374218&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>173998</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2009-12-21 10:19:06 -0800</bug_when>
    <thetext>style-queue ran check-webkit-style on attachment 45337 without any errors.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>174316</commentid>
    <comment_count>3</comment_count>
      <attachid>45337</attachid>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2009-12-22 11:27:20 -0800</bug_when>
    <thetext>Comment on attachment 45337
Patch

I&apos;m going to try tackling this a different way.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>177252</commentid>
    <comment_count>4</comment_count>
      <attachid>45912</attachid>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2010-01-05 11:04:57 -0800</bug_when>
    <thetext>Created attachment 45912
Make it safe to call IWebView::close when IWebView::initWithFrame hasn&apos;t been called</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>177255</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-01-05 11:10:02 -0800</bug_when>
    <thetext>style-queue ran check-webkit-style on attachment 45912 without any errors.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>177282</commentid>
    <comment_count>6</comment_count>
      <attachid>45916</attachid>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2010-01-05 12:02:30 -0800</bug_when>
    <thetext>Created attachment 45916
Make IWebView::close and destroying a WebView&apos;s HWND optional for WebKit clients</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>177378</commentid>
    <comment_count>7</comment_count>
      <attachid>45912</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-05 13:56:52 -0800</bug_when>
    <thetext>Comment on attachment 45912
Make it safe to call IWebView::close when IWebView::initWithFrame hasn&apos;t been called

Looks sane to me too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>177428</commentid>
    <comment_count>8</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2010-01-05 15:10:08 -0800</bug_when>
    <thetext>Committed r52829: &lt;http://trac.webkit.org/changeset/52829&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>177430</commentid>
    <comment_count>9</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2010-01-05 15:10:31 -0800</bug_when>
    <thetext>Committed r52830: &lt;http://trac.webkit.org/changeset/52830&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>45337</attachid>
            <date>2009-12-21 10:15:36 -0800</date>
            <delta_ts>2009-12-22 11:27:20 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>20091221131539.patch</filename>
            <type>text/plain</type>
            <size>4485</size>
            <attacher name="Adam Roben (:aroben)">aroben</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC93aW4vQ2hhbmdlTG9nIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cK
aW5kZXggYzIxYTU3ZC4uM2U0NjBlMiAxMDA2NDQKLS0tIGEvV2ViS2l0L3dpbi9DaGFuZ2VMb2cK
KysrIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKQEAgLTEsNSArMSw0NSBAQAogMjAwOS0xMi0yMSAg
QWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKKyAgICAgICAgTWFrZSBpdCB1bm5lY2Vz
c2FyeSBmb3IgY2xpZW50cyB0byBjYWxsIERlc3Ryb3lXaW5kb3cgb24gYSBXZWJWaWV3CisKKyAg
ICAgICAgV2ViS2l0IGNsaWVudHMgY2FuIGN1cnJlbnRseSBjbGVhbmx5IGdldCByaWQgb2YgYSBX
ZWJWaWV3IGluIHR3byB3YXlzLgorICAgICAgICAgIEEpCisgICAgICAgICAgICAgMSkgRGVzdHJv
eVdpbmRvdyh3ZWJWaWV3SFdORCkKKyAgICAgICAgICAgICAyKSB3ZWJWaWV3LT5SZWxlYXNlKCkK
KyAgICAgICAgICBCKQorICAgICAgICAgICAgIDEpIHdlYlZpZXctPmNsb3NlKCkKKyAgICAgICAg
ICAgICAyKSBEZXN0cm95V2luZG93KHdlYlZpZXdIV05EKSAoY2FuIGJlIHN3YXBwZWQgd2l0aCAo
MSkpCisgICAgICAgICAgICAgMykgd2ViVmlldy0+UmVsZWFzZSgpCisKKyAgICAgICAgV2UnZCBs
aWtlIGNsaWVudHMgdG8gYmUgYWJsZSB0byBnZXQgcmlkIG9mIGEgV2ViVmlldyBqdXN0IGJ5IHJl
bGVhc2luZworICAgICAgICB0aGUgbGFzdCByZWZlcmVuY2UgdG8gaXQuIFRoaXMgcGF0Y2ggZ2V0
cyB1cyBhIGxpdHRsZSBjbG9zZXIgdG8gdGhhdAorICAgICAgICBieSByZW1vdmluZyBzdGVwIEIy
IGFib3ZlICh0aG91Z2ggY2FsbGluZyBEZXN0cm95V2luZG93IGluIHRoaXMgY2FzZQorICAgICAg
ICBpcyBoYXJtbGVzcykuIEEgZnV0dXJlIHBhdGNoIHdpbGwgbWFrZSBzdGVwcyBBMSBhbmQgQjEg
dW5uZWNlc3NhcnksIGFzCisgICAgICAgIHdlbGwuCisKKyAgICAgICAgRml4ZXMgPHJkYXI6Ly9w
cm9ibGVtLzczNzQyMTg+IENyYXNoIGluIFdlYlZpZXc6OnVwZGF0ZUFjdGl2ZVN0YXRlCisgICAg
ICAgIHdoZW4gY2xvc2luZyAiV2VsY29tZSB0byBpVHVuZXMiIHdpbmRvdworCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmlldy5jcHA6CisgICAg
ICAgIChXZWJWaWV3Ojp+V2ViVmlldyk6IENhbGwgc2V0SXNCZWluZ0Rlc3Ryb3llZCgpIHNvIHRo
YXQgd2Ugd29uJ3QgYmUKKyAgICAgICAgcmVmJ2QgYnkgb3VyIFduZFByb2MsIHdoaWNoIHdvdWxk
IHJlc3VsdCBpbiB0aGlzIGRlc3RydWN0b3IgYmVpbmcKKyAgICAgICAgcmUtZW50ZXJlZC4KKyAg
ICAgICAgKFdlYlZpZXc6OmNsb3NlKTogTW92ZWQgdGhlIGNhbGwgdG8gcmV2b2tlRHJhZ0Ryb3Ag
aGVyZS4uLgorICAgICAgICAoV2ViVmlldzo6V2ViVmlld1duZFByb2MpOiAuLi5mcm9tIGhlcmUu
IFRoaXMgaXMgaW1wb3J0YW50IGluIG9yZGVyIHRvCisgICAgICAgIHJlbGVhc2UgdGhlIHJlZmVy
ZW5jZSB0aGF0IE9MRSBob2xkcyB3aGlsZSB3ZSdyZSByZWdpc3RlcmVkIGFzIGEgZHJvcAorICAg
ICAgICB0YXJnZXQuIE90aGVyd2lzZSwgY2xpZW50cyB0aGF0IGNhbGwgSVdlYlZpZXc6OmNsb3Nl
IGJ1dCBub3QKKyAgICAgICAgRGVzdHJveVdpbmRvdyB3b3VsZCBsZWFrIHRoZSBXZWJWaWV3Lgor
CisgICAgICAgICogV2ViVmlldy5oOgorICAgICAgICAoV2ViVmlldzo6c2V0SXNCZWluZ0Rlc3Ry
b3llZCk6CisgICAgICAgIChXZWJWaWV3Ojppc0JlaW5nRGVzdHJveWVkKToKKyAgICAgICAgTWFk
ZSB0aGVzZSBwcml2YXRlLCBhbmQgYWRkZWQgYSBjb21tZW50IGFib3V0IHdoYXQgaXNCZWluZ0Rl
c3Ryb3llZCgpCisgICAgICAgIG5vdyBtZWFucy4KKworMjAwOS0xMi0yMSAgQWRhbSBSb2JlbiAg
PGFyb2JlbkBhcHBsZS5jb20+CisKICAgICAgICAgRml4IG5vbi1BQ0NFTEVSQVRFRF9DT01QT1NJ
VElORyBidWlsZHMKIAogICAgICAgICAqIFdlYlByZWZlcmVuY2VzLmNwcDoKZGlmZiAtLWdpdCBh
L1dlYktpdC93aW4vV2ViVmlldy5jcHAgYi9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCmluZGV4IDky
MjUxNTAuLjBiMTJjMGYgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW4vV2ViVmlldy5jcHAKKysrIGIv
V2ViS2l0L3dpbi9XZWJWaWV3LmNwcApAQCAtMzQ4LDEyICszNDgsMTcgQEAgV2ViVmlldzo6V2Vi
VmlldygpCiAKIFdlYlZpZXc6On5XZWJWaWV3KCkKIHsKKyAgICAvLyBXZSBjYWxsIHNldElzQmVp
bmdEZXN0cm95ZWQoKSBzbyB0aGF0IFdlYlZpZXdXbmRQcm9jIHdvbid0IHJlZiB1cyB3aGVuIHdl
IGNhbGwgRGVzdHJveVdpbmRvdworICAgIC8vIGJlbG93ICh3aGljaCB3b3VsZCByZXN1bHQgaW4g
cmUtZW50ZXJpbmcgdGhpcyBkZXN0cnVjdG9yKS4KKyAgICBib29sIHdhc0FscmVhZHlCZWluZ0Rl
c3Ryb3llZCA9IGlzQmVpbmdEZXN0cm95ZWQoKTsKKyAgICBzZXRJc0JlaW5nRGVzdHJveWVkKCk7
CisKICAgICBkZWxldGVCYWNraW5nU3RvcmUoKTsKIAogICAgIC8vIDxyZGFyOi8vNDk1ODM4Mj4g
bV92aWV3V2luZG93IHdpbGwgYmUgZGVzdHJveWVkIHdoZW4gbV9ob3N0V2luZG93IGlzIGRlc3Ry
b3llZCwgYnV0IGlmCiAgICAgLy8gc2V0SG9zdFdpbmRvdyB3YXMgbmV2ZXIgY2FsbGVkIHdlIHdp
bGwgbGVhayBvdXIgSFdORC4gSWYgd2Ugc3RpbGwgaGF2ZSBhIHZhbGlkIEhXTkQgYXQKICAgICAv
LyB0aGlzIHBvaW50LCB3ZSBzaG91bGQganVzdCBkZXN0cm95IGl0IG91cnNlbHZlcy4KLSAgICBp
ZiAoIWlzQmVpbmdEZXN0cm95ZWQoKSAmJiA6OklzV2luZG93KG1fdmlld1dpbmRvdykpCisgICAg
aWYgKCF3YXNBbHJlYWR5QmVpbmdEZXN0cm95ZWQgJiYgOjpJc1dpbmRvdyhtX3ZpZXdXaW5kb3cp
KQogICAgICAgICA6OkRlc3Ryb3lXaW5kb3cobV92aWV3V2luZG93KTsKIAogICAgIC8vIHRoZSB0
b29sdGlwIHdpbmRvdyBuZWVkcyB0byBiZSBleHBsaWNpdGx5IGRlc3Ryb3llZCBzaW5jZSBpdCBp
c24ndCBhIFdTX0NISUxECkBAIC02NDEsNiArNjQ2LDggQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxM
VFlQRSBXZWJWaWV3OjpjbG9zZSgpCiAgICAgICAgIG1fbW91c2VPdXRUcmFja2VyLnNldCgwKTsK
ICAgICB9CiAgICAgCisgICAgcmV2b2tlRHJhZ0Ryb3AoKTsKKwogICAgIHNldEhvc3RXaW5kb3co
MCk7CiAKICAgICBzZXREb3dubG9hZERlbGVnYXRlKDApOwpAQCAtMTkwNCw3ICsxOTExLDYgQEAg
TFJFU1VMVCBDQUxMQkFDSyBXZWJWaWV3OjpXZWJWaWV3V25kUHJvYyhIV05EIGhXbmQsIFVJTlQg
bWVzc2FnZSwgV1BBUkFNIHdQYXJhbSwKICAgICAgICAgY2FzZSBXTV9ERVNUUk9ZOgogICAgICAg
ICAgICAgd2ViVmlldy0+c2V0SXNCZWluZ0Rlc3Ryb3llZCgpOwogICAgICAgICAgICAgd2ViVmll
dy0+Y2xvc2UoKTsKLSAgICAgICAgICAgIHdlYlZpZXctPnJldm9rZURyYWdEcm9wKCk7CiAgICAg
ICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBXTV9HRVNUVVJFTk9USUZZOgogICAgICAgICAg
ICAgaGFuZGxlZCA9IHdlYlZpZXctPmdlc3R1cmVOb3RpZnkod1BhcmFtLCBsUGFyYW0pOwpkaWZm
IC0tZ2l0IGEvV2ViS2l0L3dpbi9XZWJWaWV3LmggYi9XZWJLaXQvd2luL1dlYlZpZXcuaAppbmRl
eCBjOWI0ZTgyLi5iYTEzYTJlIDEwMDY0NAotLS0gYS9XZWJLaXQvd2luL1dlYlZpZXcuaAorKysg
Yi9XZWJLaXQvd2luL1dlYlZpZXcuaApAQCAtODI5LDkgKzgyOSw2IEBAIHB1YmxpYzoKIAogICAg
IHN0YXRpYyBXZWJDb3JlOjpTdHJpbmcgc3RhbmRhcmRVc2VyQWdlbnRXaXRoQXBwbGljYXRpb25O
YW1lKGNvbnN0IFdlYkNvcmU6OlN0cmluZyYpOwogCi0gICAgdm9pZCBzZXRJc0JlaW5nRGVzdHJv
eWVkKCkgeyBtX2lzQmVpbmdEZXN0cm95ZWQgPSB0cnVlOyB9Ci0gICAgYm9vbCBpc0JlaW5nRGVz
dHJveWVkKCkgY29uc3QgeyByZXR1cm4gbV9pc0JlaW5nRGVzdHJveWVkOyB9Ci0KICAgICBjb25z
dCBjaGFyKiBpbnRlcnByZXRLZXlFdmVudChjb25zdCBXZWJDb3JlOjpLZXlib2FyZEV2ZW50Kik7
CiAgICAgYm9vbCBoYW5kbGVFZGl0aW5nS2V5Ym9hcmRFdmVudChXZWJDb3JlOjpLZXlib2FyZEV2
ZW50Kik7CiAKQEAgLTg2OSw2ICs4NjYsMTAgQEAgcHVibGljOgogI2VuZGlmCiAKIHByaXZhdGU6
CisgICAgLy8gV2hlbiB0cnVlLCBpbmRpY2F0ZXMgdGhhdCBXTV9ERVNUUk9ZIGhhcyBiZWVuIHJl
Y2VpdmVkIG9yIHRoYXQgb3VyIGRlc3RydWN0b3IgaGFzIGJlZW4gY2FsbGVkLgorICAgIHZvaWQg
c2V0SXNCZWluZ0Rlc3Ryb3llZCgpIHsgbV9pc0JlaW5nRGVzdHJveWVkID0gdHJ1ZTsgfQorICAg
IGJvb2wgaXNCZWluZ0Rlc3Ryb3llZCgpIGNvbnN0IHsgcmV0dXJuIG1faXNCZWluZ0Rlc3Ryb3ll
ZDsgfQorCiAgICAgdm9pZCBzZXRab29tTXVsdGlwbGllcihmbG9hdCBtdWx0aXBsaWVyLCBib29s
IGlzVGV4dE9ubHkpOwogICAgIGZsb2F0IHpvb21NdWx0aXBsaWVyKGJvb2wgaXNUZXh0T25seSk7
CiAgICAgYm9vbCBjYW5ab29tSW4oYm9vbCBpc1RleHRPbmx5KTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>45912</attachid>
            <date>2010-01-05 11:04:57 -0800</date>
            <delta_ts>2010-01-05 13:56:51 -0800</delta_ts>
            <desc>Make it safe to call IWebView::close when IWebView::initWithFrame hasn&apos;t been called</desc>
            <filename>bug-32827-20100105140509.patch</filename>
            <type>text/plain</type>
            <size>4544</size>
            <attacher name="Adam Roben (:aroben)">aroben</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC93aW4vQ2hhbmdlTG9nIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cK
aW5kZXggMjc0MjIyNi4uOWVjZjliMyAxMDA2NDQKLS0tIGEvV2ViS2l0L3dpbi9DaGFuZ2VMb2cK
KysrIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMC0wMS0wNSAg
QWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKKyAgICAgICAgTWFrZSBpdCBzYWZlIHRv
IGNhbGwgSVdlYlZpZXc6OmNsb3NlIHdoZW4gSVdlYlZpZXc6OmluaXRXaXRoRnJhbWUKKyAgICAg
ICAgaGFzbid0IGJlZW4gY2FsbGVkCisKKyAgICAgICAgUGFydCBvZiA8aHR0cDovL3dlYmtpdC5v
cmcvYi8zMjgyNz4gQ3Jhc2ggd2hlbiBjYWxsaW5nCisgICAgICAgIElXZWJWaWV3OjpjbG9zZSwg
dGhlbiByZWxlYXNpbmcgdGhlIFdlYlZpZXcsIHdpdGhvdXQgY2FsbGluZworICAgICAgICBEZXN0
cm95V2luZG93CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZpZXc6OmNsb3NlKTogTnVsbC1jaGVjayBt
X3BhZ2UgYW5kIG1fcHJlZmVyZW5jZXMgYmVmb3JlIHVzaW5nCisgICAgICAgIHRoZW0uIFRoZXkg
d2lsbCBiZSBudWxsIGlmIGluaXRXaXRoRnJhbWUgd2FzIG5ldmVyIGNhbGxlZC4KKworMjAxMC0w
MS0wNSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisKICAgICAgICAgQWRkIGFzc2Vy
dGlvbnMgdG8gY2F0Y2ggZG91YmxlLWRlc3RydWN0aW9uIG9mIFdlYlZpZXdzIGVhcmxpZXIKIAog
ICAgICAgICBJIGJhc2ljYWxseSBjb3BpZWQgdGhlIG1fZGVsZXRpb25IYXNCZWd1biBsb2dpYyBm
cm9tIFdURjo6UmVmQ291bnRlZC4KZGlmZiAtLWdpdCBhL1dlYktpdC93aW4vV2ViVmlldy5jcHAg
Yi9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCmluZGV4IGM1ZDU5YzAuLmYxZjJkNGUgMTAwNjQ0Ci0t
LSBhL1dlYktpdC93aW4vV2ViVmlldy5jcHAKKysrIGIvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcApA
QCAtNjM1LDkgKzYzNSwxMCBAQCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFdlYlZpZXc6OmNs
b3NlKCkKIAogICAgIHJlbW92ZUZyb21BbGxXZWJWaWV3c1NldCgpOwogCi0gICAgRnJhbWUqIGZy
YW1lID0gbV9wYWdlLT5tYWluRnJhbWUoKTsKLSAgICBpZiAoZnJhbWUpCi0gICAgICAgIGZyYW1l
LT5sb2FkZXIoKS0+ZGV0YWNoRnJvbVBhcmVudCgpOworICAgIGlmIChtX3BhZ2UpIHsKKyAgICAg
ICAgaWYgKEZyYW1lKiBmcmFtZSA9IG1fcGFnZS0+bWFpbkZyYW1lKCkpCisgICAgICAgICAgICBm
cmFtZS0+bG9hZGVyKCktPmRldGFjaEZyb21QYXJlbnQoKTsKKyAgICB9CiAKICAgICBpZiAobV9t
b3VzZU91dFRyYWNrZXIpIHsKICAgICAgICAgbV9tb3VzZU91dFRyYWNrZXItPmR3RmxhZ3MgPSBU
TUVfQ0FOQ0VMOwpAQCAtNjY4LDE3ICs2NjksMTggQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQ
RSBXZWJWaWV3OjpjbG9zZSgpCiAgICAgSVdlYk5vdGlmaWNhdGlvbkNlbnRlciogbm90aWZ5Q2Vu
dGVyID0gV2ViTm90aWZpY2F0aW9uQ2VudGVyOjpkZWZhdWx0Q2VudGVySW50ZXJuYWwoKTsKICAg
ICBub3RpZnlDZW50ZXItPnJlbW92ZU9ic2VydmVyKHRoaXMsIFdlYlByZWZlcmVuY2VzOjp3ZWJQ
cmVmZXJlbmNlc0NoYW5nZWROb3RpZmljYXRpb24oKSwgc3RhdGljX2Nhc3Q8SVdlYlByZWZlcmVu
Y2VzKj4obV9wcmVmZXJlbmNlcy5nZXQoKSkpOwogCi0gICAgQlNUUiBpZGVudGlmaWVyID0gMDsK
LSAgICBtX3ByZWZlcmVuY2VzLT5pZGVudGlmaWVyKCZpZGVudGlmaWVyKTsKLQotICAgIENPTVB0
cjxXZWJQcmVmZXJlbmNlcz4gcHJlZmVyZW5jZXMgPSBtX3ByZWZlcmVuY2VzOwotICAgIG1fcHJl
ZmVyZW5jZXMgPSAwOwotICAgIHByZWZlcmVuY2VzLT5kaWRSZW1vdmVGcm9tV2ViVmlldygpOwot
ICAgIC8vIE1ha2Ugc3VyZSB3ZSByZWxlYXNlIHRoZSByZWZlcmVuY2UsIHNpbmNlIFdlYlByZWZl
cmVuY2VzOjpyZW1vdmVSZWZlcmVuY2VGb3JJZGVudGlmaWVyIHdpbGwgY2hlY2sgZm9yIGxhc3Qg
cmVmZXJlbmNlIHRvIFdlYlByZWZlcmVuY2VzCi0gICAgcHJlZmVyZW5jZXMgPSAwOwotICAgIGlm
IChpZGVudGlmaWVyKSB7Ci0gICAgICAgIFdlYlByZWZlcmVuY2VzOjpyZW1vdmVSZWZlcmVuY2VG
b3JJZGVudGlmaWVyKGlkZW50aWZpZXIpOwotICAgICAgICBTeXNGcmVlU3RyaW5nKGlkZW50aWZp
ZXIpOworICAgIGlmIChDT01QdHI8V2ViUHJlZmVyZW5jZXM+IHByZWZlcmVuY2VzID0gbV9wcmVm
ZXJlbmNlcykgeworICAgICAgICBCU1RSIGlkZW50aWZpZXIgPSAwOworICAgICAgICBwcmVmZXJl
bmNlcy0+aWRlbnRpZmllcigmaWRlbnRpZmllcik7CisKKyAgICAgICAgbV9wcmVmZXJlbmNlcyA9
IDA7CisgICAgICAgIHByZWZlcmVuY2VzLT5kaWRSZW1vdmVGcm9tV2ViVmlldygpOworICAgICAg
ICAvLyBNYWtlIHN1cmUgd2UgcmVsZWFzZSB0aGUgcmVmZXJlbmNlLCBzaW5jZSBXZWJQcmVmZXJl
bmNlczo6cmVtb3ZlUmVmZXJlbmNlRm9ySWRlbnRpZmllciB3aWxsIGNoZWNrIGZvciBsYXN0IHJl
ZmVyZW5jZSB0byBXZWJQcmVmZXJlbmNlcworICAgICAgICBwcmVmZXJlbmNlcyA9IDA7CisgICAg
ICAgIGlmIChpZGVudGlmaWVyKSB7CisgICAgICAgICAgICBXZWJQcmVmZXJlbmNlczo6cmVtb3Zl
UmVmZXJlbmNlRm9ySWRlbnRpZmllcihpZGVudGlmaWVyKTsKKyAgICAgICAgICAgIFN5c0ZyZWVT
dHJpbmcoaWRlbnRpZmllcik7CisgICAgICAgIH0KICAgICB9CiAKICAgICBkZWxldGVCYWNraW5n
U3RvcmUoKTsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xz
L0NoYW5nZUxvZwppbmRleCBjNWE4MjRlLi4yOWI4OTU0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s
cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAK
IDIwMTAtMDEtMDUgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCisgICAgICAgIFRl
c3QgdGhhdCBpdCdzIHNhZmUgdG8gY2FsbCBJV2ViVmlldzo6Y2xvc2Ugd2hlbgorICAgICAgICBJ
V2ViVmlldzo6aW5pdFdpdGhGcmFtZSBoYXNuJ3QgYmVlbiBjYWxsZWQKKworICAgICAgICBQYXJ0
IG9mIDxodHRwOi8vd2Via2l0Lm9yZy9iLzMyODI3PiBDcmFzaCB3aGVuIGNhbGxpbmcKKyAgICAg
ICAgSVdlYlZpZXc6OmNsb3NlLCB0aGVuIHJlbGVhc2luZyB0aGUgV2ViVmlldywgd2l0aG91dCBj
YWxsaW5nCisgICAgICAgIERlc3Ryb3lXaW5kb3cKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdEFQSVRlc3QvdGVzdHMvV2ViVmlld0Rlc3Ry
dWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYktpdEFQSVRlc3Q6OkNsb3NlV2l0aG91dEluaXRXaXRo
RnJhbWUpOiBDYWxscyBJV2ViVmlldzo6Y2xvc2UKKyAgICAgICAgd2l0aG91dCBldmVyIGNhbGxp
bmcgSVdlYlZpZXc6OmluaXRXaXRoRnJhbWUgYW5kIHRlc3RzIHRoYXQgd2UgZG9uJ3QKKyAgICAg
ICAgY3Jhc2ggb3IgbGVhay4KKworMjAxMC0wMS0wNSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBs
ZS5jb20+CisKICAgICAgICAgQWRkIG1vcmUgV2ViVmlld0Rlc3RydWN0aW9uIHRlc3RzCiAKICAg
ICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJMIChPT1BTISkKZGlmZiAt
LWdpdCBhL1dlYktpdFRvb2xzL1dlYktpdEFQSVRlc3QvdGVzdHMvV2ViVmlld0Rlc3RydWN0aW9u
LmNwcCBiL1dlYktpdFRvb2xzL1dlYktpdEFQSVRlc3QvdGVzdHMvV2ViVmlld0Rlc3RydWN0aW9u
LmNwcAppbmRleCAyODBhY2FjLi42YzA5ZTZmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9XZWJL
aXRBUElUZXN0L3Rlc3RzL1dlYlZpZXdEZXN0cnVjdGlvbi5jcHAKKysrIGIvV2ViS2l0VG9vbHMv
V2ViS2l0QVBJVGVzdC90ZXN0cy9XZWJWaWV3RGVzdHJ1Y3Rpb24uY3BwCkBAIC0xMDIsNiArMTAy
LDE2IEBAIFRFU1QoV2ViVmlld0Rlc3RydWN0aW9uLCBOb0luaXRXaXRoRnJhbWUpCiAgICAgZmlu
aXNoV2ViVmlld0Rlc3RydWN0aW9uVGVzdCh3ZWJWaWV3LCAwKTsKIH0KIAorVEVTVChXZWJWaWV3
RGVzdHJ1Y3Rpb24sIENsb3NlV2l0aG91dEluaXRXaXRoRnJhbWUpCit7CisgICAgQ09NUHRyPElX
ZWJWaWV3PiB3ZWJWaWV3OworICAgIFRFU1RfQVNTRVJUKFNVQ0NFRURFRChXZWJLaXRDcmVhdGVJ
bnN0YW5jZShfX3V1aWRvZihXZWJWaWV3KSwgJndlYlZpZXcpKSk7CisKKyAgICBURVNUX0FTU0VS
VChTVUNDRUVERUQod2ViVmlldy0+Y2xvc2UoKSkpOworCisgICAgZmluaXNoV2ViVmlld0Rlc3Ry
dWN0aW9uVGVzdCh3ZWJWaWV3LCAwKTsKK30KKwogLy8gVGVzdHMgdGhhdCByZWxlYXNpbmcgYSBX
ZWJWaWV3IHdpdGhvdXQgY2FsbGluZyBJV2ViVmlldzo6Y2xvc2Ugb3IgRGVzdHJveVdpbmRvdyBk
b2Vzbid0IGxlYWsuIDxodHRwOi8vd2Via2l0Lm9yZy9iLzMzMTYyPgogVEVTVChXZWJWaWV3RGVz
dHJ1Y3Rpb24sIE5vQ2xvc2VPckRlc3Ryb3lWaWV3V2luZG93KQogewo=
</data>
<flag name="review"
          id="28075"
          type_id="1"
          status="+"
          setter="sfalken"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>45916</attachid>
            <date>2010-01-05 12:02:30 -0800</date>
            <delta_ts>2010-01-05 12:23:49 -0800</delta_ts>
            <desc>Make IWebView::close and destroying a WebView&apos;s HWND optional for WebKit clients</desc>
            <filename>bug-32827-20100105150244.patch</filename>
            <type>text/plain</type>
            <size>6115</size>
            <attacher name="Adam Roben (:aroben)">aroben</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC93aW4vQ2hhbmdlTG9nIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cK
aW5kZXggOWVjZjliMy4uOGFmOWJjMCAxMDA2NDQKLS0tIGEvV2ViS2l0L3dpbi9DaGFuZ2VMb2cK
KysrIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKQEAgLTEsNSArMSw0OSBAQAogMjAxMC0wMS0wNSAg
QWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKKyAgICAgICAgTWFrZSBJV2ViVmlldzo6
Y2xvc2UgYW5kIGRlc3Ryb3lpbmcgYSBXZWJWaWV3J3MgSFdORCBvcHRpb25hbCBmb3IKKyAgICAg
ICAgV2ViS2l0IGNsaWVudHMKKworICAgICAgICBXZWJWaWV3IHdpbGwgbm93IHRha2UgY2FyZSBv
ZiB0aGVzZSBvcGVyYXRpb25zIGl0c2VsZiB3aGVuIGl0cyBsYXN0CisgICAgICAgIHJlZmVyZW5j
ZSBpcyByZWxlYXNlZCwgaWYgdGhleSBoYXZlbid0IGFscmVhZHkgYmVlbiBkb25lLgorCisgICAg
ICAgIElXZWJWaWV3OjpjbG9zZSBub3cgYWxzbyBkZXN0cm95cyB0aGUgV2ViVmlldydzIEhXTkQu
IEFsbCBXZWJLaXQKKyAgICAgICAgY2xpZW50cyB3ZXJlIGFscmVhZHkgcGVyZm9ybWluZyB0aGVz
ZSBvcGVyYXRpb25zIGluIHN1Y2Nlc3Npb24gYW55d2F5LAorICAgICAgICBvciB3ZXJlIGF0dGVt
cHRpbmcgdG8gYnkgY2FsbGluZyBJV2ViVmlldzo6Y2xvc2UgdGhlbiBkZXN0cm95aW5nIHRoZQor
ICAgICAgICBXZWJWaWV3J3MgaG9zdCB3aW5kb3cgKHdoaWNoIGFjdHVhbGx5IHJlc3VsdGVkIGlu
IHRoZSBXZWJWaWV3J3MgSFdORAorICAgICAgICBsZWFraW5nLCBhbmQgdGhlIGNyYXNoIGluIHRo
ZSBiZWxvdyBidWcpLgorCisgICAgICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzMyODI3
PiBDcmFzaCB3aGVuIGNhbGxpbmcgSVdlYlZpZXc6OmNsb3NlLAorICAgICAgICB0aGVuIHJlbGVh
c2luZyB0aGUgV2ViVmlldywgd2l0aG91dCBjYWxsaW5nIERlc3Ryb3lXaW5kb3cKKworICAgICAg
ICBGaXhlcyBhIGZldyBXZWJWaWV3RGVzdHJ1Y3Rpb24gdGVzdHMsIHRvby4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlZpZXcuY3BwOgorICAg
ICAgICAoV2ViVmlldzo6fldlYlZpZXcpOiBEb24ndCB0cnkgdG8gZGVzdHJveSBtX3ZpZXdXaW5k
b3cgaGVyZS4gVGhhdAorICAgICAgICBzaG91bGQgYWxyZWFkeSBoYXZlIGhhcHBlbmVkLiBBc3Nl
cnQgdGhhdCB0aGlzIGlzIHRoZSBjYXNlLgorICAgICAgICAoV2ViVmlldzo6Y2xvc2UpOiBJZiBt
X3ZpZXdXaW5kb3cgaXNuJ3QgYWxyZWFkeSBiZWluZyBkZXN0cm95ZWQsCisgICAgICAgIGRlc3Ry
b3kgaXQgbm93LiBNb3ZlZCB0aGUgY2FsbCB0byByZXZva2VEcmFnRHJvcCgpIGhlcmUgZnJvbSBv
dXIKKyAgICAgICAgV01fREVTVFJPWSBoYW5kbGVyIGJlY2F1c2UgaXQgbmVlZHMgdG8gYmUgZG9u
ZSBiZWZvcmUgbV92aWV3V2luZG93IGlzCisgICAgICAgIG51bGxlZCBvdXQuCisgICAgICAgIChX
ZWJWaWV3OjpXZWJWaWV3V25kUHJvYyk6IFJlbW92ZWQgY2FsbCB0byByZXZva2VEcmFnRHJvcCgp
IHRoYXQKKyAgICAgICAgY2xvc2UoKSBub3cgcGVyZm9ybXMuCisgICAgICAgIChXZWJWaWV3OjpS
ZWxlYXNlKTogSWYgb3VyIGxhc3QgcmVmZXJlbmNlIGlzIGJlaW5nIHJlbGVhc2VkLCBjYWxsCisg
ICAgICAgIGNsb3NlKCkgc28gdGhhdCBjbGllbnRzIGRvbid0IGhhdmUgdG8uIChJdCdzIGhhcm1s
ZXNzIHRvIGNhbGwgY2xvc2UoKQorICAgICAgICBtdWx0aXBsZSB0aW1lcy4pIFdlIGRvIHRoaXMg
aGVyZSBpbnN0ZWFkIG9mIGluIHRoZSBkZXN0cnVjdG9yIGJlY2F1c2UKKyAgICAgICAgY2xvc2Uo
KSBjYW4gY2F1c2UgQWRkUmVmKCkgYW5kIFJlbGVhc2UoKSB0byBiZSBjYWxsZWQsIGFuZCBjYWxs
aW5nCisgICAgICAgIHRob3NlIGZyb20gd2l0aGluIHRoZSBkZXN0cnVjdG9yIGxlYWRzIHRvIGRv
dWJsZS1kZXN0cnVjdGlvbi4KKyAgICAgICAgKFdlYlZpZXc6OnNldEhvc3RXaW5kb3cpOiBSZW1v
dmVkIGFuIHVubmVjZXNzYXJ5IChhbmQgbm93IGhhcm1mdWwpCisgICAgICAgIG51bGwtY2hlY2su
CisgICAgICAgIChXZWJWaWV3OjpyZXZva2VEcmFnRHJvcCk6IENoYW5nZWQgYW4gYXNzZXJ0aW9u
IGludG8gYSBydW4tdGltZSBjaGVjaywKKyAgICAgICAgc2luY2UgdGhpcyB3aWxsIG5vdyBzb21l
dGltZXMgYmUgY2FsbGVkIHdoZW4gbV92aWV3V2luZG93IGhhc24ndCBiZWVuCisgICAgICAgIGNy
ZWF0ZWQgeWV0LiBDaGFuZ2VkIHRoZSBJc1dpbmRvdyBjYWxsIHRvIGEgbnVsbC1jaGVjayBiZWNh
dXNlIHdlCisgICAgICAgIG5ldmVyIGhvbGQgb250byBhIGRlc3Ryb3llZCBtX3ZpZXdXaW5kb3cu
CisgICAgICAgIChXZWJWaWV3Ojp3aW5kb3dBbmNlc3RyeURpZENoYW5nZSk6IElmIHdlIGRvbid0
IGhhdmUgYSB2aWV3IHdpbmRvdywKKyAgICAgICAgc3RvcCB0cmFja2luZyBjaGFuZ2VzIHRvIG91
ciBwYXJlbnQncyBhY3RpdmUgc3RhdGUuCisKKzIwMTAtMDEtMDUgIEFkYW0gUm9iZW4gIDxhcm9i
ZW5AYXBwbGUuY29tPgorCiAgICAgICAgIE1ha2UgaXQgc2FmZSB0byBjYWxsIElXZWJWaWV3Ojpj
bG9zZSB3aGVuIElXZWJWaWV3Ojppbml0V2l0aEZyYW1lCiAgICAgICAgIGhhc24ndCBiZWVuIGNh
bGxlZAogCmRpZmYgLS1naXQgYS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwIGIvV2ViS2l0L3dpbi9X
ZWJWaWV3LmNwcAppbmRleCBmMWYyZDRlLi5kYTY3NzJhIDEwMDY0NAotLS0gYS9XZWJLaXQvd2lu
L1dlYlZpZXcuY3BwCisrKyBiL1dlYktpdC93aW4vV2ViVmlldy5jcHAKQEAgLTM1NCwxOCArMzU0
LDEzIEBAIFdlYlZpZXc6On5XZWJWaWV3KCkKIHsKICAgICBkZWxldGVCYWNraW5nU3RvcmUoKTsK
IAotICAgIC8vIDxyZGFyOi8vNDk1ODM4Mj4gbV92aWV3V2luZG93IHdpbGwgYmUgZGVzdHJveWVk
IHdoZW4gbV9ob3N0V2luZG93IGlzIGRlc3Ryb3llZCwgYnV0IGlmCi0gICAgLy8gc2V0SG9zdFdp
bmRvdyB3YXMgbmV2ZXIgY2FsbGVkIHdlIHdpbGwgbGVhayBvdXIgSFdORC4gSWYgd2Ugc3RpbGwg
aGF2ZSBhIHZhbGlkIEhXTkQgYXQKLSAgICAvLyB0aGlzIHBvaW50LCB3ZSBzaG91bGQganVzdCBk
ZXN0cm95IGl0IG91cnNlbHZlcy4KLSAgICBpZiAoIWlzQmVpbmdEZXN0cm95ZWQoKSAmJiA6Oklz
V2luZG93KG1fdmlld1dpbmRvdykpCi0gICAgICAgIDo6RGVzdHJveVdpbmRvdyhtX3ZpZXdXaW5k
b3cpOwotCiAgICAgLy8gdGhlIHRvb2x0aXAgd2luZG93IG5lZWRzIHRvIGJlIGV4cGxpY2l0bHkg
ZGVzdHJveWVkIHNpbmNlIGl0IGlzbid0IGEgV1NfQ0hJTEQKICAgICBpZiAoOjpJc1dpbmRvdyht
X3Rvb2xUaXBId25kKSkKICAgICAgICAgOjpEZXN0cm95V2luZG93KG1fdG9vbFRpcEh3bmQpOwog
CiAgICAgQVNTRVJUKCFtX3BhZ2UpOwogICAgIEFTU0VSVCghbV9wcmVmZXJlbmNlcyk7CisgICAg
QVNTRVJUKCFtX3ZpZXdXaW5kb3cpOwogCiAgICAgV2ViVmlld0NvdW50LS07CiAgICAgZ0NsYXNz
Q291bnQtLTsKQEAgLTY0Niw2ICs2NDEsMTggQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBX
ZWJWaWV3OjpjbG9zZSgpCiAgICAgICAgIG1fbW91c2VPdXRUcmFja2VyLnNldCgwKTsKICAgICB9
CiAgICAgCisgICAgcmV2b2tlRHJhZ0Ryb3AoKTsKKworICAgIGlmIChtX3ZpZXdXaW5kb3cpIHsK
KyAgICAgICAgLy8gV2UgY2FuJ3QgY2hlY2sgSXNXaW5kb3cobV92aWV3V2luZG93KSBoZXJlLCBi
ZWNhdXNlIHRoYXQgd2lsbCByZXR1cm4gdHJ1ZSBldmVuIHdoaWxlCisgICAgICAgIC8vIHdlJ3Jl
IGFscmVhZHkgaGFuZGxpbmcgV01fREVTVFJPWS4gU28gd2UgY2hlY2sgIWlzQmVpbmdEZXN0cm95
ZWQoKSBpbnN0ZWFkLgorICAgICAgICBpZiAoIWlzQmVpbmdEZXN0cm95ZWQoKSkKKyAgICAgICAg
ICAgIERlc3Ryb3lXaW5kb3cobV92aWV3V2luZG93KTsKKyAgICAgICAgLy8gRWl0aGVyIHdlIGp1
c3QgZGVzdHJveWVkIG1fdmlld1dpbmRvdywgb3IgaXQncyBpbiB0aGUgcHJvY2VzcyBvZiBiZWlu
ZyBkZXN0cm95ZWQuIEVpdGhlcgorICAgICAgICAvLyB3YXksIHdlIGNsZWFyIGl0IG91dCB0byBt
YWtlIHN1cmUgd2UgZG9uJ3QgdHJ5IHRvIHVzZSBpdCBsYXRlci4KKyAgICAgICAgbV92aWV3V2lu
ZG93ID0gMDsKKyAgICB9CisKICAgICBzZXRIb3N0V2luZG93KDApOwogCiAgICAgc2V0RG93bmxv
YWREZWxlZ2F0ZSgwKTsKQEAgLTE5MTAsNyArMTkxNyw2IEBAIExSRVNVTFQgQ0FMTEJBQ0sgV2Vi
Vmlldzo6V2ViVmlld1duZFByb2MoSFdORCBoV25kLCBVSU5UIG1lc3NhZ2UsIFdQQVJBTSB3UGFy
YW0sCiAgICAgICAgIGNhc2UgV01fREVTVFJPWToKICAgICAgICAgICAgIHdlYlZpZXctPnNldElz
QmVpbmdEZXN0cm95ZWQoKTsKICAgICAgICAgICAgIHdlYlZpZXctPmNsb3NlKCk7Ci0gICAgICAg
ICAgICB3ZWJWaWV3LT5yZXZva2VEcmFnRHJvcCgpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAg
ICAgIGNhc2UgV01fR0VTVFVSRU5PVElGWToKICAgICAgICAgICAgIGhhbmRsZWQgPSB3ZWJWaWV3
LT5nZXN0dXJlTm90aWZ5KHdQYXJhbSwgbFBhcmFtKTsKQEAgLTIyODAsNiArMjI4NiwxNCBAQCBV
TE9ORyBTVERNRVRIT0RDQUxMVFlQRSBXZWJWaWV3OjpSZWxlYXNlKHZvaWQpCiB7CiAgICAgQVNT
RVJUKCFtX2RlbGV0aW9uSGFzQmVndW4pOwogCisgICAgaWYgKG1fcmVmQ291bnQgPT0gMSkgewor
ICAgICAgICAvLyBDYWxsIGNsb3NlKCkgbm93IHNvIHRoYXQgY2xpZW50cyBkb24ndCBoYXZlIHRv
LiAoSXQncyBoYXJtbGVzcyB0byBjYWxsIGNsb3NlKCkgbXVsdGlwbGUKKyAgICAgICAgLy8gdGlt
ZXMuKSBXZSBkbyB0aGlzIGhlcmUgaW5zdGVhZCBvZiBpbiBvdXIgZGVzdHJ1Y3RvciBiZWNhdXNl
IGNsb3NlKCkgY2FuIGNhdXNlIEFkZFJlZigpCisgICAgICAgIC8vIGFuZCBSZWxlYXNlKCkgdG8g
YmUgY2FsbGVkLCBhbmQgaWYgdGhhdCBoYXBwZW5lZCBpbiBvdXIgZGVzdHJ1Y3RvciB3ZSB3b3Vs
ZCBiZSBkZXN0cm95ZWQKKyAgICAgICAgLy8gbW9yZSB0aGFuIG9uY2UuCisgICAgICAgIGNsb3Nl
KCk7CisgICAgfQorCiAgICAgVUxPTkcgbmV3UmVmID0gLS1tX3JlZkNvdW50OwogICAgIGlmICgh
bmV3UmVmKSB7CiAjaWYgIUFTU0VSVF9ESVNBQkxFRApAQCAtMzA2MCw4ICszMDc0LDcgQEAgSFJF
U1VMVCBTVERNRVRIT0RDQUxMVFlQRSBXZWJWaWV3OjpzZXRIb3N0V2luZG93KAogCiAgICAgbV9o
b3N0V2luZG93ID0gd2luZG93OwogCi0gICAgaWYgKG1fdmlld1dpbmRvdykKLSAgICAgICAgd2lu
ZG93QW5jZXN0cnlEaWRDaGFuZ2UoKTsKKyAgICB3aW5kb3dBbmNlc3RyeURpZENoYW5nZSgpOwog
CiAgICAgcmV0dXJuIFNfT0s7CiB9CkBAIC00OTQxLDcgKzQ5NTQsOSBAQCBIUkVTVUxUIFdlYlZp
ZXc6OnJlZ2lzdGVyRHJhZ0Ryb3AoKQogCiBIUkVTVUxUIFdlYlZpZXc6OnJldm9rZURyYWdEcm9w
KCkKIHsKLSAgICBBU1NFUlQoOjpJc1dpbmRvdyhtX3ZpZXdXaW5kb3cpKTsKKyAgICBpZiAoIW1f
dmlld1dpbmRvdykKKyAgICAgICAgcmV0dXJuIFNfT0s7CisKICAgICByZXR1cm4gOjpSZXZva2VE
cmFnRHJvcChtX3ZpZXdXaW5kb3cpOwogfQogCkBAIC01MzY5LDcgKzUzODQsMTUgQEAgSFJFU1VM
VCBTVERNRVRIT0RDQUxMVFlQRSBXZWJWaWV3OjppbnNwZWN0b3IoSVdlYkluc3BlY3RvcioqIGlu
c3BlY3RvcikKIAogSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBXZWJWaWV3Ojp3aW5kb3dBbmNl
c3RyeURpZENoYW5nZSgpCiB7Ci0gICAgSFdORCBuZXdQYXJlbnQgPSBmaW5kVG9wTGV2ZWxQYXJl
bnQobV9ob3N0V2luZG93KTsKKyAgICBIV05EIG5ld1BhcmVudDsKKyAgICBpZiAobV92aWV3V2lu
ZG93KQorICAgICAgICBuZXdQYXJlbnQgPSBmaW5kVG9wTGV2ZWxQYXJlbnQobV9ob3N0V2luZG93
KTsKKyAgICBlbHNlIHsKKyAgICAgICAgLy8gVGhlcmUncyBubyBwb2ludCBpbiB0cmFja2luZyBh
Y3RpdmUgc3RhdGUgY2hhbmdlcyBvZiBvdXIgcGFyZW50IHdpbmRvdyBpZiB3ZSBkb24ndCBoYXZl
CisgICAgICAgIC8vIGEgd2luZG93IG91cnNlbHZlcy4KKyAgICAgICAgbmV3UGFyZW50ID0gMDsK
KyAgICB9CisKICAgICBpZiAobmV3UGFyZW50ID09IG1fdG9wTGV2ZWxQYXJlbnQpCiAgICAgICAg
IHJldHVybiBTX09LOwogCg==
</data>
<flag name="review"
          id="28080"
          type_id="1"
          status="+"
          setter="sfalken"
    />
          </attachment>
      

    </bug>

</bugzilla>