32821 2009-12-21 04:41:02 -0800 types must match on ?: in css/CSSComputedStyleDeclaration.cpp 2011-03-24 10:07:04 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 0 bentaylor.solx86 webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 173953 0 45325 bentaylor.solx86 2009-12-21 04:41:02 -0800 Created attachment 45325 Patch to fix the problem with the conflicting types. compiling qt-4.6.0 with webkit on Solaris 10 with Studio 12, I see the following error: "css/CSSComputedStyleDeclaration.cpp", line 570: Error: Ambiguous "?:"expression, second operand of type "int" and third operand of type "WTF::PassRefPtr<WebCore::CSSPrimitiveValue>" can be converted to one another. "css/CSSComputedStyleDeclaration.cpp", line 571: Error: Ambiguous "?:"expression, second operand of type "int" and third operand of type "WTF::PassRefPtr<WebCore::CSSPrimitiveValue>" can be converted to one another. I've submitted a patch which has passed compilation. 174373 1 ap 2009-12-22 13:54:54 -0800 Would you be willing to submit a patch for review, as described in <http://webkit.org/coding/contributing.html>? 174437 2 bentaylor.solx86 2009-12-22 15:15:53 -0800 (In reply to comment #1) > Would you be willing to submit a patch for review, as described in > <http://webkit.org/coding/contributing.html>? Someone who actually knows something about the application might be better to check the very small patch I submitted. I'm just trying to get QT compiled. I don't know when I'll have the port complete. 365994 3 85472 bentaylor.solx86 2011-03-11 07:36:14 -0800 Created attachment 85472 Updated version of the patch to more correctly represent a "0" (as previously used in the conditional) to a type acceptable by the SS12 compiler This is an updated patch that fixes a webkit component to compile on Solaris 10 with the SunStudio12 compiler. Simply, a 0 (int) causes a problem for strongly typed SunStudio 12 C++ and this patch uses a more normalized form of an "empty" pointer so that the compilation will continue. 366183 4 ap 2011-03-11 11:51:51 -0800 I'm sorry to sound like a broken record, but please do follow <http://webkit.org/coding/contributing.html> to contribute code. In particular, the patch lacks a ChangeLog, and doesn't have r? bit set for review. Without a ChangeLog, the patch cannot be landed, and without being marked for review, it isn't visible in review queue. 366579 5 85593 bentaylor.solx86 2011-03-12 07:29:15 -0800 Created attachment 85593 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler This fix is against webkit head, but works for the webkit distributed with qt-4.7.1. This fix is similar to the one in https://bugs.webkit.org/attachment.cgi?bugid=56198 which passed muster. 372827 6 85593 ap 2011-03-24 08:46:28 -0700 Comment on attachment 85593 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Thank you! 372839 7 85593 commit-queue 2011-03-24 09:08:49 -0700 Comment on attachment 85593 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Clearing flags on attachment: 85593 Committed r81869: <http://trac.webkit.org/changeset/81869> 372840 8 commit-queue 2011-03-24 09:08:54 -0700 All reviewed patches have been landed. Closing bug. 372876 9 webkit.review.bot 2011-03-24 10:07:04 -0700 http://trac.webkit.org/changeset/81869 might have broken GTK Linux 64-bit Debug The following tests are not passing: loader/reload-subresource-when-type-changes.html 45325 2009-12-21 04:41:02 -0800 2011-03-11 07:36:14 -0800 Patch to fix the problem with the conflicting types. qt-4.6.0-webkit-CSSComputedStyleDeclaration.cpp.221.diff text/plain 1559 bentaylor.solx86 LS0tIHF0LWV2ZXJ5d2hlcmUtb3BlbnNvdXJjZS1zcmMtNC42LjAtT1JJRy9zcmMvM3JkcGFydHkv d2Via2l0L1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAJMjAwOS0x Mi0yMSAwNzowOTozOC42MDE1NDE5NTkgLTA1MDAKKysrIHF0LWV2ZXJ5d2hlcmUtb3BlbnNvdXJj ZS1zcmMtNC42LjAvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0 eWxlRGVjbGFyYXRpb24uY3BwCTIwMDktMTItMjEgMDY6NTk6MTIuMjc2MDgzNTIwIC0wNTAwCkBA IC01NjcsOCArNTY3LDggQEAKICAgICAgICAgUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiB4ID0g Q1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZShzLT54LCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BY KTsKICAgICAgICAgUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiB5ID0gQ1NTUHJpbWl0aXZlVmFs dWU6OmNyZWF0ZShzLT55LCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BYKTsKICAgICAgICAgUmVm UHRyPENTU1ByaW1pdGl2ZVZhbHVlPiBibHVyID0gQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZShz LT5ibHVyLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BYKTsKLSAgICAgICAgUmVmUHRyPENTU1By aW1pdGl2ZVZhbHVlPiBzcHJlYWQgPSBwcm9wZXJ0eUlEID09IENTU1Byb3BlcnR5VGV4dFNoYWRv dyA/IDAgOiBDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlKHMtPnNwcmVhZCwgQ1NTUHJpbWl0aXZl VmFsdWU6OkNTU19QWCk7Ci0gICAgICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gc3R5bGUg PSBwcm9wZXJ0eUlEID09IENTU1Byb3BlcnR5VGV4dFNoYWRvdyB8fCBzLT5zdHlsZSA9PSBOb3Jt YWwgPyAwIDogQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZUlkZW50aWZpZXIoQ1NTVmFsdWVJbnNl dCk7CisgICAgICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gc3ByZWFkID0gcHJvcGVydHlJ RCA9PSBDU1NQcm9wZXJ0eVRleHRTaGFkb3cgPyBDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlSWRl bnRpZmllcihDU1NWYWx1ZU5vbmUpIDogQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZShzLT5zcHJl YWQsIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfUFgpOworICAgICAgICBSZWZQdHI8Q1NTUHJpbWl0 aXZlVmFsdWU+IHN0eWxlID0gcHJvcGVydHlJRCA9PSBDU1NQcm9wZXJ0eVRleHRTaGFkb3cgfHwg cy0+c3R5bGUgPT0gTm9ybWFsID8gQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZUlkZW50aWZpZXIo Q1NTVmFsdWVOb25lKSA6IENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGVJZGVudGlmaWVyKENTU1Zh bHVlSW5zZXQpOwogICAgICAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IGNvbG9yID0gQ1NT UHJpbWl0aXZlVmFsdWU6OmNyZWF0ZUNvbG9yKHMtPmNvbG9yLnJnYigpKTsKICAgICAgICAgbGlz dC0+cHJlcGVuZChTaGFkb3dWYWx1ZTo6Y3JlYXRlKHgucmVsZWFzZSgpLCB5LnJlbGVhc2UoKSwg Ymx1ci5yZWxlYXNlKCksIHNwcmVhZC5yZWxlYXNlKCksIHN0eWxlLnJlbGVhc2UoKSwgY29sb3Iu cmVsZWFzZSgpKSk7CiAgICAgfQo= 85472 2011-03-11 07:36:14 -0800 2011-03-12 07:29:15 -0800 Updated version of the patch to more correctly represent a "0" (as previously used in the conditional) to a type acceptable by the SS12 compiler qt-4.7.1-webkit-CSSComputerStyleDeclaraation.cpp.diff text/plain 1530 bentaylor.solx86 LS0tIHF0LWV2ZXJ5d2hlcmUtb3BlbnNvdXJjZS1zcmMtNC43LjEtT1JJRy9zcmMvM3JkcGFydHkv d2Via2l0L1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAgICAgIDIw MDktMTIgLTIxIDA3OjA5OjM4LjYwMTU0MTk1OSAtMDUwMAorKysgcXQtZXZlcnl3aGVyZS1vcGVu c291cmNlLXNyYy00LjcuMS9zcmMvM3JkcGFydHkvd2Via2l0L1dlYkNvcmUvY3NzL0NTU0NvbXB1 dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAgIDIwMTEtMDMtMTEgMDY6NTk6MTIuMjc2MDgzNTIwIC0w NTAwCkBAIC01NjcsOCArNTY3LDggQEAKICAgICAgICAgUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVl PiB4ID0gQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZShzLT54LCBDU1NQcmltaXRpdmVWYWx1ZTo6 Q1NTX1BYKTsKICAgICAgICAgUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiB5ID0gQ1NTUHJpbWl0 aXZlVmFsdWU6OmNyZWF0ZShzLT55LCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BYKTsKICAgICAg ICAgUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiBibHVyID0gQ1NTUHJpbWl0aXZlVmFsdWU6OmNy ZWF0ZShzLT5ibHVyLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BYKTsKLSAgICAgICAgUmVmUHRy PENTU1ByaW1pdGl2ZVZhbHVlPiBzcHJlYWQgPSBwcm9wZXJ0eUlEID09IENTU1Byb3BlcnR5VGV4 dFNoYWRvdyA/IDAgOiBDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlKHMtPnNwcmVhZCwgQ1NTUHJp bWl0aXZlVmFsdWU6OkNTU19QWCk7Ci0gICAgICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4g c3R5bGUgPSBwcm9wZXJ0eUlEID09IENTU1Byb3BlcnR5VGV4dFNoYWRvdyB8fCBzLT5zdHlsZSA9 PSBOb3JtYWwgPyAwIDogQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZUlkZW50aWZpZXIoQ1NTVmFs dWVJbnNldCk7CisgICAgICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gc3ByZWFkID0gcHJv cGVydHlJRCA9PSBDU1NQcm9wZXJ0eVRleHRTaGFkb3cgPyBQYXNzUmVmUHRyPENTU1ByaW1pdGl2 ZVZhbHVlPigpIDogQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZShzLT5zcHJlYWQsIENTU1ByaW1p dGl2ZVZhbHVlOjpDU1NfUFgpOworICAgICAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IHN0 eWxlID0gcHJvcGVydHlJRCA9PSBDU1NQcm9wZXJ0eVRleHRTaGFkb3cgfHwgcy0+c3R5bGUgPT0g Tm9ybWFsID8gUGFzc1JlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4oKSA6IENTU1ByaW1pdGl2ZVZh bHVlOjpjcmVhdGVJZGVudGlmaWVyKENTU1ZhbHVlSW5zZXQpOwogICAgICAgICBSZWZQdHI8Q1NT UHJpbWl0aXZlVmFsdWU+IGNvbG9yID0gQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZUNvbG9yKHMt PmNvbG9yLnJnYigpKTsKICAgICAgICAgbGlzdC0+cHJlcGVuZChTaGFkb3dWYWx1ZTo6Y3JlYXRl KHgucmVsZWFzZSgpLCB5LnJlbGVhc2UoKSwgYmx1ci5yZWxlYXNlKCksIHNwcmVhZC5yZWxlYXNl KCksIHN0eWxlLnJlbGVhc2UoKSwKIGNvbG9yLnJlbGVhc2UoKSkpOwogICAgIH0K 85593 2011-03-12 07:29:15 -0800 2011-03-24 09:08:49 -0700 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler webkit-bug-32821-css-CSSComputedStyleDeclaration.cpp.diff text/plain 2399 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwOTM1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMTIgIEJlbiBUYXls b3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzI4MjEKKyAgICAgICAgRml4IGNvbmRpdGlvbmFscyB3aGljaCBoYWQgYW4gaW50 IGZvciBvbmUgY2FzZSBhbmQgYSBwb2ludGVyIGZvciBhbm90aGVyLgorICAgICAgICBGaXggaXMg c2ltaWxhciB0byBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTYxOTgK KworICAgICAgICBObyBuZXcgdGVzdHMuIEZpeCBjb21waWxhdGlvbiBvbiBTb2xhcmlzIDEwIHdp dGggU3VuU3R1ZGlvIDEyIEMrKworCisgICAgICAgICogY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNs YXJhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRp b246OnZhbHVlRm9yU2hhZG93KToKKwogMjAxMS0wMy0xMiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQ6IEluc3BlY3QgRWxlbWVu dCBhY3Rpb24gcmVncmVzc2lvbiBmaXguCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29t cHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9j c3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAkocmV2aXNpb24gODA5MzUpCisrKyBT b3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNjUzLDggKzY1Myw4IEBAIFBhc3NSZWZQdHI8Q1NTVmFsdWU+IENTU0NvbXB1 dGVkU3R5bGVEZWMKICAgICAgICAgUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiB4ID0gem9vbUFk anVzdGVkUGl4ZWxWYWx1ZShzLT54KCksIHN0eWxlLCBwcmltaXRpdmVWYWx1ZUNhY2hlKTsKICAg ICAgICAgUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiB5ID0gem9vbUFkanVzdGVkUGl4ZWxWYWx1 ZShzLT55KCksIHN0eWxlLCBwcmltaXRpdmVWYWx1ZUNhY2hlKTsKICAgICAgICAgUmVmUHRyPENT U1ByaW1pdGl2ZVZhbHVlPiBibHVyID0gem9vbUFkanVzdGVkUGl4ZWxWYWx1ZShzLT5ibHVyKCks IHN0eWxlLCBwcmltaXRpdmVWYWx1ZUNhY2hlKTsKLSAgICAgICAgUmVmUHRyPENTU1ByaW1pdGl2 ZVZhbHVlPiBzcHJlYWQgPSBwcm9wZXJ0eUlEID09IENTU1Byb3BlcnR5VGV4dFNoYWRvdyA/IDAg OiB6b29tQWRqdXN0ZWRQaXhlbFZhbHVlKHMtPnNwcmVhZCgpLCBzdHlsZSwgcHJpbWl0aXZlVmFs dWVDYWNoZSk7Ci0gICAgICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gc3R5bGUgPSBwcm9w ZXJ0eUlEID09IENTU1Byb3BlcnR5VGV4dFNoYWRvdyB8fCBzLT5zdHlsZSgpID09IE5vcm1hbCA/ IDAgOiBwcmltaXRpdmVWYWx1ZUNhY2hlLT5jcmVhdGVJZGVudGlmaWVyVmFsdWUoQ1NTVmFsdWVJ bnNldCk7CisgICAgICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gc3ByZWFkID0gcHJvcGVy dHlJRCA9PSBDU1NQcm9wZXJ0eVRleHRTaGFkb3cgPyBQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZh bHVlPigpIDogem9vbUFkanVzdGVkUGl4ZWxWYWx1ZShzLT5zcHJlYWQoKSwgc3R5bGUsIHByaW1p dGl2ZVZhbHVlQ2FjaGUpOworICAgICAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IHN0eWxl ID0gcHJvcGVydHlJRCA9PSBDU1NQcm9wZXJ0eVRleHRTaGFkb3cgfHwgcy0+c3R5bGUoKSA9PSBO b3JtYWwgPyBQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPigpIDogcHJpbWl0aXZlVmFsdWVD YWNoZS0+Y3JlYXRlSWRlbnRpZmllclZhbHVlKENTU1ZhbHVlSW5zZXQpOwogICAgICAgICBSZWZQ dHI8Q1NTUHJpbWl0aXZlVmFsdWU+IGNvbG9yID0gcHJpbWl0aXZlVmFsdWVDYWNoZS0+Y3JlYXRl Q29sb3JWYWx1ZShzLT5jb2xvcigpLnJnYigpKTsKICAgICAgICAgbGlzdC0+cHJlcGVuZChTaGFk b3dWYWx1ZTo6Y3JlYXRlKHgucmVsZWFzZSgpLCB5LnJlbGVhc2UoKSwgYmx1ci5yZWxlYXNlKCks IHNwcmVhZC5yZWxlYXNlKCksIHN0eWxlLnJlbGVhc2UoKSwgY29sb3IucmVsZWFzZSgpKSk7CiAg ICAgfQo=